[pushed] Add new text_art::tree_widget and use it in analyzer

2024-05-30 Thread David Malcolm
Define INCLUDE_VECTOR. * gcc.dg/plugin/analyzer_gil_plugin.c: Likewise. * gcc.dg/plugin/analyzer_kernel_plugin.c: Likewise. * gcc.dg/plugin/analyzer_known_fns_plugin.c: Likewise. Signed-off-by: David Malcolm --- gcc/Makefile.in | 1 + gcc/

[pushed] analyzer: fix a -Wunused-parameter

2024-05-30 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r15-926-g0b3a3a66eb816b. gcc/analyzer/ChangeLog: * infinite-loop.cc (looping_back_event::get_desc): Fix unused parameter warning introduced by me in r15-636-g770657d02c986c. Signed-off-by: D

[gcc r15-926] analyzer: fix a -Wunused-parameter

2024-05-30 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:0b3a3a66eb816b7c7e6bcb6f720813284e3eb0ef commit r15-926-g0b3a3a66eb816b7c7e6bcb6f720813284e3eb0ef Author: David Malcolm Date: Thu May 30 08:42:01 2024 -0400 analyzer: fix a -Wunused-parameter gcc/analyzer/ChangeLog: * infinite-loop.cc

[gcc r15-925] Add new text_art::tree_widget and use it in analyzer

2024-05-30 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:97238e4217d5cdc62686d86e784421bd0f76aa4a commit r15-925-g97238e4217d5cdc62686d86e784421bd0f76aa4a Author: David Malcolm Date: Thu May 30 08:42:00 2024 -0400 Add new text_art::tree_widget and use it in analyzer This patch adds a new text_art::tree_widget

Re: CFG edge visualization to path-printing bootstrap failure

2024-05-29 Thread David Malcolm
On Wed, 2024-05-29 at 15:26 -0400, David Edelsohn wrote: > On Mon, May 20, 2024 at 1:56 PM David Edelsohn > wrote: > > > Hi, David > > > > Unfortunately r15-636-g770657d02c986c causes a bootstrap failure on > > AIX > > when building f951 in stage2.  cc1 and cc1plus link successfully. > > There

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-29 Thread David Malcolm
On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > On Tue, May 28, 2024 at 1:21 PM David Malcolm > wrote: > > > > Ping. > > > > This patch has actually been *very* helpful to me when debugging > > selftest failures involving ASSERT_STREQ. > >

Re: [RFC/RFA] [PATCH 08/12] Add a new pass for naive CRC loops detection

2024-05-29 Thread David Malcolm
On Fri, 2024-05-24 at 12:42 +0400, Mariam Arutunian wrote: > This patch adds a new compiler pass aimed at identifying naive CRC > implementations, > characterized by the presence of a loop calculating a CRC (polynomial > long > division). > Upon detection of a potential CRC, the pass prints an

[pushed 1/3] selftests: split out make_fndecl from selftest.h to its own header

2024-05-28 Thread David Malcolm
eLog: * function-tests.cc: Include "selftest-tree.h". * selftest-tree.h: New file. * selftest.h (make_fndecl): Move to selftest-tree.h. Signed-off-by: David Malcolm --- gcc/analyzer/region-model.cc | 1 + gcc/function-tests.cc| 1 +

[pushed 3/3] diagnostics: consolidate global state in diagnostic-color.cc

2024-05-28 Thread David Malcolm
_cc_tests. * selftest.h (selftest::diagnostic_color_cc_tests): New decl. Signed-off-by: David Malcolm --- gcc/diagnostic-color.cc | 277 +- gcc/selftest-run-tests.cc | 1 + gcc/selftest.h| 1 + 3 files changed, 216 insertions(+), 63 de

[pushed 2/3] libcpp: move label_text to its own header

2024-05-28 Thread David Malcolm
on.h: Include "label-text.h". (class label_text): Move to label-text.h. Signed-off-by: David Malcolm --- libcpp/Makefile.in | 2 +- libcpp/include/label-text.h| 102 + libcpp/include/rich-location.h | 79 +---

[gcc r15-875] diagnostics: consolidate global state in diagnostic-color.cc

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:21fc89bac61983a869c066f7377f8280a6adca49 commit r15-875-g21fc89bac61983a869c066f7377f8280a6adca49 Author: David Malcolm Date: Tue May 28 15:55:28 2024 -0400 diagnostics: consolidate global state in diagnostic-color.cc Simplify the table of default colors

[gcc r15-874] libcpp: move label_text to its own header

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:9bda2c4c81b668b1d9abbb58cc4e805ac955a639 commit r15-874-g9bda2c4c81b668b1d9abbb58cc4e805ac955a639 Author: David Malcolm Date: Tue May 28 15:55:24 2024 -0400 libcpp: move label_text to its own header No functional change intended. libcpp/ChangeLog

[gcc r15-873] selftests: split out make_fndecl from selftest.h to its own header

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:fb7a943ead689e80e1ffdf6fa4e129dc155312d3 commit r15-873-gfb7a943ead689e80e1ffdf6fa4e129dc155312d3 Author: David Malcolm Date: Tue May 28 15:55:17 2024 -0400 selftests: split out make_fndecl from selftest.h to its own header Avoid selftest.h requiring

Re: [PATCH] regenerate-opt-urls.py: fix transposed values for "vax" and "v850"

2024-05-28 Thread David Malcolm
On Tue, 2024-05-28 at 11:41 -0400, David Malcolm wrote: > > On Tue, 2024-05-28 at 15:03 +0200, Mark Wielaard wrote: > > Hi Maciej (Hi David, added to CC), > > > On Mon, 2024-05-27 at 05:19 +0100, Maciej W. Rozycki wrote: > > >  As reported in PR target/79646

[gcc r15-872] regenerate-opt-urls.py: fix transposed values for "vax" and "v850"

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:7cc529fe514cc64e88208a6a7acfc6fe6419a453 commit r15-872-g7cc529fe514cc64e88208a6a7acfc6fe6419a453 Author: David Malcolm Date: Tue May 28 15:47:38 2024 -0400 regenerate-opt-urls.py: fix transposed values for "vax" and "v850"

PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-28 Thread David Malcolm
Ping. This patch has actually been *very* helpful to me when debugging selftest failures involving ASSERT_STREQ. Thanks Dave On Fri, 2024-05-17 at 15:51 -0400, David Malcolm wrote: > Currently when ASSERT_STREQ or ASSERT_STREQ_AT fail we print > both strings to stderr.  However it can b

[pushed] diagnostics: disable localization of events in selftest paths [PR115203]

2024-05-28 Thread David Malcolm
path::test_diagnostic_path): Call disable_event_localization. Signed-off-by: David Malcolm --- gcc/diagnostic-path.h | 3 +++ gcc/diagnostic.cc | 8 +--- gcc/tree-diagnostic-path.cc | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gcc/diagnostic-path

[pushed] Fix bootstrap on AIX by adding c-family/c-type-mismatch.cc [PR115167]

2024-05-28 Thread David Malcolm
ation.h" with "c-family/c-type-mismatch.h". * c-typeck.cc: Likewise. gcc/cp/ChangeLog: PR bootstrap/115167 PR bootstrap/115167 * call.cc: Replace include of "gcc-rich-location.h" with "c-family/c-type-mismatch.h".

[gcc r15-866] diagnostics: disable localization of events in selftest paths [PR115203]

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:2dbb1c124c1e585dc413132d7a8d4be62c6b7baa commit r15-866-g2dbb1c124c1e585dc413132d7a8d4be62c6b7baa Author: David Malcolm Date: Tue May 28 13:04:26 2024 -0400 diagnostics: disable localization of events in selftest paths [PR115203] gcc/ChangeLog

[gcc r15-865] Fix bootstrap on AIX by adding c-family/c-type-mismatch.cc [PR115167]

2024-05-28 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:b544ff88560e100e53ed8966d38f172c5bafce8d commit r15-865-gb544ff88560e100e53ed8966d38f172c5bafce8d Author: David Malcolm Date: Tue May 28 13:04:25 2024 -0400 Fix bootstrap on AIX by adding c-family/c-type-mismatch.cc [PR115167] PR bootstrap/115167 reports

[PATCH] regenerate-opt-urls.py: fix transposed values for "vax" and "v850"

2024-05-28 Thread David Malcolm
to trunk (and backport to gcc 14) after suitable testing. Dave gcc/ChangeLog: * config/v850/v850.opt.urls: Regenerate, with fix. * config/vax/vax.opt.urls: Likewise. * regenerate-opt-urls.py (TARGET_SPECIFIC_PAGES): Fix transposed values for "vax" and "v850&q

Re: [RFC][PATCH] PR tree-optimization/109071 - -Warray-bounds false positive warnings due to code duplication from jump threading

2024-05-23 Thread David Malcolm
On Thu, 2024-05-23 at 14:03 +, Qing Zhao wrote: [...snip...] > Is “location_adhoc_data” an available data structure in current GCC? > I just searched GCC source tree, cannot find it. It's in libcpp/include/line-table.h; see the big comment at the top of that file. Dave

Re: [RFC][PATCH] PR tree-optimization/109071 - -Warray-bounds false positive warnings due to code duplication from jump threading

2024-05-21 Thread David Malcolm
On Tue, 2024-05-21 at 15:13 +, Qing Zhao wrote: > Thanks for the comments and suggestions. > > > On May 15, 2024, at 10:00, David Malcolm > > wrote: > > > > On Tue, 2024-05-14 at 15:08 +0200, Richard Biener wrote: > > > On Mon, 13 May 2024, Qing Zh

Re: [COMMITTED] Regenerate riscv.opt.urls and i386.opt.urls

2024-05-20 Thread David Malcolm
On Mon, 2024-05-20 at 16:19 +, Jiang, Haochen wrote: > Thanks for your help! I haven't noticed this file is newly added to > GCC. > I suppose that is why the buildbot is reporting something the whole > afternoon for me. > > So just for confirm, does that mean we will always need to run >

Re: ☠ Buildbot (Sourceware): gcc-autoregen - failed 'git diff ...' (failure) (master)

2024-05-17 Thread David Malcolm via Gcc-testresults
s; should be fixed by https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652062.html Dave > > Build state: failed 'git diff ...' (failure) > Revision: e0b9c8ad7098fb08a25a61fe17d4274dd73e5145 > Worker: bb1-2 > Build Reason: (unknown) > Blamelist: David Malcolm , Robin Dapp

[pushed] Regenerate common.opt.urls

2024-05-17 Thread David Malcolm
I forgot to do this for r15-636-g770657d02c986c. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r15-640-g4e3bb431bbf280. gcc/ChangeLog: * common.opt.urls: Regenerate to add fdiagnostics-show-event-links. Signed-off-by: David Malcolm ---

[gcc r15-640] Regenerate common.opt.urls

2024-05-17 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:4e3bb431bbf2802bcf8e5d983dd1450f719d6ac7 commit r15-640-g4e3bb431bbf2802bcf8e5d983dd1450f719d6ac7 Author: David Malcolm Date: Fri May 17 17:56:56 2024 -0400 Regenerate common.opt.urls I forgot to do this for r15-636-g770657d02c986c. gcc/ChangeLog

[PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-17 Thread David Malcolm
n-null strings. Signed-off-by: David Malcolm --- gcc/selftest.cc | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/gcc/selftest.cc b/gcc/selftest.cc index 6438d86a6aa0..f58c0631908e 100644 --- a/gcc/selftest.cc +++ b/gcc/selftest.cc @@ -63,6 +63,26 @@

[pushed] diagnostics, analyzer: add CFG edge visualization to path-printing

2024-05-17 Thread David Malcolm
vent-links-color.c: New test. * gcc.dg/analyzer/event-links-disabled.c: New test. * gcc.dg/analyzer/event-links-unicode.c: New test. libcpp/ChangeLog: * include/rich-location.h (class label_effects): New forward decl. (range_label::get_effects): New v

[gcc r15-636] diagnostics, analyzer: add CFG edge visualization to path-printing

2024-05-17 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:770657d02c986c8724214dba51f21bb3c299ebae commit r15-636-g770657d02c986c8724214dba51f21bb3c299ebae Author: David Malcolm Date: Fri May 17 14:51:47 2024 -0400 diagnostics, analyzer: add CFG edge visualization to path-printing This patch adds some ability

[pushed] diagnostics: use unicode art for interprocedural depth

2024-05-15 Thread David Malcolm
Test with both ascii and unicode themes. (selftest::test_interprocedural_path_2): Likewise. (selftest::test_recursion): Likewise. Signed-off-by: David Malcolm --- .../analyzer/out-of-bounds-diagram-1-emoji.c | 26 +- .../out-of-bounds-diagram-1-unicode.c | 26 +-

[pushed] diagnostics: add warning emoji to events with VERB_danger

2024-05-15 Thread David Malcolm
agnostic_event::VERB_danger, and the theme enables emojis, then add a warning emoji between the event number and the event text. Signed-off-by: David Malcolm --- .../analyzer/out-of-bounds-diagram-1-emoji.c | 2 +- gcc/testsuite/gcc.dg/analyzer/warning-emoji.c | 29 ++ gcc/t

[pushed] diagnostics: simplify output of purely intraprocedural execution paths

2024-05-15 Thread David Malcolm
purely intraprocedural. (selftest::test_intraprocedural_path): Update expected output. Signed-off-by: David Malcolm --- gcc/diagnostic-path.h | 32 +- gcc/doc/invoke.texi | 30 +- .../analyzer/allocation-size-multiline-1.c| 68 +-

[pushed] diagnostics: handle SGR codes in line_label::m_display_width

2024-05-15 Thread David Malcolm
8): Update expected text to reflect that the labels can fit on one line if we don't get confused by SGR colorization codes. Signed-off-by: David Malcolm --- gcc/diagnostic-show-locus.cc | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --g

[gcc r15-535] diagnostics: use unicode art for interprocedural depth

2024-05-15 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:e656656e711949ef42a7e284f7cf81ca56f37374 commit r15-535-ge656656e711949ef42a7e284f7cf81ca56f37374 Author: David Malcolm Date: Wed May 15 21:22:52 2024 -0400 diagnostics: use unicode art for interprocedural depth gcc/testsuite/ChangeLog: * gcc.dg

[gcc r15-534] diagnostics: add warning emoji to events with VERB_danger

2024-05-15 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:0b7ebe5427a4af0956e0aed5e7432b98559ca7b5 commit r15-534-g0b7ebe5427a4af0956e0aed5e7432b98559ca7b5 Author: David Malcolm Date: Wed May 15 21:22:51 2024 -0400 diagnostics: add warning emoji to events with VERB_danger Tweak the printing of -fdiagnostics-path

[gcc r15-533] diagnostics: simplify output of purely intraprocedural execution paths

2024-05-15 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:3cd267446755ab6b2c59936a718d34c8bc474ca5 commit r15-533-g3cd267446755ab6b2c59936a718d34c8bc474ca5 Author: David Malcolm Date: Wed May 15 21:22:51 2024 -0400 diagnostics: simplify output of purely intraprocedural execution paths Diagnostic path printing

[gcc r15-532] diagnostics: handle SGR codes in line_label::m_display_width

2024-05-15 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:a7be993806a90a58397e9d5bc9b54160ac9f35db commit r15-532-ga7be993806a90a58397e9d5bc9b54160ac9f35db Author: David Malcolm Date: Wed May 15 21:22:51 2024 -0400 diagnostics: handle SGR codes in line_label::m_display_width gcc/ChangeLog: * diagnostic

[pushed] analyzer: fix ICE seen with -fsanitize=undefined [PR114899]

2024-05-15 Thread David Malcolm
null. gcc/testsuite/ChangeLog: PR analyzer/114899 * c-c++-common/analyzer/out-of-bounds-diagram-pr114899.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/access-diagram.cc| 3 ++- .../analyzer/out-of-bounds-diagram-pr114899.c | 15 ++

[gcc r15-526] analyzer: fix ICE seen with -fsanitize=undefined [PR114899]

2024-05-15 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:1779e22150b917e28e959623c819ef943fab02df commit r15-526-g1779e22150b917e28e959623c819ef943fab02df Author: David Malcolm Date: Wed May 15 18:40:56 2024 -0400 analyzer: fix ICE seen with -fsanitize=undefined [PR114899] gcc/analyzer/ChangeLog: PR

Re: [RFC][PATCH] PR tree-optimization/109071 - -Warray-bounds false positive warnings due to code duplication from jump threading

2024-05-15 Thread David Malcolm
g new heuristic: > > > > If > >    1. the stmt is duplicated and splitted into two conditional > > paths; > > +  2. the warning level < 2; > > +  3. the current block is not dominating the exit block > > Then not report the warning. > > > >

Re: [PATCH] testsuite: analyzer: Fix fd-glibc-byte-stream-connection-server.c on Solaris [PR107750]

2024-05-14 Thread David Malcolm
On Tue, 2024-05-14 at 14:32 +0200, Rainer Orth wrote: > gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c currently > FAILs > on Solaris: > > FAIL: gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c (test > for excess errors) > > Excess errors: >

Re: [EXTERNAL] [COMMITTED] Regenerate cygming.opt.urls and mingw.opt.urls

2024-05-13 Thread David Malcolm
On Mon, 2024-05-13 at 09:42 -0400, David Malcolm wrote: > On Mon, 2024-05-13 at 11:14 +0200, Mark Wielaard wrote: > > Hi Evgeny, > > > > Adding David to the CC, who might know the details. > > > > On Mon, May 13, 2024 at 08:44:12AM +, Evgeny Karpov

Re: [EXTERNAL] [COMMITTED] Regenerate cygming.opt.urls and mingw.opt.urls

2024-05-13 Thread David Malcolm
On Mon, 2024-05-13 at 11:14 +0200, Mark Wielaard wrote: > Hi Evgeny, > > Adding David to the CC, who might know the details. > > On Mon, May 13, 2024 at 08:44:12AM +, Evgeny Karpov wrote: > > Sunday, May 12, 2024 > > > > Thank you for reviewing our changes related to the refactoring of > >

[PATCH 21/21] diagnostics: fix corrupt json/SARIF on stderr [PR114348]

2024-05-09 Thread David Malcolm
uested one of the machine-readable diagnostic output formats on stderr. (diagnostic_output_format_init): Set output_format. Signed-off-by: David Malcolm --- gcc/diagnostic.cc | 24 1 file changed, 24 insertions(+) diff --git a/gcc/diagnostic.cc b/gcc/diagnosti

[PATCH 19/21] diagnostics: fix ICE on sarif output when source file is unreadable [PR111700]

2024-05-09 Thread David Malcolm
lookup_or_add_file failing. gcc/testsuite/ChangeLog: PR driver/111700 * c-c++-common/diagnostic-format-sarif-file-pr111700.c: New test. Signed-off-by: David Malcolm --- gcc/input.cc | 12 ++-- .../diagnostic-format-sarif-file

[PATCH 13/21] analyzer: fix defaults in compound assignments from non-zero offsets [PR112969]

2024-05-09 Thread David Malcolm
/compound-assignment-pr112969.c: New test. * gcc.dg/plugin/infoleak-pr112969.c: New test. * gcc.dg/plugin/plugin.exp: Add infoleak-pr112969.c to analyzer_kernel_plugin.c tests. Signed-off-by: David Malcolm --- gcc/analyzer/store.cc | 11

[PATCH 10/21] analyzer: fix ICE for 2 bits before the start of base region [PR112889]

2024-05-09 Thread David Malcolm
::is_empty): Likewise. gcc/testsuite/ChangeLog: PR analyzer/112889 * gcc.dg/analyzer/ice-pr112889.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/store.h | 10 +- gcc/testsuite/gcc.dg/analyzer/ice-pr112889.c | 17 + 2 files

[PATCH 15/21] analyzer: fix -Wanalyzer-va-arg-type-mismatch false +ve on int types [PR111289]

2024-05-09 Thread David Malcolm
types. (kf_va_arg::impl_call_pre): Pass arg_sval to va_arg_compatible_types_p. gcc/testsuite/ChangeLog: PR analyzer/111289 * gcc.dg/analyzer/stdarg-pr111289-int.c: New test. * gcc.dg/analyzer/stdarg-pr111289-ptr.c: New test. Signed-off-by: David Malcolm

[PATCH 18/21] analyzer: fix ICE and false positive with -Wanalyzer-deref-before-check [PR114408]

2024-05-09 Thread David Malcolm
: New test. Signed-off-by: David Malcolm --- gcc/analyzer/engine.cc| 7 ++ gcc/analyzer/kf.cc| 22 +++ .../ubsan/analyzer-ice-pr114408.c | 9 .../analyzer/deref-before-check-pr114408.c| 22

[PATCH 03/21] testsuite: Add more allocation size tests for conjured svalues [PR110014]

2024-05-09 Thread David Malcolm
. (cherry picked from commit r14-1685-g39adc5eebd61fd276f3f1ef9d7228756a35bd0cb) Signed-off-by: David Malcolm --- .../gcc.dg/analyzer/realloc-pr110014.c| 25 +++ 1 file changed, 25 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/realloc-pr110014.c diff --git

[PATCH 11/21] analyzer: fix deref-before-check false positives due to inlining [PR112790]

2024-05-09 Thread David Malcolm
: Include "analyzer/inlining-iterator.h". (maybe_complain_about_deref_before_check): Reject stmts that were inlined from another function. gcc/testsuite/ChangeLog: PR analyzer/112790 * gcc.dg/analyzer/deref-before-check-pr112790.c: New test. Signed-off-by: Dav

[PATCH 20/21] Fix ICE in -fdiagnostics-generate-patch [PR112684]

2024-05-09 Thread David Malcolm
Backported from r14-8255-ge254d1224df306. gcc/ChangeLog: PR middle-end/112684 * toplev.cc (toplev::main): Don't ICE in -fdiagnostics-generate-patch when exiting after options, since no edit context will have been created. Signed-off-by: David Malcolm --- gcc

[PATCH 16/21] analyzer: fix -Wanalyzer-deref-before-check false positive seen in loop header macro [PR109251]

2024-05-09 Thread David Malcolm
. (deref_before_check::loop_header_p): New. gcc/testsuite/ChangeLog: PR analyzer/109251 * gcc.dg/analyzer/deref-before-check-pr109251-1.c: New test. * gcc.dg/analyzer/deref-before-check-pr109251-2.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/sm-malloc.cc

[PATCH 09/21] jit: dump string literal initializers correctly

2024-05-09 Thread David Malcolm
From: Vibhav Pant Signed-off-by: David Malcolm gcc/jit/ChangeLog: * jit-recording.cc (recording::global::write_to_dump): Fix dump of string literal initializers. (cherry picked from commit r14-4923-gac66744d94226a) Signed-off-by: David Malcolm --- gcc/jit/jit-recording.cc

[PATCH 08/21] testsuite, analyzer: add test case [PR108171]

2024-05-09 Thread David Malcolm
) Signed-off-by: David Malcolm --- gcc/testsuite/gcc.dg/analyzer/pr108171.c | 31 1 file changed, 31 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/pr108171.c diff --git a/gcc/testsuite/gcc.dg/analyzer/pr108171.c b/gcc/testsuite/gcc.dg/analyzer/pr108171.c

[PATCH 17/21] analyzer: fix ICE due to type mismatch when replaying call summary [PR114473]

2024-05-09 Thread David Malcolm
::convert_region_from_summary_1): Add missing cast for the deref of RK_SYMBOLIC case. gcc/testsuite/ChangeLog: PR analyzer/114473 * gcc.dg/analyzer/call-summaries-pr114473.c: New test. (cherry picked from commit r14-9697-gfdd59818e2abf6) Signed-off-by: David Malcolm --- gcc/analyzer/call

[PATCH 14/21] analyzer: fix skipping of debug stmts [PR113253]

2024-05-09 Thread David Malcolm
/ChangeLog: PR analyzer/113253 * gcc.dg/analyzer/deref-before-check-pr113253.c: New test. (cherry picked from commit r14-8670-gcc7aebff74d896) Signed-off-by: David Malcolm --- gcc/analyzer/region-model.cc | 5 + gcc/analyzer/state-purge.cc | 9

[PATCH 02/21] analyzer: Fix allocation size false positive on conjured svalue [PR109577]

2024-05-09 Thread David Malcolm
test. (cherry picked from commit r14-1684-g1d57a2232575913ad1085bac0ba5e22b58185179) Signed-off-by: David Malcolm --- gcc/analyzer/constraint-manager.cc| 131 ++ gcc/analyzer/constraint-manager.h | 1 + gcc/analyzer/region-model.cc | 80

[PATCH 07/21] analyzer: fix ICE on zero-sized arrays [PR110882]

2024-05-09 Thread David Malcolm
gcc/analyzer/ChangeLog: PR analyzer/110882 * region.cc (int_size_in_bits): Fail on zero-sized types. gcc/testsuite/ChangeLog: PR analyzer/110882 * gcc.dg/analyzer/pr110882.c: New test. (cherry picked from commit r14-2955-gc62f93d1e0383d) Signed-off-by: David

[PATCH 05/21] jit.exp: handle dwarf version mismatch in jit-check-debug-info [PR110466]

2024-05-09 Thread David Malcolm
gcc/testsuite/ChangeLog: PR jit/110466 * jit.dg/jit.exp (jit-check-debug-info): Gracefully handle too early versions of gdb that don't support our dwarf version, via "unsupported". (cherry picked from commit r14-2223-gc3c0ba5436170e) Signed-off-by: Dav

[PATCH 12/21] analyzer: casting all zeroes should give all zeroes [PR113333]

2024-05-09 Thread David Malcolm
): Casting all zeroes should give all zeroes. gcc/testsuite/ChangeLog: PR analyzer/11 * gcc.dg/analyzer/calloc-1.c: Add tests. * gcc.dg/analyzer/data-model-9.c: Update expected results. * gcc.dg/analyzer/pr96639.c: Update expected results. Signed-off-by: David

[PATCH 06/21] analyzer: fix ICE on division of tainted floating-point values [PR110700]

2024-05-09 Thread David Malcolm
-integral types. gcc/testsuite/ChangeLog: PR analyzer/110700 * gcc.dg/analyzer/taint-divisor-2.c: New test. (cherry picked from commit r14-2658-gb86c0fe327a519) Signed-off-by: David Malcolm --- gcc/analyzer/region-model-manager.cc| 3 ++- gcc/analyzer/sm-taint.cc

[PATCH 04/21] jit: avoid using __vector in testcase [PR110466]

2024-05-09 Thread David Malcolm
(run_test_of_comparison): Fix size param to gcc_jit_type_get_vector. (verify_comparisons): Use a typedef rather than __vector. (cherry picked from commit r14--g6735d660839533) Co-authored-by: Marek Polacek Signed-off-by: David Malcolm --- gcc/testsuite/jit.dg/test-expressions.c | 22

[pushed 00/21] Various backports to gcc 13 (analyzer, jit, diagnostics)

2024-05-09 Thread David Malcolm
c 13: r13-8760-g2a6f99aef7c852 * [pushed] diagnostics: fix corrupt json/SARIF on stderr [PR114348] * https://gcc.gnu.org/pipermail/gcc-patches/2024-March/648048.html * (backported from commit r14-9554-g0bf99b1b7eda2f) gcc 13: r13-8761-gb7a2697733d19a David Malcolm (18): analyzer:

[PATCH 01/21] analyzer: add caching to globals with initializers [PR110112]

2024-05-09 Thread David Malcolm
::calc_svalue_for_constructor): New decl. (decl_region::m_ctor_svalue): New field. (cherry picked from commit r14-1664-gfe9771b59f576f) Signed-off-by: David Malcolm --- gcc/analyzer/region-model.cc | 25 + gcc/analyzer/region.cc | 71 +--- gcc/analyzer

[gcc r13-8761] diagnostics: fix corrupt json/SARIF on stderr [PR114348]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:b7a2697733d19a093cbdd0e200ffce069a4bc812 commit r13-8761-gb7a2697733d19a093cbdd0e200ffce069a4bc812 Author: David Malcolm Date: Thu May 9 13:09:33 2024 -0400 diagnostics: fix corrupt json/SARIF on stderr [PR114348] Various values of -fdiagnostics-format

[gcc r13-8760] Fix ICE in -fdiagnostics-generate-patch [PR112684]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:2a6f99aef7c8522471967b171180d9ba4136da90 commit r13-8760-g2a6f99aef7c8522471967b171180d9ba4136da90 Author: David Malcolm Date: Thu May 9 13:09:32 2024 -0400 Fix ICE in -fdiagnostics-generate-patch [PR112684] Backported from r14-8255-ge254d1224df306

[gcc r13-8754] analyzer: fix skipping of debug stmts [PR113253]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:2c688f6afce4cbb414f5baab1199cd525f309fca commit r13-8754-g2c688f6afce4cbb414f5baab1199cd525f309fca Author: David Malcolm Date: Thu May 9 13:09:30 2024 -0400 analyzer: fix skipping of debug stmts [PR113253] PR analyzer/113253 reports a case where the analyzer

[gcc r13-8757] analyzer: fix ICE due to type mismatch when replaying call summary [PR114473]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:810d35a7e054bcbb5b66d2e5924428e445f5fba9 commit r13-8757-g810d35a7e054bcbb5b66d2e5924428e445f5fba9 Author: David Malcolm Date: Thu May 9 13:09:31 2024 -0400 analyzer: fix ICE due to type mismatch when replaying call summary [PR114473] gcc/analyzer/ChangeLog

[gcc r13-8751] analyzer: fix deref-before-check false positives due to inlining [PR112790]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:994477c41049d45b60a4d6db7f624fe5c89860fe commit r13-8751-g994477c41049d45b60a4d6db7f624fe5c89860fe Author: David Malcolm Date: Thu May 9 13:09:29 2024 -0400 analyzer: fix deref-before-check false positives due to inlining [PR112790] Backported from commit

[gcc r13-8748] testsuite, analyzer: add test case [PR108171]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:44968a0e00f656e9bb3e504bb2fa1a8282002015 commit r13-8748-g44968a0e00f656e9bb3e504bb2fa1a8282002015 Author: David Malcolm Date: Thu May 9 13:09:28 2024 -0400 testsuite, analyzer: add test case [PR108171] The ICE in PR analyzer/108171 appears to be a dup

[gcc r13-8756] analyzer: fix -Wanalyzer-deref-before-check false positive seen in loop header macro [PR109251]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:ed026106ce420c7d9dd4d89caac017b6f235e219 commit r13-8756-ged026106ce420c7d9dd4d89caac017b6f235e219 Author: David Malcolm Date: Thu May 9 13:09:31 2024 -0400 analyzer: fix -Wanalyzer-deref-before-check false positive seen in loop header macro [PR109251

[gcc r13-8758] analyzer: fix ICE and false positive with -Wanalyzer-deref-before-check [PR114408]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:96f7a3694c3e4c72af6258cc9b38bce30e609bee commit r13-8758-g96f7a3694c3e4c72af6258cc9b38bce30e609bee Author: David Malcolm Date: Thu May 9 13:09:32 2024 -0400 analyzer: fix ICE and false positive with -Wanalyzer-deref-before-check [PR114408] Backported from

[gcc r13-8746] analyzer: fix ICE on division of tainted floating-point values [PR110700]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:0df1ee083434ac00ecb19582b1e5b25e105981b2 commit r13-8746-g0df1ee083434ac00ecb19582b1e5b25e105981b2 Author: David Malcolm Date: Thu May 9 13:09:28 2024 -0400 analyzer: fix ICE on division of tainted floating-point values [PR110700] gcc/analyzer/ChangeLog

[gcc r13-8759] diagnostics: fix ICE on sarif output when source file is unreadable [PR111700]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:230f672b3ed0f64c9110ef9dba616c17d713816d commit r13-8759-g230f672b3ed0f64c9110ef9dba616c17d713816d Author: David Malcolm Date: Thu May 9 13:09:32 2024 -0400 diagnostics: fix ICE on sarif output when source file is unreadable [PR111700] Backported from r14

[gcc r13-8755] analyzer: fix -Wanalyzer-va-arg-type-mismatch false +ve on int types [PR111289]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:67d104f3a032ee64bae335269bf1b8434785cc63 commit r13-8755-g67d104f3a032ee64bae335269bf1b8434785cc63 Author: David Malcolm Date: Thu May 9 13:09:31 2024 -0400 analyzer: fix -Wanalyzer-va-arg-type-mismatch false +ve on int types [PR111289] Backported from

[gcc r13-8745] jit.exp: handle dwarf version mismatch in jit-check-debug-info [PR110466]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:60dcb710b6b4aa22ea96abc8df6dfe9067f3d7fe commit r13-8745-g60dcb710b6b4aa22ea96abc8df6dfe9067f3d7fe Author: David Malcolm Date: Thu May 9 13:09:27 2024 -0400 jit.exp: handle dwarf version mismatch in jit-check-debug-info [PR110466] gcc/testsuite/ChangeLog

[gcc r13-8749] jit: dump string literal initializers correctly

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:b8c772cae97b54386f7853edf0f9897012bfa90b commit r13-8749-gb8c772cae97b54386f7853edf0f9897012bfa90b Author: Vibhav Pant Date: Thu May 9 13:09:28 2024 -0400 jit: dump string literal initializers correctly Signed-off-by: David Malcolm gcc/jit

[gcc r13-8753] analyzer: fix defaults in compound assignments from non-zero offsets [PR112969]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:0593151221ad21c2a67dfda597539c458ab731d8 commit r13-8753-g0593151221ad21c2a67dfda597539c458ab731d8 Author: David Malcolm Date: Thu May 9 13:09:30 2024 -0400 analyzer: fix defaults in compound assignments from non-zero offsets [PR112969] Confusion

[gcc r13-8747] analyzer: fix ICE on zero-sized arrays [PR110882]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:a0b13d0860848dd5f2876897ada1e22e4e681e91 commit r13-8747-ga0b13d0860848dd5f2876897ada1e22e4e681e91 Author: David Malcolm Date: Thu May 9 13:09:28 2024 -0400 analyzer: fix ICE on zero-sized arrays [PR110882] gcc/analyzer/ChangeLog: PR analyzer

[gcc r13-8750] analyzer: fix ICE for 2 bits before the start of base region [PR112889]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:a1cb188cb2ca2ad3f4e837dba2967f323669d36e commit r13-8750-ga1cb188cb2ca2ad3f4e837dba2967f323669d36e Author: David Malcolm Date: Thu May 9 13:09:29 2024 -0400 analyzer: fix ICE for 2 bits before the start of base region [PR112889] Cncrete bindings were using

[gcc r13-8752] analyzer: casting all zeroes should give all zeroes [PR113333]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:132eb1a210bc7806c4cf188ecac6c08339c94384 commit r13-8752-g132eb1a210bc7806c4cf188ecac6c08339c94384 Author: David Malcolm Date: Thu May 9 13:09:29 2024 -0400 analyzer: casting all zeroes should give all zeroes [PR11] In particular, accessing the result

[gcc r13-8744] jit: avoid using __vector in testcase [PR110466]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:b38472ffc1e631bd357573b44d956ce16d94e666 commit r13-8744-gb38472ffc1e631bd357573b44d956ce16d94e666 Author: David Malcolm Date: Thu May 9 13:09:27 2024 -0400 jit: avoid using __vector in testcase [PR110466] r13-4531-gd2e782cb99c311 added test coverage

[gcc r13-8743] testsuite: Add more allocation size tests for conjured svalues [PR110014]

2024-05-09 Thread David Malcolm via Gcc-cvs
picked from commit r14-1685-g39adc5eebd61fd276f3f1ef9d7228756a35bd0cb) Signed-off-by: David Malcolm Diff: --- gcc/testsuite/gcc.dg/analyzer/realloc-pr110014.c | 25 1 file changed, 25 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/realloc-pr110014.c b

[gcc r13-8742] analyzer: Fix allocation size false positive on conjured svalue [PR109577]

2024-05-09 Thread David Malcolm via Gcc-cvs
and add new test case. * gcc.dg/analyzer/pr109577.c: New test. (cherry picked from commit r14-1684-g1d57a2232575913ad1085bac0ba5e22b58185179) Signed-off-by: David Malcolm Diff: --- gcc/analyzer/constraint-manager.cc| 131 ++ gcc

[gcc r13-8741] analyzer: add caching to globals with initializers [PR110112]

2024-05-09 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:89feb3557a018893cfe50c2e07f91559bd3cde2b commit r13-8741-g89feb3557a018893cfe50c2e07f91559bd3cde2b Author: David Malcolm Date: Thu May 9 13:09:26 2024 -0400 analyzer: add caching to globals with initializers [PR110112] PR analyzer/110112 notes

[PATCH] testsuite: fix analyzer C++ failures on Solaris [PR111475]

2024-05-03 Thread David Malcolm
ze output for C vs C++. * c-c++-common/analyzer/signal-4a.c: Move back to... * gcc.dg/analyzer/signal-4a.c: ...here, dropping attempt to generalize output for C vs C++. * c-c++-common/analyzer/signal-4b.c: Move back to... * gcc.dg/analyzer/signal-4b.c: ...here

[gcc r15-131] testsuite: fix analyzer C++ failures on Solaris [PR111475]

2024-05-03 Thread David Malcolm via Gcc-cvs
https://gcc.gnu.org/g:5219414f3cde3c1037e289a6654cd722cfa75dea commit r15-131-g5219414f3cde3c1037e289a6654cd722cfa75dea Author: David Malcolm Date: Fri May 3 09:05:29 2024 -0400 testsuite: fix analyzer C++ failures on Solaris [PR111475] As part of PR analyzer/96395, these patches

Building libgccjit with -fno-semantic-interposition? ( was Re: 1.76% performance loss in VRP due to inlining)

2024-04-30 Thread David Malcolm via Gcc
On Tue, 2024-04-30 at 21:15 +0200, Richard Biener via Gcc wrote: > > > > Am 30.04.2024 um 21:11 schrieb Jason Merrill via Gcc > > : > > > > On Fri, Apr 26, 2024 at 5:44 AM Aldy Hernandez via Gcc > > wrote: > > > > > > In implementing prange (pointer ranges), I have found a 1.74% > > >

Re: [PATCH] c++: fix source printing for "required from here" message

2024-04-25 Thread David Malcolm
On Wed, 2024-04-24 at 17:05 -0400, Patrick Palka wrote: > On Wed, 24 Apr 2024, Jason Merrill wrote: > > > On 4/24/24 13:22, Patrick Palka wrote: > > > Tested on x86_64-pc-linux-gnu, full bootstrap+regtest in > > > progress, > > > does this look OK if successful? > > > > > > -- >8 -- > > > > > >

Re: [PATCH] v2: DOCUMENTATION_ROOT_URL vs. release branches [PR114738]

2024-04-24 Thread David Malcolm
On Wed, 2024-04-24 at 11:07 +0200, Jakub Jelinek wrote: > On Tue, Apr 23, 2024 at 07:07:17PM -0400, David Malcolm wrote: > > That sounds like a better approach; thanks. > > Attached below.  Tested by checking > ../configure --disable-bootstrap --enable-languages=c --disable-

Re: [PATCH] DOCUMENTATION_ROOT_URL vs. release branches [PR114738]

2024-04-23 Thread David Malcolm
On Tue, 2024-04-23 at 17:45 +0200, Jakub Jelinek wrote: > On Tue, Apr 23, 2024 at 11:40:55AM -0400, David Malcolm wrote: > > > So, I think at least for the MAJOR.MINOR.0 releases we want to > > > use > > > URLs like above rather than the trunk ones and we can us

Re: [PATCH] DOCUMENTATION_ROOT_URL vs. release branches [PR114738]

2024-04-23 Thread David Malcolm
On Wed, 2024-04-17 at 13:16 +0200, Jakub Jelinek wrote: > Hi! > > Starting with GCC 14 we have the nice URLification of the options > printed > in diagnostics, say for in > test.c:4:23: warning: format ‘%d’ expects argument of type ‘int’, but > argument 2 has type ‘long int’ [-Wformat=] > the

[pushed] analyzer: add SARIF property bag to -Wanalyzer-infinite-recursion

2024-04-10 Thread David Malcolm
t-sarif.h". (infinite_recursion_diagnostic::maybe_add_sarif_properties): New. Signed-off-by: David Malcolm --- gcc/analyzer/infinite-recursion.cc | 13 + 1 file changed, 13 insertions(+) diff --git a/gcc/analyzer/infinite-recursion.cc b/gcc/analyzer/infinite-recu

[pushed] analyzer: fixes to internal docs

2024-04-10 Thread David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r14-9897-g7f6599a201be2a. gcc/ChangeLog: * doc/analyzer.texi: Various tweaks. Signed-off-by: David Malcolm --- gcc/doc/analyzer.texi | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[pushed] analyzer: fix ICE on negative values for size_t [PR114472]

2024-04-10 Thread David Malcolm
fset. * store.cc (bit_range::intersects_p): Replace assertion with test. (bit_range::exceeds_p): Likewise. (bit_range::falls_short_of_p): Likewise. gcc/testsuite/ChangeLog: * c-c++-common/analyzer/out-of-bounds-pr114472.c: New test. Signed-off-by: David Malcolm ---

[pushed] analyzer: show size in SARIF property bag for -Wanalyzer-tainted-allocation-size

2024-04-10 Thread David Malcolm
r. Signed-off-by: David Malcolm --- gcc/analyzer/sm-taint.cc | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/gcc/analyzer/sm-taint.cc b/gcc/analyzer/sm-taint.cc index 1d1e208fdf49..a9c6d4db43f4 100644 --- a/gcc/analyzer/sm-taint.cc +++ b/gcc/analyzer/sm-taint.cc @@

[pushed] analyzer, testuite: comment fixes

2024-04-10 Thread David Malcolm
Successfully regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r14-9896-g082374f6570a31. gcc/testsuite/ChangeLog: * c-c++-common/analyzer/memset-1.c: Clarify some comments. Signed-off-by: David Malcolm --- gcc/testsuite/c-c++-common/analyzer/memset-1.c | 4 ++-- 1 file changed, 2

[pushed] testsuite: add some missing -fanalyzer to plugin tests

2024-04-10 Thread David Malcolm
NULL derefs. * gcc.dg/plugin/taint-CVE-2011-0521-2.c: Likewise. * gcc.dg/plugin/taint-CVE-2011-0521-3-fixed.c: Add missing -fanalyzer to options. * gcc.dg/plugin/taint-CVE-2011-0521-3.c: Likewise. Drop xfail. Signed-off-by: David Malcolm --- gcc/tests

  1   2   3   4   5   6   7   8   9   10   >