[patch] Fix debug info for packed array types in Ada

2021-09-03 Thread Eric Botcazou
for: FAIL: gdb.ada/arrayptr.exp: scenario=minimal: print pa_ptr.all FAIL: gdb.ada/arrayptr.exp: scenario=minimal: print pa_ptr.all(3) in the GDB testsuite. Tested on x86-64/Linux, both GCC and GDB, OK for the mainline? 2021-09-03 Eric Botcazou * dwarf2out.c (modified_type_die

Re: [PATCH] Make sure -fexceptions is enabled when -fnon-call-exceptions is

2021-08-30 Thread Eric Botcazou
> This makes -fexceptions enabled by -fnon-call-exceptions, removing > the odd state of !flag_exceptions && flag_non_call_exceptions from > middle-end consideration. FWIW fine with me. -- Eric Botcazou

[patch] Fix regression in debug info for Ada with DWARF 5

2021-08-16 Thread Eric Botcazou
for mainline and 11 branch? 2021-08-16 Eric Botcazou * dwarf2out.c (add_scalar_info): Deal with DW_AT_data_bit_offset. -- Eric Botcazoudiff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index 4bcd3313fee..ba0a6d6ed60 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -21253,6 +21253,7

Disable GNAT encodings by default

2021-08-16 Thread Eric Botcazou
Eric Botcazou * dwarf2out.c (add_data_member_location_attribute): Use GNAT encodings only when -fgnat-encodings=all is specified. (add_bound_info): Likewise. (add_byte_size_attribute): Likewise. (gen_member_die): Likewise. -- Eric Botcazoudiff --git

Re: [patch] Make -no-pie option work for native Windows

2021-08-12 Thread Eric Botcazou
> Looks good to me. Do you have push permissions? Thanks. Yes, see the preceding message on gcc-patches@, so applied. -- Eric Botcazou

[patch] Make -no-pie option work for native Windows

2021-08-11 Thread Eric Botcazou
the compiler. Bootstrapped on x86 and x86-64/Windows, w/ and w/o binutils 2.36, OK for the mainline and 11 branch? 2021-08-11 Eric Botcazou * configure.ac (PE linker --disable-dynamicbase support): New check. * configure: Regenerate. * config.in: Likewise

Small tweak to expand_used_vars

2021-08-11 Thread Eric Botcazou
This completes the replacement of DECL_ATTRIBUTES (current_function_decl) with the attribs local variable. Tested on x86-64/Linux, applied on the mainline as obvious. 2021-08-11 Eric Botcazuo * cfgexpand.c (expand_used_vars): Reuse attribs local variable. -- Eric Botcazoudiff

Re: [PATCH][v2] Adjust volatile handling of the operand scanner

2021-08-11 Thread Eric Botcazou
> So I'm leaning towards leaving build3 alone and fixing up frontends > as issues pop up. FWIW fine with me. -- Eric Botcazou

Re: [PATCH][v2] Adjust volatile handling of the operand scanner

2021-08-11 Thread Eric Botcazou
the FIELD_DECL has > TREE_THIS_VOLATILE set. This would be weird semantics in my opinion. > I guess I'll do one more experiment and add verification that > TREE_THIS_VOLATILE on COMPONENT_REFs and FIELD_DECLs is consistent > and see where that trips. Sounds good to me. -- Eric Botcazou

Re: [PATCH][v2] Adjust volatile handling of the operand scanner

2021-08-10 Thread Eric Botcazou
What do we do for other similar flags, e.g. TREE_READONLY? -- Eric Botcazou

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Eric Botcazou
_4 = x_1(D); > # DEBUG x => NULL > retval.5_2 = _4; > return retval.5_2; > > } > > > the line numbers are gone, and the function has DECL_IGNORED_P, > but still a useful DECL_SOURCE_LOCATION, I don't know > where the DECL_SOURCE_LOCATION can be seen in the dump files, > but from debugging this effect, I know that quite well. > > This second effect is why as a special case DECL_IGNORED_P functions > with valid looking DECL_SOURCE_LOCATION have now a .loc statement, > because that is less surprising to a user than having no line numbers > at all here. OK, thanks for the explanation, the patch is OK then. -- Eric Botcazou

Re: [PATCH] Fix ICE when mixing VLAs and statement expressions [PR91038]

2021-08-10 Thread Eric Botcazou
error:| | in gimplify_expr, at gimplify.c:15019| | Error detected around vect1.adb:6:23 probably because array_ref_low_bound, where it is normally eliminated, cannot do its jub properly when it is called after the base expression is gimplified. -- Eric Botcazou

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Eric Botcazou
's patch is acceptable, modulo a small tweak for -gnatD. Let me experiment a little bit though. -- Eric Botcazou

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-09 Thread Eric Botcazou
he location for Test2 is better > than no debug info at all? But we want no debug info at all for these IP functions. > What do you think? I guess I still don't understand why DECL_IGNORED_P was changed. -- Eric Botcazou

Re: [PATCH] Fix ICE when mixing VLAs and statement expressions [PR91038]

2021-08-09 Thread Eric Botcazou
omment is right, then Martin's patch should break Ada indeed. -- Eric Botcazou

Fix PR tree-optimization/101626

2021-08-05 Thread Eric Botcazou
This is a regression present on the mainline, caused by an oversight of mine in an earlier fix for SRA, whereby I forgot to exclude cases for reverse SSO. Tested on x86-64/Linux, applied on the mainline as obvious. 2021-08-05 Eric Botcazuo PR tree-optimization/101626 *

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-04 Thread Eric Botcazou
e still want to have location information in the compiler itself to debug it. -- Eric Botcazou

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-02 Thread Eric Botcazou
gt; 2021-07-24 Bernd Edlinger > > PR debug/101598 > * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the > DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to > UNKNOWN_LOCATION. Is that really needed in DWARF 5? If no, I'm not sure that we want it. -- Eric Botcazou

Re: [PATCH take 2] PR tree-optimization/38943: Preserve trapping instructions with -fpreserve-traps

2021-07-12 Thread Eric Botcazou
issue a warning that it requires -fexceptions if the latter is not enabled? -- Eric Botcazou

Re: [Ada] Always translate Is_Pure flag into pure in C sense

2021-07-09 Thread Eric Botcazou
> Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. > > > 2021-05-21 Eric Botcazou > > * gcc-interface/decl.c (gnat_to_gnu_subprog_type): Always translate > the Is_Pure flag into the "pure" attribute of GNU C. This is the mis

Fix PR target/101377

2021-07-09 Thread Eric Botcazou
are defined and HAVE_LD_BROKEN_PE_DWARF5 is not with it. Tested on x86-64/Linux and x86[-64]/Windows, OK for mainline and 11 branch? 2021-07-07 Eric Botcazou PR target/101377 * gcc.c.c (ASM_DEBUG_DWARF_OPTION): Set again to --gdwarf2 if HAVE_AS_WORKING_DWARF_N_FLAG

Re: Bootstrap failure of GCC 11.1.1 on x86_64-w64-mingw32

2021-07-08 Thread Eric Botcazou
> Maybe it was the EH format changes or dwarf5 stuff backported, CCing > Eric. Indeed, the latter, the HAVE_LD_BROKEN_PE_DWARF5 kludge is incomplete. -- Eric Botcazou

Re: [PATCH] PR tree-optimization/38943: Preserve trapping instructions with -fnon-call-exceptions

2021-07-08 Thread Eric Botcazou
y Richard, EH is orthogonal to side effects and pure/const. -- Eric Botcazou

[x86] Change EH pointer encodings to PC relative on Windows

2021-07-01 Thread Eric Botcazou
the .eh_frame section when processing the relocations contained in the .reloc section. The attached patch simply forces the PIC encodings for EH on PE-COFF targets. Tested on x86/Windows, OK for all active branches? 2021-07-01 Eric Botcazou * config/i386/i386.c

Fix PR ada/101094

2021-07-01 Thread Eric Botcazou
This is a minor regression present on mainline and 11 branch, whereby the value of the Enum_Rep attribute is always unsigned. Tested on x86-64/Linux, applied on the mainline and 11 branch. 2021-07-01 Eric Botcazou PR ada/101094 * exp_attr.adb (Get_Integer_Type): Return

[c-family] Fix duplicate name issues in output of -fdump-ada-spec #2

2021-07-01 Thread Eric Botcazou
This extends the type name conflict detection mechanism to variables. Tested on x86-64/Linux, applied on the mainline. 2021-07-01 Eric Botcazou c-family/ * c-ada-spec.c (check_name): Rename into... (check_type_name_conflict): ...this. Minor tweak

[c-family] Improve packed record layout support with -fdump-ada-spec

2021-07-01 Thread Eric Botcazou
We cannot fully support packed record layout in -fdump-ada-spec, as packing in C and Ada does not behave the same, so we issue a warning. But some simple cases are OK and can actually be handled without much work. Tested on x86-64/Linux, applied on the mainline. 2021-07-01 Eric Botcazou

[PATCH] Emit .file 0 marker earlier in DWARF 5

2021-06-23 Thread Eric Botcazou
to the beginning of the file (next to the .cfi_sections marker). Tested on x86-64/Linux and x86[-64]/Windows, OK for mainline and 11 branch? 2021-06-23 Eric Botcazou * dwarf2out.c (dwarf2out_assembly_start): Emit .file 0 marker here... (dwarf2out_finish): ...instead of here

[PATCH] Fix --gdwarf-5 configure tests for Windows

2021-06-23 Thread Eric Botcazou
The issues are that 1) they use readelf instead of objdump and 2) they use ELF syntax in the assembly code. Tested on x86-64/Linux and x86[-64]/Windows, OK for mainline and 11 branch? 2021-06-23 Eric Botcazou * configure.ac (--gdwarf-5 option): Use objdump instead of readelf

Re: [RFA] Minor improvement to compare elimination

2021-06-15 Thread Eric Botcazou
unk? Sure, thanks. -- Eric Botcazou

Re: [patch] Reuse non-gimple_reg variable for inlining

2021-06-09 Thread Eric Botcazou
DONLY marker in C/C++ if this is a lie. -- Eric Botcazou

Re: [PATCH] ifcvt: Fix -fcompare-debug bug [PR100852]

2021-06-09 Thread Eric Botcazou
g++.dg/opt/pr100852.C: New test. This looks obvious to me, but OK. -- Eric Botcazou

[SPARC] Reimplement LEAF_REG_REMAP macro

2021-06-06 Thread Eric Botcazou
The current implementation as an array of chars is indeed a bit awkward so this reimplements it as a function taking and returning an int. Tested on SPARC/Solaris, applied on the mainline. 2021-06-06 Eric Botcazou * config/sparc/sparc-protos.h (order_regs_for_local_alloc): Rename

[C] Fix thinko in new warning on type punning for storage order purposes

2021-06-06 Thread Eric Botcazou
that. Tested on x86-64/Linux, applied on the mainline as obvious. 2021-06-06 Eric Botcazou PR c/100920 * c-decl.c (finish_struct): Fix thinko in previous change. * c-typeck.c (convert_for_assignment): Do not warn on pointer assignment and initialization for storage

Re: [PATCH] libgcc: Fix _Unwind_Backtrace() for SEH

2021-06-04 Thread Eric Botcazou
https://gcc.gnu.org/pipermail/gcc-patches/2020-September/553418.html -- Eric Botcazou

[c-family] Fix duplicate name issues in output of -fdump-ada-spec

2021-06-03 Thread Eric Botcazou
The namespace rules are different in the C family of languages and in Ada, and a few adjustments are further needed in -fdump-ada-spec because of them. Tested on x86-64/Linux, applied on the mainline. 2021-06-03 Eric Botcazou c-family/ * c-ada-spec.c (dump_ada_enum_type): Dump

[c-family] Fix issue for nested record types with -fdump-ada-spec

2021-06-03 Thread Eric Botcazou
Ada does not support anonymous record declarations nested in other record declarations so -fdump-ada-spec needs to unnest them, and this contains a few fixes for this machinery. Tested on x86-64/Linux, applied on the mainline. 2021-06-03 Eric Botcazou c-family/ * c-ada-spec.c

[c-family] Fix issue for external subtypes with -fdump-ada-spec

2021-06-03 Thread Eric Botcazou
This works around an irregularity of the language whereby subtypes, unlike types, are not visible through a limited_with clause. Tested on x86-64/Linux, applied on the mainline. 2021-06-03 Eric Botcazou c-family/ * c-ada-spec.c (pp_ada_tree_identifier): Tidy up

[Ada] Fix miscompilation of predicate on bit-packed array types

2021-06-03 Thread Eric Botcazou
array types. Tested on x86-64/Linux, applied on the mainline. 2021-06-03 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Add PAT local constant and use it throughout. If it is set, use a ref-all pointer type for the pointer-to-array field of the fat pointer

Re: [patch] Tame fix for PR ipa/99122

2021-06-03 Thread Eric Botcazou
ytes on a case-by-case basis; when the size is uniform, this complication is unnecessary. > As for the patch we indeed didn't have a testcase covering the > return case so it should be safe to revert the return part. OK, thanks, patch installed. -- Eric Botcazou

[patch] Tame fix for PR ipa/99122

2021-06-02 Thread Eric Botcazou
Hi, as explained in the audit trail, the return part has a major performance impact in Ada where variable-sized types are first-class citizens, but it turns out that it is not exercized in the testsuite yet. Tested on x86-64/Linux, OK for mainline and 11 branch? 2021-06-02 Eric Botcazou

[DWARF] Couple of pending patches

2021-06-01 Thread Eric Botcazou
the last step before we can drop the historical GNAT encodings in favor of (GNU) DWARF. Thanks in advance. -- Eric Botcazou

[DWARF] Also generate DW_OP_GNU_variable_value at file scope

2021-05-28 Thread Eric Botcazou
But only for the reference variant (dw_val_class_die_ref). This is needed for variable-sized types declared at library level in Ada. Tested on x86-64/Linux, both GCC and GDB, OK for the mainline? 2021-05-28 Eric Botcazou * dwarf2out.c (loc_list_from_tree_1) : Also generate

Re: [C] Warn on type punning that toggles scalar storage order

2021-05-26 Thread Eric Botcazou
> OK Thanks. I have also installed the attached tweak to the documentation. PR c/100653 * doc/extend.texi (scalar_storage_order): Rephrase slightly. -- Eric Botcazoudiff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 3ddeb0dee3a..bfe9c21bddf 100644 ---

Re: [r12-1053 Regression] FAIL: libgomp.c++/task-reduction-8.C execution test on Linux/x86_64

2021-05-26 Thread Eric Botcazou
s apparently, hence the random outcome. -- Eric Botcazou

[C] Warn on type punning that toggles scalar storage order

2021-05-26 Thread Eric Botcazou
Hi, As documented in the manual, we do not support type punning that toggles the scalar storage order, so this adds a warning for the simple case of unions. Tested on x86-64/Linux, OK for the mainline? 2021-05-26 Eric Botcazou PR c/100653 * c-decl.c (finish_struct): Warn

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-26 Thread Eric Botcazou
> * gimplify.c (gimplify_decl_expr): Clear TREE_READONLY on the DECL > when really creating an initialization statement for it. Quite an interesting can of worms I have opened it seems. :-( So the change apparently causes OMP lowering to create dangling references, I have applied

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Eric Botcazou
> LGTM. Thanks, but a bit too bold because gimplify_and_add can promote the non-static DECL to static memory and reinstate DECL_INITIAL, so first hunk adjusted. * gimplify.c (gimplify_decl_expr): Clear TREE_READONLY on the DECL when really creating an initialization statement

[c++tools] Fix typo and weird syntax in configure script

2021-05-25 Thread Eric Botcazou
Tested on x86-64/Linux, applied on mainline and 11 branch as obvious. 2021-05-25 Eric Botcazou c++tools/ * configure.ac (--enable-maintainer-mode): Fix typo and weird syntax. * configure: Regenerate. -- Eric Botcazoudiff --git a/c++tools/configure.ac b/c++tools/configure.ac

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-25 Thread Eric Botcazou
> The problem with this patch is that it causes: > > FAIL: gnat.dg/opt94.adb scan-tree-dump-times optimized "worker" 1 > > which is exactly the testcase from the commit which caused the bug I am > trying to address. Sorry about that, a thinko in the original change, I'm testing this fixlet.

Re: [PATCH 2/11] use xxx_no_warning APIs in Ada

2021-05-25 Thread Eric Botcazou
> [PATCH 2/11] use xxx_no_warning APIs in Ada. Looks good to me, but remove the useless pair of parentheses in the 3rd hunk. -- Eric Botcazou

Re: [Ada] Detect illegal conditions in Raise_xxx_Error nodes

2021-05-21 Thread Eric Botcazou
> 2021-05-21 Piotr Trojanek > > * gcc-interface/trans.c (Raise_Error_to_gnu): Add an assertion. -- Eric Botcazoudiff --git a/gcc/ada/gcc-interface/trans.c b/gcc/ada/gcc-interface/trans.c index 289a2efcaf1..ee014a35cc2 100644 --- a/gcc/ada/gcc-interface/trans.c +++

[Ada] Detect illegal conditions in Raise_xxx_Error nodes

2021-05-21 Thread Eric Botcazou
. -- Eric Botcazou

[Ada] Consistently generate debug info for elaboration variables

2021-05-21 Thread Eric Botcazou
This makes sure that debug info is generated for elaboration variables, even if the variables are not generated exclusively for this purpose. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Do not pass

[Ada] Replace ? with ?? in warning messages

2021-05-21 Thread Eric Botcazou
The former has been deprecated in favor of the latter. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Ghjuvan Lacambre * gcc-interface/decl.c (gnat_to_gnu_entity): Replace ? with ??. (gnat_to_gnu_param): Likewise. (gnat_to_gnu_subprog_type): Likewise.

[Ada] Fix internal error on locally derived bit-packed array type

2021-05-21 Thread Eric Botcazou
This is a regression present on the mainline, 11 and 10 branches, in the form of an ICE on a locally derived bit-packed array type. Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Process

[Ada] Always translate Is_Pure flag into pure in C sense

2021-05-21 Thread Eric Botcazou
2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_subprog_type): Always translate the Is_Pure flag into the "pure" attribute of GNU C. -- Eric Botcazoudiff --git a/gcc/ada/gcc-interface/decl.c b/gcc/ada/gcc-interface/decl.c index a7595cbf514..19e851ff712

[Ada] Fix segfault at run time on strict-alignment platforms

2021-05-21 Thread Eric Botcazou
This fixes a regression present on the mainline and 11 branch by restricting the problematic change dealing with bitfields whose nomimal subtype is self- referential to the cases where the size is really lower. Tested on x86-64/Linux, applied on the mainline and 11 branch. 2021-05-21 Eric

[Ada] Fix spurious No_Elaboration violation for Size attribute

2021-05-21 Thread Eric Botcazou
We optimize the associated range check but nevertheless flag a violation. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/trans.c (Call_to_gnu): Minor tweaks. (gnat_to_gnu_external): Likewise. (Raise_Error_to_gnu): Return

[Ada] Fix incorrect SLOC on instruction

2021-05-21 Thread Eric Botcazou
This puts the missing SLOC on a statement generated by a return. Tested on x86-64/Linux, applied on the mainline, 11 and 10 branches. 2021-05-21 Eric Botcazou * gcc-interface/trans.c (gnat_to_gnu) : Put a SLOC on the assignment from the return value to the return

[Ada] Use EXACT_DIV_EXPR as much as possible

2021-05-21 Thread Eric Botcazou
...when the division is exact, typically dividing TYPE_SIZE by BITS_PER_UNIT. Tested on x86-64/Linux, applied on the mainline. 2021-05-21 Eric Botcazou * gcc-interface/decl.c (gnat_to_gnu_entity) : Replace CEIL_DIV_EXPR with EXACT_DIV_EXPR. * gcc-interface/misc.c

Re: Signedness of boolean types (and Ada)

2021-05-18 Thread Eric Botcazou
build_int_cst (TREE_TYPE (*expr_p), 1)); -- Eric Botcazou

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-17 Thread Eric Botcazou
+1822,7 @@ gimplify_decl_expr (tree *stmt_p, gimple_seq *seq_p) if (!TREE_STATIC (decl)) { DECL_INITIAL (decl) = NULL_TREE; + TREE_READONLY (decl) = 0; init = build2 (INIT_EXPR, void_type_node, decl, init); gimplify_and_add (init, seq_p); ggc_free (init); -- Eric Botcazou

Re: [PATCH] tree-sra: Avoid refreshing into const base decls (PR 100453)

2021-05-14 Thread Eric Botcazou
> FAIL: gnat.dg/spark1.adb (test for excess errors) > FAIL: gnat.dg/sync2.adb (test for excess errors) > FAIL: gnat.dg/synchronized1.adb (test for excess errors) Yes, it did, as well as PR boostrap/100597 probably. -- Eric Botcazou

[DWARF] Couple of pending patches

2021-05-14 Thread Eric Botcazou
. -- Eric Botcazou

Re: [PATCH][OBVIOUS] testsuite: prune new LTO warning

2021-05-13 Thread Eric Botcazou
> gcc/testsuite/ChangeLog: > > PR testsuite/100569 > * gcc.dg/atomic/c11-atomic-exec-2.c: Prune new LTO warning. > * gcc.dg/torture/pr94947-1.c: Likewise. Another one: PR testsuite/100569 * gnat.dg/lto21.adb: Prune new LTO warning. -- Eric Botcazoudiff --git

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> The following patch fixes that, ready for master? Sure, thanks! -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Do you know Eric where version.o needs to be added to be included in the > problematic command line? You can presumably remove it from GNATLINK_OBJS & GNATMAKE_OBJS. And it needs to be added to GNAT1_C_OBJS instead of GNAT_ADA_OBJS in Make-lang.in. -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Do you know Eric where version.o needs to be added to be included in the > problematic command line? Presumably to the beginning of TOOLS_LIBS in ada/gcc-interface/Makefile.in: TOOLS_LIBS = ../version.o ../link.o ../targext.o ../../ggc-none.o \ -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
Provide_Shift_Operators (Slot); in atree.ads with function Shift_Left (S : Slot; V : Natural) return Slot; pragma Import (Intrinsic, Shift_Left); function Shift_Right (S : Slot; V : Natural) return Slot; pragma Import (Intrinsic, Shift_Right); -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
fsf-funding.pod lto-dump.pod gfdl.pod gpl.pod cpp.pod gcov- dump.pod gcc.pod gcov-tool.pod make[3]: Leaving directory '/home/eric/build/gcc/native/gcc' make[2]: *** [Makefile:4781: all-stage1-gcc] Error 2 ada/gnatvsn.adb imports version_string from version.c -- Eric Botcazou

Re: [PATCH] Bump LTO_major_version to 11.

2021-05-10 Thread Eric Botcazou
> Ready for master? This breaks the build for me: make[3]: *** No rule to make target '/home/eric/cvs/gcc/gcc/version.c', needed by 'ada/stamp-sdefault'. Stop. make[3]: *** Waiting for unfinished jobs -- Eric Botcazou

Re: [GOVERNANCE] Where to file complaints re project-maintainers?

2021-05-09 Thread Eric Botcazou
> It is a gcc issue, see the very first link you've quoted ( > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92729). IIUC you're complaining about the bounty process, not about the GCC PR, so this technical list is not the appropriate place to do it. AFAICS you have already filed a complaint

[patch] Remove call to gcc_unreachable in range-op.cc

2021-05-08 Thread Eric Botcazou
Botcazou * range-op.cc (get_bool_state): Adjust head comment. (operator_not_equal::op1_range): Fix comment. (operator_bitwise_xor::op1_range): Remove call to gcc_unreachable. 2021-05-08 Eric Botcazou * gnat.dg/specs/opt5.ads: New test. * gnat.dg/specs

[patch] Fix incorrect array bounds with -fgnat-encodings=minimal in DWARF

2021-05-07 Thread Eric Botcazou
Hi, this makes add_subscript_info query the get_array_descr_info hook for the actual information when it is defined. Tested on x86-64/Linux, OK for mainline? 2021-05-07 Eric Botcazou * dwarf2out.c (add_subscript_info): Retrieve the bounds and the index type by means

[patch] Do not apply scalar storage order to pointer fields

2021-05-07 Thread Eric Botcazou
them out. Tested on x86-64/Linux, OK for mainline? 2021-05-07 Eric Botcazou * doc/extend.texi (scalar_storage_order): Mention effect on pointer and vector fields. * tree.h (reverse_storage_order_for_component_p): Return false if the type is a pointer. c

Re: Issue with pointer types marked with scalar_storage_order

2021-05-06 Thread Eric Botcazou
- line change in the reverse_storage_order_for_component_p predicate. -- Eric Botcazou

Fix PR target/100402

2021-05-05 Thread Eric Botcazou
it, but this breaks for some reason; at least it appears that a .seh_setframe directive with 0 as second argument always works, so the fix aligns it this way. Tested on x86-64/Windows, applied on the affected branches as obvious. 2021-05-05 Eric Botcazou PR target/100402 * config/i386

Re: [patch] Fix PR rtl-optimization/100411

2021-05-05 Thread Eric Botcazou
> At least for NOTE_INSN_BASIC_BLOCK skipping more than one might > be problematic, because that would mean we've skipped into a different basic > block and it wouldn't surprise me if split_block in that case crashed or > did something weird (if the first argument is not BLOCK_FOR_INSN of the >

Re: [patch] Fix PR rtl-optimization/100411

2021-05-05 Thread Eric Botcazou
> I mean, can't we have just one while loop that skips over all debug insns, > NOTE_INSN_BASIC_BLOCK_P, NOTE_INSN_PROLOGUE_END and NOTE_INSN_FUNCTION_BEG > and stops on anything else, or, if we want to skip at most one of some or > all of those note kinds, do some tracking if we've already skipped

[patch] Fix PR rtl-optimization/100411

2021-05-05 Thread Eric Botcazou
); the rest (CFG cleanup, BB reordering) is downhill from there. Tested on x86-64/Linux and x86-64/Windows, OK for mainline and 11 branch? 2021-05-05 Eric Botcazou PR rtl-optimization/100411 * cfgcleanup.c (try_crossjump_to_edge): Also skip end of prologue and beginning

Re: [PATCH] PR rtl-optimization/100263: Ensure register can change mode

2021-05-05 Thread Eric Botcazou
n > change mode. > > Bootstrapped and regtested releases/gcc-{8,9,10,11} and master on IBM Z. > Ok for those branches? Yes, OK everywhere, thanks. -- Eric Botcazou

Re: [patch] Generate debug info for local dynamic record types

2021-05-05 Thread Eric Botcazou
gs=minimal but it's actually easy to check in DWARF 5. * gnat.dg/debug17.adb: New test. -- Eric Botcazou-- { dg-do compile } -- { dg-skip-if "No Dwarf" { { hppa*-*-hpux* } && { ! lp64 } } } -- { dg-options "-cargs -O0 -g -dA -fgnat-encodings=minimal -margs" } pra

Re: [wwwdocs] Remove CC0 from backends.html

2021-05-04 Thread Eric Botcazou
> Pushed. What is next? :-) You can finally remove powerpcspe. :-) -- Eric Botcazou

Re: [PATCH] Remove CC0

2021-05-04 Thread Eric Botcazou
I don't know if such splitting would directly > lead to the ability to remove the redundant compares - it might need a > new pass to spot them. Do you mean in addition to the existing pass_compare_elim_after_reload? -- Eric Botcazou

Re: [PATCH] Avoid DSE/DCE of pure call that throws

2021-05-04 Thread Eric Botcazou
ion, but may read global memory). */ #define DECL_PURE_P(NODE) (FUNCTION_DECL_CHECK (NODE)>function_decl.pure_flag) Maybe: "Note that being pure or const for a function is orthogonal to being no-throw, i.e. it is valid to have DECL_PURE_P set and TREE_NOTHROW cleared". -- Eric Botcazou

Re: [patch] Reuse non-gimple_reg variable for inlining

2021-05-03 Thread Eric Botcazou
> Hmm, instead of (ab-)using debug_map can we instead use sth like setting > TREE_VISITED on the argument decl (not the value - it might be passed > multiple tiimes)? IIRC TREE_VISITED state is undetermined thus we can > clear it at the start of setup_one_parameter and set it when we want to >

Re: [PATCH] Avoid DSE/DCE of pure call that throws

2021-05-03 Thread Eric Botcazou
ion. -- Eric Botcazou

[patch] Reuse non-gimple_reg variable for inlining

2021-05-03 Thread Eric Botcazou
needs to be prevented from creating a CLOBBER for the cases where it ends uo being reused. Tested on x86-64/Linux, OK for the mainline? 2021-05-03 Eric Botcazou * tree-inline.c (setup_one_parameter): Do not create a variable if the value is either a read-only DECL or a non

[patch] Fix libiberty link failure in LTO mode

2021-05-03 Thread Eric Botcazou
to be resolved in LTO mode. Tested on x86-64/Linux, x86-64/Windows and x86/Windows, OK for the mainline? 2021-05-03 Eric Botcazou * builtins.c (builtin_with_linkage_p): Return true for stp[n]cpy. * symtab.c (symtab_node::output_to_lto_symbol_table_p): Tidy up. -- Eric Botcazoudiff

[libiberty] Make test for variables more robust

2021-05-03 Thread Eric Botcazou
qrstuvwxyz' 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'` AC_DEFINE_UNQUOTED($n) else AC_MSG_RESULT(no) fi done because the assignment to 'p' is optimized away by LTO. This is visible on MinGW platforms in the form of a link failure for sys_siglist. Tested on x86-64/Linux, x86-64/Windows and x86/Windows, OK for t

[patch] Generate debug info for local dynamic record types

2021-05-01 Thread Eric Botcazou
? 2021-05-01 Eric Botcazou * dwarf2out.c (loc_list_from_tree_1) : During early DWARF, do not expand the VALUE_EXPR of variables put in the non-local frame. * gimplify.c (gimplify_type_sizes) : If the type is not to be ignored for debug info, ensure its variable

[SPARC] Small housekeeping work

2021-04-29 Thread Eric Botcazou
Tested on SPARC/Solaris and SPARC64/Linux, applied on the mainline. 2021-04-29 Eric Botcazou * config/sparc/sparc.c (gen_load_pcrel_sym): Delete. (load_got_register): Do the PIC dance here. (sparc_legitimize_tls_address): Simplify

[patch] Add parallelism support to gcov for MinGW platforms

2021-04-29 Thread Eric Botcazou
do a profiled bootstrap with -jN, N > 1, on these platforms. Tested on x86-64/Linux, x86-64/Windows and x86/Windows, OK for the mainline? 2021-04-29 Eric Botcazou libgcc/ * libgcc/libgcov.h: For the target, define GCOV_LOCKED_WITH_LOCKING if __MSVCRT__ and, for the host,

[Ada] Avoid creating useless local bounds around calls

2021-04-28 Thread Eric Botcazou
This prevents the compiler from creating useless local bounds around calls that take a parameter of an unconstrained array type when the bounds already exist somewhere else for the actual parameter. Tested on x86-64/Linux, applied on the mainline. 2021-04-28 Eric Botcazou * gcc

[Ada] Get rid of useless temporary for call to pure function

2021-04-28 Thread Eric Botcazou
This avoids creating a useless temporary for a call to a pure function with good properties by using the RSO. Tested on x86-64/Linux, applied on the mainline. 2021-04-28 Eric Botcazou * gcc-interface/trans.c (is_array_of_scalar_type): New predicate. (find_decls_r): New

[Ada] Fix loss of optimization of array iteration due to inlining

2021-04-28 Thread Eric Botcazou
This helps loop-invariant motion to hoist complicated offset computations. Tested on x86-64/Linux, applied on the mainline. 2021-04-28 Eric Botcazou * gcc-interface/trans.c (language_function): Add comment. (loop_info_d): Add fndecl and invariants fields

Re: [DWARF] Fix signedness issue in DWARF functions (2)

2021-04-27 Thread Eric Botcazou
> Yes, but even bitsizetype is undistinguishable from other (usually 2 * > pointer size) precision integral types. OK, I can propose the attached patch. The typed_binop_from_tree computation works on my Ada testcase in 32-bit mode from within GDB, but not in 64-bit mode because GDB chokes

Re: [DWARF] Fix signedness issue in DWARF functions (2)

2021-04-26 Thread Eric Botcazou
k; This also looks incorrect if the size is larger than DWARF2_ADDR_SIZE then, isn't there a typo in the code? if (GET_MODE_SIZE (int_mode) < DWARF2_ADDR_SIZE) { op = DW_OP_div; goto do_binop; } -- Eric Botcazou

[DWARF] Fix signedness issue in DWARF functions (1)

2021-04-26 Thread Eric Botcazou
on x86-64/Linux, both GCC and GDB, OK for the mainline? 2021-04-26 Eric Botcazou * dwarf2out.c (scompare_loc_descriptor): Fix head comment. (is_handled_procedure_type): Likewise. (struct loc_descr_context): Add strict_signedness field. (resolve_args_picking_1

<    1   2   3   4   5   6   7   8   9   10   >