Re: [CHKP] Support returned bounds in thunks expand

2015-04-07 Thread Ilya Enkovich
is OK then (preferably merging as much as possible with ipa-split) Honza Here is a refactored version with common code moved to tree-chkp.c. Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it look OK? Thanks, Ilya -- gcc/ 2015-04-07 Ilya Enkovich ilya.enkov

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-06 Thread Ilya Enkovich
2015-04-03 20:09 GMT+03:00 Jan Hubicka hubi...@ucw.cz: That is the reason for fixing chains in privatize_symbol_name. OK, so with your proposed patch you produce the links during lto-stream-in but because the links may be wrong due to multiple different symbol sharing same assembler name

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-06 Thread Ilya Enkovich
2015-04-03 21:49 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Assembler name of instrumented function is a transparent alias of original function's name. Alias chains are not taken into account by analysis. Thus we see no conflict between instrumented function's name and a variable name but emit

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-04-06 Thread Ilya Enkovich
On 05 Apr 19:44, Sandra Loosemore wrote: On 04/03/2015 01:34 PM, Joseph Myers wrote: On Tue, 31 Mar 2015, Ilya Enkovich wrote: +library. It also passes '-z bndplt' to a linker in case it supports this +option (which is checked on libmpx configuration). Note that old versions +of linker

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-04-06 Thread Ilya Enkovich
2015-04-06 18:28 GMT+03:00 Jeff Law l...@redhat.com: On 04/06/2015 09:17 AM, Ilya Enkovich wrote: To tell the truth, I can't figure out what this means from a user perspective. How does a user know whether the linker option is being ignored, or if they have a new enough linker

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-06 Thread Ilya Enkovich
2015-04-03 20:12 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Currently ipa_comdats doesn't set comdat groups for thunks. At the I see, that is a bug. It is supposed to keep thunks in the same section as their target (thunks doesn't really work across sections on some target, like PPC, because

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-03 Thread Ilya Enkovich
2015-04-02 20:01 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Ping It would help if you add hubi...@ucw.cz to CC for IPA related patches. 2015-03-19 11:34 GMT+03:00 Ilya Enkovich enkovich@gmail.com: On 12 Mar 13:27, Ilya Enkovich wrote: Hi, Currently cgraph merge has several issues

Re: [CHKP] Support returned bounds in thunks expand

2015-04-03 Thread Ilya Enkovich
2015-04-02 23:55 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Ping 2015-03-10 13:12 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, Currentl we loose returned bounds when functions are merged. This patch fixes it by adding returne bounds support for cgraph_node::expand_thunk

Re: [PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-03 Thread Ilya Enkovich
reference local symbol in comdat not being in comdat by itself. This patch fixes the problem. Doesn't affect not instrumented code. Testing is in progress. Does it look OK? Thanks, Ilya -- gcc/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com * ipa-comdats.c (ipa_comdats): Visit

Re: [CHKP] Support returned bounds in thunks expand

2015-04-03 Thread Ilya Enkovich
2015-04-02 22:42 GMT+03:00 Jeff Law l...@redhat.com: On 04/02/2015 08:49 AM, Ilya Enkovich wrote: Ping 2015-03-10 13:12 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, Currentl we loose returned bounds when functions are merged. This patch fixes it by adding returne bounds support

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-03 Thread Ilya Enkovich
2015-04-02 21:48 GMT+03:00 Jan Hubicka hubi...@ucw.cz: On 03/20/2015 02:20 AM, Ilya Enkovich wrote: Hi, Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. We always expect it for instrumentation clones, thus restore it input_cgraph_1. Bootstrapped and tested

Re: [CHKP] Never expand instrumentation thunks

2015-04-03 Thread Ilya Enkovich
2015-04-03 0:13 GMT+03:00 Jan Hubicka hubi...@ucw.cz: On 04/02/2015 02:11 PM, Jan Hubicka wrote: 2015-03-18 Ilya Enkovich ilya.enkov...@intel.com * cgraphunit.c (cgraph_node::expand_thunk): Don't expand instrumentation thunks. diff --git a/gcc/cgraphunit.c b/gcc

Re: [PATCH, CHKP] Fix cdtor merge for instrumented functions

2015-04-03 Thread Ilya Enkovich
/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com * ipa.c (ipa_cdtor_merge): Skip instrumentation thunks. So the problem here is that you do have two names for the function, one that is not instrumented and other that is instrumented? I am bit surprised we get instrumentation

Re: ipa-cp heuristic tweek

2015-04-03 Thread Ilya Enkovich
2015-03-31 15:32 GMT+03:00 Ilya Enkovich enkovich@gmail.com: 2015-03-29 18:43 GMT+03:00 Jan Hubicka hubi...@ucw.cz: +static bool +set_single_call_flag (cgraph_node *node, void *) +{ + cgraph_edge *cs = node-callers; + /* Local thunks can be handled transparently, skip them

Re: [PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-03 Thread Ilya Enkovich
/ 2015-04-03 Ilya Enkovich ilya.enkov...@intel.com * tree-chkp.c (chkp_find_const_bounds_var): Search by assembler name. (chkp_make_static_const_bounds): Use make_decl_one_only. gcc/testsuite/ 2015-04-03 Ilya Enkovich ilya.enkov...@intel.com * gcc.dg/lto/chkp

[PATCH, CHKP] Fix static const bounds creation in LTO

2015-04-02 Thread Ilya Enkovich
? Thanks, Ilya -- gcc/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com * tree-chkp.c (CHKP_LTO_SYMBOL_SUFFIX): New. (chkp_make_static_const_bounds): Use another symbol in LTO. gcc/testsuite/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com * gcc.dg/lto/chkp

[PATCH, CHKP, i386] Fix retval generated for instrumented calls returning values on multiple registers

2015-04-02 Thread Ilya Enkovich
] function_decl 0x7fb609bf7ca8 test1.chkp) [0 test1.chkp S1 A8]) (const_int 0 [0]))) complex.c:11 670 {*call_value} Only MPX target is affected. Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it look OK? Thanks, Ilya -- 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com

[PATCH, CHKP] Fix ipa-comdats for instrumentation thunks

2015-04-02 Thread Ilya Enkovich
. This patch fixes the problem. Doesn't affect not instrumented code. Testing is in progress. Does it look OK? Thanks, Ilya -- gcc/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com * ipa-comdats.c (ipa_comdats): Visit all instrumentation thunks to set proper comdat group

[PATCH, CHKP] Fix cdtor merge for instrumented functions

2015-04-02 Thread Ilya Enkovich
Hi, This patch doesn't allow instrumentation thunks calls while merging constructors and destructors. Not isntrumented code is not affeceted. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-04-02 Ilya Enkovich ilya.enkov...@intel.com

Re: [CHKP] Support returned bounds in thunks expand

2015-04-02 Thread Ilya Enkovich
Ping 2015-03-10 13:12 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, Currentl we loose returned bounds when functions are merged. This patch fixes it by adding returne bounds support for cgraph_node::expand_thunk. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-04-02 Thread Ilya Enkovich
Ping 2015-03-19 11:34 GMT+03:00 Ilya Enkovich enkovich@gmail.com: On 12 Mar 13:27, Ilya Enkovich wrote: Hi, Currently cgraph merge has several issues with instrumented code: - original function node may be removed = no assembler name conflict is detected between function and variable

Re: [CHKP] Never expand instrumentation thunks

2015-04-02 Thread Ilya Enkovich
Ping. Patch doesn't affect not instrumented code. Thanks, Ilya 2015-03-18 15:19 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, This patch disables attempts to expand instrumentation thunks which appear when we create specialized function versions. Problem was found during SPEC2006

Re: [PATCH, CHKP] Restore transparent alias chains

2015-04-02 Thread Ilya Enkovich
Ping. This patch doesn't affect not instrumented code. Thanks, Ilya 2015-03-20 11:20 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. We always expect it for instrumentation clones, thus restore

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-04-02 Thread Ilya Enkovich
On 24 Mar 15:06, Jakub Jelinek wrote: On Tue, Mar 24, 2015 at 12:22:27PM +0300, Ilya Enkovich wrote: 2015-03-24 11:33 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Thu, Mar 19, 2015 at 11:29:44AM +0300, Ilya Enkovich wrote: + /* We might propagate instrumented function pointer

Re: [PATCH, PR target/65602] Fix check_effective_target_mpx to check lib availability

2015-03-31 Thread Ilya Enkovich
2015-03-30 23:30 GMT+03:00 Rainer Orth r...@cebitec.uni-bielefeld.de: I originally reported the bug and did test the patch over the weekend: the Solaris/x86 testsuite failures are gone, so that part is fine. I couldn't of course test the alloca - __builtin_alloca change since the tests aren't

Re: Fix ice on comdat groups with -check-pointer-bounds

2015-03-31 Thread Ilya Enkovich
2015-03-30 20:20 GMT+03:00 Jan Hubicka hubi...@ucw.cz: On 30 Mar 14:05, Ilya Enkovich wrote: 2015-03-27 18:23 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Index: symtab.c === --- symtab.c(revision 221734) +++ symtab.c

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-31 Thread Ilya Enkovich
On 23 Mar 13:19, Ilya Enkovich wrote: Hi, May this patch go into trunk at this point? It is very important for dynamic MPX codes. Thanks, Ilya I additionally documented changes in invoke.texi. OK for trunk? Thanks, Ilya -- gcc/ 2015-03-31 Ilya Enkovich ilya.enkov...@intel.com

Re: ipa-cp heuristic tweek

2015-03-31 Thread Ilya Enkovich
2015-03-29 18:43 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Hi, this patch improve crafty performance by avoiding ipa-cp clonning of Search function that specializes the first iteration of the recursion. The patch is by Martin, I only tested it and cleaned up code in count_callers and

Re: Fix ice on comdat groups with -check-pointer-bounds

2015-03-30 Thread Ilya Enkovich
2015-03-27 18:23 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Hi, this patch fixes bug in symtab_node::verify_symtab_nodes pointed out by Ilya. The loop checking that there all comdats are linked by same_comdat_group was completely bogus. In addition it checked also external symbols that are

Re: Fix ice on comdat groups with -check-pointer-bounds

2015-03-30 Thread Ilya Enkovich
2015-03-27 18:23 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Hi, this patch fixes bug in symtab_node::verify_symtab_nodes pointed out by Ilya. The loop checking that there all comdats are linked by same_comdat_group was completely bogus. In addition it checked also external symbols that are

[PATCH, PR target/65602] Fix check_effective_target_mpx to check lib availability

2015-03-30 Thread Ilya Enkovich
with __builtin_alloca calls. Have no machine to test it though (Linux testing is OK). Any help with testing? Does it look OK? Thanks, Ilya -- 2015-03-30 Ilya Enkovich ilya.enkov...@intel.com PR target/65602 * gcc.target/i386/mpx/alloca-1-lbv.c (mpx_test): Use

Re: Fix ice on comdat groups with -check-pointer-bounds

2015-03-30 Thread Ilya Enkovich
On 30 Mar 14:05, Ilya Enkovich wrote: 2015-03-27 18:23 GMT+03:00 Jan Hubicka hubi...@ucw.cz: Index: symtab.c === --- symtab.c(revision 221734) +++ symtab.c(working copy) @@ -1130,15 +1130,20 @@ symtab_node

Re: [PATCH, PR target/65495] List available languages for all chkp options

2015-03-27 Thread Ilya Enkovich
2015-03-27 13:13 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Fri, Mar 27, 2015 at 10:44 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch avoids various ICEs due to -fcheck-pointer-bounds used for not supported languages. All options get the same languages list

[PATCH, PR target/65495] List available languages for all chkp options

2015-03-27 Thread Ilya Enkovich
Hi, This patch avoids various ICEs due to -fcheck-pointer-bounds used for not supported languages. All options get the same languages list. Bootstrapped and tested on x86_64-unknown-linux-gnu. Does it look OK? Thanks, Ilya -- 2015-03-27 Ilya Enkovich ilya.enkov...@intel.com PR

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-25 Thread Ilya Enkovich
2015-03-24 17:06 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Tue, Mar 24, 2015 at 12:22:27PM +0300, Ilya Enkovich wrote: 2015-03-24 11:33 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Thu, Mar 19, 2015 at 11:29:44AM +0300, Ilya Enkovich wrote: + /* We might propagate instrumented function

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-25 Thread Ilya Enkovich
2015-03-24 17:40 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Tue, Mar 24, 2015 at 3:06 PM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Mar 24, 2015 at 12:22:27PM +0300, Ilya Enkovich wrote: The question is what you want to do in the LTO case for the different cases

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-25 Thread Ilya Enkovich
2015-03-25 11:16 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Wed, Mar 25, 2015 at 11:05:17AM +0300, Ilya Enkovich wrote: The question is what you want to do in the LTO case for the different cases, in particular a TU compiled with -fcheck-pointer-bounds and LTO link without

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-25 Thread Ilya Enkovich
2015-03-25 12:50 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Wed, Mar 25, 2015 at 10:38:56AM +0100, Richard Biener wrote: --- gcc/passes.c(revision 221633) +++ gcc/passes.c(working copy) @@ -156,7 +156,8 @@ void pass_manager::execute_early_local_passes () {

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-25 Thread Ilya Enkovich
2015-03-25 13:15 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Wed, Mar 25, 2015 at 10:50 AM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Mar 25, 2015 at 10:38:56AM +0100, Richard Biener wrote: --- gcc/passes.c(revision 221633) +++ gcc/passes.c(working copy) @@

[PATCH, CHKP, PR target/65508] Set static chain for instrumented calls

2015-03-25 Thread Ilya Enkovich
Hi, This patch fixes PR target/65508 by proper copy of static chain for instrumented calls. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk or wait for stage 1? Thanks, Ilya -- gcc/ 2015-03-25 Ilya Enkovich ilya.enkov...@intel.com PR target/65508 * tree

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-24 Thread Ilya Enkovich
2015-03-24 11:33 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Thu, Mar 19, 2015 at 11:29:44AM +0300, Ilya Enkovich wrote: + /* We might propagate instrumented function pointer into + not instrumented function and vice versa. In such a + case we need to either fix function declaration

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-23 Thread Ilya Enkovich
Hi, May this patch go into trunk at this point? It is very important for dynamic MPX codes. Thanks, Ilya 2015-03-18 14:56 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, This patch fixes PR target/65444 by passing '-z bndplt' to linker when appropriate. Bootstrapped and tested

[PATCH, CHKP] Restore transparent alias chains

2015-03-20 Thread Ilya Enkovich
Hi, Identifiers read with input_identifier miss IDENTIFIER_TRANSPARENT_ALIAS bit. We always expect it for instrumentation clones, thus restore it input_cgraph_1. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-03-20 Ilya Enkovich ilya.enkov

Re: [CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-19 Thread Ilya Enkovich
On 12 Mar 13:09, Ilya Enkovich wrote: Hi, Instrumented function pointer may be propagated into not instrumented indirect call and vice versa. It requires additional call modifications (either remove bounds or change callee). Bootstrapped and tested on x86_64-unknown-linux-gnu. OK

[PATCH, CHKP] Fix references for instrumented aliases

2015-03-19 Thread Ilya Enkovich
-gnu. Will apply after prerequisite patch (https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00992.html) is applied. Thanks, Ilya -- gcc/ 2015-03-19 Ilya Enkovich ilya.enkov...@intel.com * ipa-chkp.c (chkp_maybe_create_clone): Create alias reference when cloning alias node. gcc

Re: [CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-03-19 Thread Ilya Enkovich
On 12 Mar 13:27, Ilya Enkovich wrote: Hi, Currently cgraph merge has several issues with instrumented code: - original function node may be removed = no assembler name conflict is detected between function and variable - only orig_decl name is privatized for instrumented function = node

[PATCH, CHKP, Committed] Don't try to clone instrumented thunks

2015-03-19 Thread Ilya Enkovich
Hi, When thunk is cloned, its callee is temporarily set to original thunks's target which is later also cloned. Thus we should be more careful when clonning node's thunks. Bootstrapped and tested on x86_64-unknown-linux-gnu. Applied to trunk. Thanks, Ilya -- 2015-03-19 Ilya Enkovich

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 15:42 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Wed, Mar 18, 2015 at 1:25 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Mar 18, 2015 at 5:13 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 15:08 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 16:31 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 6:24 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 15:42 GMT+03:00 Richard Biener richard.guent...@gmail.com: On Wed, Mar 18, 2015 at 1:25 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Mar 18, 2015

[CHKP] Never expand instrumentation thunks

2015-03-18 Thread Ilya Enkovich
-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-03-18 Ilya Enkovich ilya.enkov...@intel.com * cgraphunit.c (cgraph_node::expand_thunk): Don't expand instrumentation thunks. diff --git a/gcc/cgraphunit.c b/gcc/cgraphunit.c index e640907..abc9cfe 100644 --- a/gcc/cgraphunit.c +++ b

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 15:02 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 4:56 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR target/65444 by passing '-z bndplt' to linker when appropriate. Bootstrapped and tested on x86_64-unknown-linux-gnu. Will commit

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 15:08 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 5:05 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 15:02 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 4:56 AM, Ilya Enkovich enkovich@gmail.com wrote: Hi, This patch fixes PR

[PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
Hi, This patch fixes PR target/65444 by passing '-z bndplt' to linker when appropriate. Bootstrapped and tested on x86_64-unknown-linux-gnu. Will commit it to trunk in a couple of days if no objections arise. Thanks, Ilya -- gcc/ 2015-03-18 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 16:52 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 6:41 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 16:31 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 6:24 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 15:42 GMT+03:00

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 17:42 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 7:31 AM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Mar 18, 2015 at 7:02 AM, Jakub Jelinek ja...@redhat.com wrote: Yeah, I agree, the configure check is a reasonable thing to do. We should either always pass -z

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 20:14 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 10:13 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 19:45 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 9:14 AM, Ilya Enkovich enkovich@gmail.com wrote: Instrumented binary

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 20:39 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 10:34 AM, Ilya Enkovich What is USER? The one who build GCC may not be same person who uses GCC. The person who build GCC determines its default behavior. User either uses it with default settings

Re: [PATCH, libmpx, i386, PR driver/65444] Pass '-z bndplt' when building dynamic objects with MPX

2015-03-18 Thread Ilya Enkovich
2015-03-18 19:45 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 9:14 AM, Ilya Enkovich enkovich@gmail.com wrote: 2015-03-18 17:42 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 18, 2015 at 7:31 AM, H.J. Lu hjl.to...@gmail.com wrote: MPX is a security feature. Knowing

[CHKP, PATCH] Fix instrumented indirect calls with propagated pointers

2015-03-12 Thread Ilya Enkovich
Ilya Enkovich ilya.enkov...@intel.com * cgraph.c (cgraph_edge::redirect_call_stmt_to_callee): Add redirection for instrumented calls. * tree-chkp.h (chkp_copy_call_skip_bounds): New. (chkp_redirect_edge): New. * tree-chkp.c (chkp_copy_call_skip_bounds): New

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-03-12 Thread Ilya Enkovich
2015-03-12 12:02 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Thu, Mar 12, 2015 at 11:51:51AM +0300, Ilya Enkovich wrote: On 09 Mar 15:51, Jakub Jelinek wrote: On Mon, Mar 02, 2015 at 01:25:43PM +0300, Ilya Enkovich wrote: --- a/gcc/toplev.c +++ b/gcc/toplev.c @@ -1376,6 +1376,11

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-03-12 Thread Ilya Enkovich
On 09 Mar 15:51, Jakub Jelinek wrote: On Mon, Mar 02, 2015 at 01:25:43PM +0300, Ilya Enkovich wrote: --- a/gcc/toplev.c +++ b/gcc/toplev.c @@ -1376,6 +1376,11 @@ process_options (void) { if (targetm.chkp_bound_mode () == VOIDmode) error (-fcheck-pointer

[CHKP, PATCH] Fix LTO cgraph merge for instrumented functions

2015-03-12 Thread Ilya Enkovich
reachable, privatizing both nodes and fixing chkp references. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-03-12 Ilya Enkovich ilya.enkov...@intel.com * ipa-chkp.h (chkp_maybe_fix_chkp_ref): New. * ipa-chkp.c

Re: [PATCH, PR target/65103, 1/3] Fix cost of PIC register in ix86_address_cost

2015-03-12 Thread Ilya Enkovich
10 (-97%) 181.mcf 4 0 (-100%)4 2 (-50%) Do you also have executable sizes at hand? Summary size change for SPEC2000 on -O2 is -0,11%. 2015-03-10 Ilya Enkovich ilya.enkov...@intel.com PR target/65103 * config/i386/i386.c (ix86_address_cost

Re: [patch] disable libmpx x32 multilib builds

2015-03-12 Thread Ilya Enkovich
On 11 Mar 19:11, Ilya Enkovich wrote: 2015-03-11 18:59 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 11, 2015 at 7:37 AM, Matthias Klose d...@ubuntu.com wrote: current trunk fails to build on x86*-linux, when configured for x32 multilibs because libmpx doesn't support these. Disable

Re: [patch] disable libmpx x32 multilib builds

2015-03-11 Thread Ilya Enkovich
2015-03-11 18:59 GMT+03:00 H.J. Lu hjl.to...@gmail.com: On Wed, Mar 11, 2015 at 7:37 AM, Matthias Klose d...@ubuntu.com wrote: current trunk fails to build on x86*-linux, when configured for x32 multilibs because libmpx doesn't support these. Disable them. ok for the trunk? *

[CHKP] Support returned bounds in thunks expand

2015-03-10 Thread Ilya Enkovich
Hi, Currentl we loose returned bounds when functions are merged. This patch fixes it by adding returne bounds support for cgraph_node::expand_thunk. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-03-06 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-03-10 Thread Ilya Enkovich
On 10 Mar 18:00, Ilya Enkovich wrote: Hi, This patch allows propagation of loop invariants for i386 if propagated value is a constant to be used in address operand. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk or stage 1? Thanks, Ilya Updated ChangeLog and test

Re: [PATCH, PR target/65103, 1/3] Fix cost of PIC register in ix86_address_cost

2015-03-10 Thread Ilya Enkovich
On 10 Mar 16:17, Jakub Jelinek wrote: On Tue, Mar 10, 2015 at 05:54:46PM +0300, Ilya Enkovich wrote: This patches set addresses the problem of inefficient usage of x86 addressing modes in PIC. Looking into generated 32bit PIC assembler we may see lots of 'leal symbol@GOTOFF, %reg

[PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants

2015-03-10 Thread Ilya Enkovich
Ilya Enkovich ilya.enkov...@intel.com PR target/65103 * gcc/config/i386/i386.c (ix86_rtx_costs): We want to propagate link time constants into adress expressions and therefore set their cost to 0. gcc/testsuite/ 2015-03-10 Ilya Enkovich ilya.enkov...@intel.com

Re: [PATCH, PR target/65103, 3/3] Change rtx cost for i386 address constants

2015-03-10 Thread Ilya Enkovich
On 10 Mar 18:11, Ilya Enkovich wrote: Hi, This patch changes rtx cost for address constants to 0 similar to what we have in address cost hook beacuse we expect them to be propagated into address expression anyway. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk

[PATCH, PR target/65103, 1/3] Fix cost of PIC register in ix86_address_cost

2015-03-10 Thread Ilya Enkovich
. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-03-10 Ilya Enkovich ilya.enkov...@intel.com PR target/65103 * gcc/config/i386/i386.c (ix86_address_cost): Fix cost of a PIC register. gcc/testsuite/ 2015-03-10 Ilya Enkovich

[PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-03-10 Thread Ilya Enkovich
Hi, This patch allows propagation of loop invariants for i386 if propagated value is a constant to be used in address operand. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk or stage 1? Thanks, Ilya -- gcc/ 2015-03-10 Ilya Enkovich ilya.enkov...@intel.com PR

Re: [PATCH, CHKP, PR target/65183] Avoid wrong pass local data usage

2015-03-02 Thread Ilya Enkovich
2015-03-02 15:25 GMT+03:00 Maxim Kuvyrkov maxim.kuvyr...@linaro.org: On Mar 2, 2015, at 1:41 PM, Ilya Enkovich enkovich@gmail.com wrote: Committed to trunk. Hi Ilya, Was this approved offline? If so, it is a good habit to note in the Committed to trunk message who approved

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-03-02 Thread Ilya Enkovich
Ping 2015-02-16 20:15 GMT+03:00 Ilya Enkovich enkovich@gmail.com: On 16 Feb 17:01, Jakub Jelinek wrote: On Mon, Feb 16, 2015 at 06:56:45PM +0300, Ilya Enkovich wrote: On 16 Feb 16:31, Jakub Jelinek wrote: On Mon, Feb 16, 2015 at 06:20:59PM +0300, Ilya Enkovich wrote: This patch

[committed] add new roles to MAINTAINERS

2015-03-02 Thread Ilya Enkovich
Hi, I've checked in this patch adding new roles for myself. Thanks, Ilya -- 2015-03-02 Ilya Enkovich ilya.enkov...@intel.com * MAINTAINERS (Various Maintainers): Add myself as libmpx, pointer bounds checker and i386 MPX maintainer. Index: MAINTAINERS

Re: [PATCH, CHKP, i386, PR target/65184] Fix pass_by_reference for MS ABI for bounds

2015-03-02 Thread Ilya Enkovich
Committed to trunk. 2015-02-25 17:25 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, Currenly ix86_pass_by_reference may return 1 for bounds if MS ABI is used. This patch explicitly says bounds are never passed by reference. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK

Re: [PATCH, CHKP, PR target/65183] Avoid wrong pass local data usage

2015-03-02 Thread Ilya Enkovich
Committed to trunk. 2015-02-25 12:19 GMT+03:00 Ilya Enkovich enkovich@gmail.com: Hi, This patch fixes a case when outdated checker local data is used to process external calls. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2015-03-02 Thread Ilya Enkovich
On 09 Dec 23:56, Ilya Enkovich wrote: 2014-12-09 22:57 GMT+03:00 Jeff Law l...@redhat.com: Wasn't this duplicated in the mpx-wrapper patch? Wrappers patch introduces similar option static-libmpxwrappers. I think this is OK on the technical side. I need to do to some vote tallying

Re: MPX runtime inclusion for GCC 5

2015-02-26 Thread Ilya Enkovich
2015-02-26 11:30 GMT+03:00 Richard Biener rguent...@suse.de: On Wed, 25 Feb 2015, Jeff Law wrote: So the steering committee has agreed to include the MPX runtime in GCC. The runtime bits are a necessary component to actually make use of the MPX capabilities. GCC is a downstream consumer

[PATCH, CHKP, i386, PR target/65184] Fix pass_by_reference for MS ABI for bounds

2015-02-25 Thread Ilya Enkovich
Hi, Currenly ix86_pass_by_reference may return 1 for bounds if MS ABI is used. This patch explicitly says bounds are never passed by reference. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich ilya.enkov...@intel.com

[PATCH, CHKP, i386, PR target/65167] Avoid motion of bounds args during scheduling

2015-02-25 Thread Ilya Enkovich
Hi, This patch adds support for bounds registers into args recognition mechanism used by scheduler. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich ilya.enkov...@intel.com PR target/65167 * gcc/config/i386

Re: need help with Pointer Bounds Checking documentation

2015-02-25 Thread Ilya Enkovich
2015-02-25 19:16 GMT+03:00 Sandra Loosemore san...@codesourcery.com: On 02/25/2015 12:56 AM, Ilya Enkovich wrote: 2015-02-24 19:47 GMT+03:00 Sandra Loosemore san...@codesourcery.com: Poking around, I see that the -fcheck-pointer-bounds and various -fchkp-* options are listed in c-family

[PATCH, CHKP, PR target/65183] Avoid wrong pass local data usage

2015-02-25 Thread Ilya Enkovich
Hi, This patch fixes a case when outdated checker local data is used to process external calls. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-25 Ilya Enkovich ilya.enkov...@intel.com PR target/65183 * tree-chkp.c

Re: need help with Pointer Bounds Checking documentation

2015-02-24 Thread Ilya Enkovich
2015-02-20 19:39 GMT+03:00 Sandra Loosemore san...@codesourcery.com: On 02/20/2015 01:12 AM, Ilya Enkovich wrote: 2015-02-20 3:48 GMT+03:00 Sandra Loosemore san...@codesourcery.com: The section Pointer Bounds Checker builtins in extend.texi is on my list for being in need of copy-editing

Re: need help with Pointer Bounds Checking documentation

2015-02-24 Thread Ilya Enkovich
2015-02-24 19:47 GMT+03:00 Sandra Loosemore san...@codesourcery.com: On 02/24/2015 01:14 AM, Ilya Enkovich wrote: 2015-02-20 19:39 GMT+03:00 Sandra Loosemore san...@codesourcery.com: On 02/20/2015 01:12 AM, Ilya Enkovich wrote: 2015-02-20 3:48 GMT+03:00 Sandra Loosemore san

Re: need help with Pointer Bounds Checking documentation

2015-02-20 Thread Ilya Enkovich
2015-02-20 3:48 GMT+03:00 Sandra Loosemore san...@codesourcery.com: The section Pointer Bounds Checker builtins in extend.texi is on my list for being in need of copy-editing, but reading through the existing text, I am quite confused. In several places it refers to turning the Pointer Bounds

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-02-16 Thread Ilya Enkovich
On 16 Feb 16:31, Jakub Jelinek wrote: On Mon, Feb 16, 2015 at 06:20:59PM +0300, Ilya Enkovich wrote: This patch restricts usage of Pointer Bounds Checker with Sanitizer. OK for trunk? There are many sanitizers, and for most of them I don't see why they would be in any conflict

Re: [PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-02-16 Thread Ilya Enkovich
On 16 Feb 17:01, Jakub Jelinek wrote: On Mon, Feb 16, 2015 at 06:56:45PM +0300, Ilya Enkovich wrote: On 16 Feb 16:31, Jakub Jelinek wrote: On Mon, Feb 16, 2015 at 06:20:59PM +0300, Ilya Enkovich wrote: This patch restricts usage of Pointer Bounds Checker with Sanitizer. OK

[PATCH, CHKP, PR target/65044] Restrict pointer bounds checker with Sanitizer

2015-02-16 Thread Ilya Enkovich
Hi, This patch restricts usage of Pointer Bounds Checker with Sanitizer. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-16 Ilya Enkovich ilya.enkov...@intel.com PR target/65044 * toplev.c (process_options): Restrict Pointer Bounds Checker usage with sanitizers. gcc

Re: [PATCH, PR tree-optimization/65002] Disable SRA for functions wrongly marked as read-only

2015-02-16 Thread Ilya Enkovich
2015-02-15 20:25 GMT+03:00 Mike Stump mikest...@comcast.net: On Feb 13, 2015, at 11:25 AM, Jakub Jelinek ja...@redhat.com wrote: 2015-02-12 Ilya Enkovich ilya.enkov...@intel.com PR tree-optimization/65002 * gcc.dg/pr65002.C: New. This test should have gone into g++.dg. Into g

Re: [PATCH, PR tree-optimization/65002] Disable SRA for functions wrongly marked as read-only

2015-02-13 Thread Ilya Enkovich
2015-02-13 11:54 GMT+03:00 Jakub Jelinek ja...@redhat.com: On Fri, Feb 13, 2015 at 09:47:56AM +0100, Richard Biener wrote: 2015-02-12 Ilya Enkovich ilya.enkov...@intel.com PR tree-optimization/65002 * tree-cfg.c (pass_data_fixup_cfg): Don't update SSA on start

[PATCH, PR tree-optimization/65002] Disable SRA for functions wrongly marked as read-only

2015-02-12 Thread Ilya Enkovich
on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-02-12 Ilya Enkovich ilya.enkov...@intel.com PR tree-optimization/65002 * tree-cfg.c (pass_data_fixup_cfg): Don't update SSA on start. * tree-sra.c (some_callers_have_no_vuse_p): New

Re: [PATCH, PR tree-optimization/64277] Improve loop iterations count estimation

2015-02-02 Thread Ilya Enkovich
On 27 Jan 12:29, Richard Biener wrote: On Tue, Jan 27, 2015 at 11:47 AM, Ilya Enkovich enkovich@gmail.com wrote: On 27 Jan 12:40, Ilya Enkovich wrote: Hi, This patch was supposed to fix PR tree-optimization/64277. Tracker is now fixed by warnings disabling but I think patch

[PATCH, CHKP] Follow alias chain for decl visibility and aliases

2015-01-30 Thread Ilya Enkovich
Hi, This patch fixes two more cases where alias chain should be followed to emit correct assembler name for instrumented functions. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- gcc/ 2015-01-30 Ilya Enkovich ilya.enkov...@intel.com * varasm.c

Re: [PATCH, i386] Never fix register for PIC when pseudo PIC reg is used

2015-01-29 Thread Ilya Enkovich
the attached patch that exports ix86_use_pseudo_pic_reg. Uros. Hello Uros, Thank you for review! Here is an updated version with proposed changes. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-01-29 Ilya Enkovich ilya.enkov...@intel.com * config

[PATCH, i386] Never fix register for PIC when pseudo PIC reg is used

2015-01-28 Thread Ilya Enkovich
help to avoid problems in the future. BTW if we don't want to support possibility to switch to the fixed PIC register in i386 target then this code may be removed at all. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Ilya -- 2015-01-28 Ilya Enkovich ilya.enkov

Re: [PATCH] Fix PR64277

2015-01-27 Thread Ilya Enkovich
2015-01-27 12:47 GMT+03:00 Richard Biener rguent...@suse.de: On Tue, 27 Jan 2015, Jakub Jelinek wrote: On Tue, Jan 27, 2015 at 10:25:48AM +0100, Richard Biener wrote: This disables array-bound warnings from VRP2 as discussed. Bootstrapped and tested on x86_64-unknown-linux-gnu - ok for

[PATCH, PR tree-optimization/64277] Improve loop iterations count estimation

2015-01-27 Thread Ilya Enkovich
Hi, This patch was supposed to fix PR tree-optimization/64277. Tracker is now fixed by warnings disabling but I think patch is still useful to avoid dead code generated by complete unroll. Bootstrapped and tested on x86_64-unknown-linux-gnu. Thanks, Ilya -- gcc/ 2015-01-27 Ilya Enkovich

Re: [RFC PATCH] Avoid most of the BUILT_IN_*_CHKP enum values

2015-01-27 Thread Ilya Enkovich
2015-01-27 17:27 GMT+03:00 Jakub Jelinek ja...@redhat.com: Hi! I've grepped for BUILT_IN_.*_CHKP in the sources and we actually need far fewer enum values than the 1204 that are being defined. This patch requires builtins.def to say explicitly (by using DEF_*BUILTIN_CHKP macro instead of

Re: [PATCH, PR tree-optimization/64277] Improve loop iterations count estimation

2015-01-27 Thread Ilya Enkovich
On 27 Jan 12:40, Ilya Enkovich wrote: Hi, This patch was supposed to fix PR tree-optimization/64277. Tracker is now fixed by warnings disabling but I think patch is still useful to avoid dead code generated by complete unroll. Bootstrapped and tested on x86_64-unknown-linux-gnu

<    1   2   3   4   5   6   7   8   9   10   >