Re: [PATCH v3] workqueue: Wrap flush_workqueue() using a macro

2022-05-16 Thread Joe Perches
ove > "#undef flush_workqueue", suggested by Joe Perches .

Re: c plugin guidance wanted

2018-07-30 Thread Joe Perches
On Mon, 2018-07-30 at 10:51 -0400, David Malcolm wrote: > On Sun, 2018-07-29 at 13:41 -0700, Joe Perches wrote: > > I would like to implement a gcc plugin that can compress an > > __attribute__((format(printf, x, y))) const char array before > > storage so that the formats can

c plugin guidance wanted

2018-07-29 Thread Joe Perches
I would like to implement a gcc plugin that can compress an __attribute__((format(printf, x, y))) const char array before storage so that the formats can be size reduced when stored and expanded appropriately before use. As this is the first plugin I am trying to implement, I'm a bit lost in

Re: suggestion: c compiler warning for failure to test result

2017-04-27 Thread Joe Perches
On Thu, 2017-04-27 at 10:42 -0600, Jeff Law wrote: > On 04/25/2017 05:02 PM, Martin Sebor wrote: > > On 04/25/2017 02:35 PM, Joe Perches wrote: > > > A possibly useful addition similar to: > > > > > > __attribute__((warn_unused_result)) > > &g

suggestion: c compiler warning for failure to test result

2017-04-25 Thread Joe Perches
A possibly useful addition similar to: __attribute__((warn_unused_result)) might be __attribute__((warn_untested_result)) for things like allocation failures that are not verified before use. For instance: void *malloc(size_t size); could become void *

Re: String literals in __init functions

2015-04-02 Thread Joe Perches
On Thu, 2015-04-02 at 16:00 +, Joseph Myers wrote: On Thu, 26 Mar 2015, Joe Perches wrote: I'd have thought that a function-wide __attribute__((__string_section__(foo)) wouldn't be a ton of work to implement. Maybe not. Could some future version of gcc move string

Re: String literals in __init functions

2015-03-26 Thread Joe Perches
(adding gcc@gcc.gnu.org) On Thu, 2015-03-26 at 14:40 -0700, Andrew Morton wrote: On Thu, 26 Mar 2015 21:49:06 +0100 Mathias Krause mini...@googlemail.com wrote: Andrew, what's your opinion on such a patch set? Do you too think it's useful? Or do you share Ingo's fear about the additional

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-03-24 Thread Joe Perches
On Sun, 2008-03-23 at 16:22 +0100, Denys Vlasenko wrote: On Friday 29 February 2008 02:09, Joe Perches wrote: But the function place_entity doesn't use it directly or indirectly. If the lines above are removed, the generated code for place_entity changes. I see it all the time. Whenever I

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-28 Thread Joe Perches
On Thu, 2008-02-28 at 11:23 +0100, Jan Hubicka wrote: The call ought to be always early inlined and not seen by any optimization pass. The inlined functions don't actually appear in the generated code. Look at the code generation differences for kernel/sched.c function place_entity $ size

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-26 Thread Joe Perches
On Tue, 2008-02-26 at 21:13 -0700, Matthew Wilcox wrote: That's very interesting. It's only 64 bytes, but still, it's not supposed to have any different effect. Especially because __simple_attr_check_format is not even used or called in an x86 defconfig. It's powerpc/cell specific. Could

Re: [PATCH] linux/fs.h - Convert debug functions declared inline __attribute__((format (printf,x,y) to statement expression macros

2008-02-26 Thread Joe Perches
On Tue, 2008-02-26 at 21:44 -0800, David Rientjes wrote: I'm not seeing any change in text size with allyesconfig after applying this patch with latest git: This is just x86 defconfig Joe, what version of gcc are you using? $ gcc --version gcc (GCC) 4.2.2 20071128 (prerelease)