Re: [Patch 0/X] HWASAN v3

2020-01-08 Thread Kostya Serebryany via gcc-patches
[asan/hwasan co-author here, with clearly biased opinions] On Android, HWASAN is already a fully usable testing tool. We apply it to the kernel, user space system libraries, and select apps. A phone with HWASAN-ified system is fully usable (I carry one as my primary device since March 2019).

Re: [Patch 0/X] [WIP][RFC][libsanitizer] Introduce HWASAN to GCC

2019-09-09 Thread Kostya Serebryany via gcc-patches
+Peter Collingbourne +Evgeniy Stepanov (the main developers of HWASAN in LLVM, FYI) Please note that Peter has recently implemented support for globals in LLVM's HWASAN. --kcc On Mon, Sep 9, 2019 at 8:55 AM Matthew Malcomson wrote: > > On 09/09/19 11:47, Martin Liška wrote: > > On 9/6/19 4:46

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
On Wed, Jul 18, 2018 at 12:29 PM H.J. Lu wrote: > > On Wed, Jul 18, 2018 at 11:45 AM, Kostya Serebryany wrote: > > On Wed, Jul 18, 2018 at 11:40 AM H.J. Lu wrote: > >> > >> On Wed, Jul 18, 2018 at 11:18 AM, Kostya Serebryany > >> wrote: > >> > What's ENDBR and do we really need to have it in

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
On Wed, Jul 18, 2018 at 11:40 AM H.J. Lu wrote: > > On Wed, Jul 18, 2018 at 11:18 AM, Kostya Serebryany wrote: > > What's ENDBR and do we really need to have it in compiler-rt? > > When shadow stack from Intel CET is enabled, the first instruction of all > indirect branch targets must be a

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
What's ENDBR and do we really need to have it in compiler-rt? As usual, I am opposed to any gcc compiler-rt that bypass upstream. --kcc On Wed, Jul 18, 2018 at 8:37 AM H.J. Lu wrote: > > asan/asan_interceptors.cc has > > ... > int res = REAL(swapcontext)(oucp, ucp); > ... > >

Re: Add support to trace comparison instructions and switch statements

2017-09-12 Thread Kostya Serebryany via gcc-patches
On Tue, Sep 12, 2017 at 7:32 AM, Dmitry Vyukov wrote: > On Thu, Sep 7, 2017 at 9:02 AM, 吴潍浠(此彼) wrote: >> Hi >> The trace-div and trace-gep options seems be used to evaluate corpus >> to trigger specific kind of bugs. And they don't have strong effect to

Re: Add support to trace comparison instructions and switch statements

2017-07-14 Thread Kostya Serebryany via gcc-patches
On Fri, Jul 14, 2017 at 5:23 AM, Dmitry Vyukov wrote: > On Thu, Jul 13, 2017 at 11:18 PM, Kostya Serebryany wrote: >>> > Hi >>> > >>> > I wrote a test for "-fsanitize-coverage=trace-cmp" . >>> > >>> > Is there anybody tells me if these codes could be merged