Hello,
this trivial fix was pre-approved by Richard, I regtested and committed
it.
2014-10-17 Marc Glisse marc.gli...@inria.fr
* tree-into-ssa.c (is_old_name): Replace new with old.
--- tree-into-ssa.c (revision 216366)
+++ tree-into-ssa.c (working copy)
@@ -572,23 +572,23
on this. It may be a different
issue from yours with frcz, but I kept the impression from then that
builtins were still the way to go for anything non-trivial.
--
Marc Glisse
On Thu, 16 Oct 2014, Jeff Law wrote:
BTW, I dislike having multiple DCE implementations...
Similarly. The proposal above was just to determine if we should schedule
DCE or not.
Thinking about it some more, I don't think we should need any kind of DCE
here. The rewriting in update_ssa
runs quite late
but we do preserve points-to information to RTL (and RTL expansion
handles stack slot sharing fine with points-to sets - but we'd need to
handle NRV the same here).
Ah, ok. It would be great to paste some of this in tree-nrv.c, unless you
think it will be too much.
--
Marc Glisse
On Thu, 16 Oct 2014, Richard Biener wrote:
On Wed, Oct 15, 2014 at 6:08 PM, Jeff Law l...@redhat.com wrote:
On 10/15/14 08:35, Marc Glisse wrote:
Would that extra pass be acceptable?
Ugh, rather not. We have too many passes ;)
I expected you would say that...
Otherwise, what do you
__glibcxx_max_b (TYPE, BITSIZE);; } \
Maybe shorten the double ;; as well?
--
Marc Glisse
On Sun, 7 Sep 2014, Marc Glisse wrote:
On Sun, 27 Jul 2014, Marc Glisse wrote:
On Thu, 10 Jul 2014, Richard Biener wrote:
--- gcc/tree-into-ssa.c (revision 212109)
+++ gcc/tree-into-ssa.c (working copy)
@@ -1831,26 +1831,38 @@ maybe_register_def (def_operand_p def_p,
{
tree def
a
comment in tree-nrv.c), that would be good.
2014-10-16 Marc Glisse marc.gli...@inria.fr
* tree-nrv.c (pass_nrv::execute): Don't disable when address is taken.
--
Marc GlisseIndex: gcc/tree-nrv.c
===
--- gcc/tree-nrv.c
On Mon, 13 Oct 2014, Kito Cheng wrote:
- -1 if it is not a cost classe. */
+ -1 if it is not a cost classes. */
a cost class, no plural here.
--
Marc Glisse
Ping https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00361.html
(sorry that my message looked like I had committed as obvious)
On Sat, 4 Oct 2014, Marc Glisse wrote:
On Thu, 2 Oct 2014, Jason Merrill wrote:
OK.
Thanks. While committing, I noticed that I restricted ! to integer vectors
be
fixed. This triggered one of the issues listed in PR 63345 (casting to a
node* even for the sentinel), which I am fixing here.
Bootstrap+testsuite on x86_64-linux-gnu.
2014-10-13 Marc Glisse marc.gli...@inria.fr
PR libstdc++/61347
PR libstdc++/63345
* include/bits
to fma to 'f')
If I omit the avx512fintrin.h part, I think it is very unlikely this can
conflict with Kirill's work in any way (but I can still wait / use a
branch).
Bootstrap+testsuite on x86_64-linux-gnu.
2014-10-13 Marc Glisse marc.gli...@inria.fr
gcc/
* config/i386/xmmintrin.h
for integers:
(__m128d)((__v2df)__A + (__v2df)__B)
--
Marc Glisse
On Thu, 9 Oct 2014, Uros Bizjak wrote:
On Thu, Oct 9, 2014 at 12:33 PM, Marc Glisse marc.gli...@inria.fr wrote:
Ping https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01812.html
(another part of the discussion is around
https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02288.html )
Most people who
On Thu, 9 Oct 2014, Olivier Hainque wrote:
On Oct 9, 2014, at 12:33 PM, Marc Glisse wrote:
If this is accepted, I will gladly prepare patches removing the unused builtins
and extending this to a few more operations (integer vectors in particular). If
this is not the direction we want to go
for the conversion. Maybe even ada
can be tested there to not regress with the compatibility stuff.
No problem. We can also wait until next stage1 if you believe the release
of gcc-5 is too close.
--
Marc Glisse
is
implicit in C++11 but not C++14.
2014-10-09 Marc Glisse marc.gli...@inria.fr
gcc/cp/
* decl.c (grokdeclarator): constexpr only implies const in C++11.
gcc/testsuite/
* g++.dg/cpp0x/constexpr-52892-1.C: Error on missing const in C++14.
* g++.dg/cpp0x/constexpr-array-ptr7
.
(If A and B don't have the same size, the argument 20 can be a hint)
--
Marc Glisse
as suggested in PR 61347?
--
Marc Glisse
to
change:
- __detail::_List_node_base _M_node;
- size_t _M_size;
+ _List_nodesize_t _M_node;
and store the size in _M_node._M_data. Since I will have to touch it
anyway, don't feel forced to move it to _M_impl.
--
Marc Glisse
On Thu, 2 Oct 2014, Jason Merrill wrote:
OK.
Thanks. While committing, I noticed that I restricted ! to integer
vectors, whereas it seems to work just fine with scalar floats, so it
would make sense to extend it to float vectors. Tested on
x86_64-linux-gnu.
2014-10-04 Marc Glisse
On Fri, 22 Aug 2014, Marc Glisse wrote:
On Fri, 22 Aug 2014, Jason Merrill wrote:
On 08/22/2014 03:24 PM, Marc Glisse wrote:
Note that there is a patch waiting for a review that makes us accept !v
for vector v:
Ah, indeed. I still think we might as well treat vectors the same as other
an unusable value (zero or trapping) is not very
useful, while providing the real usable minimum lets users do something
meaningful with it.
The main issue is using incompatible flags in different objects or at
link time...
--
Marc Glisse
On Wed, 24 Sep 2014, Jonathan Wakely wrote:
I'm tempted to tidy up the GLIBCXX_3.4 patterns in the linker script
quite considerably,
Paolo has done something like that this summer (motivated by -O0 builds)
and reverted it for a detail, but it could be a good starting point.
--
Marc Glisse
Uros that I wasn't clear enough
in the PR...
--
Marc Glisse
library, that doesn't mean anything.
--
Marc Glisse
On Wed, 17 Sep 2014, Ian Grant wrote:
On Wed, Sep 17, 2014 at 1:36 PM, Marc Glisse marc.gli...@inria.fr wrote:
On Wed, 17 Sep 2014, Ian Grant wrote:
And is there any way to disable the Intel library?
--disable-libcilkrts (same as the other libs)
If it explicitly doesn't support your
generalize 0 and 1 to i and 1i, but that might
require an extra check on the size of XEXP (op0, 0).
--
Marc Glisse
potentially slow, and having a thread_local counter in valueize to limit
the call depth may not be ideal.
Please note that I am not at all saying the above is a good design, just
dropping a random thought.
--
Marc Glisse
with
(mult (realpart@1 @0) @1) */
- (mult (realpart @0) (realpart @0))
- (mult (imagpart @0) (imagpart @0)))
+ (mult (realpart@1 @0) @1)
+ (mult (imagpart@2 @0) @2))
Maybe remove the comment above?
You seem to have trailing spaces on most of your new lines.
--
Marc Glisse
optimizations for vectors, that I am fixing at the
same time.
Bootstrap+testsuite on x86_64-linux-gnu.
2014-09-12 Marc Glisse marc.gli...@inria.fr
gcc/
* tree.c (integer_each_onep): New function.
* tree.h (integer_each_onep): Declare it.
* fold-const.c (fold_binary_loc): Use
On Fri, 12 Sep 2014, Richard Biener wrote:
+/* x ^ ~0 - ~x */
(simplify
(bit_and @0 integer_all_onesp)
@0)
The comment doesn't seem to match.
--
Marc Glisse
|| flag_associative_math
when this was in forwprop?
--
Marc Glisse
that only differ for complex. And we
would probably want a corresponding build_ function to produce such
constants.
--
Marc Glisse
On Thu, 11 Sep 2014, Joseph S. Myers wrote:
On Thu, 11 Sep 2014, Marc Glisse wrote:
I don't know what kind of test you have in mind, so I added a runtime test. I
am just guessing that it probably fails on alpha because of PR 58757, I can't
test. Computing d+d may be even more likely
as expected.
The next step might be to define has_denorm as false in more cases
(-mno-ieee on alpha, -ffast-math on x86, etc) but that's a different
issue.
(this is C++ but I believe Joseph is the floating-point expert, hence the
cc)
gcc/c-family/
2014-09-10 Marc Glisse marc.gli...@inria.fr
On Wed, 10 Sep 2014, Joseph S. Myers wrote:
On Wed, 10 Sep 2014, Marc Glisse wrote:
Hello,
according to the C++ standard, numeric_limits::denorm_min should return min
(not 0) when there are no denormals.
Tested with bootstrap+testsuite on x86_64-linux-gnu. I also tested a basic
make all-gcc
On Sun, 27 Jul 2014, Marc Glisse wrote:
On Thu, 10 Jul 2014, Richard Biener wrote:
--- gcc/tree-into-ssa.c (revision 212109)
+++ gcc/tree-into-ssa.c (working copy)
@@ -1831,26 +1831,38 @@ maybe_register_def (def_operand_p def_p,
{
tree def = DEF_FROM_PTR (def_p);
tree sym = DECL_P (def
. Is that a feature, or
should I file a PR for that... ?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53155
--
Marc Glisse
has a 32 bit type with
wrapping overflow, this is just doing the wrapping modulo 2^32.
--
Marc Glisse
with
4.9.2, I only expect to have to fix such things when moving to 5.0.
--
Marc Glisse
Ping?
On Sat, 26 Jul 2014, Marc Glisse wrote:
Hello,
any comment on this patch?
https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00769.html
On Tue, 10 Jun 2014, Marc Glisse wrote:
On Tue, 19 Mar 2013, Richard Henderson wrote:
I'm not fond of this, primarily because I believe the pattern
On Fri, 22 Aug 2014, Tejas Belagod wrote:
On 28/06/14 11:25, Marc Glisse wrote:
On Mon, 23 Jun 2014, Tejas Belagod wrote:
Here is a patch that restructures neon builtins to use vector types based
on
standard base types. We previously defined arm_neon.h's neon vector
types(int8x8_t) using
at what level you do the test, so I don't know if it can
see a TRUTH_NOT_EXPR for a vector or if it has already been replaced by
EQ_EXPR at that point.
--
Marc Glisse
On Fri, 22 Aug 2014, Jason Merrill wrote:
On 08/22/2014 03:24 PM, Marc Glisse wrote:
Note that there is a patch waiting for a review that makes us accept !v
for vector v:
Ah, indeed. I still think we might as well treat vectors the same as other
types here.
Ok, now that it is a conscious
, if the version in fold-const.c
is supposed to disappear.
(if that's planned for later, please ignore my message)
--
Marc Glisse
it simplifies, but that was a pretty unreadable way to write
it, and I was scared that you had done it on purpose to help the machinery
guess the type. Glad to see that the simple version is ok.
--
Marc Glisse
Hello,
here is a new version of the patch which passed bootstrap+testsuite. I am
still removing the ref_maybe_used_by_stmt_p test, see the previous message
for a discussion.
2014-08-20 Marc Glisse marc.gli...@inria.fr
PR tree-optimization/62112
gcc/
* gimple-iterator.c
change the
operation.
--
Marc Glisse
On Wed, 20 Aug 2014, Richard Biener wrote:
On Wed, 20 Aug 2014, Marc Glisse wrote:
On Wed, 20 Aug 2014, Richard Biener wrote:
Committed.
Also makes visible a desirable change I plan for if-exprs. They
should behave like outer ifs and allow us to write that series
of pattern as
(for op
of the code
has changed quite a bit since then, it isn't that surprising if some test
becomes redundant. But if it makes you nervous, we could keep it as a
checking_assert, the cost should be negligible...
--
Marc Glisse
On Wed, 20 Aug 2014, Richard Biener wrote:
On Wed, Aug 20, 2014 at 9:14 AM, Marc Glisse marc.gli...@inria.fr wrote:
Hello,
here is a new version of the patch which passed bootstrap+testsuite. I am
still removing the ref_maybe_used_by_stmt_p test, see the previous message
for a discussion
On Wed, 20 Aug 2014, Marc Glisse wrote:
On Wed, 20 Aug 2014, Richard Biener wrote:
On Wed, Aug 20, 2014 at 9:14 AM, Marc Glisse marc.gli...@inria.fr wrote:
Hello,
here is a new version of the patch which passed bootstrap+testsuite. I am
still removing the ref_maybe_used_by_stmt_p test, see
On Wed, 20 Aug 2014, Richard Biener wrote:
On Wed, Aug 20, 2014 at 4:18 PM, Marc Glisse marc.gli...@inria.fr wrote:
On Wed, 20 Aug 2014, Richard Biener wrote:
- if (stmt != use_stmt
- ref_maybe_used_by_stmt_p (use_stmt, gimple_assign_lhs
(stmt)))
- return;
-
I don't
' didn't turn
up anything. I could keep it as a gcc_checking_assert (with a slight
update to the comment) if you like. Or did I miss a path in
dse_possible_dead_store_p?
Thanks,
--
Marc Glisse
+testsuite on x86_64-linux-gnu.
2014-08-18 Marc Glisse marc.gli...@inria.fr
PR c++/54427
PR c++/57198
PR c++/58845
gcc/c-family/
* c-common.c (warn_logical_operator): Punt for vectors.
gcc/cp/
* typeck.c (cp_build_binary_op): save_expr after convert to save
-Werror can work.
--
Marc Glisse
it easier to add more builtins like strcpy.
Bootstrap+testsuite (really all languages) on x86_64-linux-gnu.
2014-08-18 Marc Glisse marc.gli...@inria.fr
PR tree-optimization/62112
gcc/
tree-ssa-alias.c (ref_may_alias_global_p, refs_may_alias_p,
ref_maybe_used_by_stmt_p
On Wed, 13 Aug 2014, Sylvestre Ledru wrote:
On 12/08/2014 19:38, Marc Glisse wrote:
On Tue, 12 Aug 2014, Sylvestre Ledru wrote:
The patch fixes some typos found by Lintian, the Debian static analyzer.
Did you check them yourself?
Sure (but I am not a native English speaker).
I am
On Wed, 13 Aug 2014, Paolo Carlini wrote:
... fixed with the below.
Could you please use __sq instead of recomputing it?
--
Marc Glisse
= a b;
if (a b)
return -r;
return r;
}
Note that in this particular case, we should just return -(ab) like llvm
does.
--
Marc Glisse
that's
what we want.
--
Marc Glisse
On Tue, 12 Aug 2014, Sylvestre Ledru wrote:
The patch fixes some typos found by Lintian, the Debian static analyzer.
Did you check them yourself? We end up with these information which
doesn't seem correct to me.
--
Marc Glisse
may add noexcept wherever you like.
It is constexpr that we can only add in GNU mode.
--
Marc Glisse
, but a pointer would be much
appreciated.
--
Marc Glisse
vectors with norm zero.
While there, do we want to also reject infinite norms?
I would have done: while (__sum small || __sum large)
but testing exactly for 0 and infinity seems good enough.
--
Marc Glisse
On Sat, 9 Aug 2014, Ulrich Drepper wrote:
On Sat, Aug 9, 2014 at 3:15 AM, Marc Glisse marc.gli...@inria.fr wrote:
While there, do we want to also reject infinite norms?
I would have done: while (__sum small || __sum large)
but testing exactly for 0 and infinity seems good enough.
I guess
points in a square until you get one in the disk). When the dimension
becomes higher, the probability that a point in the cube actually belongs
to the ball decreases, and it becomes cheaper to use a Gaussian.
--
Marc Glisse
hurt speed though, so not a big issue.
--
Marc Glisse
On Wed, 6 Aug 2014, Jakub Jelinek wrote:
- libstdc++ ABI changes
It seems unlikely to be in the next release, it is too late in the cycle.
Chances to break the ABI don't come often, and rushing one at the end of
stage1 would be wasting a good opportunity.
--
Marc Glisse
dependent on
the compiler version used?!
Yes, just like a move to .so.7 would entail.
--
Marc Glisse
effort. With .so.7, you have no option, nothing will be interoperable.
I disagree that it is worse, but you have more experience, I guess we
will see the results in a few years...
--
Marc Glisse
; /* { dg-warning integer overflow in expression } */
+}
Why do you want a warning for (q - 1) - q ? It looks like a perfectly
correct way to say -1 to me (ptrdiff_t is a signed type for a reason).
--
Marc Glisse
On Mon, 4 Aug 2014, Marek Polacek wrote:
On Mon, Aug 04, 2014 at 12:51:06PM +0200, Richard Biener wrote:
On Mon, 4 Aug 2014, Marc Glisse wrote:
On Mon, 4 Aug 2014, Marek Polacek wrote:
+/* { dg-do compile } */
+
+void
+foo (void)
+{
+ volatile __PTRDIFF_TYPE__ t;
+ int i;
+ int *p = i
checking for the next warning patch.
--
Marc Glisse
.
--
Marc Glisse
On Tue, 29 Jul 2014, David Malcolm wrote:
On Tue, 2014-07-29 at 19:36 +0200, Marc Glisse wrote:
On Sun, 27 Jul 2014, Richard Sandiford wrote:
Marc Glisse marc.gli...@inria.fr writes:
Hello,
I followed the advice in this discussion:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html
On Sun, 27 Jul 2014, Richard Sandiford wrote:
Marc Glisse marc.gli...@inria.fr writes:
Hello,
I followed the advice in this discussion:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html
and here is a new patch. I made an effort to isolate a path in at least
one subcase so it doesn't
On Tue, 29 Jul 2014, David Malcolm wrote:
On Tue, 2014-07-29 at 19:36 +0200, Marc Glisse wrote:
On Sun, 27 Jul 2014, Richard Sandiford wrote:
Marc Glisse marc.gli...@inria.fr writes:
Hello,
I followed the advice in this discussion:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html
for the C++ testcase because SRA sets
nowarning_flag (it doesn't if I create a new variable), but I guess we can
see about changing that next.
--
Marc Glisse
hack)
--
Marc Glisse
On Sun, 27 Jul 2014, Richard Sandiford wrote:
Marc Glisse marc.gli...@inria.fr writes:
Hello,
I followed the advice in this discussion:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html
and here is a new patch. I made an effort to isolate a path in at least
one subcase so it doesn't
On Sun, 27 Jul 2014, Andreas Schwab wrote:
Marc Glisse marc.gli...@inria.fr writes:
On Sun, 27 Jul 2014, Richard Sandiford wrote:
Marc Glisse marc.gli...@inria.fr writes:
+ if (always_executed)
+ msg = function returns address of local variable
Hello,
any comment on this patch?
https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00769.html
On Tue, 10 Jun 2014, Marc Glisse wrote:
On Tue, 19 Mar 2013, Richard Henderson wrote:
I'm not fond of this, primarily because I believe the pattern should
not exist at all.
One year later, new try
On Tue, 8 Jul 2014, Kirill Yukhin wrote:
Hello Marc.
On 04 Jul 21:11, Marc Glisse wrote:
On Thu, 3 Jul 2014, Kirill Yukhin wrote:
like combining 2 shuffles unless the result is the identity. And
expanding shuffles that can be done in a single instruction works
well.
But I am happy not doing
if all values of the normal distribution
happen to be 0?
* should the implementation be specialized for small dimensions to avoid
the normal distributions and instead generate points in a square/cube
until they fall in the disk/ball?
--
Marc Glisse
On Wed, 16 Jul 2014, Jeff Law wrote:
On 06/22/14 12:20, Marc Glisse wrote:
Hello,
I followed the advice in this discussion:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00269.html
and here is a new patch. I made an effort to isolate a path in at least
one subcase so it doesn't look too
be away next week, but I'll re-read all the replies carefully when I
come back.
--
Marc Glisse
On Mon, 7 Jul 2014, Jeff Law wrote:
On 07/06/14 08:23, Marc Glisse wrote:
What is the lifetime of an SSA_NAME with a default definition? The way
we handle it now, we start from the uses and go back to all blocks that
can reach one of the uses, since there is no defining statement where we
On Mon, 7 Jul 2014, Richard Biener wrote:
On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote:
Hello,
with this patch on top of
https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html
we finally warn for the testcase of PR 60517.
The new function is copied from
and replacing them with undef
SSA_NAMEs doesn't seem to fit well with how SRA works. It would certainly
be possible, but would require quite a bit of new code. Also, the
domination relation between the clobber and the reads is not always
obvious and may require some PHIs in between.
--
Marc Glisse
On Mon, 30 Jun 2014, Jeff Law wrote:
On 06/28/14 16:33, Marc Glisse wrote:
In an earlier version of the patch, I was using
get_or_create_ssa_default_def (cfun, sym);
(I was reusing the same variable). This passed bootstrap+testsuite on
all languages except for ada. Indeed, the compiler wanted
On Sun, 6 Jul 2014, pins...@gmail.com wrote:
The below patch won't work for parameters.
Er, that's why I am testing: TREE_CODE (var) == VAR_DECL
(and the patch passed the testsuite with all languages)
Could you be more specific about what won't work?
--
Marc Glisse
On Thu, 3 Jul 2014, Kirill Yukhin wrote:
Hello Marc,
On 28 Jun 12:42, Marc Glisse wrote:
It would enable a number of optimizations, like constant
propagation, FMA contraction, etc. It would also allow us to remove
several builtins.
This should be main motivation for replacing built-ins
On Tue, 1 Jul 2014, Tom de Vries wrote:
On 01-07-14 21:58, Marc Glisse wrote:
So my question is: is the combination of '' and '+' supported ? If so,
what is the exact semantics ? If not, should we warn or give an error ?
I don't think we can define any reasonable semantics for +. My
On Wed, 2 Jul 2014, Tom de Vries wrote:
On 02-07-14 08:23, Marc Glisse wrote:
I think it could have used (match_dup 0) instead of operand 1, if there
had been only the first alternative. And then the constraint would have
been +.
isn't that explicitly listed as unsupported here (
https
On Wed, 2 Jul 2014, Tom de Vries wrote:
On 02-07-14 09:02, Marc Glisse wrote:
Still, the meaning of +, in inline asm for instance, seems relatively
clear, no?
I can't find any testsuite examples using this construct.
Furthermore, I'd expect the same semantics and restrictions
On Wed, 2 Jul 2014, Alan Modra wrote:
On Mon, Jun 30, 2014 at 11:37:50PM +0200, Marc Glisse wrote:
On Mon, 30 Jun 2014, Jeff Law wrote:
On 06/29/14 03:22, Marc Glisse wrote:
After looking at PR 61597, I updated the 2 conditions to:
+ if ((TREE_CODE (valbase) == VAR_DECL
to an
earlyclobber operand and goes on to explain why that is useful. It avoids
using the same register for other input when they are identical.
--
Marc Glisse
a as an rvalue, so it uses that constructor for Aint, and that uses a
private member of a different specialization of A, which is illegal.
--
Marc Glisse
901 - 1000 of 1798 matches
Mail list logo
