Re: [PATCH] Remove old diagnostic macros.

2016-06-09 Thread Marcin Baczyński
2016-06-09 18:35 GMT+02:00 Jeff Law <l...@redhat.com>: > On 05/30/2016 05:19 PM, Marcin Baczyński wrote: >> >> Hi, >> this is my first GCC patch, so please bear with me if something is wrong >> with >> it in an obvious way. >> >> I've found two u

[PATCH] Print column numbers in inclusion trace consistently.

2016-06-03 Thread Marcin Baczyński
Hi, the patch below fixes PR/42014. Although the fix itself seems easy enough, I have a problem with the test. Is there a way to match the output before the "warning:" line? dg-{begin,end}-multiline-output doesn't do the job, or at least I don't know how to convince it. Bootstrapped on x86_64

Re: [PATCH] Warn about return with a void expression with -Wreturn-type.

2016-06-03 Thread Marcin Baczyński
2016-06-03 11:36 GMT+02:00 Bernd Schmidt <bschm...@redhat.com>: > On 06/02/2016 12:03 PM, Marcin Baczyński wrote: >> >> 2016-06-02 4:51 GMT+02:00 Martin Sebor <mse...@gmail.com>: >>> >>> As a disclaimer, someone else endowed with those special pow

Re: A simple question about virtual destructors.

2016-06-02 Thread Marcin Baczyński
2016-06-02 11:55 GMT+02:00 K : > Hi, > > My question is what if a compiler will generate a virtual destructor (or > convert a nonvirtual to virtual) in a base class if the base class has at > least one virtual function and classes down in the hierarchy have > nontrivial

Re: [PATCH] Warn about return with a void expression with -Wreturn-type.

2016-06-02 Thread Marcin Baczyński
2016-06-02 4:51 GMT+02:00 Martin Sebor : >> So here's my shot at fixing this in the documentation. Does that look >> okay? >> > > It looks good to me. Just one minor point below. > >> @@ -4055,8 +4055,12 @@ Warn whenever a function is defined with a >> return type that defaults

Re: [PATCH] Warn about return with a void expression with -Wreturn-type.

2016-06-01 Thread Marcin Baczyński
2016-06-01 19:03 GMT+02:00 Martin Sebor <mse...@gmail.com>: > > On 06/01/2016 10:39 AM, Jakub Jelinek wrote: >> >> On Wed, Jun 01, 2016 at 02:44:22PM +0200, Marcin Baczyński wrote: >>> >>> On 1 Jun 2016 14:07, "Jakub Jelinek" <ja...@redhat.c

[PATCH] Warn about return with a void expression with -Wreturn-type.

2016-06-01 Thread Marcin Baczyński
PR c/48116. Botstrapped and tested on x86_64-pc-linux-gnu. gcc/ChangeLog: * c/c-typeck.c (c_finish_return): emit warning about return with a void expression in a function returning void if warn_return_type. gcc/testsuite/ChangeLog: * gcc.dg/Wreturn-type3.c: new test. ---

[PATCH 1/2] Fix warnings reported with -Wreturn-type after patching PR c/48116.

2016-06-01 Thread Marcin Baczyński
libgomp/ChangeLog: * fortran.c (omp_set_default_device_, omp_set_default_device_8): don't put a void expression in a return, * oacc-mem.c (acc_free): likewise, * target.c (GOMP_target, GOMP_target_data, GOMP_target_data_ext): likewise. --- libgomp/fortran.c | 4 ++--

[PATCH] Remove old diagnostic macros.

2016-05-30 Thread Marcin Baczyński
Hi, this is my first GCC patch, so please bear with me if something is wrong with it in an obvious way. I've found two unused macros in gcc/diagnostic.h. Is the patch okay as is? Bootstrapped on x86_64-pc-linux-gnu. 2016-05-31 Marcin Baczyński <marb...@gmail.com> * gcc/diagno

Incorrect casting?

2010-03-09 Thread Marcin Baczyński
Hi, the following piece of code produces different output on svn trunk and gcc-4_4-branch: #include stdio.h int main() { struct { unsigned bar:1; } foo; foo.bar = 0x1; printf(%08x\n, (unsigned char)(foo.bar * 0xfe)); printf(%08x\n, (unsigned char)(foo.bar *