Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Richard Guenther
On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, an opinion on this? (I just noticed: I'll update the list in the comment visible at the top of the patch if this gets in). It looks ok to me but I am no floating-point expert. Can you add a testcase? Ok with

Re: [patch, fortran] Fix PR 54033, problems with -I, with test cases

2012-08-02 Thread Richard Guenther
On Tue, Jul 31, 2012 at 3:47 PM, Tobias Burnus bur...@net-b.de wrote: On 07/29/2012 11:24 AM, Thomas Koenig wrote: here is an updated patch for PR 54033, this time with test cases. Thanks to Janis for pointing me in the right direction with these. Regression-tested. OK for trunk? Ok.

Re: [PATCH][7/n] into-SSA TLC

2012-08-02 Thread Richard Guenther
On Thu, 2 Aug 2012, Tom de Vries wrote: On 01/08/12 10:47, Richard Guenther wrote: * tree-ssa-tail-merge.c (release_last_vdef): Remove. (replace_block_by): Adjust. (tail_merge_optimize): Use mark_virtual_operands_for_renaming. Richard, this caused PR50672 to trigger again

Re: PATCH: Remove redundant instructions after regcprop

2012-08-02 Thread Richard Guenther
On Thu, Aug 2, 2012 at 12:19 PM, Paulo J. Matos pa...@matos-sorge.com wrote: Forgot to mention: this is to fix PR 54154. Updated changelog: 2012-08-02 Paulo Matos paulo.ma...@csr.com PR middle-end/54154 * regcprop.c (copy_value): remove check for redundant moves. *

Re: [C++ patch] Allow p-~T() when T is a vector

2012-08-02 Thread Richard Guenther
On Thu, Aug 2, 2012 at 1:42 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, this patch allows p-~T() when T is (after substitution) a vector, which is necessary for use in std::vector for instance. Why not include VECTOR_TYPE in ARITHMETIC_TYPE_P? gcc/cp/ChangeLog 2012-08-02 Marc

Re: ORDERED_EXPR in invert_tree_comparison

2012-08-02 Thread Richard Guenther
On Thu, Aug 2, 2012 at 2:48 PM, Marc Glisse marc.gli...@inria.fr wrote: On Thu, 2 Aug 2012, Richard Guenther wrote: On Wed, Aug 1, 2012 at 9:21 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, an opinion on this? (I just noticed: I'll update the list in the comment visible at the top

[PATCH] Speedup into-SSA a bit

2012-08-02 Thread Richard Guenther
This removes some of the redundant hash lookups for the decl aux info. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-08-02 Richard Guenther rguent...@suse.de * tree-into-ssa.c (struct common_info_d): New struct. (struct var_info_d, struct

Re: How to set params under option?

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 9:25 AM, Konstantin Vladimirov konstantin.vladimi...@gmail.com wrote: Hi, Working on private backend. Need to add some knobs to tune inlining. Code (with name of backend substituted to my): in my.c file: #undef TARGET_OPTION_DEFAULT_PARAMS #define

Re: [PATCH 0/2] Convert s390 to atomic optabs, v2

2012-08-01 Thread Richard Guenther
On Tue, 31 Jul 2012, Richard Henderson wrote: On 2012-07-31 02:09, Richard Guenther wrote: What do we expect __builtin_compare_exchange to do for unaligned inputs? At the moment we expect it to SIGBUS, as a rule. We'd *like* to defer to the library routine for unaligned, but we don't

[PATCH][7/n] into-SSA TLC

2012-08-01 Thread Richard Guenther
This cleans up the way we rename all virtual operands throughout the compiler by simply providing an abstraction for that. mark_sym_for_renaming is gone then. Bootstrapped and tested on x86_64-unknown-linux-gnu. I will apply 6/n and 7/n later today. Richard. 2012-08-01 Richard Guenther

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2012-08-01 Thread Richard Guenther
On Fri, Dec 2, 2011 at 8:28 PM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Dec 02, 2011 at 02:27:40PM +0100, Richard Guenther wrote: This change seems wrong. We are turning valid gimple # DEBUG D#2 = transfer.0 [with addres taken] into invalid one # DEBUG D#2 = transfer.0 [without

[PATCH][1/2] Remove referenced vars

2012-08-01 Thread Richard Guenther
capability uid - decl. This was the last user of referenced_var (). Bootstrapped and tested on x86_64-unknown-linux-gnu. Richard. 2012-08-01 Richard Guenther rguent...@suse.de * tree-flow-inline.h (referenced_var): Remove. * tree-ssa-coalesce.c (create_outofssa_var_map): Remove

[PATCH] Update tree-ssa docs

2012-08-01 Thread Richard Guenther
Committed as obvious. Richard. 2012-08-01 Richard Guenther rguent...@suse.de * tree-ssa.texi: Remove pieces mentioning mark_sym_for_renaming. Index: gcc/doc/tree-ssa.texi === --- gcc/doc/tree-ssa.texi (revision

[PATCH][2a/2] Remove referenced vars

2012-08-01 Thread Richard Guenther
-08-01 Richard Guenther rguent...@suse.de * tree-dfa.c (referenced_var_lookup): Remove. * tree-flow.h (referenced_var_lookup): Likewise. * cfgexpand.c (update_alias_info_with_stack_vars): Remove assert. * gimple-pretty-print.c (pp_points_to_solution): Dump UIDs

[PATCH][2b/2] Remove referenced vars

2012-08-01 Thread Richard Guenther
This removes the referenced vars machinery (stubbing out add_referenced_vars and gimple_referenced_vars - a patch fixing all callers will be 2c/2). Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2012-08-01 Richard Guenther rguent...@suse.de * tree-flow.h (struct

Re: Ping: [PATCH] Fix PR46556 (straight-line strength reduction, part 2)

2012-08-01 Thread Richard Guenther
On Sun, Jul 22, 2012 at 5:19 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: Ping... On Thu, 2012-06-28 at 16:45 -0500, William J. Schmidt wrote: Here's a relatively small piece of strength reduction that solves that pesky addressing bug that got me looking at this in the first

Re: [PATCH] propagate anti-range to switch in tree-vrp

2012-08-01 Thread Richard Guenther
On Sat, Jul 21, 2012 at 3:57 PM, Tom de Vries tom_devr...@mentor.com wrote: Jakub, this patch adds propagation of anti-ranges to switches. The test-case is this: ... void f3 (int s) { if (s 3 == -2) /* s in range [ -16, -9]. */ ; else { /* s in range ~[-16,

Re: [Patch, Fortran] assumed-rank some bound intrinsics support, fix failures and improve diagnostcs

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 2:37 PM, Tobias Burnus bur...@net-b.de wrote: On 08/01/2012 01:37 PM, Mikael Morin wrote: However, I found another spot where one needs to have a scalarizer; possibly a poor man's version is enough. Namely INTENT(OUT) handling. Indeed. Do you have an idea how to best

Re: [1/3] remove var_ann: tlc for out-of-ssa

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 4:05 PM, Michael Matz m...@suse.de wrote: Hi, this tidies ssa liveness calculation a bit (related to out-of-ssa). In particular it doesn't make use of var annotations to compress the index space from partitions to base variable indices anymore, but instead a hashmap

Re: [2/3] remove var_ann: Remove used flag

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 4:09 PM, Michael Matz m...@suse.de wrote: Hi, this removes the last member of var_ann_d, a bit used only locally in remove_unused_locals, so we can as well just use a bitmap. (The funny renaming of the member I had to do because gengtype doesn't like empty structs,

Re: [3/3] remove var_ann: die

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 4:13 PM, Michael Matz m...@suse.de wrote: Hi, On Wed, 1 Aug 2012, Michael Matz wrote: The only remaining semantic of var_ann now is if it's non-zero it's a non-global variable that was put into referenced_vars. And that's removed in this patch. Most of the time it's

Re: rfa: merge handling of locals and globals in remove_unused_locals

2012-08-01 Thread Richard Guenther
On Wed, Aug 1, 2012 at 5:28 PM, Michael Matz m...@suse.de wrote: Hi, On Wed, 1 Aug 2012, Richard Guenther wrote: Ok. Would be nice to now unify global and local var handling with a single bitmap. Yeah, wanted to do that as follow-up. Namely like so. Regstrapping on x86_64-linux

Re: [PATCH 0/2] Convert s390 to atomic optabs, v2

2012-08-01 Thread Richard Guenther
On Wed, 1 Aug 2012, Richard Henderson wrote: On 08/01/2012 01:40 AM, Richard Guenther wrote: I see. So your issue is that you don't get the knowledge that the address is even more aligned than required by the builtin. Yes. Very helpful for quite a few targets that only have word-sized

Re: [PATCH][1/2] Remove referenced vars

2012-08-01 Thread Richard Guenther
On Wed, 1 Aug 2012, Richard Guenther wrote: This series aims at removing referenced vars. It builds on the into-SSA TLC series and the still to be posted removal of var-anns. This first patch removes SRAs use of referenced vars. Instead of turning it upside-down the following simply

Re: memset and host char requirement

2012-07-31 Thread Richard Guenther
On Mon, Jul 30, 2012 at 5:29 PM, Paulo J. Matos pa...@matos-sorge.com wrote: On 26/07/12 15:04, Joseph S. Myers wrote: On Thu, 26 Jul 2012, Paulo J. Matos wrote: My target has 16bit chars. As I explained before, support for such targets is extremely limited and bitrotten (this applies

Re: [PATCH] Fix PR53733

2012-07-31 Thread Richard Guenther
))) + LOOP_VINFO_OPERANDS_SWAPPED (loop_info) = true; } else { -- Richard Guenther rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend

Re: [PATCH 0/2] Convert s390 to atomic optabs, v2

2012-07-31 Thread Richard Guenther
/config/s390/s390.md | 401 + 3 files changed, 465 insertions(+), 209 deletions(-) -- Richard Guenther rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend

Re: [PATCH] Fix the LOOP_BRANCH prediction

2012-07-31 Thread Richard Guenther
On Tue, Jul 31, 2012 at 5:17 AM, Dehao Chen de...@google.com wrote: Hi, This patch fixed the problem when a LOOP_EXIT edge for the inner loop happened to target at the LOOP_LATCH of the outer loop. As the outer loop is processed first, the LOOP_BRANCH heuristic is honored (first_match), thus

Re: [patch] Dump slim RTL to assembly file if the final dump is slim

2012-07-31 Thread Richard Guenther
On Tue, Jul 31, 2012 at 12:13 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, For me, the slim RTL dumps are much easier to read than the default lisp-like representation. I use the -dAP option frequently, to see where an assembly instruction came from. This patch scratches an itch:

Re: [PATCH] Fix the LOOP_BRANCH prediction

2012-07-31 Thread Richard Guenther
, PRED_LOOP_ITERATIONS_GUESSED) On Tue, Jul 31, 2012 at 5:18 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jul 31, 2012 at 5:17 AM, Dehao Chen de...@google.com wrote: Hi, This patch fixed the problem when a LOOP_EXIT edge for the inner loop happened to target at the LOOP_LATCH of the outer loop

Re: [PATCH] Fix the LOOP_BRANCH prediction

2012-07-31 Thread Richard Guenther
On Tue, Jul 31, 2012 at 12:38 PM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Jul 31, 2012 at 12:20 PM, Dehao Chen de...@google.com wrote: Are you suggesting a patch like this: Index: gcc/predict.c === --- gcc/predict.c

Re: [PATCH] Fix the LOOP_BRANCH prediction

2012-07-31 Thread Richard Guenther
On Tue, Jul 31, 2012 at 12:43 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jul 31, 2012 at 12:38 PM, Jan Hubicka hubi...@ucw.cz wrote: On Tue, Jul 31, 2012 at 12:20 PM, Dehao Chen de...@google.com wrote: Are you suggesting a patch like this: Index: gcc/predict.c

[PATCH][RFC][6/n] into-SSA TLC

2012-07-31 Thread Richard Guenther
removed in matrix-reorg.c reminds me of removing that useless beast ... Thanks, Richard. 2012-07-31 Richard Guenther rguent...@suse.de * tree-flow.h (struct gimple_df): Remove syms_to_rename member, add ssa_renaming_needed and rename_vops flags. (SYMS_TO_RENAME): Remove

Re: [PATCH][5/n] into-SSA TLC

2012-07-31 Thread Richard Guenther
On Mon, 30 Jul 2012, Michael Matz wrote: Hi, On Mon, 30 Jul 2012, Richard Guenther wrote: This makes into-SSA no longer rely on variable annotations and instead uses on-the-side information local to into/update-SSA. Lookups can probably be avoided in some places if we pass around

Re: graphite loop optimizer - C examples?

2012-07-30 Thread Richard Guenther
On Sun, Jul 29, 2012 at 7:33 PM, Gary Funck g...@intrepid.com wrote: I have been experimenting with the graphite optimizer, based on GCC trunk, and cloog-isl. I started with the attached simple C program, which has this basic structure. #define N 2 int a[N][N], b[N], c[N]; [...]

Re: [PATCH v2] Target-specific limits on vector alignment

2012-07-30 Thread Richard Guenther
On Fri, Jul 27, 2012 at 5:24 PM, Ulrich Weigand uweig...@de.ibm.com wrote: Richard Guenther wrote: On Mon, Jun 11, 2012 at 5:25 PM, Richard Earnshaw rearn...@arm.com wrote: On 11/06/12 15:53, Richard Guenther wrote: The type argument or the size argument looks redundant. Technically, yes

Re: [PATCH][4/n] into-SSA TLC

2012-07-30 Thread Richard Guenther
On Fri, 27 Jul 2012, Richard Guenther wrote: This avoids triggering update-ssa right after into-ssa just because we didn't rename virtual operands yet. Simply do that on-the-fly, update_stmt will have added bare symbols as operands already. Surprisingly simple ... no idea why I chose

[PATCH][5/n] into-SSA TLC

2012-07-30 Thread Richard Guenther
-unknown-linux-gnu, queued for now. The remaining var-ann users are remove_unused_locals (the used flag) and cfgexpands out-of-SSA. Richard. 2012-07-30 Richard Guenther rguent...@suse.de * tree-flow.h (struct var_ann_d): Remove need_phi_state and current_def members. * tree

Re: [patch[ Add explanations to sbitmap, bitmap, and sparseset

2012-07-30 Thread Richard Guenther
On Mon, Jul 30, 2012 at 4:43 PM, Peter Bergner berg...@vnet.ibm.com wrote: On Fri, 27 Jul 2012 15:40:35 +0200 Richard Guenther richard.guent...@gmail.com wrote: Also it looks less efficient than sbitmap in the case when your main operation is adding to the set and querying the set randomly

Re: [patch[ Add explanations to sbitmap, bitmap, and sparseset

2012-07-30 Thread Richard Guenther
On Mon, Jul 30, 2012 at 5:14 PM, Richard Guenther richard.guent...@gmail.com wrote: On Mon, Jul 30, 2012 at 5:05 PM, Steven Bosscher stevenb@gmail.com wrote: On Mon, Jul 30, 2012 at 4:53 PM, Richard Guenther richard.guent...@gmail.com wrote: No, but less space efficient and of comparable

Re: [patch[ Add explanations to sbitmap, bitmap, and sparseset

2012-07-30 Thread Richard Guenther
On Mon, Jul 30, 2012 at 5:05 PM, Steven Bosscher stevenb@gmail.com wrote: On Mon, Jul 30, 2012 at 4:53 PM, Richard Guenther richard.guent...@gmail.com wrote: No, but less space efficient and of comparable speed as sbitmap which is also O(1). But iterating an sbitmap has worse complexity

Re: Add hot/cold attributes for labels

2012-07-27 Thread Richard Guenther
On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson r...@redhat.com wrote: On 07/26/2012 02:41 PM, Richard Henderson wrote: This is a patch... ... that I should have attached. Bah. Do we need to mark the labels so we preserve them? Consider goto foo; foo: bar __attribute__((cold)): ...

Re: Add hot/cold attributes for labels

2012-07-27 Thread Richard Guenther
On Fri, Jul 27, 2012 at 11:08 AM, Steven Bosscher stevenb@gmail.com wrote: On Fri, Jul 27, 2012 at 10:57 AM, Richard Guenther richard.guent...@gmail.com wrote: On Thu, Jul 26, 2012 at 11:58 PM, Richard Henderson r...@redhat.com wrote: On 07/26/2012 02:41 PM, Richard Henderson wrote

Re: Add hot/cold attributes for labels

2012-07-27 Thread Richard Guenther
On Fri, Jul 27, 2012 at 11:40 AM, Steven Bosscher stevenb@gmail.com wrote: On Fri, Jul 27, 2012 at 11:15 AM, Richard Guenther richard.guent...@gmail.com wrote: Right. I don't like the use of this attribute on labels at all, for the reasons you list here. I think it would be much cleaner

[PATCH][1/n] into-SSA TLC

2012-07-27 Thread Richard Guenther
mapping (referenced-vars) in into-SSA (which is the major blocker for getting rid of that mapping alltogether). Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2012-07-27 Richard Guenther rguent...@suse.de * tree-into-ssa.c (def_blocks_p): New typedef

[PATCH][2/n] into-SSA TLC

2012-07-27 Thread Richard Guenther
issue, very many virtual operands vanished with the merge of alias-improvements. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-07-27 Richard Guenther rguent...@suse.de * doc/invoke.texi (min-virtual-mappings, virtual-mappings-ratio): Remove param

Re: [PATCH] Fix comment in cgraphunit.c

2012-07-27 Thread Richard Guenther
On Fri, Jul 27, 2012 at 1:44 PM, Marek Polacek pola...@redhat.com wrote: On Wed, Jul 25, 2012 at 01:43:59PM +0200, Richard Guenther wrote: On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek pola...@redhat.com wrote: Ping. Ok. Sorry, can't commit myself. Thanks, Committed. Richard

[PATCH][3/n] into-SSA TLC

2012-07-27 Thread Richard Guenther
puts the bitmap into that SSA name auxiliar vector. Lifetime is managed by using a separate obstack and the aux vector age. Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2012-07-27 Richard Guenther rguent...@suse.de * tree-cfg.c (gimple_can_merge_blocks_p): Do

[PATCH][4/n] into-SSA TLC

2012-07-27 Thread Richard Guenther
(originally the first 'alias' pass enabled virtual operands). Btw, we still have no virtual operands at -O0, it would now become a tiny bit cheaper to add them (just to remove some !optimize checks). Bootstrap and regtest pending on x86_64-unknown-linux-gnu. Richard. 2012-07-27 Richard Guenther

Re: [PATCH]: Use GTY atomic option for arrays, new atomic vector type

2012-07-27 Thread Richard Guenther
On Fri, Jul 27, 2012 at 2:59 PM, Laurynas Biveinis laurynas.bivei...@gmail.com wrote: This is a slightly expanded version of the patch in [1]. The main difference is that I expanded gengtype diagnostics to error on GTY length option applied to strings too, in addition to other arrays of

Re: [patch[ Add explanations to sbitmap, bitmap, and sparseset

2012-07-27 Thread Richard Guenther
On Thu, Jul 26, 2012 at 11:57 AM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Jul 26, 2012 at 11:23 AM, Richard Guenther richard.guent...@gmail.com wrote: Ok! Thanks for adding this exhaustive documentation. There's more to come! I want to add some explanations to ebitmap, pointer

Re: Optimize attribute and inlining

2012-07-26 Thread Richard Guenther
On Wed, Jul 25, 2012 at 8:25 PM, David Brown david.br...@hesbynett.no wrote: On 25/07/12 17:30, Richard Guenther wrote: On Wed, Jul 25, 2012 at 4:07 PM, Selvaraj, Senthil_Kumar senthil_kumar.selva...@atmel.com wrote: Declaring a function with __attribute__((optimize(O0)) turns off inlining

Re: Optimize attribute and inlining

2012-07-26 Thread Richard Guenther
On Thu, Jul 26, 2012 at 1:21 PM, David Brown da...@westcontrol.com wrote: On 26/07/2012 11:12, Richard Guenther wrote: On Wed, Jul 25, 2012 at 8:25 PM, David Brown david.br...@hesbynett.no wrote: On 25/07/12 17:30, Richard Guenther wrote: On Wed, Jul 25, 2012 at 4:07 PM, Selvaraj

Re: memset and host char requirement

2012-07-26 Thread Richard Guenther
On Thu, Jul 26, 2012 at 2:11 PM, Paulo J. Matos pa...@matos-sorge.com wrote: Hi, My target has 16bit chars. What I am seeing is that in a memset call, the call is not inlined by GCC whenever fill value is bigger than host char. This seems to be due to the code (GCC 4.6.5) in

Re: memset and host char requirement

2012-07-26 Thread Richard Guenther
On Thu, Jul 26, 2012 at 2:32 PM, Paulo J. Matos pa...@matos-sorge.com wrote: On 26/07/12 13:27, Richard Guenther wrote: Why would the fill value in a memset call be required to fit in a host char? Obviously because of the implementation detail of its caller. Richard. Richard, I am

Re: [patch[ Add explanations to sbitmap, bitmap, and sparseset

2012-07-26 Thread Richard Guenther
On Thu, Jul 26, 2012 at 11:16 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, Add some explanations because I see a lot of places where the choice of data structure is less than optimal. Also some functional changes: sbitmap with popcounts are only used in ebitmap, and they penalize

[PATCH] Fix PR54098

2012-07-26 Thread Richard Guenther
This fixes PR54098 - if the original range was UNDEFINED simply use the update and iterate once more. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-07-26 Richard Guenther rguent...@suse.de PR tree-optimization/54098 * tree-vrp.c

Re: Problems with pragma and attribute optimize.

2012-07-25 Thread Richard Guenther
On Wed, Jul 25, 2012 at 2:23 PM, Allan Sandfeld Jensen carew...@gmail.com wrote: Hi, I have been experimenting with marking specific functions to be auto- vectorized in GCC, but have had problems getting it to work. It seems the optimize attribute works sometimes, but only if the function it

Re: Optimize attribute and inlining

2012-07-25 Thread Richard Guenther
On Wed, Jul 25, 2012 at 4:07 PM, Selvaraj, Senthil_Kumar senthil_kumar.selva...@atmel.com wrote: Declaring a function with __attribute__((optimize(O0)) turns off inlining for the translation unit (atleast) containing the function (see output at the end). Is this expected behavior? Not

Re: Problems with pragma and attribute optimize.

2012-07-25 Thread Richard Guenther
On Wed, Jul 25, 2012 at 4:25 PM, Allan Sandfeld Jensen carew...@gmail.com wrote: On Wednesday 25 July 2012, Richard Guenther wrote: On Wed, Jul 25, 2012 at 2:23 PM, Allan Sandfeld Jensen carew...@gmail.com wrote: Hi, I have been experimenting with marking specific functions to be auto

Re: [PATCH] Fix PR 52631 (VN does not use simplified expression for lookup)

2012-07-25 Thread Richard Guenther
On Tue, Jul 24, 2012 at 5:50 PM, Andrew Pinski andrew.pin...@caviumnetworks.com wrote: Hi, Before tuples was introduced, VN used to lookup the simplified expression to see if it was available already and use that instead of the non simplified one. This patch adds the support back to VN to

Re: [PATCH] Fix comment in cgraphunit.c

2012-07-25 Thread Richard Guenther
On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek pola...@redhat.com wrote: Ping. Ok. Thanks, Richard. On Fri, Jul 13, 2012 at 02:00:54PM +0200, Marek Polacek wrote: I think the comment at the start of the file is wrong, since it speaks about varpool_finalize_variable, but there's no such

Re: [4.7 RFT PATCH, i386]: Backport recent LEA improvements to 4.7 branch

2012-07-25 Thread Richard Guenther
On Tue, Jul 24, 2012 at 9:32 PM, Uros Bizjak ubiz...@gmail.com wrote: Hello! Attached patch backports recent LEA improvements to 4.7 branch. As in regression fixes, or wrong-code fixes? This looks suspiciously not appropriate for 4.7 ... Richard. The patch unifies handling of LEA

Re: [patch] un-#ifdef GATHER_STATISTICS

2012-07-25 Thread Richard Guenther
On Tue, Jul 24, 2012 at 7:13 PM, Steven Bosscher stevenb@gmail.com wrote: AFAIR the qsort is just for getting a stable ordering over two pools to find the leaked regsets afterwards, the type of ordering doesn't matter. What matters is that the compare function gives a reliable result. You

Re: VRP PLUS/MINUS_EXPR

2012-07-25 Thread Richard Guenther
On Wed, Jul 25, 2012 at 12:21 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, here is a slight improvement to VRP for sum and difference of intervals. There are some things I left because I didn't understand them enough: * range_int_cst_p (vr0): I thought it was always true by that time,

Re: [patch] un-#ifdef GATHER_STATISTICS

2012-07-25 Thread Richard Guenther
On Wed, Jul 25, 2012 at 1:59 PM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Jul 25, 2012 at 1:49 PM, Richard Guenther richard.guent...@gmail.com wrote: Oh, bigger bitmap_head? That's bad ... :/ So much for '#ifdefs are bad' :/ Bigger bitmap_head isn't a problem. A bigger

Re: [patch] un-#ifdef GATHER_STATISTICS

2012-07-24 Thread Richard Guenther
On Mon, Jul 23, 2012 at 7:01 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, This large patch makes GATHER_STATISTICS always take a value, 0 (disabled) or 1 (enabled), and turns all related #ifdef code into conditional branches. This slightly increases the data section of cc1, but

Re: [Patch] PR 51938: extend ifcombine

2012-07-24 Thread Richard Guenther
On Mon, Jul 23, 2012 at 10:58 PM, Marc Glisse marc.gli...@inria.fr wrote: On Wed, 20 Jun 2012, Richard Guenther wrote: On Sun, Jun 10, 2012 at 4:16 PM, Marc Glisse marc.gli...@inria.fr wrote: Hello, currently, tree-ssa-ifcombine handles pairs of imbricated ifs that share the same

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-24 Thread Richard Guenther
On Tue, Jul 24, 2012 at 10:25 AM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jul 2012, Andrew Pinski wrote: This patch improves ifcombine by doing two things. First tries to see if the then and else are swapped and handles that case. Just a few hours after I posted:

Re: [patch] Stop gengtype from emitting empty loops

2012-07-24 Thread Richard Guenther
On Tue, Jul 24, 2012 at 11:31 AM, Laurynas Biveinis laurynas.bivei...@gmail.com wrote: For scalar fields or skipped fields, gengtype produces empty loops. This patch checks for that case and breaks out if an empty loop body is detected: Bootstrappedtested on powerpc64-unknown-linux-gnu. OK?

Re: [patch] Profiling infrastructure TLC (1/n)

2012-07-23 Thread Richard Guenther
On Sun, Jul 22, 2012 at 12:40 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, This patch cleans up some interesting things in GCC's profiling support. The most significant changes are the removal of BB_TO_GCOV_INDEX and after_tree_profile. Another visible cleanup is that

Re: [patch][gcov] Clarify the internals a bit

2012-07-23 Thread Richard Guenther
On Sun, Jul 22, 2012 at 4:34 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, While reading up on how gcov/profiling works, I noticed that there are a lot of places where the notes file is still referred to as the basic block graph file. Also, the gcov manual has not been updated for

Re: [patch] PR53881 - again

2012-07-23 Thread Richard Guenther
On Mon, Jul 23, 2012 at 1:23 AM, Steven Bosscher stevenb@gmail.com wrote: Hello, This patch fixes PR53881 by making group_case_labels_stmt look at the CFG instead of relying on label equality. Bootstrappedtested on powerpc64-unknown-linux-gnu. OK? Ok. Thanks, Richard. Ciao! Steven

[PATCH] Use local-decls in aliased vars dumping

2012-07-23 Thread Richard Guenther
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-07-23 Richard Guenther rguent...@suse.de * tree-ssa-alias.c (dump_alias_info): Walk over local decls instead of referenced vars. Index: gcc/tree-ssa-alias.c

[PATCH] Fix PR53616

2012-07-23 Thread Richard Guenther
Richard Guenther rguent...@suse.de PR tree-optimization/53616 * tree-loop-distribution.c (ldist_gen): Do not change partition ordering when merging partitions. Index: gcc/tree-loop-distribution.c === *** gcc

Re: [patch] Move sbitmap dataflow functions from sbitmap.c to cfganal.c

2012-07-23 Thread Richard Guenther
On Mon, Jul 23, 2012 at 3:59 PM, Steven Bosscher stevenb@gmail.com wrote: Hello, $SUBJECT because it makes sbitmap.c independent of basic-block.h -- as it should be, given that sbitmap is just a very simple bitmap datatype. Bootstrapped (profiledbootstrapped, actually) and tested on

Re: [PATCH] Re-work get_object_alignment (again)

2012-07-20 Thread Richard Guenther
On Thu, 19 Jul 2012, Markus Trippelsdorf wrote: On 2012.07.17 at 15:10 +0200, Richard Guenther wrote: Comments welcome, of course. This patch apparently miscompiles the Linux kernel, which just hangs during early boot: ... SLUB: Genslabs=15, HWalign=64, Order=0-3, MinObjects=0, CPUs=4

Re: [PATCH] Avoid duplicate -Wnonnull warnings (PR c++/28656)

2012-07-20 Thread Richard Guenther
On Thu, Jul 19, 2012 at 6:53 PM, Jakub Jelinek ja...@redhat.com wrote: Hi! On the following testcase we emit various (correct) -Wnonnull warnings more than once, sometimes many times. The problem on the reported memcpy testcase is that glibc uses __attribute__((nonnull (1, 2))) and gcc uses

Re: [PATCH 0/4] [RFC] Reduce the representation size of optabs

2012-07-20 Thread Richard Guenther
On Thu, Jul 19, 2012 at 8:24 PM, Richard Henderson r...@redhat.com wrote: While adding multiple new optabs over the past week or three, it occurred to me that (1) there are lots of places to update all in sync and (2) the representation size of optabs is huge. The first issue is somewhat

Re: [patch] More cleanups for CFG dumping

2012-07-20 Thread Richard Guenther
On Fri, Jul 20, 2012 at 11:02 AM, Steven Bosscher stevenb@gmail.com wrote: On Thu, Jul 19, 2012 at 11:09 AM, Richard Guenther richard.guent...@gmail.com wrote: Hmm, pp_flush looks like a lot more expensive compared to pp_newline for example in @@ -74,7 +74,7 @@ maybe_init_pretty_print

Re: [PATCH] Avoid duplicate -Wnonnull warnings (PR c++/28656)

2012-07-20 Thread Richard Guenther
On Fri, Jul 20, 2012 at 11:04 AM, Jakub Jelinek ja...@redhat.com wrote: On Fri, Jul 20, 2012 at 10:37:32AM +0200, Richard Guenther wrote: On Thu, Jul 19, 2012 at 6:53 PM, Jakub Jelinek ja...@redhat.com wrote: Hum. How hard would it be to merge the attributes? IMHO hard and ugly. The thing

[PATCH] Followup referenced vars TLC

2012-07-20 Thread Richard Guenther
specifically care about !TREE_ASM_WRITTEN. We don't have a testcase that breaks, so the following patch simply removes the code. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-07-20 Richard Guenther rguent...@suse.de * tree-inline.c (add_local_variables

Re: [Fortran-dev][Patch, Fortran] C_F_Pointer cleanup

2012-07-20 Thread Richard Guenther
On Fri, Jul 20, 2012 at 12:17 PM, Tobias Burnus bur...@net-b.de wrote: On 07/20/2012 11:52 AM, Mikael Morin wrote OK. Thanks for the review. I guess the division will be dropped too (the middle-end does the reverse multiplication implicitly in the pointer arithmetic). I wonder which one

[PATCH] Fix PR54031

2012-07-20 Thread Richard Guenther
at a pointer. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-07-20 Richard Guenther rguent...@suse.de PR tree-optimization/54031 * tree-ssa-ccp.c (get_value_from_alignment): Use get_pointer_alignment_1. Index: gcc/tree-ssa-ccp.c

[PATCH] Walk over local decls instead of referenced vars where appropriate

2012-07-20 Thread Richard Guenther
, installed. Richard. 2012-07-20 Richard Guenther rguent...@suse.de * tree-dfa.c (collect_dfa_stats): Simplify. * tree-ssa-structalias.c (compute_may_aliases): Do not dump referenced vars. * cfgexpand.c (estimated_stack_frame_size): Walk over local decls instead

Re: cosmetic change - simplify cse.c:preferable()

2012-07-19 Thread Richard Guenther
; } /* Internal function, to compute cost when X is not a register; called -- Richard Guenther rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend

Re: [patch] More cleanups for CFG dumping

2012-07-19 Thread Richard Guenther
On Wed, Jul 18, 2012 at 7:18 PM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Jul 18, 2012 at 10:08 AM, Steven Bosscher stevenb@gmail.com wrote: On Wed, Jul 18, 2012 at 2:24 AM, H.J. Lu hjl.to...@gmail.com wrote: This caused: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54008

Re: [patch] Fix ICE in set_lattice_value

2012-07-19 Thread Richard Guenther
On Thu, Jul 19, 2012 at 9:30 AM, Eric Botcazou ebotca...@adacore.com wrote: Hmm, the point is of couse to not allow transitions that could form a cycle, which is why the reverse transition is not allowed. Let me have a closer look here. You can reproduce on your favorite platform by locally

Re: [patch] Fix ICE in set_lattice_value

2012-07-19 Thread Richard Guenther
On Thu, Jul 19, 2012 at 12:00 PM, Eric Botcazou ebotca...@adacore.com wrote: That helps reproducing it. The issue is that this really is a transition in the wrong direction. We iterate Visiting statement: D.2928_263 = (sizetype) i.29_262; which is likely UNDEFINED Lattice value changed to

[PATCH] Fix CCP and addresses of multi-dimensional arrays

2012-07-19 Thread Richard Guenther
on the branch and do the backport that would be nice). Richard. 2012-07-19 Richard Guenther rguent...@suse.de Eric Botcazou ebotca...@adacore.com * tree-ssa-ccp.c (valid_lattice_transition): Clarify comment about transition from invariant to known bits

Re: [patch] Add a lexical block only when the callsite has source location info

2012-07-18 Thread Richard Guenther
don't loose it whenever we switch functions. The mid-term goal would then be to unify this with the insns locators used by the RTL infrastructure. I hope this helps. Dodji Thanks, Dehao On Tue, Jul 17, 2012 at 5:27 PM, Richard Guenther richard.guent

Re: [PATCH] Add flag to control straight-line strength reduction

2012-07-18 Thread Richard Guenther
(flag_tree_slsr) Optimization +Perform straight-line strength reduction + ftree-sra Common Report Var(flag_tree_sra) Optimization Perform scalar replacement of aggregates -- Richard Guenther rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF

Re: [PATCH] Add flag to control straight-line strength reduction

2012-07-18 Thread Richard Guenther
On Wed, 18 Jul 2012, Steven Bosscher wrote: On Wed, Jul 18, 2012 at 9:59 AM, Richard Guenther rguent...@suse.de wrote: On Tue, 17 Jul 2012, William J. Schmidt wrote: I overlooked adding a pass-control flag for strength reduction, added here. I named it -ftree-slsr for consistency

Re: Fwd: Re: Commit: ARM: Document -munaligned-access

2012-07-18 Thread Richard Guenther
. + @end table @node AVR Options -- Richard Guenther rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imend

[PATCH] Fix PR53970

2012-07-18 Thread Richard Guenther
alignment). So, just ask that - whether the scalar access is aligned to at least its size. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2012-07-18 Richard Guenther rguent...@suse.de PR tree-optimization/53970 * tree.h (contains_packed_reference

Re: [PATCH] Add flag to control straight-line strength reduction

2012-07-18 Thread Richard Guenther
(flag_tree_sink) Optimization Enable SSA code sinking on trees +ftree-slsr +Common Report Var(flag_tree_slsr) Optimization +Perform straight-line strength reduction + ftree-sra Common Report Var(flag_tree_sra) Optimization Perform scalar replacement of aggregates -- Richard Guenther

Re: [PATCH] Add flag to control straight-line strength reduction

2012-07-18 Thread Richard Guenther
On Wed, 18 Jul 2012, Steven Bosscher wrote: On Wed, Jul 18, 2012 at 3:24 PM, William J. Schmidt wschm...@linux.vnet.ibm.com wrote: It turns out I was looking at a very old copy of the manual, and the -ftree... stuff is not as prevalent now as it once was. I'll just go with -fslsr to be

Re: [patch] Fix ICE in set_lattice_value

2012-07-18 Thread Richard Guenther
On Wed, Jul 18, 2012 at 4:05 PM, Eric Botcazou ebotca...@adacore.com wrote: This is a regression present on mainline and 4.7 branch for targets using SJLJ exceptions by default in Ada (e.g. ARM). The error message is: +===GNAT BUG

Re: [patch] Fix GIMPLE verification failure on CONSTRUCTOR

2012-07-18 Thread Richard Guenther
On Wed, Jul 18, 2012 at 4:25 PM, Eric Botcazou ebotca...@adacore.com wrote: This is a regression present on mainline and 4.7 branch. The error message is: p.adb: In function 'P.Proc': p.adb:3:4: error: non-trivial conversion at assignment system__address void (*T590) (void)

Re: [patch] Fix ICE during out-of-SSA

2012-07-18 Thread Richard Guenther
On Wed, Jul 18, 2012 at 4:54 PM, Eric Botcazou ebotca...@adacore.com wrote: This is a regression present on mainline and 4.7 branch for targets using SJLJ exceptions by default in Ada (e.g. ARM). The error message is: Unable to coalesce ssa_names 2 and 20 which are marked as MUST COALESCE.

<    1   2   3   4   5   6   7   8   9   10   >