Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-06-14 Thread Wei Mi via Gcc
Yeah, create_llvm_prof depends on llvm_symbolizer which shouldn't have the same limitation. To separate from llvm, create_gcov still depends on the old set of addr2line library which likely doesn't support dwarf v5. That is an issue indeed. Thanks, Wei. On Fri, Jun 11, 2021 at 6:14 PM Eugene

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-26 Thread Wei Mi via Gcc
Thanks. Good to know the build works with newer protobuf. Wei. On Wed, May 26, 2021 at 4:40 PM Eugene Rozenfeld wrote: > > 3.0.0 is the latest supported version on Ubuntu 18.04. I verified that the > build works on Ubuntu 20.04 with protobuf-compiler and libprotobuf-dev > version 3.6.1.3. >

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Wei Mi via Gcc
I checked the source of protobuf 3.0.0 and it didn't contain the operator[] in RepeatedField. Need to install a newer version of protobuf. Thanks, Wei. On Tue, May 25, 2021 at 1:49 PM Eugene Rozenfeld wrote: > > Both are 3.0.0-9.1ubuntu1: > > eugene@eugene-Virtual-Machine:~/autofdo1/build$ apt

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-25 Thread Wei Mi via Gcc
It looks like some version problem about protobuf-compiler and libprotobuf-dev. Could you check what is the installed version on your end for those two packages and see if they are consistent? On my platform, they are both 3.12.4. On Tue, May 25, 2021 at 12:01 AM Eugene Rozenfeld wrote: > >

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Wei Mi via Gcc
It isn't exposed on my platform either. Looks like a bug in perf_data_converter (i.e., quipper). Could you try adding #include in third_party/perf_data_converter/src/quipper/huge_page_deducer.cc and see if it fixes the problem? If it works, I will need to file a bug against perf_data_converter.

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-24 Thread Wei Mi via Gcc
Sorry, I added dependency for create_gcov but missed it for dump_gcov. Fixed it at https://github.com/google/autofdo/commit/6ca36cdc30986f13583a3aef3e27746ca4fc5bf6 . Thanks, Wei. On Mon, May 24, 2021 at 6:39 PM Eugene Rozenfeld < eugene.rozenf...@microsoft.com> wrote: > Thank you Wei. Looks

Re: [EXTERNAL] Re: State of AutoFDO in GCC

2021-05-22 Thread Wei Mi via Gcc
It is a proto library build dependency issue which didn't expose on my platform. I fix it at https://github.com/google/autofdo/commit/98269aee9674cc885cc5eb1bd917eb2d12731710. Please try again. Thanks, Wei. On Fri, May 21, 2021 at 6:28 PM Eugene Rozenfeld < eugene.rozenf...@microsoft.com> wrote:

Re: State of AutoFDO in GCC

2021-05-10 Thread Wei Mi via Gcc
https://github.com/google/autofdo has been updated. Now create_gcov/dump_gcov are added back and can be built separately. Please look at "2.2 Build autofdo tool for gcc" in https://github.com/google/autofdo#readme On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen wrote: > > On Mon, Apr 26, 2021 at

Re: State of AutoFDO in GCC

2021-04-25 Thread Wei Mi via Gcc
On Sun, Apr 25, 2021 at 4:18 PM Xinliang David Li wrote: > > > On Sun, Apr 25, 2021 at 12:07 PM Jan Hubicka wrote: > >> David, >> > >> > The text format is documented here: >> > https://clang.llvm.org/docs/UsersManual.html >> > The binary format is not documented. The binary format is not >>