Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 7/1/19 10:33 AM, Richard Biener wrote: On Mon, Jul 1, 2019 at 4:55 PM Martin Sebor wrote:> [Adding gcc-patches] Richard, do you have any further comments or is the revised patch good to commit? No further comments from my side - it's good to commit. After running a full bootstrap with

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 7/1/19 10:33 AM, Richard Biener wrote: On Mon, Jul 1, 2019 at 4:55 PM Martin Sebor wrote:> [Adding gcc-patches] Richard, do you have any further comments or is the revised patch good to commit? No further comments from my side - it's good to commit. After running a full bootstrap with

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On Mon, Jul 1, 2019 at 4:55 PM Martin Sebor wrote:> > [Adding gcc-patches] > > Richard, do you have any further comments or is the revised patch > good to commit? No further comments from my side - it's good to commit. Richard. > Martin > > On 6/25/19 2:30 PM, Martin Sebor wrote: > > On

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On Mon, Jul 1, 2019 at 4:55 PM Martin Sebor wrote:> > [Adding gcc-patches] > > Richard, do you have any further comments or is the revised patch > good to commit? No further comments from my side - it's good to commit. Richard. > Martin > > On 6/25/19 2:30 PM, Martin Sebor wrote: > > On

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

[Adding gcc-patches] Richard, do you have any further comments or is the revised patch good to commit? Martin On 6/25/19 2:30 PM, Martin Sebor wrote: On 6/25/19 3:53 AM, Jonathan Wakely wrote: On 24/06/19 19:42 +0200, Richard Biener wrote: On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

[Adding gcc-patches] Richard, do you have any further comments or is the revised patch good to commit? Martin On 6/25/19 2:30 PM, Martin Sebor wrote: On 6/25/19 3:53 AM, Jonathan Wakely wrote: On 24/06/19 19:42 +0200, Richard Biener wrote: On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 6/25/19 3:53 AM, Jonathan Wakely wrote: On 24/06/19 19:42 +0200, Richard Biener wrote: On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor wrote: On 6/24/19 6:11 AM, Richard Biener wrote: > On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: >> >> On 6/21/19 6:06 AM, Richard Biener wrote: >>>

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 24/06/19 19:42 +0200, Richard Biener wrote: On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor wrote: On 6/24/19 6:11 AM, Richard Biener wrote: > On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: >> >> On 6/21/19 6:06 AM, Richard Biener wrote: >>> On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 6/24/19 11:42 AM, Richard Biener wrote: On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor wrote: On 6/24/19 6:11 AM, Richard Biener wrote: On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: On 6/21/19 6:06 AM, Richard Biener wrote: On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote:

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On Mon, Jun 24, 2019 at 4:35 PM Martin Sebor wrote: > > On 6/24/19 6:11 AM, Richard Biener wrote: > > On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: > >> > >> On 6/21/19 6:06 AM, Richard Biener wrote: > >>> On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote: > > Bug 90923 shows

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 6/24/19 6:11 AM, Richard Biener wrote: On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: On 6/21/19 6:06 AM, Richard Biener wrote: On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote: Bug 90923 shows that even though GCC hash-table based containers like hash_map can be instantiated on

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On Fri, Jun 21, 2019 at 7:17 PM Martin Sebor wrote: > > On 6/21/19 6:06 AM, Richard Biener wrote: > > On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote: > >> > >> Bug 90923 shows that even though GCC hash-table based containers > >> like hash_map can be instantiated on types with user-defined

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On 6/21/19 6:06 AM, Richard Biener wrote: On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote: Bug 90923 shows that even though GCC hash-table based containers like hash_map can be instantiated on types with user-defined ctors and dtors they invoke the dtors of such types without invoking the

Re: [PATCH] let hash-based containers work with non-trivial types (PR 90923)

On Wed, Jun 19, 2019 at 5:15 AM Martin Sebor wrote: > > Bug 90923 shows that even though GCC hash-table based containers > like hash_map can be instantiated on types with user-defined ctors > and dtors they invoke the dtors of such types without invoking > the corresponding ctors. > > It was

[PATCH] let hash-based containers work with non-trivial types (PR 90923)

Let me try that again to the right list. On 6/18/19 9:14 PM, Martin Sebor wrote: Bug 90923 shows that even though GCC hash-table based containers like hash_map can be instantiated on types with user-defined ctors and dtors they invoke the dtors of such types without invoking the corresponding

[PATCH] let hash-based containers work with non-trivial types (PR 90923)

Bug 90923 shows that even though GCC hash-table based containers like hash_map can be instantiated on types with user-defined ctors and dtors they invoke the dtors of such types without invoking the corresponding ctors. It was thanks to this bug that I spent a day debugging "interesting"