Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-12-03 Thread Richard Earnshaw via Gcc
On 29/11/2020 17:38, Florian Weimer wrote: > * Allan Sandfeld Jensen: > >> If you _do_ change it. I would suggest changing it to 120, which is next >> common step for a lot of C++ projects. > > 120 can be problematic for a full HD screen in portrait mode. Nine > pixels per character is not a

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-30 Thread Michael Matz
Hello, On Mon, 30 Nov 2020, Allan Sandfeld Jensen wrote: > > > On Sonntag, 29. November 2020 18:38:15 CET Florian Weimer wrote: > > > > * Allan Sandfeld Jensen: > > > > > If you _do_ change it. I would suggest changing it to 120, which is > > > > > next > > > > > common step for a lot of C++

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-30 Thread Allan Sandfeld Jensen
On Montag, 30. November 2020 16:47:08 CET Michael Matz wrote: > Hello, > > On Sun, 29 Nov 2020, Allan Sandfeld Jensen wrote: > > On Sonntag, 29. November 2020 18:38:15 CET Florian Weimer wrote: > > > * Allan Sandfeld Jensen: > > > > If you _do_ change it. I would suggest changing it to 120, which

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-30 Thread Michael Matz
Hello, On Sun, 29 Nov 2020, Allan Sandfeld Jensen wrote: > On Sonntag, 29. November 2020 18:38:15 CET Florian Weimer wrote: > > * Allan Sandfeld Jensen: > > > If you _do_ change it. I would suggest changing it to 120, which is next > > > common step for a lot of C++ projects. > > > > 120 can be

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-29 Thread Allan Sandfeld Jensen
On Sonntag, 29. November 2020 18:38:15 CET Florian Weimer wrote: > * Allan Sandfeld Jensen: > > If you _do_ change it. I would suggest changing it to 120, which is next > > common step for a lot of C++ projects. > > 120 can be problematic for a full HD screen in portrait mode. Nine > pixels per

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-29 Thread Florian Weimer
* Allan Sandfeld Jensen: > If you _do_ change it. I would suggest changing it to 120, which is next > common step for a lot of C++ projects. 120 can be problematic for a full HD screen in portrait mode. Nine pixels per character is not a lot (it's what VGA used), and you can't have any window

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-28 Thread Thomas Koenig via Gcc
Am 27.11.20 um 00:50 schrieb Jonathan Wakely via Gcc: Does anybody object to raising the line length for libstdc++ code (not the rest of GCC) to 100 columns? In gfortran, we have a habit of using long and expressive function names (which is good) which lead to lots of columns of indentation,

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Ed Smith-Rowland via Gcc
On 11/26/20 6:50 PM, Jonathan Wakely via Gcc wrote: I've touched on the subject a few times, e.g. https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html Libstdc++ code is indented by 2 columns for the enclosing namespace,

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Allan Sandfeld Jensen
On Freitag, 27. November 2020 00:50:57 CET Jonathan Wakely via Gcc wrote: > I've touched on the subject a few times, e.g. > https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html > and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html > > Libstdc++ code is indented by 2 columns for

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Ville Voutilainen via Gcc
On Fri, 27 Nov 2020 at 11:54, Liu Hao via Libstdc++ wrote: > As you can see, qualified names in C++ can grow up to ~100 characters quite > frequently. This may > deteriorate when `typename` and `template` are sometimes required. I don't > think there is > practically a set of rules which

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Liu Hao via Gcc
在 2020/11/27 下午4:14, Richard Biener 写道: > > I prefer the ( on the next line. The argument list can be two spaces > indented from > the function name or "right justified" (I think the latter looks > visually better). > The right justification thing looks reasonable. For example, I think this

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Ville Voutilainen via Gcc
On Fri, 27 Nov 2020 at 10:16, Richard Biener via Libstdc++ wrote: > > Why not change this to: > > > > > if (present) > > > ptr = gfc_build_conditional_assign_expr ( > > > block, present, ptr, nullarg); > > > > > > > I think

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-27 Thread Richard Biener via Gcc
On Fri, Nov 27, 2020 at 3:48 AM Liu Hao via Gcc wrote: > > 在 2020/11/27 上午7:50, Jonathan Wakely via Gcc 写道: > > I've touched on the subject a few times, e.g. > > https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html > > and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html > > > >

Re: [RFC] Increase libstdc++ line length to 100(?) columns

2020-11-26 Thread Liu Hao via Gcc
在 2020/11/27 上午7:50, Jonathan Wakely via Gcc 写道: > I've touched on the subject a few times, e.g. > https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html > and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html > > Libstdc++ code is indented by 2 columns for the enclosing namespace,

[RFC] Increase libstdc++ line length to 100(?) columns

2020-11-26 Thread Jonathan Wakely via Gcc
I've touched on the subject a few times, e.g. https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html Libstdc++ code is indented by 2 columns for the enclosing namespace, usually another two for being in a template, and is full