Re: CSE deletes valid REG_EQUAL?

2020-11-17 Thread Paolo Bonzini via Gcc
On 17/11/20 02:12, Jeff Law wrote: Removing all REG_EQUAL notes for regs that become dead anywhere That's not what it does. seems to just be a thinko? All pseudos are dead somewhere! (Yeah okay, infinite loops, but other than that.) Yea, but the code which wipes the notes probably has no

Re: CSE deletes valid REG_EQUAL?

2020-11-16 Thread Jeff Law via Gcc
On 11/13/20 6:55 AM, Segher Boessenkool wrote: > Hi guys, > > On Thu, Nov 12, 2020 at 09:10:14PM -0700, Jeff Law wrote: >> On 11/12/20 7:02 PM, Xionghu Luo via Gcc wrote: >>> The output shows "REQ_EQUAL r118:DI+0x66546b64" is deleted by >>> df_remove_dead_eq_notes, >>> but r120:DI is not

Re: CSE deletes valid REG_EQUAL?

2020-11-13 Thread Segher Boessenkool
Hi guys, On Thu, Nov 12, 2020 at 09:10:14PM -0700, Jeff Law wrote: > On 11/12/20 7:02 PM, Xionghu Luo via Gcc wrote: > > The output shows "REQ_EQUAL r118:DI+0x66546b64" is deleted by > > df_remove_dead_eq_notes, > > but r120:DI is not REG_DEAD here, so is it correct here to check insn use > >

Re: CSE deletes valid REG_EQUAL?

2020-11-12 Thread Jeff Law via Gcc
On 11/12/20 7:02 PM, Xionghu Luo via Gcc wrote: > Hi all, > > In PR51505(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51505), Paolo Bonzini > added the code to delete REG_EQUAL notes in df_remove_dead_eq_notes: > > gcc/df-problems.c: > df_remove_dead_eq_notes (rtx_insn *insn, bitmap live) > { >

CSE deletes valid REG_EQUAL?

2020-11-12 Thread Xionghu Luo via Gcc
Hi all, In PR51505(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51505), Paolo Bonzini added the code to delete REG_EQUAL notes in df_remove_dead_eq_notes: gcc/df-problems.c: df_remove_dead_eq_notes (rtx_insn *insn, bitmap live) { ... case REG_EQUAL: case REG_EQUIV: {