Re: Not using DECL_VALUE_EXPR for callee-copied parameters?

2009-09-14 Thread Richard Guenther
On Mon, Sep 14, 2009 at 3:52 AM, John David Anglin wrote: > Hi Martin, > >> Having said that, if anybody has problems with this patch going in, >> please speak out now rather than later. > > I very much appreciate the work you have done on this problem.  However, > the patch doesn't work as expect

Re: Not using DECL_VALUE_EXPR for callee-copied parameters?

2009-09-13 Thread John David Anglin
Hi Martin, > Having said that, if anybody has problems with this patch going in, > please speak out now rather than later. I very much appreciate the work you have done on this problem. However, the patch doesn't work as expected. I get multiple comparison failures with this change on hppa-unkn

Re: Not using DECL_VALUE_EXPR for callee-copied parameters?

2009-09-13 Thread Martin Jambor
On Fri, Sep 11, 2009 at 06:39:10PM -0700, Ian Lance Taylor wrote: > Martin Jambor writes: > > > I have run the testsuite on hppa with the following patch and I > > successfully bootstrapped and tested it on x86_64. Unless someone > > objects, I will bootstrap it on hppa and commit it in a week o

Re: Not using DECL_VALUE_EXPR for callee-copied parameters?

2009-09-11 Thread Ian Lance Taylor
Martin Jambor writes: > I have run the testsuite on hppa with the following patch and I > successfully bootstrapped and tested it on x86_64. Unless someone > objects, I will bootstrap it on hppa and commit it in a week or two > along with Richi's patch verifying such decls don't leak to the IL >

Not using DECL_VALUE_EXPR for callee-copied parameters?

2009-09-11 Thread Martin Jambor
Hi, we sometimes currently mess up when compiling callee-copied parameters on architectures that use it (so, as far as I know, on hppa). The manifestation of the issue is e.g. PR 40464 but I believe there maight be others. The real problem is that even though a comment in tree.h says that declar