Hi!
On Mon, 30 Mar 2015 22:28:41 +, Aditya K hiradi...@msn.com wrote:
So I have modified the patch to use hash_map instead of std::map. The patch
is attached.
However, I got one regression after that.
# Comparing directories
## Dir1=../build-pristine/: 11 sum files
##
From: tho...@codesourcery.com
To: hiradi...@msn.com
CC: richard.guent...@gmail.com; tbsau...@tbsaunde.org; gcc@gcc.gnu.org;
prathamesh.kulka...@linaro.org
Subject: RE: Proposal for adding splay_tree_find (to find elements without
updating the
So I have modified the patch to use hash_map instead of std::map. The patch is
attached.
However, I got one regression after that.
# Comparing directories
## Dir1=../build-pristine/: 11 sum files
## Dir2=../build-test/: 11 sum files
# Comparing 11 common sum files
## /bin/sh
On Mon, Mar 16, 2015 at 4:33 AM, Aditya K hiradi...@msn.com wrote:
Date: Sun, 15 Mar 2015 02:32:23 -0400
From: tbsau...@tbsaunde.org
To: gcc@gcc.gnu.org
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
Date: Wed, 18 Mar 2015 11:50:16 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
From: richard.guent...@gmail.com
To: hiradi...@msn.com
CC: tbsau...@tbsaunde.org; gcc@gcc.gnu.org
On Mon, Mar
On 18 March 2015 at 21:20, Aditya K hiradi...@msn.com wrote:
Date: Wed, 18 Mar 2015 11:50:16 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
From: richard.guent...@gmail.com
To:
Date: Wed, 18 Mar 2015 22:01:18 +0530
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
From: prathamesh.kulka...@linaro.org
To: hiradi...@msn.com
CC: richard.guent...@gmail.com; tbsau...@tbsaunde.org;
From: hiradi...@msn.com
To: lopeziba...@gmail.com; jwakely@gmail.com
CC: tbsau...@tbsaunde.org; gcc@gcc.gnu.org
Subject: RE: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
Date: Mon, 16 Mar 2015 18:45:22
Thanks for the feedback, they were really helpful. I have updated the patch.
Please review this.
Also, although I run `make check` while compiling gcc (with bootstrap
enabled), I'm not sure if 'omp' related tests were exercised.
I'm still unfamiliar with several components of gcc. Any
On 16 March 2015 at 16:55, Jonathan Wakely jwakely@gmail.com wrote:
On 16 March 2015 at 15:54, Jonathan Wakely wrote:
DejaGnu is not meant to be a link, but the wiki automatically treats
any MixedCase word as a link.
I've fixed that now.
We can actually link to the DejaGNU page if
On 16 March 2015 at 15:51, Aditya K wrote:
I started looking at the steps to test gcc, (https://gcc.gnu.org/Testing_GCC):
In the first step: to install prerequisites 'dejagnu', tcl and Expect
- The link to dejagnu does not have any information. for tcl and expect
there are no links.
From: lopeziba...@gmail.com
Date: Mon, 16 Mar 2015 15:16:55 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
To: tbsau...@tbsaunde.org; gcc@gcc.gnu.org; hiradi...@msn.com
Thanks for the
On 16 March 2015 at 15:54, Jonathan Wakely wrote:
DejaGnu is not meant to be a link, but the wiki automatically treats
any MixedCase word as a link.
I've fixed that now.
From: lopeziba...@gmail.com
Date: Mon, 16 Mar 2015 17:04:58 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
To: jwakely@gmail.com
CC: hiradi...@msn.com; tbsau...@tbsaunde.org;
hi,
I'm only commenting on algorithmic stuff at this point, you should make
sure this doesn't regress anything in make check. This stuff only
effects code using omp stuff so compiling random c++ is unlikely to test
this code at all.
Also please follow the style in
Date: Sun, 15 Mar 2015 02:32:23 -0400
From: tbsau...@tbsaunde.org
To: gcc@gcc.gnu.org
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
hi,
I'm only commenting on algorithmic stuff at this point, you
On Mon, Mar 16, 2015 at 03:33:18AM +, Aditya K wrote:
Date: Sun, 15 Mar 2015 02:32:23 -0400
From: tbsau...@tbsaunde.org
To: gcc@gcc.gnu.org
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
---
Date: Tue, 10 Mar 2015 11:20:07 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
From: richard.guent...@gmail.com
To: stevenb@gmail.com
CC: hiradi...@msn.com; gcc@gcc.gnu.org
On Mon, Mar 9,
Are you sure your compare_variables functor is correct?
Subtracting the two values seems very strange for a strict weak ordering.
(Also compare_variables is a pretty poor name!)
You're right. I'll change this to:
/* A stable comparison functor to sort trees. */
struct tree_compare_decl_uid {
bool operator ()(const tree xa, const tree xb) const
{
return DECL_UID (xa) DECL_UID (xb);
}
};
New patch attached.
Thanks,
-Aditya
On Mon, Mar 9, 2015 at 11:59 PM, Steven Bosscher stevenb@gmail.com wrote:
On Mon, Mar 9, 2015 at 7:59 PM, vax mzn wrote:
w.r.t, https://gcc.gnu.org/wiki/Speedup_areas where we want to improve the
performance of splay trees.
The function `splay_tree_node splay_tree_lookup (splay_tree,
Date: Mon, 9 Mar 2015 15:26:26 -0400
From: tbsau...@tbsaunde.org
To: gcc@gcc.gnu.org
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
On Mon, Mar 09, 2015 at 06:59:10PM +, vax mzn wrote:
w.r.t,
On Mon, Mar 09, 2015 at 06:59:10PM +, vax mzn wrote:
w.r.t, https://gcc.gnu.org/wiki/Speedup_areas where we want to improve the
performance of splay trees.
The function `splay_tree_node splay_tree_lookup (splay_tree, splay_tree_key);'
updates the nodes every time a lookup is done.
w.r.t, https://gcc.gnu.org/wiki/Speedup_areas where we want to improve the
performance of splay trees.
The function `splay_tree_node splay_tree_lookup (splay_tree, splay_tree_key);'
updates the nodes every time a lookup is done.
IIUC, There are places where we call this function in a loop i.e.,
On Mon, Mar 9, 2015 at 7:59 PM, vax mzn wrote:
w.r.t, https://gcc.gnu.org/wiki/Speedup_areas where we want to improve the
performance of splay trees.
The function `splay_tree_node splay_tree_lookup (splay_tree, splay_tree_key);'
updates the nodes every time a lookup is done.
IIUC, There
From: stevenb@gmail.com
Date: Mon, 9 Mar 2015 23:59:52 +0100
Subject: Re: Proposal for adding splay_tree_find (to find elements without
updating the nodes).
To: hiradi...@msn.com
CC: gcc@gcc.gnu.org
On Mon, Mar 9, 2015 at 7:59 PM, vax mzn
26 matches
Mail list logo
