I see. I think it may be appropriate to adopt what clang has done and have
one -Winvalid-noreturn for both cases, thoughts?
On Fri, Jul 21, 2023 at 5:43 PM Jonathan Wakely
wrote:
> On Fri, 21 Jul 2023 at 04:28, Julian Waters via Gcc
> wrote:
> >
> > Hi all,
> >
> > I've found the places
On Fri, 21 Jul 2023 at 04:28, Julian Waters via Gcc wrote:
>
> Hi all,
>
> I've found the places responsible for the warnings, but before I do
> anything I'd like to discuss a couple of things.
>
> 1. What would a good name for the warning switch be? How does
> -Wreturning-noreturn sound?
> 2.
Hi all,
I've found the places responsible for the warnings, but before I do
anything I'd like to discuss a couple of things.
1. What would a good name for the warning switch be? How does
-Wreturning-noreturn sound?
2. I've thought about this for a while, and I feel like throwing a warning
for a
On Wed, Jul 5, 2023 at 7:28 AM Jonathan Wakely via Gcc wrote:
>
> On Wed, 5 Jul 2023 at 12:01, Julian Waters via Gcc wrote:
> >
> > I see, thanks Andrew.
> >
> > Anyone else have opinions on this besides Liu or Andrew? The responses have
> > been surprisingly quiet thus far
>
> IMHO all warnings
On Wed, 5 Jul 2023, 14:13 Julian Waters, wrote:
> Hi Jonathan,
>
> Thanks for the reply, is there a place in gcc's source code I could look
> at for this?
>
This is a commit where I added four new warnings, and then changed the code
that issues those warnings to use the new OPT_Wxxx variables:
Hi Jonathan,
Thanks for the reply, is there a place in gcc's source code I could look at
for this? As for the returning an explicit value from noreturn, I'm
unfortunately not the one who wrote the code that way; I'm merely a build
systems developer trying to get it to work with gcc :/
best
On Wed, 5 Jul 2023 at 12:01, Julian Waters via Gcc wrote:
>
> I see, thanks Andrew.
>
> Anyone else have opinions on this besides Liu or Andrew? The responses have
> been surprisingly quiet thus far
IMHO all warnings should have an option controlling them, so that you
can disable them via
I see, thanks Andrew.
Anyone else have opinions on this besides Liu or Andrew? The responses have
been surprisingly quiet thus far
best regards,
Julian
On Wed, 5 Jul 2023, 09:40 Andrew Pinski, wrote:
> On Tue, Jul 4, 2023 at 6:32 PM Julian Waters
> wrote:
> >
> > Hi Andrew, thanks for the
在 2023/7/5 09:40, Andrew Pinski via Gcc 写道:
It is wrong to use noreturn on a function other than one which has a
return type of void as documented.
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-noreturn-function-attribute
:
```
It does not make sense for a noreturn
On Tue, Jul 4, 2023 at 6:32 PM Julian Waters wrote:
>
> Hi Andrew, thanks for the quick response,
>
> What if the method has a return value? I know it sounds counterintuitive, but
> in some places HotSpot relies on the noreturn attribute being applied to
> methods that do return a value in an
Hi Andrew, thanks for the quick response,
What if the method has a return value? I know it sounds counterintuitive,
but in some places HotSpot relies on the noreturn attribute being applied
to methods that do return a value in an unreachable code path. Does the
unreachable builtin cover that case
On Tue, Jul 4, 2023 at 5:54 PM Julian Waters via Gcc wrote:
>
> Hi all,
>
> Currently to disable the warning that a noreturn method does return, it's
> required to disable warnings entirely. This can be very inconvenient when
> -Werror is enabled with a noreturn method that isn't specifically
Hi all,
Currently to disable the warning that a noreturn method does return, it's
required to disable warnings entirely. This can be very inconvenient when
-Werror is enabled with a noreturn method that isn't specifically calling
something like std::abort() at the end, when one wants all other
13 matches
Mail list logo
