google branch breakage

2013-10-01 Thread Oleg Smolsky
Hey all, hey Paul, it looks like the code branches/google/gcc-4_8 does not compile any more: ../../../../../gcc48-google/libstdc++-v3/src/c++11/snprintf_lite.cc: In function 'int __gnu_cxx::__concat_size_t(char*, std::size_t, std::size_t)':

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 8:00 AM, Oleg Smolsky oleg.smol...@riverbed.com wrote: Hey all, hey Paul, it looks like the code branches/google/gcc-4_8 does not compile any more: It sure does still build for us. I've attached the fill log. How was this GCC configured? As a guess, it may be due to

Re: google branch breakage

2013-10-01 Thread Jonathan Wakely
On 1 October 2013 16:49, Paul Pluzhnikov wrote: Paolo, does attached patch look correct for trunk? There would need to be a corresponding _GLIBCXX_END_NAMESPACE_VERSION.

Re: google branch breakage

2013-10-01 Thread Jonathan Wakely
On 1 October 2013 16:49, Paul Pluzhnikov wrote: The same problem likely exists on trunk, so please do tell how to configure GCC in order to reproduce it. The std::__7 namespace implies --enable-symvers=gnu-versioned-namespace'

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 8:56 AM, Jonathan Wakely jwakely@gmail.com wrote: On 1 October 2013 16:49, Paul Pluzhnikov wrote: The same problem likely exists on trunk, so please do tell how to configure GCC in order to reproduce it. The std::__7 namespace implies

Re: google branch breakage

2013-10-01 Thread Oleg Smolsky
On 2013-10-01 08:49, Paul Pluzhnikov wrote: I've attached the fill log. How was this GCC configured? Hey Paul, thanks for the quick reply. Here is how the final compiler is configured (it's an intel-to-intel sysroot'd cross-compiler): ../gcc48-google/configure \ --prefix=%{PREFIX}

Re: google branch breakage

2013-10-01 Thread Oleg Smolsky
On 2013-10-01 09:00, Paul Pluzhnikov wrote: I'll test trunk breakage with --enable-symvers above, and then attached patch should fix it. libstdc++-v3/ChangeLog: 2013-10-01 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/snprintf_lite.cc: Add missing

Re: google branch breakage

2013-10-01 Thread Paolo Carlini
Hi, Jonathan Wakely jwakely@gmail.com ha scritto: On 1 October 2013 16:49, Paul Pluzhnikov wrote: Paolo, does attached patch look correct for trunk? There would need to be a corresponding _GLIBCXX_END_NAMESPACE_VERSION. Indeed. Otherwise, if the patch passes testing (in the various

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 9:12 AM, Oleg Smolsky oleg.smol...@riverbed.com wrote: On 2013-10-01 09:00, Paul Pluzhnikov wrote: 2013-10-01 Paul Pluzhnikov ppluzhni...@google.com * src/c++11/snprintf_lite.cc: Add missing _GLIBCXX_{BEGIN,END}_NAMESPACE_VERSION Thanks. This patch address

Re: google branch breakage

2013-10-01 Thread Paul Pluzhnikov
On Tue, Oct 1, 2013 at 9:16 AM, Paul Pluzhnikov ppluzhni...@google.com wrote: Thanks. I've also confirmed that trunk is similarly broken with --enable-symvers=gnu-versioned-namespace, and that the patch fixes that. Would you like me to build the whole compiler package as well as a test