Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 2:35 PM Uecker, Martin wrote: > > Am Mittwoch, den 02.10.2019, 14:18 +0200 schrieb Richard Biener: > > On Wed, Oct 2, 2019 at 1:57 PM Uecker, Martin > > wrote: > > > > > Thank you for your answers. > > > > Finally, how does LTO does it? It somehow also needs to unify > > >

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Uecker, Martin
Am Mittwoch, den 02.10.2019, 12:47 +0200 schrieb Richard Biener: > On Wed, Oct 2, 2019 at 12:46 PM Richard Biener > wrote: > > > > On Tue, Oct 1, 2019 at 7:49 PM Uecker, Martin > > wrote: ... > > > > > > In particular, the idea is to make structs (+ unions, enums) > > > with the same tag and

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On Tue, Oct 1, 2019 at 7:49 PM Uecker, Martin wrote: > > > > Hi, > > I have a proposal for making changes to the rules for > compatibility of tagged types in C2X (N2366). This was > received with interest by WG14, so there is a chance > that this could get accepted into C2X. > > In particular,

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 12:46 PM Richard Biener wrote: > > On Tue, Oct 1, 2019 at 7:49 PM Uecker, Martin > wrote: > > > > > > > > Hi, > > > > I have a proposal for making changes to the rules for > > compatibility of tagged types in C2X (N2366). This was > > received with interest by WG14, so

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 1:57 PM Uecker, Martin wrote: > > Am Mittwoch, den 02.10.2019, 12:47 +0200 schrieb Richard Biener: > > On Wed, Oct 2, 2019 at 12:46 PM Richard Biener > > wrote: > > > > > > On Tue, Oct 1, 2019 at 7:49 PM Uecker, Martin > > > wrote: > > ... > > > > > > > > In particular,

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 3:10 PM Richard Biener wrote: > > On Wed, Oct 2, 2019 at 2:35 PM Uecker, Martin > wrote: > > > > Am Mittwoch, den 02.10.2019, 14:18 +0200 schrieb Richard Biener: > > > On Wed, Oct 2, 2019 at 1:57 PM Uecker, Martin > > > wrote: > > > > > > > > Thank you for your answers. >

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Uecker, Martin
Am Mittwoch, den 02.10.2019, 14:18 +0200 schrieb Richard Biener: > On Wed, Oct 2, 2019 at 1:57 PM Uecker, Martin > wrote: > > Thank you for your answers. > > Finally, how does LTO does it? It somehow also needs to unify > > different tagged types? Could we reuse this mechanism somehow? > >

Re: syncing the GCC vax port, atomic issue

2019-10-02 Thread Richard Earnshaw (lists)
On 01/10/2019 20:43, Jeff Law wrote: On 9/20/19 7:18 PM, co...@sdf.org wrote: On Fri, Sep 20, 2019 at 10:07:59PM +, co...@sdf.org wrote: Introducing the reversed jbb* patterns doesn't seem to help with the original issue. It crashes building libatomic. My loose understanding of what is

Re: Modifying types during optimization

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 1:43 AM Gary Oblock wrote: > > I'm working on structure reorganization optimizations and one of the > things that needs to happen is that pointers to arrays of structures > need to be modified into either being an integer of a structure depending > on which optimization is

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Uecker, Martin
Am Mittwoch, den 02.10.2019, 15:12 +0200 schrieb Richard Biener: > On Wed, Oct 2, 2019 at 3:10 PM Richard Biener > wrote: > > > > On Wed, Oct 2, 2019 at 2:35 PM Uecker, Martin > > wrote: > > > > > > Am Mittwoch, den 02.10.2019, 14:18 +0200 schrieb Richard Biener: > > > > On Wed, Oct 2, 2019 at

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Richard Biener
On October 2, 2019 3:55:43 PM GMT+02:00, "Uecker, Martin" wrote: >Am Mittwoch, den 02.10.2019, 15:12 +0200 schrieb Richard Biener: >> On Wed, Oct 2, 2019 at 3:10 PM Richard Biener >> wrote: >> > >> > On Wed, Oct 2, 2019 at 2:35 PM Uecker, Martin >> > wrote: >> > > >> > > Am Mittwoch, den

Re: compatibility of structs/unions/enums in the middle end

2019-10-02 Thread Uecker, Martin
Am Mittwoch, den 02.10.2019, 17:37 +0200 schrieb Richard Biener: > On October 2, 2019 3:55:43 PM GMT+02:00, "Uecker, Martin" > > wrote: > > Am Mittwoch, den 02.10.2019, 15:12 +0200 schrieb Richard Biener: > > > On Wed, Oct 2, 2019 at 3:10 PM Richard Biener > > > wrote: > > > > ... > > > Oh,

Re: syncing the GCC vax port, atomic issue

2019-10-02 Thread Segher Boessenkool
On Wed, Oct 02, 2019 at 10:39:23AM +0100, Richard Earnshaw (lists) wrote: > There are some target hooks in combine that might help here. > targetm.cannot_copy_insn_p and targetm.legitimate_combined_insn. The > former is used more widely than just combine, so you might need to be > careful that

Re: Adding -Wshadow=local to gcc build rules

2019-10-02 Thread Bernd Edlinger
On 9/18/19 3:08 PM, Bernd Edlinger wrote: > Hi, > > I'm currently trying to add -Wshadow=local to the gcc build rules. > I started with -Wshadow, but gave up that idea immediately. > > As you could expect the current code base has plenty of shadowed > local variables. Most are trivial to

[Bug other/91879] --with-build-time-tools doesn't work as expected

2019-10-02 Thread stsp at users dot sourceforge.net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91879 Stas Sergeev changed: What|Removed |Added Status|RESOLVED|NEW Resolution|INVALID

[Bug libstdc++/81091] libstdc++ not built with large file support

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81091 --- Comment #3 from Jonathan Wakely --- (In reply to Richard Biener from comment #0) > libstdc++ seems to lack AC_SYS_LARGEFILE in configury and thus uses > fopen/open > in fstream and friends that can fail not only because of large files but >

[Bug libstdc++/81091] libstdc++ not built with large file support

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81091 Jonathan Wakely changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug target/88630] Incorrect float negating together with convertion to int on ST-40

2019-10-02 Thread zavadovsky.yan at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88630 --- Comment #11 from Zavadovsky Yan --- >We can set it as a default behavior for all FPU-capable SH4 variants, >but that will pessimize it for everything. >The other option is to enable this only for your specific CPU (ST-40), >which would

[Bug libstdc++/91947] std::filesystem::file_size will return wrong value on 32bit platforms with large files support

2019-10-02 Thread fregloin at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91947 --- Comment #3 from Fregl --- In out product we use 32 bit toolchain, but work with large files. So there is only solution to use direct stat call insted fs::file_size? It seems this is firm limitation.

Re: Fix MIPS call-clobbered-*.c tests

2019-10-02 Thread Jeff Law
On 10/2/19 5:47 AM, Richard Sandiford wrote: > Jeff pointed out that gcc.target/mips/call-clobbered-4.c started > failing after the function-abi series. This is because IRA used > to treat partly call-clobbered registers as hard conflicts and > so wouldn't consider them for -fcaller-saves. Now

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-02 Thread Richard Biener
On Wed, Oct 2, 2019 at 10:39 AM Kugan Vivekanandarajah wrote: > > Hi, > > As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for > passing assembler options specified with -Wa, to the link-time driver. > > The proposed solution only works for uniform -Wa options across all > TUs. As

Re: [patch] range-ops contribution

2019-10-02 Thread Richard Biener
On Tue, Oct 1, 2019 at 8:07 PM Jeff Law wrote: > > On 10/1/19 11:11 AM, Aldy Hernandez wrote: > > Hi folks. > > > > Here is my official submission of the range-ops part of the ranger to > > mainline. > > > > I realize that I could have split this patch up into 2-3 separate ones, > > but I don't

[Bug c++/91222] [10 Regression] 507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571

2019-10-02 Thread ktkachov at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222 --- Comment #26 from ktkachov at gcc dot gnu.org --- (In reply to Jan Hubicka from comment #25) > > --- Comment #24 from ktkachov at gcc dot gnu.org --- > > Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on > > aarch64 > >

Re: [C++ PATCH] PR c++/91369 - Implement P0784R7: constexpr new

2019-10-02 Thread Jakub Jelinek
Hi! Thanks for the review, let me start with the unrelated bugfixes then and deal with the rest later. On Tue, Oct 01, 2019 at 05:56:00PM -0400, Jason Merrill wrote: > > @@ -3905,7 +4033,7 @@ cxx_eval_store_expression (const constex > > bool no_zero_init = true; > > releasing_vec ctors;

Re: [patch] range-ops contribution

2019-10-02 Thread Aldy Hernandez
On 10/2/19 8:19 AM, Andrew MacLeod wrote: On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range.  */ + +void +value_range_base::invert () +{ +  if (undefined_p ()) +    return; +  if (varying_p ()) +    set_undefined (); +  else if (m_kind == VR_RANGE) +    m_kind =

[Bug c++/91222] [10 Regression] 507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571

2019-10-02 Thread hubicka at ucw dot cz
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222 --- Comment #28 from Jan Hubicka --- > Thanks! That fixes the benchmark build (and the rest of SPEC builds fine with > -flto). It also bootstraps and tests on aarch64-none-linux-gnu fine. Thanks! My testing concluded independently so I went

[OG9] Comitted backport of: [Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Tobias Burnus
Simply committing that patch to the GCC's git OG9 branch as 32568a014c678e09a251dd3c5f64618779f036f5 Tobias

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread edlinger at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #6 from Bernd Edlinger --- (In reply to Jörg Richter from comment #5) > There needs to be at least a way to suppress the warning with a cast > or some other construct (not pragma). That is simple: if ( C != A ) ...

[Bug c++/91606] [9 regression] Optimization leads to invalid code

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91606 Richard Biener changed: What|Removed |Added Known to work||10.0 Summary|[9/10

Re: [patch] range-ops contribution

2019-10-02 Thread Andrew MacLeod
On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range. */ + +void +value_range_base::invert () +{ + if (undefined_p ()) +return; + if (varying_p ()) +set_undefined (); + else if (m_kind == VR_RANGE) +m_kind = VR_ANTI_RANGE; + else if (m_kind ==

Fix another -Wodr ICE

2019-10-02 Thread Jan Hubicka
Hi, this patch finally makes cactusBSSN working. The logic which was supposed to get anonymous namespace type first (if it exists) was wrong as was caught by a subsetquent assert. Bootstrapped/regtested x86_64-linux, comitted. Honza Index: ChangeLog

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread joerg.rich...@pdv-fs.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #7 from Jörg Richter --- Yes, I changed our code already to if( C != Enum() ) But I still think that an explicit cast should always silence this warning.

[Bug other/91879] --with-build-sysroot doesn't work as expected

2019-10-02 Thread stsp at users dot sourceforge.net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91879 --- Comment #16 from Stas Sergeev --- (In reply to Jonathan Wakely from comment #15) > For the record, this has moved to > https://gcc.gnu.org/ml/gcc-help/2019-10/msg2.html Thanks, I also would like to apologize to Joseph for not following

Re: -O2 inliner returning 1/n: reduce EARLY_INLINING_INSNS for O1 and O2

2019-10-02 Thread Jan Hubicka
> On Tue, Oct 01, 2019 at 07:04:53PM +0200, Jan Hubicka wrote: > > * gcc.dg/tree-ssa/ssa-thread-12.c: Mark compure_idf inline. > > > --- testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (revision 276272) > > +++ testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (working copy) > > @@ -56,7 +56,7

[Bug c++/91606] [9 regression] Optimization leads to invalid code

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91606 --- Comment #12 from Richard Biener --- Author: rguenth Date: Wed Oct 2 10:54:10 2019 New Revision: 276448 URL: https://gcc.gnu.org/viewcvs?rev=276448=gcc=rev Log: 2019-10-02 Richard Biener PR c++/91606 * decl.c

[Bug libstdc++/81091] libstdc++ not built with large file support

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81091 --- Comment #4 from Richard Biener --- (In reply to Jonathan Wakely from comment #3) > (In reply to Richard Biener from comment #0) > > libstdc++ seems to lack AC_SYS_LARGEFILE in configury and thus uses > > fopen/open > > in fstream and friends

[PATCH] Split out stmt transform from vectorizable_reduction

2019-10-02 Thread Richard Biener
I've done only "trivial" pruning of unnecessary code to reduce the chance of functional changes. Cleanup will happen as followup. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-02 Richard Biener * tree-vectorizer.h (vect_transform_reduction):

Fix MIPS call-clobbered-*.c tests

2019-10-02 Thread Richard Sandiford
Jeff pointed out that gcc.target/mips/call-clobbered-4.c started failing after the function-abi series. This is because IRA used to treat partly call-clobbered registers as hard conflicts and so wouldn't consider them for -fcaller-saves. Now that we treat call clobbers the same way regardless of

[Bug libstdc++/91947] std::filesystem::file_size will return wrong value on 32bit platforms with large files support

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91947 --- Comment #5 from Jonathan Wakely --- (In reply to Jonathan Wakely from comment #1) > Huh, I thought I'd already fixed this a while ago. I was thinking of Bug 85632 which is different.

[Bug libstdc++/91947] std::filesystem::file_size will return wrong value on 32bit platforms with large files support

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91947 --- Comment #4 from Jonathan Wakely --- (In reply to Fregl from comment #3) > It seems this is firm limitation. It's a bug, you just have to wait for it to be fixed.

[Bug tree-optimization/91965] New: missing simplification for (C - a) << N

2019-10-02 Thread amonakov at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91965 Bug ID: 91965 Summary: missing simplification for (C - a) << N Product: gcc Version: 9.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: normal

[Bug c++/91222] [10 Regression] 507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571

2019-10-02 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222 --- Comment #27 from Jan Hubicka --- Author: hubicka Date: Wed Oct 2 12:41:36 2019 New Revision: 276454 URL: https://gcc.gnu.org/viewcvs?rev=276454=gcc=rev Log: PR c++/91222 * ipa-devirt.c (warn_types_mismatch): Fix conditional

Re: [01/32] Add function_abi.{h,cc}

2019-10-02 Thread Richard Sandiford
Bernd Edlinger writes: > Hi, > > I am currently trying to implement -Wshadow=local, and > this patch triggers a build-failure with -Wshadow=local > since i is a parameter that is the regno. > But it is also used as loop variable, > so I think this introduces probably a bug: > >> @@ -728,7 +731,11

[Bug fortran/91716] [9 Regression] ICE in output_constant, at varasm.c:5026

2019-10-02 Thread edlinger at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91716 --- Comment #8 from Bernd Edlinger --- Author: edlinger Date: Wed Oct 2 13:22:37 2019 New Revision: 276458 URL: https://gcc.gnu.org/viewcvs?rev=276458=gcc=rev Log: 2019-10-02 Bernd Edlinger Backport from mainline

Re: -O2 inliner returning 1/n: reduce EARLY_INLINING_INSNS for O1 and O2

2019-10-02 Thread Jakub Jelinek
On Tue, Oct 01, 2019 at 07:04:53PM +0200, Jan Hubicka wrote: > * gcc.dg/tree-ssa/ssa-thread-12.c: Mark compure_idf inline. > --- testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (revision 276272) > +++ testsuite/gcc.dg/tree-ssa/ssa-thread-12.c (working copy) > @@ -56,7 +56,7 @@ bmp_iter_and_compl

Re: [PATCH] Fix PR91606

2019-10-02 Thread Nathan Sidwell
On 10/2/19 6:07 AM, Richard Biener wrote: A middle-end change exposed that the C++ FE handling of pointer-to-member aggregates in cxx_get_alias_set isn't effective. The following patch makes it so by design by marking the structure members as not being aliased (there can be no pointers like

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread joerg.rich...@pdv-fs.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #5 from Jörg Richter --- There needs to be at least a way to suppress the warning with a cast or some other construct (not pragma).

[Bug target/91927] -mstrict-align doesn't prevent unaligned accesses at -O2 and -O3 on AARCH64 targets

2019-10-02 Thread gr.audio at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91927 --- Comment #5 from Guillaume --- I think I found a work-around for the time being. If you define your packed structs with the 'volatile' qualifier, the bug doesn't seem to show up. May not be completely ideal, but it appears to work, and the

[Bug c++/91606] [9/10 regression] Optimization leads to invalid code

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91606 Richard Biener changed: What|Removed |Added CC||jason at gcc dot gnu.org --- Comment

[Bug middle-end/91957] [10 Regression] ICE in lra_assign building libgcc for csky-linux-gnuabiv2 soft-float

2019-10-02 Thread rsandifo at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91957 --- Comment #3 from rsandifo at gcc dot gnu.org --- Author: rsandifo Date: Wed Oct 2 07:37:10 2019 New Revision: 276440 URL: https://gcc.gnu.org/viewcvs?rev=276440=gcc=rev Log: [LRA] Don't make eliminable registers live (PR91957) One effect

[Bug fortran/91963] Logical function does not simplify

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91963 Richard Biener changed: What|Removed |Added Keywords||rejects-valid --- Comment #1 from

Re: [PATCH] Add some hash_map_safe_* functions like vec_safe_*.

2019-10-02 Thread Richard Biener
On Tue, Oct 1, 2019 at 8:50 PM Jason Merrill wrote: > > On 10/1/19 3:34 AM, Richard Biener wrote: > > On Mon, Sep 30, 2019 at 8:33 PM Jason Merrill wrote: > >> > >> My comments accidentally got lost. > >> > >> Several places in the front-end (and elsewhere) use the same lazy > >> allocation

[Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Tobias Burnus
Simple patch – large effect. Currently, gfortran prints for any parsing issue in !$omp (-fopenmp) and likewise for !$acc (-fopenacc) just:     8 | !$omp target data  map(to:a) is_device_ptr(a)   |  1 Error: Unclassifiable OpenMP directive at (1) This patch adds a new error message –

[Patch, Fortran, OpenMP] Support OpenMP 5.0's use_device_addr

2019-10-02 Thread Tobias Burnus
This patch adds the first OpenMP 5 feature to gfortran – which is trivial as it justs adds some parsing, the heavy lifting is already done in the middle end. (Minus bugs.) Additionally, I add a check for "is_device_ptr" – which is explicitly is specified in the OpenMP 4.5/5.0 spec. (i.e.

[Bug tree-optimization/91940] __builtin_bswap16 loop optimization

2019-10-02 Thread glisse at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91940 --- Comment #7 from Marc Glisse --- (In reply to Jakub Jelinek from comment #1) > The loop with the rotate is vectorized, while the one with __builtin_bswap16 > is not. It is a bit surprising that we do not canonicalize one to the other

Re: [SVE] PR91532

2019-10-02 Thread Richard Biener
On Tue, 1 Oct 2019, Jeff Law wrote: > On 10/1/19 12:40 AM, Richard Biener wrote: > > On Mon, 30 Sep 2019, Prathamesh Kulkarni wrote: > > > >> On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > >>> > >>> On Wed, 25 Sep 2019, Prathamesh Kulkarni wrote: > >>> > On Fri, 20 Sep 2019 at

[Bug c/91951] goto + mixed declarations + cleanup attribute considered harmful

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91951 Richard Biener changed: What|Removed |Added Keywords||diagnostic

Re: [PATCH, Fortran] Optionally suppress no-automatic overwrites recursive warning - for approval

2019-10-02 Thread Mark Eggleston
On 28/09/2019 17:50, Steve Kargl wrote: On Thu, Sep 26, 2019 at 09:45:28AM +0100, Mark Eggleston wrote: Original thread starts here https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01185.html OK to commit? I'm not a big fan of option proliferation. If you don't want to see warns just use -w.

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #1 from Jonathan Wakely --- (In reply to Jörg Richter from comment #0) > I think all warnings are wrong because nowhere is a enum constant in a > boolean context. The warning is documented as diagnosing "using non-boolean integer

[Bug fortran/91963] Logical function does not simplify

2019-10-02 Thread tkoenig at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91963 --- Comment #2 from Thomas Koenig --- (In reply to Richard Biener from comment #1) > But is it valid fortran? I had to check, but yes. LOGICAL is an elemental type conversion function, which has only constant arguments, so it should be

[Bug c++/91964] New: Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread joerg.rich...@pdv-fs.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 Bug ID: 91964 Summary: Wrong -Wint-in-bool-context warning for enum constant Product: gcc Version: 8.3.0 Status: UNCONFIRMED Severity: normal Priority: P3

[Bug bootstrap/91949] [10 Regression] bootstrap failure on arm-linux-gnueabihf and s390x-linux-gnu (cannot convert 'bool' to 'const predefined_function_abi*')

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91949 Richard Biener changed: What|Removed |Added Target Milestone|--- |10.0

[Bug c++/91222] [10 Regression] 507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571

2019-10-02 Thread ktkachov at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222 --- Comment #24 from ktkachov at gcc dot gnu.org --- Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on aarch64 with -flto in the same place: 995 gcc_assert (TYPE_NAME (t1) 996 && TREE_CODE (TYPE_NAME

[PATCH] Split out PHI transform from vectorizable_reduction

2019-10-02 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-10-02 Richard Biener * tree-vectorizer.h (stmt_vec_info_type::cycle_phi_info_type): New. (vect_transform_cycle_phi): Declare. * tree-vect-stmts.c (vect_transform_stmt): Call

[Bug fortran/91963] New: Logical function does not simplify

2019-10-02 Thread tkoenig at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91963 Bug ID: 91963 Summary: Logical function does not simplify Product: gcc Version: 10.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: fortran

[Bug lto/91393] [10 Regression] lto1: internal compiler error: decompressed stream: Destination buffer is too small

2019-10-02 Thread dcb314 at hotmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91393 --- Comment #10 from David Binderman --- (In reply to Martin Liška from comment #9) > I've got a patch candidate for it. Ping Martin. Anything happened with that patch ?

[Bug ipa/91956] [10 Regression] ICE: verify_cgraph_node failed (error: comdat-local function called by __ct .isra outside its comdat)

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91956 Richard Biener changed: What|Removed |Added CC||jamborm at gcc dot gnu.org Target

[Bug middle-end/91957] [10 Regression] ICE in lra_assign building libgcc for csky-linux-gnuabiv2 soft-float

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91957 Richard Biener changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug other/91879] --with-build-sysroot doesn't work as expected

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91879 --- Comment #15 from Jonathan Wakely --- For the record, this has moved to https://gcc.gnu.org/ml/gcc-help/2019-10/msg2.html

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 Jonathan Wakely changed: What|Removed |Added CC||edlinger at gcc dot gnu.org ---

Re: [Patch][omp-low.c,fortran] Simple fix for optional argument handling with OpenMP's use_device_ptr

2019-10-02 Thread Jakub Jelinek
On Tue, Oct 01, 2019 at 04:19:11PM +0200, Tobias Burnus wrote: > OK for the trunk? Ok, with a small formatting nit below. > --- a/gcc/fortran/trans-openmp.c > +++ b/gcc/fortran/trans-openmp.c > @@ -47,6 +47,15 @@ along with GCC; see the file COPYING3. If not see > > int ompws_flags; > >

[PATCH] Fix PR91606

2019-10-02 Thread Richard Biener
A middle-end change exposed that the C++ FE handling of pointer-to-member aggregates in cxx_get_alias_set isn't effective. The following patch makes it so by design by marking the structure members as not being aliased (there can be no pointers like __pfn or __delta) thus making them behave

[PATCH] Fix build with GCC 4.3

2019-10-02 Thread Richard Biener
Which complains libcpp/internal.h:129: error: comma at end of enumerator list Committed as obvious. Richard. Index: libcpp/internal.h === --- libcpp/internal.h (revision 276439) +++ libcpp/internal.h (working copy) @@ -126,7

[Bug tree-optimization/91940] __builtin_bswap16 loop optimization

2019-10-02 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91940 --- Comment #6 from Jakub Jelinek --- Author: jakub Date: Wed Oct 2 10:18:50 2019 New Revision: 276442 URL: https://gcc.gnu.org/viewcvs?rev=276442=gcc=rev Log: PR tree-optimization/91940 * tree-vect-patterns.c: Include

Re: [patch, libgomp] testsuite remove alloca header

2019-10-02 Thread Thomas Schwinge
Hi! On 2019-09-30T15:22:52+0200, Jakub Jelinek wrote: > On Mon, Sep 30, 2019 at 03:16:00PM +0200, Andreas Tobler wrote: >> here on FreeBSD we lack the alloca.h header so two test cases fail to >> compile. >> >> Do the same as I did six years ago for another test case: 'Remove alloca.h >> and

Re: [SVE] PR91532

2019-10-02 Thread Richard Biener
On Wed, 2 Oct 2019, Prathamesh Kulkarni wrote: > On Wed, 2 Oct 2019 at 01:08, Jeff Law wrote: > > > > On 10/1/19 12:40 AM, Richard Biener wrote: > > > On Mon, 30 Sep 2019, Prathamesh Kulkarni wrote: > > > > > >> On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > > >>> > > >>> On Wed, 25 Sep

[Bug c/91952] [rfe] __attribute__((__default_value__()))

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91952 Richard Biener changed: What|Removed |Added Status|UNCONFIRMED |WAITING Last reconfirmed|

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread joerg.rich...@pdv-fs.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #2 from Jörg Richter --- The only boolean context I see is the if(...). The if() is never used with enum constants/types, but only bool-s and int-s. So according to the warning name (int-in-bool-context) the warning can be expected

[Bug c++/91222] [10 Regression] 507.cactuBSSN_r build fails in warn_types_mismatch at ipa-devirt.c:1006 since r273571

2019-10-02 Thread hubicka at ucw dot cz
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91222 --- Comment #25 from Jan Hubicka --- > --- Comment #24 from ktkachov at gcc dot gnu.org --- > Thanks. Unfortunately I still see the ICE building 507.cactuBSSN_r on aarch64 > with -flto in the same place: > 995 gcc_assert (TYPE_NAME (t1) >

Re: [Patch][Fortran] Vastly improve error message during parsing – simple patch for OpenMP/OpenACC directives

2019-10-02 Thread Jakub Jelinek
Hi! Nice! On Wed, Oct 02, 2019 at 11:24:46AM +0200, Tobias Burnus wrote: > gcc/fortran/ > * openmp.c (gfc_match_omp_clauses): Show a clause-parsing > error if none was rised before. > * parse.c (matcha, matcho): If error occurred after > OpenMP/OpenACC directive

Re: [Patch, Fortran, OpenMP] Support OpenMP 5.0's use_device_addr

2019-10-02 Thread Jakub Jelinek
On Wed, Oct 02, 2019 at 11:59:46AM +0200, Tobias Burnus wrote: > This patch adds the first OpenMP 5 feature to gfortran – which is trivial as > it justs adds some parsing, the heavy lifting is already done in the middle > end. (Minus bugs.) > > Additionally, I add a check for "is_device_ptr" –

[Bug c++/91606] [9/10 regression] Optimization leads to invalid code

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91606 Richard Biener changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|unassigned

[Bug tree-optimization/91954] gcc.dg/vect/pr66142.c should not need early inlining to be vectorized

2019-10-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91954 Richard Biener changed: What|Removed |Added CC||rguenth at gcc dot gnu.org --- Comment

[PR47785] COLLECT_AS_OPTIONS

2019-10-02 Thread Kugan Vivekanandarajah
Hi, As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for passing assembler options specified with -Wa, to the link-time driver. The proposed solution only works for uniform -Wa options across all TUs. As mentioned by Richard Biener, supporting non-uniform -Wa flags would require

Re: [RFC][Fortran,patch] %C error diagnostic location

2019-10-02 Thread Tobias Burnus
Hi all, I looked at error messages – and I like it. – Please review. There is actually a "fallout": One testsuite case actually checks for the row location – I didn't even know that one can do it that way. That's fixed by the attached patch (I also included the original patch). OK for the

[PATCH] Allow vectorization of __builtin_bswap16 (PR tree-optimization/91940)

2019-10-02 Thread Jakub Jelinek
On Wed, Nov 09, 2016 at 09:14:55AM +0100, Richard Biener wrote: > The following implements vectorization of bswap via VEC_PERM_EXPR > on the corresponding QImode vector. > > ARM already has backend handling via the builtin_vectorized_call > hook and thus there were already testcases available.

[Bug c++/91964] Wrong -Wint-in-bool-context warning for enum constant

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91964 --- Comment #4 from Jonathan Wakely --- The warning was introduced for PR 77434 and the current behaviour by the fix for PR 77700.

Re: [PATCH] Allow vectorization of __builtin_bswap16 (PR tree-optimization/91940)

2019-10-02 Thread Richard Biener
On Wed, 2 Oct 2019, Jakub Jelinek wrote: > On Wed, Nov 09, 2016 at 09:14:55AM +0100, Richard Biener wrote: > > The following implements vectorization of bswap via VEC_PERM_EXPR > > on the corresponding QImode vector. > > > > ARM already has backend handling via the builtin_vectorized_call > >

[Bug libstdc++/91947] std::filesystem::file_size will return wrong value on 32bit platforms with large files support

2019-10-02 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91947 Jonathan Wakely changed: What|Removed |Added Depends on||81091 --- Comment #2 from Jonathan

Re: [patch] Extend GIMPLE store merging to throwing stores

2019-10-02 Thread Eric Botcazou
> that works for me - the patch is OK with that change. Thanks. In the end, I went for your solution and the helper is called unsplit_eh_edges, which is even more explicit than unsplit_all_eh. * tree-eh.h (unsplit_eh_edges): Declare. * tree-eh.c

[Bug fortran/91963] Logical function does not simplify

2019-10-02 Thread kargl at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91963 kargl at gcc dot gnu.org changed: What|Removed |Added CC||kargl at gcc dot gnu.org ---

Re: [patch] range-ops contribution

2019-10-02 Thread Andrew MacLeod
On 10/2/19 9:36 AM, Richard Sandiford wrote: Andrew MacLeod writes: On 10/2/19 6:52 AM, Richard Biener wrote: + +/* Return the inverse of a range. */ + +void +value_range_base::invert () +{ + if (undefined_p ()) +return; + if (varying_p ()) +set_undefined (); + else if (m_kind ==

[Bug target/88630] Incorrect float negating together with convertion to int on ST-40

2019-10-02 Thread olegendo at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88630 Oleg Endo changed: What|Removed |Added Attachment #46987|0 |1 is obsolete|

[Bug rtl-optimization/87047] [7/8/9 Regression] performance regression because of if-conversion

2019-10-02 Thread amonakov at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87047 Alexander Monakov changed: What|Removed |Added Summary|[7/8/9/10 Regression] |[7/8/9 Regression]

Re: [IRA] Handle fully-tied destinations in a similar way to earlyclobbers

2019-10-02 Thread Vladimir Makarov
On 2019-09-30 10:40 a.m., Richard Sandiford wrote: IRA's make_early_clobber_and_input_conflicts checks for cases in which an output operand is likely to be an earlyclobber and an input operand is unlikely to be tieable with it. If so, the allocno for the output conflicts with the allocno for

[Bug c++/91966] New: pack expansion for Cartesian product breaks if certain indirections are involved

2019-10-02 Thread ecrypa at posteo dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91966 Bug ID: 91966 Summary: pack expansion for Cartesian product breaks if certain indirections are involved Product: gcc Version: unknown Status: UNCONFIRMED

[Bug c++/91967] New: gtest from google generates incorrect assembly code on x86 solaris

2019-10-02 Thread bobw at cristie dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91967 Bug ID: 91967 Summary: gtest from google generates incorrect assembly code on x86 solaris Product: gcc Version: 9.2.0 Status: UNCONFIRMED Severity: normal

[PR testsuite/91842] Skip gcc.dg/ipa/ipa-sra-19.c on power

2019-10-02 Thread Martin Jambor
Hi, I seem to remember I minimized gcc.dg/ipa/ipa-sra-19.c on power but perhaps I am wrong because the testcase fails there with a power-specific error: gcc.dg/ipa/ipa-sra-19.c:19:3: error: AltiVec argument passed to unprototyped function I am going to simply skip it there with the following

-O2 inline retuning 2/n: enable -finline-functions for O2

2019-10-02 Thread Jan Hubicka
Hi, this patch enables -finline-functions at -O2 and trottles it down by means of new parameters --param max-inline-insns-auto-O2 (set to 15 instead 30) --param max-inline-insns-single-O2 (set to 30 instead 200) --param inline-min-speedup-O2 (set to 30 instead 15) Overall effect of both

[Bug fortran/65438] Unnecessary ptr check

2019-10-02 Thread tschwinge at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65438 Thomas Schwinge changed: What|Removed |Added Status|WAITING |ASSIGNED Assignee|cesar at

  1   2   3   >