Re: [PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2016-01-05 Thread Chung-Lin Tang
Patch has been updated to accommodate the gomp_fini_device() removal changes. And ping. On 2015/12/14 11:47 PM, Chung-Lin Tang wrote: > [sorry, forgot to C gcc-patches in last send] > > Hi Jakub, > these patches are a revision of > https://gcc.gnu.org/ml/gcc-patches/2015-0

[PATCH] OpenACC use_device clause ICE fix

2016-01-05 Thread Chung-Lin Tang
Hi, we've been encountering an ICE for OpenACC host_data sections, which has a use_device() clause similar to OpenMP use_device_ptr. The ICE happens in make_decl_rtl() for scan-created variables, which IIUC, should not be entered at all for automatic variables. I believe the problem is, unlike

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-22 Thread Chung-Lin Tang
Ping. On 2015/11/24 6:27 PM, Chung-Lin Tang wrote: > Hi, this patch reworks some of the way that asynchronous copyouts are > implemented for OpenACC in libgomp. > > Before this patch, we had a somewhat confusing way of implementing this > by having two refcounts for each ma

[PATCH 1/3, libgomp] Resolve libgomp plugin deadlock on exit, libgomp proper parts

2015-12-14 Thread Chung-Lin Tang
patch is the changes for the machine independent libgomp proper. The entire patch set was tested without regressions. Is this okay for trunk? Thanks, Chung-Lin 2015-12-14 Chung-Lin Tang <clt...@codesourcery.com> * target.c (gomp_device_copy): New function. (gomp_copy_ho

[PATCH 2/3, libgomp] Resolve libgomp plugin deadlock on exit, nvptx parts

2015-12-14 Thread Chung-Lin Tang
These are the nvptx parts. Thanks, Chung-Lin * plugin/plugin-nvptx.c (CUDA_CALL_ERET): New convenience macro. (CUDA_CALL): Likewise. (CUDA_CALL_ASSERT): Likewise. (map_init): Change return type to bool, use CUDA_CALL* macros. (map_fini): Likewise.

[PATCH 3/3, libgomp] Resolve libgomp plugin deadlock on exit, intelmic parts

2015-12-14 Thread Chung-Lin Tang
Hi Ilya, thanks for the prior review (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01893.html), This version is mostly a like the prior one, with some minor code updates. Thanks, Chung-Lin 2015-12-14 Chung-Lin Tang <clt...@codesourcery.com> * plugin/libgomp-plugin-intelm

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-05 Thread Chung-Lin Tang
On 2015/12/1 08:01 PM, Julian Brown wrote: > On Tue, 24 Nov 2015 18:27:24 +0800 > Chung-Lin Tang <clt...@codesourcery.com> wrote: > >> Hi, this patch reworks some of the way that asynchronous copyouts are >> implemented for OpenACC in libgomp. >> >> Before

Re: [PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-12-05 Thread Chung-Lin Tang
On 2015/12/3 06:32 PM, Chung-Lin Tang wrote: > On 2015/12/3 6:11 PM, Jakub Jelinek wrote: >> On Thu, Dec 03, 2015 at 06:05:36PM +0800, Chung-Lin Tang wrote: >>>> Oh wait, it looks like the C++ front end is not actually using the >>>> functions defined in the

Re: [PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-12-03 Thread Chung-Lin Tang
On 2015/12/3 6:11 PM, Jakub Jelinek wrote: > On Thu, Dec 03, 2015 at 06:05:36PM +0800, Chung-Lin Tang wrote: >>> Oh wait, it looks like the C++ front end is not actually using the >>> functions defined in the C/C++-shared gcc/c-family/c-omp.c, but has its >>>

Re: [PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-12-03 Thread Chung-Lin Tang
On 2015/12/3 4:59 PM, Thomas Schwinge wrote: > Hi! > > On Thu, 03 Dec 2015 09:51:31 +0100, I wrote: >> On Mon, 23 Nov 2015 21:15:00 +0800, Chung-Lin Tang <clt...@codesourcery.com> >> wrote: >>> The OpenACC wait directive is represented as a call to the runti

Re: [gomp4] Adjust Fortran OACC async lib test

2015-12-02 Thread Chung-Lin Tang
Ping. Hi Thomas, this is only for gomp4 ATM, okay to commit? Thanks, Chung-Lin On 2015/11/23 7:09 PM, Chung-Lin Tang wrote: > Hi Thomas, > this fix adds more acc_wait's to libgomp.oacc-fortran/lib-1[13].f90. > > For lib-12.f90, it's sort of a fix before we can resolve the issue &

Re: [PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-12-02 Thread Chung-Lin Tang
Ping. On 2015/11/23 9:15 PM, Chung-Lin Tang wrote: > The OpenACC wait directive is represented as a call to the runtime > function "GOACC_wait" instead of a tree code. I am seeing when > '#pragma acc wait' is using inside a template function, the CALL_EXPR > to GOACC_

[PATCH, libgomp] Rewire OpenACC async

2015-11-24 Thread Chung-Lin Tang
those. Tested without regressions, is this okay for trunk? Thanks, Chung-Lin 2015-11-24 Chung-Lin Tang <clt...@codesourcery.com> * oacc-plugin.h (GOMP_PLUGIN_async_unmap_vars): Add int parameter. * oacc-plugin.c (GOMP_PLUGIN_async_unmap_vars): Add 'int async' par

[gomp4] Adjust Fortran OACC async lib test

2015-11-23 Thread Chung-Lin Tang
Hi Thomas, this fix adds more acc_wait's to libgomp.oacc-fortran/lib-1[13].f90. For lib-12.f90, it's sort of a fix before we can resolve the issue of intended semantics for "wait+async". As for lib-13.f90, I believe these added acc_wait calls seem reasonable, since we can't immediately assume

[PATCH, C++] Wrap OpenACC wait in EXPR_STMT

2015-11-23 Thread Chung-Lin Tang
The OpenACC wait directive is represented as a call to the runtime function "GOACC_wait" instead of a tree code. I am seeing when '#pragma acc wait' is using inside a template function, the CALL_EXPR to GOACC_wait is being silently ignored/removed during tsubst_expr(). I think the correct way to

Re: [PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-09-29 Thread Chung-Lin Tang
On 2015/9/25 上午 04:27, Ilya Verbin wrote: > On Thu, Aug 27, 2015 at 21:44:50 +0800, Chung-Lin Tang wrote: >> We've discovered that, for several of the libgomp plugin interface routines, >> if the target specific routine calls exit() (usually upon a fatal condition), >> dead

Re: [PATCH, libgomp] PR 67141, uninitialized acc_device_lock mutex

2015-09-22 Thread Chung-Lin Tang
On 2015/9/18 04:02 PM, Jakub Jelinek wrote: > On Fri, Sep 18, 2015 at 03:41:30PM +0800, Chung-Lin Tang wrote: >> this patch fixes the uninitialized acc_device_lock mutex situation >> reported in PR 67141. The patch attached on the bugzilla page >> tries to solve it by construc

[PATCH, nios2] Fix to nios2_legitimize_address

2015-09-22 Thread Chung-Lin Tang
Nios II Linux had a bad TLS relocation generated, exposed by the test case for PR 65771. A fix for this in nios2_legitimize_address() was tested and applied. Chung-Lin 2015-09-22 Chung-Lin Tang <clt...@codesourcery.com> * config/nios2/nios2.c (nios2_legitimize_address): When ha

Re: [PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-09-22 Thread Chung-Lin Tang
Ping x2. On 2015/9/9 04:08 PM, Chung-Lin Tang wrote: > Ping. > > On 2015/8/27 09:44 PM, Chung-Lin Tang wrote: >> We've discovered that, for several of the libgomp plugin interface routines, >> if the target specific routine calls exit() (usually upon a fatal condition), &

[PATCH, libgomp] PR 67141, uninitialized acc_device_lock mutex

2015-09-18 Thread Chung-Lin Tang
goacc_runtime_initialize() instead, thereby ensuring the init order. libgomp testsuite was re-run without regressions, okay for trunk? Thanks, Chung-Lin 2015-09-18 Chung-Lin Tang <clt...@codesourcery.com> PR libgomp/67141 * oacc-int.h (goacc_host_init): Add decla

Re: [gomp4] force global locks for nvptx targets

2015-09-09 Thread Chung-Lin Tang
ks in worker reductions. We're still investigating that > issue, but for the time being, global locks appear to work albeit with a > lock contention penalty. > > I've applied this patch to gomp-4_0-branch. > > Cesar > Fixed typo, committed as obvious. Chung-Lin

Re: [PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-09-09 Thread Chung-Lin Tang
Ping. On 2015/8/27 09:44 PM, Chung-Lin Tang wrote: > We've discovered that, for several of the libgomp plugin interface routines, > if the target specific routine calls exit() (usually upon a fatal condition), > deadlock ensues. We found this using nvptx, but it's possible on intelmic a

[PATCH] Propagate -fdiagnostics-* options in lto-wrapper

2015-09-06 Thread Chung-Lin Tang
tested this patch without regressions, is this okay for trunk? Thanks, Chung-Lin 2015-09-06 Chung-Lin Tang <clt...@codesourcery.com> * lto-wrapper.c (merge_and_complain): Add OPT_fdiagnostics_show_caret, OPT_fdiagnostics_show_option, OPT_fdiagnostics_show_loc

[PATCH 1/3, libgomp] Adjust offload plugin interface for avoiding deadlock on exit

2015-08-27 Thread Chung-Lin Tang
for both accel targets, is this okay for trunk? Thanks, Chung-Lin 2015-08-27 Chung-Lin Tang clt...@codesourcery.com * oacc-host.c (host_init_device): Change return type to bool. (host_fini_device): Likewise. (host_dev2host): Likewise. (host_host2dev): Likewise

[PATCH 2/3, libgomp] nvptx plugin parts

2015-08-27 Thread Chung-Lin Tang
These are the nvptx plugin specific parts. Chung-Lin * plugin/plugin-nvptx.c (CUDA_CALL_ERET): New convenience macro. (CUDA_CALL): Likewise. (CUDA_CALL_ASSERT): Likewise. (map_init): Change return type to bool, use CUDA_CALL* macros. (map_fini): Likewise.

[PATCH 3/3, libgomp] intelmic specific parts

2015-08-27 Thread Chung-Lin Tang
These are the intelmic plugin specific parts (actually beneath liboffloadmic instead of libgomp). The changes are basically to expose the return value of offload() back to libgomp. I only checked parts of the plugin, it appears that there may still be code in the liboffloadmic runtime that can

[PATCH, nios2] Remove unused header from libgcc linux-atomic.c

2015-07-22 Thread Chung-Lin Tang
The asm/unistd.h header was used back when Nios II Linux used a syscall cmpxchg, long since removed and actually never got into the FSF trunk. Patch removes the #include, and the following error code #defines which are all no longer used. Committed. Chung-Lin 2015-07-22 Chung-Lin Tang clt

Re: [PATCH, gomp4] Propagate independent clause for OpenACC kernels pass

2015-07-14 Thread Chung-Lin Tang
On 15/7/14 3:00 PM, Jakub Jelinek wrote: On Tue, Jul 14, 2015 at 01:46:04PM +0800, Chung-Lin Tang wrote: this patch provides a 'bool independent' field in struct loop, which will be switched on by an independent clause in a #pragma acc loop directive. I assume you'll be wiring

[PATCH, gomp4] Propagate independent clause for OpenACC kernels pass

2015-07-13 Thread Chung-Lin Tang
loop, namely 'safelen' and 'can_be_parallel', used by OMP simd safelen and GRAPHITE respectively. The intention and/or setting of these fields are all a bit different, so I've decided to add a new bool for OpenACC. Tested and committed to gomp-4_0-branch. Chung-Lin 2015-07-14 Chung-Lin Tang clt

[gomp4] implicit firstprivate and other testcase fixes

2015-07-01 Thread Chung-Lin Tang
in the patch. Also a typo-bug in testcase libgomp.oacc-c-c++-common/reduction-4.c is also corrected, where reduction variable names are apparently wrong. Tested without regressions, and applied to gomp-4_0-branch. Chung-Lin 2015-07-01 Chung-Lin Tang clt...@codesourcery.com gcc

Re: [patch] fix regrename pass to ensure renamings produce valid insns

2015-06-30 Thread Chung-Lin Tang
On 2015/6/30 05:06 PM, Eric Botcazou wrote: I notice the way gcc_assert() is defined in system.h now, the test won't disappear even when runtime checks are disabled, though you might still adjust it to avoid any programmer confusion. It will disappear at run time, see the definition: /*

Re: [patch] fix regrename pass to ensure renamings produce valid insns

2015-06-29 Thread Chung-Lin Tang
On 2015/6/30 12:22 PM, Sandra Loosemore wrote: On 06/29/2015 09:07 PM, Kito Cheng wrote: Hi all: This patch seem will broken when disable assert checking for c6x Index: gcc/config/c6x/c6x.c === --- gcc/config/c6x/c6x.c

Re: [patch] fix regrename pass to ensure renamings produce valid insns

2015-06-29 Thread Chung-Lin Tang
On 2015/6/30 下午 01:13, Chung-Lin Tang wrote: On 2015/6/30 12:22 PM, Sandra Loosemore wrote: On 06/29/2015 09:07 PM, Kito Cheng wrote: Hi all: This patch seem will broken when disable assert checking for c6x Index: gcc/config/c6x/c6x.c

Re: [gomp4] Generate sequential loop for OpenACC loop directive inside kernels

2015-06-23 Thread Chung-Lin Tang
On 2015/6/16 05:05 PM, Tom de Vries wrote: On 16/06/15 10:59, Chung-Lin Tang wrote: This patch adjusts omp-low.c:expand_omp_for_generic() to expand to a sequential loop form (without the OMP runtime calls), used for loop directives inside OpenACC kernels constructs. Tom mentions

[gomp4] Generate sequential loop for OpenACC loop directive inside kernels

2015-06-16 Thread Chung-Lin Tang
create OMP_FOR, which the loop analysis phases don't understand. Tested and committed to gomp-4_0-branch. Chung-Lin 2015-06-16 Chung-Lin Tang clt...@codesourcery.com * omp-low.c (struct omp_region): Add inside_kernels_p field. (expand_omp_for_generic): Adjust to generate

Re: [patch, libgomp] Re-factor GOMP_MAP_POINTER handling

2015-05-21 Thread Chung-Lin Tang
Ping x2. On 15/5/11 7:19 PM, Chung-Lin Tang wrote: Ping. On 2015/4/21 08:21 PM, Chung-Lin Tang wrote: Hi, while investigating some issues in the variable mapping code, I observed that the GOMP_MAP_POINTER handling is essentially duplicated under the PSET case. This patch abstracts

Re: [patch, libgomp] Re-factor GOMP_MAP_POINTER handling

2015-05-11 Thread Chung-Lin Tang
Ping. On 2015/4/21 08:21 PM, Chung-Lin Tang wrote: Hi, while investigating some issues in the variable mapping code, I observed that the GOMP_MAP_POINTER handling is essentially duplicated under the PSET case. This patch abstracts and unifies the handling code, basically just a cleanup

[patch, libgomp] Re-factor GOMP_MAP_POINTER handling

2015-04-21 Thread Chung-Lin Tang
for trunk? Thanks, Chung-Lin 2015-04-21 Chung-Lin Tang clt...@codesourcery.com libgomp/ * target.c (gomp_map_pointer): New function abstracting out GOMP_MAP_POINTER handling. (gomp_map_vars): Remove GOMP_MAP_POINTER handling code and use gomp_map_pointer

[patch, nios2, committed] Fix nios2-linux crti/crtn settings

2015-03-25 Thread Chung-Lin Tang
the extra_parts setting for nios2-linux libgcc; now crti.o/crtn.o links to the correct ones provided by glibc. Chung-Lin 2015-03-25 Chung-Lin Tang clt...@codesourcery.com libgcc/ * config.host (nios2-*-linux*): Remove 'extra_parts' setting. Index: config.host

[PATCH, nios2] Updates to Nios II Linux

2015-01-20 Thread Chung-Lin Tang
The Nios II ports of glibc and Linux kernel are now both upstream. New system conventions now use a non-executable stack. Attached patch committed to support new conventions, applied to both trunk and 4.9 branch. Chung-Lin 2015-01-20 Chung-Lin Tang clt...@codesourcery.com gcc

Re: [PATCH] gcc/config/nios2/nios2.c: Let custom_builtin_name[*] always be zero terminated string

2014-07-26 Thread Chung-Lin Tang
On 14/7/26 11:28 AM, Chen Gang wrote: The related strncpy() for custom_builtin_name[*] may set 5 none-zero characters, which may cause custom_builtin_name[*] is none-zero terminated. So add additional '\0' byte for custom_builtin_name[*]. Where did you see this? Supposedly the snprintf of

Re: [PATCH] gcc/config/nios2/nios2.c: Let custom_builtin_name[*] always be zero terminated string

2014-07-26 Thread Chung-Lin Tang
On 2014/7/26 03:33 PM, Chen Gang wrote: On 07/26/2014 02:32 PM, Chung-Lin Tang wrote: On 14/7/26 11:28 AM, Chen Gang wrote: The related strncpy() for custom_builtin_name[*] may set 5 none-zero characters, which may cause custom_builtin_name[*] is none-zero terminated. So add additional '\0

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-18 Thread Chung-Lin Tang
On 2014/7/18 上午 05:19, Joel Sherrill wrote: Unless someone objects, I am going to commit this to the 4.9 branch and head. --joel Sorry about the delay, I'll review it today. Thanks, Chung-Lin On 7/7/2014 1:42 AM, Sebastian Huber wrote: Ping. On 2014-06-26 13:43, Sebastian Huber wrote:

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-18 Thread Chung-Lin Tang
For the default multilib settings, it looks like you just intended to use -mcustom-fpu-cfg=60-2. I suggest you modify t-rtems to do that instead of enumerating the individual FPU insn options. Other than that, the patch looks okay. Chung-Lin On 2014/6/26 07:43 PM, Sebastian Huber wrote: diff

Re: [PATCH] RTEMS: Add Nios 2 support

2014-07-18 Thread Chung-Lin Tang
On 14/7/18 2:30 PM, Chung-Lin Tang wrote: For the default multilib settings, it looks like you just intended to use -mcustom-fpu-cfg=60-2. I suggest you modify t-rtems to do that instead of enumerating the individual FPU insn options. Other than that, the patch looks okay. Chung-Lin BTW

Re: [PATCH, ARM] Cortex-A9 MPCore volatile load workaround

2014-06-26 Thread Chung-Lin Tang
Ping x2. On 14/6/20 2:24 PM, Chung-Lin Tang wrote: Ping. On 2014/6/9 10:03 PM, Chung-Lin Tang wrote: Hi Richard, As we talked about earlier, here's a patch to add a compiler option to work around Cortex-A9 MPCore errata 761319: http://infocenter.arm.com/help/topic/com.arm.doc.uan0004a

Re: [PATCH, PR61554] ICE during CCP

2014-06-24 Thread Chung-Lin Tang
On 2014/6/23 04:45 PM, Richard Biener wrote: On Mon, Jun 23, 2014 at 7:32 AM, Chung-Lin Tang clt...@codesourcery.com wrote: Hi Richard, In this change: https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01278.html where substitute_and_fold() was changed to use a dom walker, the calls to purge

[PATCH, PR61554] ICE during CCP

2014-06-22 Thread Chung-Lin Tang
...) Bootstrapped and tested on x86_64-linux, is this okay for trunk? Thanks, Chung-Lin 2014-06-23 Chung-Lin Tang clt...@codesourcery.com PR tree-optimization/61554 * tree-ssa-propagate.c (substitute_and_fold_dom_walker): Add 'vecbasic_block bbs_to_purge_dead_eh_edges' member

Re: [PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY

2014-06-20 Thread Chung-Lin Tang
On 2014/6/18 上午 06:26, Ramana Radhakrishnan wrote: On Sun, Jun 8, 2014 at 12:27 PM, Chung-Lin Tang clt...@codesourcery.com wrote: Hi Richard, Ramana, Attached is a small fix for resolving a g++.old-deja/g++.jason/thunk2.C regression we found under a TARGET_THUMB1_ONLY multilib (-mthumb

Re: [PATCH, ARM] Cortex-A9 MPCore volatile load workaround

2014-06-20 Thread Chung-Lin Tang
Ping. On 2014/6/9 10:03 PM, Chung-Lin Tang wrote: Hi Richard, As we talked about earlier, here's a patch to add a compiler option to work around Cortex-A9 MPCore errata 761319: http://infocenter.arm.com/help/topic/com.arm.doc.uan0004a/UAN0004A_a9_read_read.pdf What the option does

Re: [ARM] Fix build failure due to movsi_compare0 (PR 61430)

2014-06-16 Thread Chung-Lin Tang
On 14/6/16 5:55 PM, James Greenhalgh wrote: On Fri, Jun 13, 2014 at 05:46:45PM +0100, Vladimir Makarov wrote: On 2014-06-11, 1:17 PM, Chung-Lin Tang wrote: Looking at this too, as an LRA exercise. I don't really think the pattern is wrong, rather LRA should just avoid creating the copy

Re: [ARM] Fix build failure due to movsi_compare0 (PR 61430)

2014-06-11 Thread Chung-Lin Tang
On 2014/6/11 下午 06:32, James Greenhalgh wrote: Hi, A recent change somewhere exposed a latent bug between LRA and the definition of the movsi_compare0 pattern. This pattern ties the source and destination register of a set together a (match_dup) and register constraints: [(set

[PATCH, ARM] Cortex-A9 MPCore volatile load workaround

2014-06-09 Thread Chung-Lin Tang
, and finally a few trivial adjustments by me. Again, we've been carrying this fix for a release or two. Okay for trunk? Thanks, Chung-Lin 2014-06-09 Julian Brown jul...@codesourcery.com Meador Inge mead...@codesourcery.com Chung-Lin Tang clt...@codesourcery.com

[PATCH, ARM] MI-thunk fix for TARGET_THUMB1_ONLY

2014-06-08 Thread Chung-Lin Tang
. Original patch was by Julian, with trivial adaptations for trunk by me. We've been carrying this fix for a while by now. Okay for trunk? (and stable branches?) Thanks, Chung-Lin 2014-06-08 Julian Brown jul...@codesourcery.com Chung-Lin Tang clt...@codesourcery.com * config

[PATCH, nios2] Misc. fixes

2014-04-01 Thread Chung-Lin Tang
UNSPECs warning when building with -g. (5) Adjust the nios2-linux LINK_SPEC to define the dynamic linker name to /lib/ld-linux-nios2.so.1, which is the current upstreamed arrangement. Chung-Lin 2014-04-01 Chung-Lin Tang clt...@codesourcery.com * config/nios2/nios2.md (unspec): Remove

[PATCH, nios2] Fix frame pointer calculation

2014-03-11 Thread Chung-Lin Tang
, plus nios2 GDB's prologue analyzer is capable of determining where FP is stored. Still this needs to fixed to be conformant to the ABI. Tested (both the compiler and gdb) and applied to trunk. Chung-Lin 2014-03-11 Chung-Lin Tang clt...@codesourcery.com * config/nios2/nios2.c

Re: [PATCH/middle-end 2/6] __builtin_thread_pointer and AARCH64 ILP32

2014-02-24 Thread Chung-Lin Tang
by having its higher 32 bits cleared. I think expand_builtin_thread_pointer and expand_builtin_set_thread_pointer should use ptr_mode instead. Correct me if I missed anything. Add Chung-Lin Tang to the CC list; Chung-Lin wrote these builtins in r192364 Pmode seems more correct as the hardware mode

[PATCH, nios2] Large -fPIC support

2014-02-20 Thread Chung-Lin Tang
This patch adds large GOT support for the Nios II backend. Tested by running glibc tests with -fPIC forced on. A few smaller libgcc fixes are also included as well. Patch committed. Chung-Lin 2014-02-20 Chung-Lin Tang clt...@codesourcery.com Sandra Loosemore san

[PATCH, nios2, committed] PR59784, fextsd asm output fix

2014-01-29 Thread Chung-Lin Tang
Hi Savin, I've committed your patch for PR59784; the fix seems small enough to accept directly. Thanks a lot for catching this. Thanks, Chung-Lin 2014-01-30 Savin Zlobec savin.zlo...@gmail.com PR target/59784 * config/nios2/nios2.c (nios2_fpu_insn_asm): Fix asm output of

Re: Reload codegen improvement

2014-01-23 Thread Chung-Lin Tang
On 14/1/8 12:22 AM, Bernd Schmidt wrote: This fixes a problem identified by Chung-Lin. Once reload is done, all equivalencing insns for pseudos that didn't get a hard reg but could be eliminated using their REG_EQUIV are deleted. However, we still can produce reloads and reload insns for them

Re: [buildrobot] [PATCH] Fix redefinition of BITS_PER_UNIT

2014-01-01 Thread Chung-Lin Tang
On 2014/1/1 02:45 PM, Mike Stump wrote: On Dec 31, 2013, at 12:26 PM, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Tue, 2013-12-31 15:24:52 +0800, Chung-Lin Tang clt...@codesourcery.com wrote: The nios2 port was just committed. Thanks to all that gave time and effort to review this. Just

nios2 port committed (Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts)

2013-12-30 Thread Chung-Lin Tang
On 2013/12/28 02:29 PM, Chung-Lin Tang wrote: On 13/12/23 12:54 AM, Chung-Lin Tang wrote: Other than these two, I think this can go in. Bernd Attached is the updated patch for the compiler. Since Bernd is a Global Reviewer, am I clear for committing the port now? (including the testsuite

Re: Question about simple_return pattern for the GCC ARM backend.

2013-12-28 Thread Chung-Lin Tang
On 2013/12/28 09:31 AM, Yangfei (Felix) wrote: Hi, I think that simple_return standard pattern is useful for the ARM. I mean it should be good for target code performance.  But seems this pattern is not there for the GCC ARM backend. Can anyone explain the reason why we don’t need

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-12-27 Thread Chung-Lin Tang
On 13/12/23 12:54 AM, Chung-Lin Tang wrote: Other than these two, I think this can go in. Bernd Attached is the updated patch for the compiler. Since Bernd is a Global Reviewer, am I clear for committing the port now? (including the testsuite and libgcc parts) I will be taking Bernd's

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-12-16 Thread Chung-Lin Tang
Ping x3. On 13/12/10 12:57 PM, Chung-Lin Tang wrote: Ping x2. On 2013/12/5 12:19 PM, Chung-Lin Tang wrote: Ping. On 2013/11/26 02:45 PM, Chung-Lin Tang wrote: Hi Bernd, I've updated the patch again, please see if it looks fit for approval now. Including ChangeLog again for completeness

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-12-09 Thread Chung-Lin Tang
Ping x2. On 2013/12/5 12:19 PM, Chung-Lin Tang wrote: Ping. On 2013/11/26 02:45 PM, Chung-Lin Tang wrote: Hi Bernd, I've updated the patch again, please see if it looks fit for approval now. Including ChangeLog again for completeness. Thanks, Chung-Lin 2013-11-26 Chung-Lin Tang clt

Re: [PATCH] Hexadecimal numbers in option arguments

2013-12-09 Thread Chung-Lin Tang
On 2013/7/14 09:27 PM, Joseph S. Myers wrote: On Sun, 14 Jul 2013, Chung-Lin Tang wrote: Original patch posted as part of Nios II patches: http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01087.html This patch is to allow hexadecimal numbers to be used in option arguments, e.g. -falign-loops

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-12-04 Thread Chung-Lin Tang
Ping. On 2013/11/26 02:45 PM, Chung-Lin Tang wrote: Hi Bernd, I've updated the patch again, please see if it looks fit for approval now. Including ChangeLog again for completeness. Thanks, Chung-Lin 2013-11-26 Chung-Lin Tang clt...@codesourcery.com Sandra Loosemore san

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-11-22 Thread Chung-Lin Tang
On 13/11/22 10:31 PM, Bernd Schmidt wrote: If you don't object, I'll keep the clobbers there for now. If they serve no purpose (and I think they don't), they should go. I'll check again, but I remember df_regs_ever_live_p doesn't include the RA reg if the call pattern doesn't have the

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-11-21 Thread Chung-Lin Tang
On 2013/11/21 03:25 PM, Richard Henderson wrote: On 11/21/2013 02:41 PM, Chung-Lin Tang wrote: I'm not saying we tolerate wrong RTL form, but rather that, it should be an issue of the RTL passes, not the backend. The backend should just be as much as possible, a machine description

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-11-20 Thread Chung-Lin Tang
On 13/11/20 1:34 AM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: +;; Integer logical Operations + +(define_code_iterator LOGICAL [and ior xor]) +(define_code_attr logical_asm [(and and) (ior or) (xor xor)]) + +(define_insn codesi3 + [(set (match_operand:SI 0

Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-11-20 Thread Chung-Lin Tang
On 13/11/21 7:21 AM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: On 13/11/20 1:34 AM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: +;; Integer logical Operations + +(define_code_iterator LOGICAL [and ior xor]) +(define_code_attr

Re: [PATCH][3/3] Re-submission of Altera Nios II port, libgcc parts

2013-11-16 Thread Chung-Lin Tang
On 2013/7/14 03:55 PM, Chung-Lin Tang wrote: nios2 libgcc parts. Since the original post, the only main change has been the fdpbit vs soft-fp issue raised by Joseph, which has been resolved. Other parts are mostly the same. The Nios II libgcc parts have been further updated to include a sfp

Re: [PATCH][2/3] Re-submission of Altera Nios II port, testsuite parts

2013-11-16 Thread Chung-Lin Tang
On 2013/10/17 10:20 PM, Bernd Schmidt wrote: On 07/14/2013 09:54 AM, Chung-Lin Tang wrote: These are nios2 patches for the gcc testsuite. Some new testcases were added since the last posting. Index: gcc/testsuite/gcc.c-torture/execute/builtins/lib/chk.c

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Chung-Lin Tang
On 2013/10/6 05:57 PM, Richard Sandiford wrote: But case 16 is different. This case is only produced at prologue/epilogue phase, using a temporary register $r15 to hold a large constant for adjusting stack pointer. Since prologue/epilogue is after split1/split2 phase, we can only output

Re: [PING] Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-09-02 Thread Chung-Lin Tang
Ping. On 13/8/20 10:57 AM, Chung-Lin Tang wrote: Ping. BTW, the SC has approved the Nios II port already: http://gcc.gnu.org/ml/gcc/2013-07/msg00434.html The port is still awaiting technical review. Thanks, Chung-Lin On 13/7/14 下午3:54, Chung-Lin Tang wrote: Hi, the last ping

[PING] Re: [PATCH][1/3] Re-submission of Altera Nios II port, gcc parts

2013-08-19 Thread Chung-Lin Tang
Ping. BTW, the SC has approved the Nios II port already: http://gcc.gnu.org/ml/gcc/2013-07/msg00434.html The port is still awaiting technical review. Thanks, Chung-Lin On 13/7/14 下午3:54, Chung-Lin Tang wrote: Hi, the last ping of the Nios II patches was: http://gcc.gnu.org/ml/gcc-patches

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 10:06 PM, Mike Stump wrote: On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/7/15 1:43 AM, Diego Novillo wrote: Could you please repost the patch with its description? This thread is sufficiently old and noisy that I'm not even sure what the patch

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-05 Thread Chung-Lin Tang
On 13/8/5 下午10:24, Mike Stump wrote: On Aug 5, 2013, at 7:15 AM, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/8/5 10:06 PM, Mike Stump wrote: On Aug 4, 2013, at 8:14 AM, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/7/15 1:43 AM, Diego Novillo wrote: Could you please repost

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-04 Thread Chung-Lin Tang
for convenience). Thanks, Chung-Lin 2013-08-04 Chung-Lin Tang clt...@codesourcery.com PR target/32219 * rtlanal.c (nonzero_address_p): Robustify checking by look recursively into PIC constant offsets and (CONST (UNSPEC ...)) expressions. Index: rtlanal.c

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-08-01 Thread Chung-Lin Tang
On 13/8/1 5:16 PM, Bernhard Reutner-Fischer wrote: On 14 July 2013 19:43, Diego Novillo dnovi...@google.com wrote: On Sun, Jul 14, 2013 at 2:08 AM, Chung-Lin Tang clt...@codesourcery.com wrote: Ping. Could you please repost the patch with its description? This thread is sufficiently old

Altera Nios II port submission

2013-07-22 Thread Chung-Lin Tang
and myself (Chung-Lin Tang), both of Mentor Graphics, as target maintainers. Thank you, Chung-Lin [1] http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00526.html http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00527.html http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00528.html

[PATCH][2/3] Re-submission of Altera Nios II port, testsuite parts

2013-07-14 Thread Chung-Lin Tang
These are nios2 patches for the gcc testsuite. Some new testcases were added since the last posting. Chung-Lin 2013-07-14 Sandra Loosemore san...@codesourcery.com Chung-Lin Tang clt...@codesourcery.com Based on patches from Altera Corporation * gcc.dg/stack

[PATCH][3/3] Re-submission of Altera Nios II port, libgcc parts

2013-07-14 Thread Chung-Lin Tang
nios2 libgcc parts. Since the original post, the only main change has been the fdpbit vs soft-fp issue raised by Joseph, which has been resolved. Other parts are mostly the same. Thanks, Chung-Lin 2013-07-14 Sandra Loosemore san...@codesourcery.com Chung-Lin Tang clt

[PATCH] Hexadecimal numbers in option arguments

2013-07-14 Thread Chung-Lin Tang
to use IXDIGIT to check the argument string first, as you suggested in the last submission. Is this okay for trunk? Thanks, Chung-Lin 2013-07-14 Chung-Lin Tang clt...@codesourcery.com * opts-common.c (integral_argument): Add support for hexadecimal command option integer arguments

Re: [PATCH] PR32219, weak hidden reference segfault [PING^2]

2013-07-14 Thread Chung-Lin Tang
Ping. On 2013/6/20 03:01 PM, Chung-Lin Tang wrote: Ping again? On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: ping, CCing middle-end maintainers for review. On 31 May 2013 10:13, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/5/15 8:12 PM, Richard Sandiford wrote: Chung-Lin

[PING^3] Nios II port

2013-06-25 Thread Chung-Lin Tang
Ping x 3. On 13/6/18 下午4:38, Chung-Lin Tang wrote: On 13/6/18 上午3:05, Sandra Loosemore wrote: Ping? I think these are the most recent versions of the unreviewed patches in the series: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00287.html http://gcc.gnu.org/ml/gcc-patches/2013-05

Re: Question about conds attribute for *thumb2_alusi3_short

2013-06-24 Thread Chung-Lin Tang
On 13/6/24 下午11:43, Tom de Vries wrote: Richard, I've noticed that f.i. *thumb2_alusi3_short has no explicit setting of the conds attribute, which means the value of the conds attribute for this insn is nocond: ... (define_insn *thumb2_alusi3_short [(set (match_operand:SI 0

Re: [PATCH] PR32219, weak hidden reference segfault [PING]

2013-06-20 Thread Chung-Lin Tang
Ping again? On 13/6/11 5:20 PM, Bernhard Reutner-Fischer wrote: ping, CCing middle-end maintainers for review. On 31 May 2013 10:13, Chung-Lin Tang clt...@codesourcery.com wrote: On 13/5/15 8:12 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: On 13/5/10 6:37 PM

Re: [ping**2] Nios II port

2013-06-18 Thread Chung-Lin Tang
On 13/6/18 上午3:05, Sandra Loosemore wrote: Ping? I think these are the most recent versions of the unreviewed patches in the series: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00287.html http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00760.html

[PING] Re: [PATCH 0/5] Submission of Altera Nios II port

2013-06-05 Thread Chung-Lin Tang
Pinging the nios2 port. On 13/5/15 1:04 AM, Chung-Lin Tang wrote: On 2013/4/26 04:35 AM, Joseph S. Myers wrote: I should ask the following general standard new-port questions: * Does the port build cleanly when configured with --enable-werror-always and built using a native compiler from

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-31 Thread Chung-Lin Tang
On 13/5/15 8:12 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: On 13/5/10 6:37 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: +case UNSPEC: + /* Reach for a contained symbol. */ + return nonzero_address_p (XVECEXP (x, 0

Re: [PATCH] PR32219, weak hidden reference segfault

2013-05-15 Thread Chung-Lin Tang
On 13/5/10 6:37 PM, Richard Sandiford wrote: Chung-Lin Tang clt...@codesourcery.com writes: +case UNSPEC: + /* Reach for a contained symbol. */ + return nonzero_address_p (XVECEXP (x, 0, 0)); I don't think this is safe. UNSPECs really are unspecified :-), so we can't assume

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-15 Thread Chung-Lin Tang
On 13/5/15 9:43 PM, Kugan wrote: On 14/05/13 19:18, Ramana Radhakrishnan wrote: On 05/13/13 04:15, Kugan wrote: Hi, Ping this patch by Chung-Lin. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html This patch allows lr registers to be used in leaf functions for ARM. There were some

Re: [PATCH 2/5] Altera Nios II: libgcc

2013-05-14 Thread Chung-Lin Tang
On 13/4/26 4:00 AM, Joseph S. Myers wrote: On Thu, 18 Apr 2013, Chung-Lin Tang wrote: +nios2-*-linux*) +tmake_file=$tmake_file nios2/t-nios2 nios2/t-linux t-libgcc-pic t-slibgcc-libgcc +extra_parts=$extra_parts crti.o crtn.o +md_unwind_header=nios2/linux-unwind.h

Re: [PATCH 0/5] Submission of Altera Nios II port

2013-05-14 Thread Chung-Lin Tang
On 2013/4/26 04:35 AM, Joseph S. Myers wrote: I should ask the following general standard new-port questions: * Does the port build cleanly when configured with --enable-werror-always and built using a native compiler from current GCC trunk - for both 32-bit host, and 64-bit host? It

Re: [ping][patch, ARM] Fix PR42017, LR not used in leaf functions

2013-05-13 Thread Chung-Lin Tang
On 13/5/13 11:15 AM, Kugan wrote: Hi, Ping this patch by Chung-Lin. http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01179.html This patch allows lr registers to be used in leaf functions for ARM. There were some concerns about performance regression in thumb2 mode for CoreMark. However,

[PATCH] PR32219, weak hidden reference segfault

2013-05-09 Thread Chung-Lin Tang
-09 Chung-Lin Tang clt...@codesourcery.com PR target/32219 * rtlanal.c (nonzero_address_p): Robustify checking by look recursively into PIC constant offsets and (CONST (UNSPEC ...)) expressions. Index: rtlanal.c

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-23 Thread Chung-Lin Tang
On 2013/4/23 01:35 AM, Cary Coutant wrote: A : host_integerp (value, TYPE_UNSIGNED (TREE_TYPE (value))) B : host_integerp (value, 0) AB AB AB AB type_size,hwi | 00 01 10 11 --+--- 32,32 | X X

Re: [PATCH 4/5] Altera Nios II: dwarf generation fix

2013-04-22 Thread Chung-Lin Tang
On 2013/4/19 12:56 AM, Cary Coutant wrote: On Thu, Apr 18, 2013 at 6:49 AM, Chung-Lin Tang clt...@codesourcery.com wrote: This patch was a fix by Julian which corrected a HOST_BITS_PER_WIDE_INT host dependency in dwarf generation. Nios II does not have need_64bit_hwint switched on during

<    1   2   3   4   5   6   >