Re: [PATCH v2] libgcc: Expose the instruction pointer and stack pointer in SEH _Unwind_Backtrace

Hello, as noone seems to be able to review this patch, I will do so, even if this is no longer a task of mine. The patch itself is reasonable and seems to fix a pending issue we have on CFA support. I had already private discussion with Martin, and I would have loved to see a test-case

Re: [aarch64}: added variable issue rate feature for falkor

Kai Tietz * config/aarch64/aarch64.c (aarch64_sched_reorder): Implement TARGET_SCHED_REORDER hook. (aarch64_variable_issue): Implement TARGET_SCHED_VARIABLE_ISSUE hook. (qdf24xx_): Add AARCH64_EXTRA_TUNE_SCHED_MICRO_OPS tune flag. (TARGET_SCHED_REORDER

Re: [patch] [match.pd]: missing optimization on comparison

tree-ssa-reassoc pass. But for simplicity of this patch, I kept them in match.pd. I ran also spec 2017 and 2006 on aarch64 architecture for it. For some tests I could messure an improvment up to 2 percent. There was no regression. Regards, Kai ChangeLog Kai Tietz * match.pd

[patch] [match.pd]: missing optimization on comparison

ass. But for simplicity of this patch, I kept them in match.pd. I ran also spec 2017 and 2006 on aarch64 architecture for it. For some tests I could messure an improvment up to 2 percent. There was no regression. ChangeLog Kai Tietz * match.pd: New optimization for integral comparison

Re: [aarch64}: added variable issue rate feature for falkor

Hello Kyrill, thanks for your comments. 2018-08-14 16:50 GMT+02:00 Kyrill Tkachov : > Hi Kai, > > > On 13/08/18 17:48, Kai Tietz wrote: >> >> I repost updated patch containing ChangeLog entry. >> >> Regards, >> Kai > > > I think I understand w

Re: [aarch64}: added variable issue rate feature for falkor

I repost updated patch containing ChangeLog entry. Regards, Kai Jim Wilson Kai Tietz * config/aarch64.c (aarch64_sched_reorder): Implement TARGET_SCHED_REORDER hook. (aarch64_variable_issue): Implement TARGET_SCHED_VARIABLE_ISSUE hook. (TARGET_SCHED_REORDER): Define

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 18:23 GMT+02:00 Segher Boessenkool : > I cannot okay patches for aarch64. But I did not notice other typoes, > if that is what you're asking. Yes. Thanks. So, is patch ok with updated ChangeLog: Jim Wilson Kai Tietz * config/aar

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 17:51 GMT+02:00 Segher Boessenkool : > Hi! > > On Mon, Aug 13, 2018 at 10:16:20AM +0200, Kai Tietz wrote: >> * config/aarch64.c (aarch64_sched_reorder): Implementing >> TARGET_SHED_REORDER hook. >> (aarch64_variable_issue): Implemented

Re: [aarch64}: added variable issue rate feature for falkor

2018-08-13 15:43 GMT+02:00 Bernhard Reutner-Fischer : > On 13 August 2018 15:12:30 CEST, Bernhard Reutner-Fischer > wrote: >>On 13 August 2018 10:16:20 CEST, Kai Tietz >>wrote: >>>Hello, >>> >>>this patch implements variable issue rate feature for f

[aarch64}: added variable issue rate feature for falkor

ions for thos tests. ChangeLog: Jim Wilson Kai Tietz * config/aarch64.c (aarch64_sched_reorder): Implementing TARGET_SHED_REORDER hook. (aarch64_variable_issue): Implemented TARGET_SHED_VARIABLE_ISSUE hook. (TARGET_SHED_REORDER): Def

Re: [PATCH] Fix ms_struct/-mms-bitfields structure layout (PR target/52991)

Hello Jakub, I can't approve this patch, but I can confirm that changes are sensible. I verified the structure layout - as far as possible - also with MS' compiler, and can confirm the adjustments. Cheers, Ka 2018-02-28 1:26 GMT+01:00 Jakub Jelinek : > Hi! > > The following

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 12:21 GMT+02:00 JonY <10wa...@gmail.com>: > On 05/01/2017 11:31 AM, Uros Bizjak wrote: >> On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos >> wrote: >>> All of patches are concerned with 64-bit Microsoft ABI functions that call >>> System V ABI function which

Re: fix crash on 64-bit mingw-w64 hosted compiler using more than 4 gb of ram

Hello Stanislaw. patch is ok. Nevertheless there is a ChangeLog entry missing for it. It is mandatory to be provided for submissions to gcc. Thanks, Kai 2016-08-11 11:31 GMT+02:00 Stanislaw Halik : > The host configuration across platforms wrongly assumes that > sizeof(long)

Re: [patch] Allow configuration with --disable-sjlj-exceptions on biarch x86 Windows targets

Ok. I just looked into patch. Sorry for the delay. As it is still possible to build old behavior, the patch is ok for me. Thanks, Kai 2016-05-19 20:55 GMT+02:00 Sandra Loosemore <san...@codesourcery.com>: > On 05/19/2016 12:40 PM, Kai Tietz wrote: >> >> Hi, >> &

Re: [patch] Allow configuration with --disable-sjlj-exceptions on biarch x86 Windows targets

Hi, hopefully this time gmail uses mail-encoding elmz ask for ... Sorry to object here. I would like to point out that defaulting to dw2 on 32-bit if SEH is used for 64-bit is nothing good in general. This is reasoned by the problems existing in dw2 in combination with other compiler-generated

[patch mingw]: Fix PR/51726 - LTO and attribute 'selectany'

of selectany-attribute on uninitialized variables, too. ChangeLog 2015-10-01 Kai Tietz <ktiet...@googlemail.com> PR target/51726 * config/i386/winnt.c (ix86_handle_selectany_attribute): Handle selectany within this function without need to keep attribute. (i386_pe_encode_sectio

Re: [PATCH] Fix Cygwin bootstrap failing to find win32 libraries

2015-09-21 0:35 GMT+02:00 JonY <10wa...@gmail.com>: > On 9/21/2015 02:05, Kai Tietz wrote: >> 2015-09-16 13:42 GMT+02:00 JonY <10wa...@gmail.com>: >>> libgcc is failing to find kerne32 etc during the 2nd stage when >>> bootstraping, explicitly add w32api dir

Patch: Adjust my e-mail-address in MAINTAINERS file

Hi, committed adjustment of my e-mail-address in MAINTAINERS file. ChangeLog 2015-09-20 Kai Tietz * MAINTAINERS: Update email. Kai Index: MAINTAINERS === --- MAINTAINERS (Revision 227950) +++ MAINTAINERS (Arbeitskopie

Re: [PATCH] Fix Cygwin bootstrap failing to find win32 libraries

2015-09-16 13:42 GMT+02:00 JonY <10wa...@gmail.com>: > libgcc is failing to find kerne32 etc during the 2nd stage when > bootstraping, explicitly add w32api directory to search path. > > Patch OK? > > diff --git a/gcc/config/i386/cygwin.h b/gcc/config/i386/cygwin.h > index 2a2a0bf..fd3bc0a 100644

Re: [c++-delayed-folding] cp_fold_r

Hi Jason, Sounds like an interesting idea. Do have already a specific approach in mind? My idea might be just hard to model, as we aren't sure we walked before the complete chain. Due cp_fold is caching, we won't try to fold an expression a second time, but we don't cover all EXPRs in cp_fold,

Re: [c++-delayed-folding] cp_fold_r

2015-09-18 18:31 GMT+02:00 Jason Merrill <ja...@redhat.com>: > On 09/18/2015 02:19 AM, Kai Tietz wrote: >> >> Hi Jason, >> >> Sounds like an interesting idea. Do have already a specific approach in >> mind? >> >> My idea might be just h

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

2015-09-17 11:12 GMT+02:00 Richard Biener <richard.guent...@gmail.com>: > On Wed, Sep 16, 2015 at 9:51 PM, Jeff Law <l...@redhat.com> wrote: >> On 09/15/2015 03:42 AM, Kai Tietz wrote: >>>>> >>>>> 2015-09-08 Kai Tietz <kti...@redhat.co

Re: [c++-delayed-folding] code review

Hello Jason, thanks for your review. I addressed most of your mentioned issues already today. To some of them I have further comments ... 2015-09-17 8:18 GMT+02:00 Jason Merrill : >> @@ -216,6 +216,7 @@ libgcov-driver-tool.o-warn = -Wno-error >> libgcov-merge-tool.o-warn =

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

2015-09-15 0:45 GMT+02:00 Jeff Law <l...@redhat.com>: > On 09/08/2015 05:17 AM, Kai Tietz wrote: >> >> Hi, >> >> This patch is the first part of obsoleting 'shorten_compare' function >> for folding. >> It adjusts the uses of 'shorten_compare'

Re: [patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

Hi Richi, thanks for the review. 2015-09-15 12:06 GMT+02:00 Richard Biener <richard.guent...@gmail.com>: > On Tue, Sep 8, 2015 at 1:17 PM, Kai Tietz <ktiet...@googlemail.com> wrote: >> Hi, >> >> This patch is the first part of obsoleting 'shorten_compare' funct

[patch match.pd c c++]: Ignore results of 'shorten_compare' and move missing patterns in match.pd

regressions within gcc.dg testsuite due patterns matched are folded more early by forward-propagation. I adjusted them, and added them to patch, too. I did regression-testing for x86_64-unknown-linux-gnu. ChangeLog 2015-09-08 Kai Tietz <kti...@redhat.com> * match.pd: Add missing pa

Re: [c++-delayed-folding] fold_simple

2015-09-01 10:15 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: > 2015-08-31 22:19 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >> 2015-08-31 21:43 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >>> 2015-08-31 21:29 GMT+02:00 Jason Merrill <ja...@redhat

Re: [c++-delayed-folding] fold_simple

2015-08-31 22:19 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: > 2015-08-31 21:43 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >> 2015-08-31 21:29 GMT+02:00 Jason Merrill <ja...@redhat.com>: >>> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>>> &g

Re: [c++-delayed-folding] fold_simple

2015-09-01 10:43 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: > 2015-09-01 10:15 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >> 2015-08-31 22:19 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >>> 2015-08-31 21:43 GMT+02:00 Kai Tietz <ktiet...@googlemai

Re: [c++-delayed-folding] fold_simple

2015-09-01 13:17 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: > 2015-09-01 10:43 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >> 2015-09-01 10:15 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: >>> 2015-08-31 22:19 GMT+02:00 Kai Tietz <ktiet...@googlemai

Re: [c++-delayed-folding] fold_simple

2015-09-01 16:47 GMT+02:00 Jason Merrill <ja...@redhat.com>: > On 08/31/2015 03:43 PM, Kai Tietz wrote: >> >> 2015-08-31 21:29 GMT+02:00 Jason Merrill <ja...@redhat.com>: >>> >>> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>>> >>

Re: [c++-delayed-folding] fold_simple

2015-09-01 17:31 GMT+02:00 Jason Merrill <ja...@redhat.com>: > On 09/01/2015 11:27 AM, Kai Tietz wrote: >> >> I rewrote binary/unary overflow-check logic so, that we avoid double >> checking-s. I think this address things as you intend, beside the >> checking f

Re: [c++-delayed-folding] fold_simple

2015-08-31 19:52 GMT+02:00 Jason Merrill <ja...@redhat.com>: > On 08/29/2015 10:10 AM, Kai Tietz wrote: >> >> Hmm, I don't think we want to call maybe_constant_value in functions >> like cp_build_binary_op. We are interested in overflow only on >> constant-values

Re: [c++-delayed-folding] fold_simple

2015-08-31 21:29 GMT+02:00 Jason Merrill <ja...@redhat.com>: > On 08/31/2015 03:08 PM, Kai Tietz wrote: >> >> I will need to verify that this patch doesn't introduce regressions. >> The wacky thing here is the encapsulation of overflowed-arguments in >> maybe_co

Re: [c++-delayed-folding] fold_simple

2015-08-31 21:43 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>: > 2015-08-31 21:29 GMT+02:00 Jason Merrill <ja...@redhat.com>: >> On 08/31/2015 03:08 PM, Kai Tietz wrote: >>> >>> I will need to verify that this patch doesn't introduce regressions. >&g

Re: [c++-delayed-folding] fold_simple

2015-08-29 6:45 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/27/2015 05:21 AM, Kai Tietz wrote: 2015-08-27 4:57 GMT+02:00 Jason Merrill ja...@redhat.com: Why does fold_simple fold so many patterns? I thought we wanted something that would just fold conversions and negations of constant

Re: [PATCH] clone_function_name_1: Retain any stdcall suffix

2015-08-18 22:23 GMT+02:00 Ray Donnelly mingw.andr...@gmail.com: I'm not familiar with setting up GCC testcases yet so I expect to have to do that at least. To aid discussion, the commit message contains a testcase. No problem. Patch looks fine to me. Thanks, Kai -- Best regards, Ray.

Re: [PATCH] Remove pointless -fPIC warning on Windows platforms

Hi Pedro, 2015-08-15 0:24 GMT+02:00 Paolo Bonzini bonz...@gnu.org: There are plenty of targets that do not require -fPIC because they always generate position independent code, but none of them feels the need to complain with the user about an unnecessary but perfectly valid option, on each

Re: C++ delayed folding branch review

2015-08-28 4:11 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/27/2015 02:12 PM, Kai Tietz wrote: + else if (TREE_CODE (type) == VECTOR_TYPE) +{ + if (TREE_CODE (arg1) == VECTOR_CST + code == NOP_EXPR + TYPE_VECTOR_SUBPARTS (type) == VECTOR_CST_NELTS (arg1

Re: C++ delayed folding branch review

2015-08-28 9:19 GMT+02:00 Kai Tietz ktiet...@googlemail.com: 2015-08-28 4:11 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/27/2015 02:12 PM, Kai Tietz wrote: + else if (TREE_CODE (type) == VECTOR_TYPE) +{ + if (TREE_CODE (arg1) == VECTOR_CST + code == NOP_EXPR

Re: C++ delayed folding branch review

2015-08-27 15:27 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/27/2015 06:39 AM, Kai Tietz wrote: 2015-08-27 4:56 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/24/2015 03:15 AM, Kai Tietz wrote: 2015-08-03 17:39 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/03/2015 05:42 AM, Kai

Re: C++ delayed folding branch review

With following patch testcase passes: Index: fold-const.c === --- fold-const.c(Revision 227111) +++ fold-const.c(Arbeitskopie) @@ -2110,6 +2110,17 @@ fold_convert_const (enum tree_code code, tree type else if

Re: [c++-delayed-folding] fold_simple

2015-08-27 12:34 GMT+02:00 Richard Biener richard.guent...@gmail.com: On Thu, Aug 27, 2015 at 11:21 AM, Kai Tietz ktiet...@googlemail.com wrote: 2015-08-27 4:57 GMT+02:00 Jason Merrill ja...@redhat.com: Why does fold_simple fold so many patterns? I thought we wanted something that would just

Re: C++ delayed folding branch review

2015-08-27 4:56 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/24/2015 03:15 AM, Kai Tietz wrote: 2015-08-03 17:39 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/03/2015 05:42 AM, Kai Tietz wrote: 2015-08-03 5:49 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/31/2015 05:54 PM, Kai

Re: [c++-delayed-folding] fold_simple

2015-08-27 4:57 GMT+02:00 Jason Merrill ja...@redhat.com: Why does fold_simple fold so many patterns? I thought we wanted something that would just fold conversions and negations of constant values. Yes, initial variant was handling much less patterns. But actually we need for functions (eg.

Re: C++ delayed folding branch review

Hello Jason, after a longer delay the answer to your question. 2015-08-03 17:39 GMT+02:00 Jason Merrill ja...@redhat.com: On 08/03/2015 05:42 AM, Kai Tietz wrote: 2015-08-03 5:49 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/31/2015 05:54 PM, Kai Tietz wrote: The STRIP_NOPS-requirement

Re: C++ delayed folding branch review

2015-08-03 5:49 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/31/2015 05:54 PM, Kai Tietz wrote: The STRIP_NOPS-requirement in 'reduced_constant_expression_p' I could remove, but for one case in constexpr. Without folding we don't do type-sinking/raising. Right. So binary/unary

Re: C++ delayed folding branch review

2015-07-31 18:14 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/30/2015 10:48 PM, Jeff Law wrote: Note, anything outside of the C/C++ front-ends depending on that canonicalization done by shorten_compare is, IMHO, broken. I think the OMP code isn't relying on it being done by

Re: C++ delayed folding branch review

- Ursprüngliche Mail - On 07/31/2015 12:46 PM, Jakub Jelinek wrote: On Fri, Jul 31, 2015 at 06:25:57PM +0200, Kai Tietz wrote: 2015-07-31 18:14 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/30/2015 10:48 PM, Jeff Law wrote: Note, anything outside of the C/C++ front-ends

Re: C++ delayed folding branch review

- Ursprüngliche Mail - On 07/30/2015 05:00 PM, Kai Tietz wrote: 2015-07-30 18:52 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/29/2015 06:56 PM, Kai Tietz wrote: @@ -13078,6 +13042,8 @@ build_enumerator (tree name, tree value, tree enumtype, tree attributes, if (value

Re: C++ delayed folding branch review

2015-07-30 0:56 GMT+02:00 Kai Tietz ktiet...@googlemail.com: 2015-07-29 19:48 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/28/2015 04:10 PM, Kai Tietz wrote: The change to adjust_temp_type seems to be no more necessary (just doing tests on it). Yes, committed it. @@ -3391,8 +3431,23

Re: C++ delayed folding branch review

2015-07-30 18:52 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/29/2015 06:56 PM, Kai Tietz wrote: @@ -1430,6 +1438,8 @@ cxx_eval_call_expression (const constexpr_ctx *ctx, tree t, bool reduced_constant_expression_p (tree t) { + /* Make sure we remove useless initial

Re: C++ delayed folding branch review

2015-07-29 19:48 GMT+02:00 Jason Merrill ja...@redhat.com: On 07/28/2015 04:10 PM, Kai Tietz wrote: 2015-07-28 1:14 GMT+02:00 Kai Tietz ktiet...@googlemail.com: 2015-07-27 18:51 GMT+02:00 Jason Merrill ja...@redhat.com: I've trimmed this to the previously mentioned issues that still need

Re: C++ delayed folding branch review

2015-07-28 1:14 GMT+02:00 Kai Tietz ktiet...@googlemail.com: 2015-07-27 18:51 GMT+02:00 Jason Merrill ja...@redhat.com: I've trimmed this to the previously mentioned issues that still need to be addressed; I'll do another full review after these are dealt with. Thanks for doing this summary

Re: C++ delayed folding branch review

, Jason Merrill wrote: On 06/12/2015 12:11 PM, Kai Tietz wrote: @@ -1052,6 +1054,9 @@ adjust_temp_type (tree type, tree temp) { if (TREE_TYPE (temp) == type) return temp; + STRIP_NOPS (temp); + if (TREE_TYPE (temp) == type) +return temp; @@ -1430,6 +1438,8

Re: Fold some equal to and not equal to patterns in match.pd

2015-07-24 7:54 GMT+02:00 Jeff Law l...@redhat.com: On 07/23/2015 10:33 AM, Segher Boessenkool wrote: On Thu, Jul 23, 2015 at 10:09:49AM -0600, Jeff Law wrote: It seems to me in these kind of cases that selection of the canonical form should be driven by factors outside of which is better

Re: C++ delayed folding branch review

Hello Jason, Thanks for the review. I addressed a lot of your comments directly on svn-branch. See revision r224439. - Ursprüngliche Mail - Generally, it seems like most of my comments from April haven't been addressed yet. Yes, most of them. @@ -3023,13 +3023,14 @@

[patch c++]: Fix PR 59759

ChangeLog 2015-05-26 Kai Tietz kti...@redhat.com PR c++/59759 * pt.c (unify): Don't ICE on VAR_DECL. Regression tested on x86_64-w64-mingw32. Ok for apply? Regards, Kai Index: pt.c === --- pt.c(Revision 219014) +++ pt.c

Re: C++ delayed folding branch review

2015-04-24 20:25 GMT+02:00 Jason Merrill ja...@redhat.com: On 04/24/2015 09:46 AM, Kai Tietz wrote: Sure, we can use here instead *_fully_fold, but for what costs? In general we need to deal here a simple one-level fold for simplifying constant-values, and/or removing useless type

Re: C++ delayed folding branch review

2015-04-24 6:22 GMT+02:00 Jason Merrill ja...@redhat.com: + expr = fold (expr); /* This may happen, because for LHS op= RHS we preevaluate RHS and create C_MAYBE_CONST_EXPR SAVE_EXPR RHS, which means we could no longer see the code of the EXPR. */ if (TREE_CODE (expr) ==

[patch emutls]:Fix PR 65566

Hi, This patch avoids that we try to operate on function-decl's cfun equal to NULL within lower_emutls_function_body. ChangeLog 2015-03-31 Kai Tietz kti...@redhat.com PR target/65566 * tree-emutls.c (lower_emutls_function_body): Don't try to operate on node's decl function

Re: [patch emutls]:Fix PR 65566

2015-03-31 13:42 GMT+02:00 Jakub Jelinek ja...@redhat.com: On Tue, Mar 31, 2015 at 01:35:56PM +0200, Kai Tietz wrote: Hi, This patch avoids that we try to operate on function-decl's cfun equal to NULL within lower_emutls_function_body. If DECL_STRUCT_FUNCTION (node-decl) is already NULL

Re: [patch c++]: Fix for PR/65390

2015-03-31 14:34 GMT+02:00 Marek Polacek pola...@redhat.com: On Tue, Mar 31, 2015 at 02:32:32PM +0200, Marek Polacek wrote: On Tue, Mar 31, 2015 at 02:25:14PM +0200, Kai Tietz wrote: Hi, I had tried same approach as Marek. For me it solved the PR, but caused other regressions

Re: [patch c++]: Fix for PR/65390

Hi, I had tried same approach as Marek. For me it solved the PR, but caused other regressions on boostrap. So I dropped the way via dependent_type_p. Well, this bootstrap-issue might be caused by some local changes I had forgot to remove, but I doubt it. Marek, have you tried to do a boostrap

[patch libgomp]: Fix PR 64972

Hi, ChangeLog 2015-03-25 Kai Tietz kti...@redhat.com PR libgomp/64972 * oacc-parallel.c (GOACC_parallel): Use PRIu64 if available. (GOACC_data_start): Likewise. * target.c (gomp_map_vars): Likewise. Tested for i686-w64-mingw32. Fix got preapproved by Jakub, so I will commit

Re: Bootstrap broken on trunk, stage 2 gengtype: Internal error: abort in error_at_line, at gengtype.c:112

Hmm, this seems to be something I haven't noticed until now. It might be new ... I see that cp-tree.h is part of gtfiles in config-lang.in. So the warning about being not tagged for that language is weird. Issue might be not directly within gcc. Instead it might be a make issue. You could ask

Re: [patch c++]: Fix for PR/65390

Hello, the problem here is that for cases of vla-array-types, the types don't get finally layouted in build_cplus_array_type. So the type-alignment isn't set in such cases for the resulting type. ChangeLog 2015-03-20 Kai Tietz kti...@redhat.com PR c++/65390 * tree.c (strip_typedefs

Re: [patch c++]: Fix for PR/65390

2015-03-17 13:36 GMT+01:00 Jason Merrill ja...@redhat.com: On 03/16/2015 03:22 PM, Kai Tietz wrote: 2015-03-16 19:07 GMT+01:00 Jason Merrill ja...@redhat.com: If there is an alignment mismatch without user intervention, there is a problem, we can't just ignore it. Where we run into trouble

[patch c++]: Fix for PR/65390

Hi, this patch avoids the attempt to create user-aligned-type for variants original and main-variants type-alignment differ and original type isn't user-aligned. Not sure if this is the preferred variant, we could create for such cases an aligned-type without setting user-align. But as this

Re: [patch c++]: Fix for PR/65390

2015-03-16 19:07 GMT+01:00 Jason Merrill ja...@redhat.com: If there is an alignment mismatch without user intervention, there is a problem, we can't just ignore it. Where we run into trouble is with array types where the version built earlier has not been laid out yet but the new one has

Re: [patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

2015-02-27 14:48 GMT+01:00 H.J. Lu hjl.to...@gmail.com: On Thu, Feb 26, 2015 at 6:49 AM, Kai Tietz ktiet...@googlemail.com wrote: Hi, This is the remaining fix for re-enabling native boostrap for Windows-variant of gcc without disabling -Werror for libgcc. ChangeLog 2015-02-26 Kai Tietz

Re: [patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

Applied at rev.revision 221055. -- Kai

[patch]: Fix Bug 65038 - [regression 5] Unable to find ftw.h for libgcov-util.c

Hi, This is the remaining fix for re-enabling native boostrap for Windows-variant of gcc without disabling -Werror for libgcc. ChangeLog 2015-02-26 Kai Tietz kti...@redhat.com PR target/65038 * config.in: Regenerated. * configure: Likewise. * configure.ac (AC_HEADER_STDC

Re: [patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

2015-02-26 19:53 GMT+01:00 Marek Polacek pola...@redhat.com: On Thu, Feb 26, 2015 at 07:28:02PM +0100, Kai Tietz wrote: Hi, This patch addresses the reported ICE about #pragma weak used on declarations not var or function. ChangeLog 2015-02-26 Kai Tietz kti...@redhat.com * c

[patch c-family]: Fix Bug 35330 - [4.8/4.9/5 regression] ICE with invalid pragma weak

Hi, This patch addresses the reported ICE about #pragma weak used on declarations not var or function. ChangeLog 2015-02-26 Kai Tietz kti...@redhat.com * c-pragma.c (handle_pragma_weak): Do not try to creat weak/alias of declarations not being function, or variable

Re: [C++ PATCH] Fix ICE in C++14 with null RETURN_EXPR (PR c++/65202)

Hi Marek, I have similiar change on the c++-delayed-fold branch. 2015-02-26 13:22 GMT+01:00 Marek Polacek pola...@redhat.com: We ICE on this invalid testcase in C++14 because in C++14 a function returning void is a valid constexpr function, so adl_swap is registered as one, while in C++11 it

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-25 12:35 GMT+01:00 Richard Biener richard.guent...@gmail.com: On Wed, Feb 25, 2015 at 12:05 PM, Kai Tietz ktiet...@googlemail.com wrote: 2015-02-25 11:57 GMT+01:00 Richard Biener richard.guent...@gmail.com: On Wed, Feb 25, 2015 at 11:06 AM, Kai Tietz ktiet...@googlemail.com wrote

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

Hello, So, I did full regression-test for following patch: ChangeLog 2015-02-25 Richard Biener rguent...@suse.de Kai Tietz kti...@redhat.com PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow vect_internal_def without reduction to exit graceful

[patch]: Fix PR target/64212

for clones we want that they getting interposable. Therefore - as suggested by Honza - we need to make explicit sure that we set DECL_DLLIMPORT_P() explicit to 0 in symtab. ChangeLog 2015-02-25 Kai Tietz kti...@redhat.com PR target/64212 * symtab.c (symtab::make_decl_local): Set DECL_IMPORT_P

Re: [patch]: Fix PR target/64212

Applied at revision 22098 to trunk. Jan approved patch on IRC. Regards, Kai

[patch]: Fix regression caused by fix for 61917

Hi, The patch didn't handled the case for dt being vect_constant_def, where of course the reduc_def_stmt is NULL. By checking for NULL before testing for PHI, we now fallback for such cases to old behavior and return in the next if-statment. 2015-02-25 Richard Biener rguent...@suse.de Kai

[patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

Hello, ChangeLog 2015-02-25 Kai Tietz kti...@redhat.com PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow vect_internal_def without reduction to exit graceful. ChagneLog testsuite/ 2015-02-25 Kai Tietz kti...@redhat.com PR tree-optimization

Re: [patch]: [Bug tree-optimization/61917] [4.9/5 Regression] ICE on valid code at -O3 on x86_64-linux-gnu in vectorizable_reduction, at tree-vect-loop.c:4913

2015-02-25 11:57 GMT+01:00 Richard Biener richard.guent...@gmail.com: On Wed, Feb 25, 2015 at 11:06 AM, Kai Tietz ktiet...@googlemail.com wrote: Hello, ChangeLog 2015-02-25 Kai Tietz kti...@redhat.com PR tree-optimization/61917 * tree-vect-loop.c (vectorizable_reduction): Allow

Re: Fix a MinGW warning in libiberty/strerror.c

Hi Eli, patch is reasonable and ok for me. Thanks Kai 2015-01-16 12:18 GMT+01:00 Eli Zaretskii e...@gnu.org: Ping! Date: Fri, 02 Jan 2015 12:54:47 +0200 From: Eli Zaretskii e...@gnu.org When compiling GDB 7.8.1, I get this warning in libiberty: gcc -c -DHAVE_CONFIG_H -O0 -g3

Re: Fix a MinGW warning in libiberty/strerror.c

2015-01-16 12:50 GMT+01:00 Eli Zaretskii e...@gnu.org: Date: Fri, 16 Jan 2015 12:34:25 +0100 From: Kai Tietz ktiet...@googlemail.com Cc: GCC Patches gcc-patches@gcc.gnu.org, gdb-patc...@sourceware.org gdb-patc...@sourceware.org Hi Eli, patch is reasonable and ok for me. Thanks. Do

Re: Unconfirmed boehm-gc test failure

Hi Tom, - Ursprüngliche Mail - Hi Kai, I encountered a test failure in boehm-gc ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64042 'FAIL: boehm-gc.c/gctest.c -O2 execution test' ). I would like to ask somebody to confirm the PR, which hopefully should be as simple as patching

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 0:14 GMT+01:00 Jason Merrill ja...@redhat.com: On 12/18/2014 01:16 PM, Kai Tietz wrote: Well, in general I would have assumed to be able to get alias decl of tmpl. Wasn't able to find a simple way to get it. So, by looking into source I found that most cases handling args tmpl

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 17:46 GMT+01:00 H.J. Lu hjl.to...@gmail.com: Did you forget to check in the testcase? No, see rev 218956. -- H.J.

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-19 18:22 GMT+01:00 Paolo Carlini paolo.carl...@oracle.com: Hi, On 12/19/2014 05:48 PM, Kai Tietz wrote: 2014-12-19 17:46 GMT+01:00 H.J. Lu hjl.to...@gmail.com: Did you forget to check in the testcase? No, see rev 218956. But you want to move it to the cpp0x directory

[patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

Hi, this patch adds handling of aliases within templates and tries to resolve specialization for them. ChangeLog 2014-12-18 Kai Tietz kti...@redhat.com PR c++/61198 * pt.c (retrieve_specialization): Handle using. Tested on x86_64-w64-mingw32. Ok for apply? Regards, Kai ChangeLog

Re: [patch c++]: Fix PR/61198: Crash when selecting specializations through aliases.

2014-12-18 18:26 GMT+01:00 Jason Merrill ja...@redhat.com: On 12/18/2014 10:10 AM, Kai Tietz wrote: + if (TMPL_ARGS_DEPTH (args) TMPL_PARMS_DEPTH (tmpl_parms)) +args = get_innermost_template_args +(args, TMPL_PARMS_DEPTH (tmpl_parms)); It seems unlikely to be correct

Re: [patch c++]: Fix PR/63996

2014-12-15 11:48 GMT+01:00 Paolo Carlini paolo.carl...@oracle.com: ... committed as obvious the below. Paolo. / Thanks Kai

[patch c++]: Fix PR/63996

Hi, The loop-expression loops endless in c++14's case for cases the statement-list isn't constant. Bug 63996 - Infinite loop in invalid C++14 constexpr fn ChangeLog 2014-12-12 Kai Tietz kti...@redhat.com PR c++/63996 * constexpr.c (cxx_eval_loop_expr): Don't loop endless on none

[patch c++]: Fix 61228 - noexcept(expression) causes internal compiler error

Hi, following patch fixes reported issue. Tested for x86_64-w64-mingw32. Ok for apply? Regards, Kai ChangeLog 2014-12-12 Kai Tietz kti...@redhat.com PR c++/61228 * call.c (set_flags_from_callee): Assume no throw by deferred noexcept. 2014-12-12 Kai Tietz kti...@redhat.com

Re: [patch c++]: Fix 61228 - noexcept(expression) causes internal compiler error

2014-12-12 21:15 GMT+01:00 Jason Merrill ja...@redhat.com: I think it would be better to call maybe_instantiate_noexcept so that we can have a definite answer. Jason Hmm, for case that decl != NULL_TREE, this is ok. But what if decl is NULL_TREE? Kai

[patch c++]: Fix PR/64100 'A static assert using the the current class in a noexcept test leads to a segfault'

Hi, The issue is that lookup_destructor calls adjust_result_of_qualified_name_lookup with an NULL_TREE decl (returned by lookup_member). So error-message is missing. As already discussed in bug-tracker: ChangeLog 2014-12-04 Kai Tietz kti...@redhat.com PR c++/64100 * typeck.c

[patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

Hi, this patch fixes an ICE happening on invalid code for c++11. It is reasoned by accessing blindly identifier without checking that it is a declaration. ChangeLog 2014-12-04 Kai Tietz kti...@redhat.com PR c++/64127 * parser.c (cp_parser_diagnose_invalid_type_name): Check id

[patch c++]: Fix PR c++/64106 ICE on valid code

Hi, this patch adds INDIRECT_REF support to cxx_eval_store_expression handling. There is a different variant suggested by Marek, which adds additional operand-0 to ref, which looks to me wrong. ChangeLog gcc/cp 2014-12-04 Kai Tietz kti...@redhat.com PR c++/64106 * constexpr.c

Re: [patch c++]: Fix PR/64100 'A static assert using the the current class in a noexcept test leads to a segfault'

2014-12-04 16:46 GMT+01:00 Marek Polacek pola...@redhat.com: On Thu, Dec 04, 2014 at 04:00:34PM +0100, Kai Tietz wrote: Hi, The issue is that lookup_destructor calls adjust_result_of_qualified_name_lookup with an NULL_TREE decl (returned by lookup_member). So error-message is missing

Re: [patch c++]: Fix PR/64127 ICE on invalid: tree check: exprected identifier_node, have template_id_expr in cp_parser_diagnose_invalid_type_name

2014-12-04 16:47 GMT+01:00 Marek Polacek pola...@redhat.com: On Thu, Dec 04, 2014 at 04:12:02PM +0100, Kai Tietz wrote: Hi, this patch fixes an ICE happening on invalid code for c++11. It is reasoned by accessing blindly identifier without checking that it is a declaration. ChangeLog

  1   2   3   4   5   6   7   8   9   10   >