Re: [google/gcc-4_9] Backport pending patch to fix demangler crash

2014-11-10 Thread Sterling Augustine
On Mon, Nov 10, 2014 at 3:56 PM, Cary Coutant ccout...@google.com wrote: Backport pending upstream patch to fix demangler crash. https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02279.html This patch is for the google/gcc-4_9 branch. Google ref: 17891596 -cary OK for Google branches.

Re: [Google 4.9] Backport of r210828

2014-10-15 Thread Sterling Augustine
On Thu, Oct 9, 2014 at 10:21 AM, Carrot Wei car...@google.com wrote: LGTM. Your description could be more detail, such as which tests on which target. Committed with a much improved message as r216291

[Google 4.9] Backport of r210828

2014-10-07 Thread Sterling Augustine
The enclosed patch for google 4.9 is a backport of r210828 from trunk. googleref:b/14623977 The given tests now pass when run by hand, but timeout under dejagnu I will be sending a different change to fix that. OK for google 4.9? The enclosed patch for google 4.9 is a backport of r210828 from

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-21 Thread Sterling Augustine
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach bar...@tkos.co.il wrote: Hi Sterling, On Mon, Jan 20, 2014 at 12:06:59PM -0800, Sterling Augustine wrote: On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach bar...@tkos.co.il wrote: The xtensa port uses __xtensa_libgcc_window_spill in libgcc

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Sterling Augustine
On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach bar...@tkos.co.il wrote: The xtensa port uses __xtensa_libgcc_window_spill in libgcc to implement __builtin_frame_address. This symbol is local/hidden in libgcc. This is not a problem when linking against static libgcc. But g++ defaults to

Re: [PATCH] libgcc: use linker script for libgcc_s.so on xtensa

2014-01-20 Thread Sterling Augustine
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach bar...@tkos.co.il wrote: Hi Sterling, This is OK for mainline. Thanks. This is needed for the 4.7 and 4.8 branches as well. I assume your copyright assignment is on file? According to

Re: [Patch, xtensa] Add section anchor support for the xtensa backend.

2014-01-14 Thread Sterling Augustine
On Tue, Jan 14, 2014 at 7:20 AM, Felix Yang fei.yang0...@gmail.com wrote: Hi Sterling, I found that we can avoid emitting excessive literal loading instructions with with section anchors. This patch also passed the cases in testsuite/gcc.c-torture/execute/ dir. Please apply it if OK

Re: [Patch, xtensa] Add LOCAL_REGNO to the xtensa backend.

2014-01-14 Thread Sterling Augustine
On Tue, Jan 14, 2014 at 7:14 AM, Felix Yang fei.yang0...@gmail.com wrote: Hi Sterling, The xtensa backend uses register windows, and we need to define LOCAL_REGNO for it. Hi Felix, How does this change the produced code? In particular, please identify a problem this patch is solving. I

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-01-13 Thread Sterling Augustine
On Thu, Jan 9, 2014 at 7:48 PM, Yangfei (Felix) felix.y...@huawei.com wrote: And here is the xtensa configuration tested (include/xtensa-config.h): #define XCHAL_HAVE_BE 0 #define XCHAL_HAVE_LOOPS1 Hi Felix, I like this patch, and expect I will approve it. However,

Re: [PATCH] Add zero-overhead looping for xtensa backend

2014-01-08 Thread Sterling Augustine
On Wed, Jan 8, 2014 at 8:27 AM, Felix Yang fei.yang0...@gmail.com wrote: Hi Sterling, This patch implements zero-overhead looping for xtensa backend using hw-doloop facility. If OK for trunk, please apply it for me. Thanks. Hi Felix, I last worked on zero-overhead loops for Xtensa in

[Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section

2013-12-02 Thread Sterling Augustine
Sterling Augustine saugust...@google.com * dwarf2out.c (output_pubnames): Use comp_unit_die ()-die_offset when there isn't a skeleton die. pubtypes-bug.tot-patch Description: Binary data

Re: [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section

2013-12-02 Thread Sterling Augustine
On Mon, Dec 2, 2013 at 1:59 PM, Cary Coutant ccout...@google.com wrote: This is OK, but your patch also has a local change to contrib/mklog. Please be careful not to commit that. Committed without the contrib/mklog portion. Also committing on google/gcc-4_8 and google/main.

Re: Fwd: [PATCH] Add gdb/gdb-index.h to gcc tree.

2013-10-22 Thread Sterling Augustine
On Fri, Oct 18, 2013 at 4:45 PM, DJ Delorie d...@redhat.com wrote: I'm not sure either, but if it's been approved in gdb and you're willing to cede control of it to gcc's policies, I'm OK with it. Note that this will be a new directory in gcc, and I think the automerge scripts will

[Google 4.8 Patch] For gnu-pubnames, Ignore unrecognized DW_TAGs to match gdb behavior

2013-10-22 Thread Sterling Augustine
I have checked in the enclosed patch, which makes GCC ignore unrecognized DW_TAGs when building gnu-pubnames, instead of ICEing. This matches GDB behavior. Google ref:11307370 Sterling Index: dwarf2out.c === --- dwarf2out.c

Re: [Dwarf Patch] Generate -ggnu-pubnames

2013-10-22 Thread Sterling Augustine
On Thu, Oct 17, 2013 at 12:09 PM, Sterling Augustine saugust...@google.com wrote: The enclosed patch (which depends on http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the new -ggnu-pubnames option from google 4.8 to trunk. -gnu-pubnames enable the gold linker to to generate

Re: [Dwarf Patch] Generate -ggnu-pubnames

2013-10-22 Thread Sterling Augustine
On Tue, Oct 22, 2013 at 12:05 PM, Sterling Augustine saugust...@google.com wrote: On Thu, Oct 17, 2013 at 12:09 PM, Sterling Augustine saugust...@google.com wrote: The enclosed patch (which depends on http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the new -ggnu-pubnames

Fwd: [PATCH] Add gdb/gdb-index.h to gcc tree.

2013-10-18 Thread Sterling Augustine
DJ, Is the below patch your purview? If not, do you know whose it is? Sterling -- Forwarded message -- From: Sterling Augustine saugust...@google.com Date: Thu, Oct 17, 2013 at 11:52 AM Subject: [PATCH] Add gdb/gdb-index.h to gcc tree. To: gcc-patches gcc-patches@gcc.gnu.org, d

[PATCH] Add gdb/gdb-index.h to gcc tree.

2013-10-17 Thread Sterling Augustine
and binutils, and it's addition here has been OK'd by the gdb maintainers. I'm not sure of the proper mechanics for adding a file already in src to gcc, so if this is best done a different way, I'm happy to do so. Thanks, Sterling include/ChangeLog: 2013-10-17 Sterling Augustine saugust

[Dwarf Patch] Generate -ggnu-pubnames

2013-10-17 Thread Sterling Augustine
The enclosed patch (which depends on http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the new -ggnu-pubnames option from google 4.8 to trunk. -gnu-pubnames enable the gold linker to to generate a better .gdb_index section by including various bits of data about the symbol. OK for

[Google 4.8 Patch] Generate gnu-pubnames for definitions only. Not declarations.

2013-10-09 Thread Sterling Augustine
/10191963. Sterling 2013-10-09 Sterling Augustine saugust...@google.com * dwarf2out.c (include_pubname_in_output): Add conditional on is_declaration_die and debug_generate_pubnames. patch.diff Description: Binary data

[Google 4.8 dwarf] Forward port r191163 from Google 4.7

2013-08-13 Thread Sterling Augustine
I have committed the following change from Google 4.7 (which is a typo-fix) as obvious. saugustine@sterling: ~/gcc-google-4_8/gcc/gcc $ svn diff dwarf2out.c Index: dwarf2out.c === --- dwarf2out.c (revision 201717) +++ dwarf2out.c

[Dwarf patch] Refactor logic to decide if a pubname should be output.

2013-07-25 Thread Sterling Augustine
the size field, so the bug was latent. Newer editions of gold will use the size field, exposing the bug. Google has been using a nearly identical patch for some time. OK for trunk? Sterling gcc/ChangeLog 013-07-25 Sterling Augustine saugust...@google.com * dwarf2out.c (size_of_pubnames

[Google 4.8] Fix up size of pubnames in the presence of pruned enumerators

2013-07-15 Thread Sterling Augustine
Hi Cary, Google 4.8 calculates the size of pubnames incorrectly in the presence of pruned enumerators. The logic in size_of_pubnames should match that in output_pubnames. The enclosed patch fixes that. OK for google 4.8? Sterling gcc/ChangeLog 2013-07-12 Sterling Augustine saugust

Re: [Google 4.8] Fix up size of pubnames in the presence of pruned enumerators

2013-07-15 Thread Sterling Augustine
On Mon, Jul 15, 2013 at 9:32 AM, Sterling Augustine saugust...@google.com wrote: Hi Cary, Google 4.8 calculates the size of pubnames incorrectly in the presence of pruned enumerators. The logic in size_of_pubnames should match that in output_pubnames. After some discussion off line, I have

Re: [google/gcc-4_7, google/gcc-4_8] Fix non-deterministic output with -gsplit-dwarf

2013-07-02 Thread Sterling Augustine
On Tue, Jul 2, 2013 at 1:37 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 and google/gcc-4_8 branches. When using -gsplit-dwarf, we use die_checksum to calculate a hash over the compilation unit for the DW_AT_dwo_id attribute. When hashing location

[Google 4.8 Dwarf] Backport .debug_str in .o files with -gsplit-dwarf from trunk (issue9052046)

2013-04-30 Thread Sterling Augustine
The enclosed patch puts strings in the .debug_str section in the .o file with -gsplit-dwarf. It is backported from from trunk (which, in turn, was ported from google_4.7). http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01355.html The patch itself is no different from the one finally applied to

Re: [Google 4.8 Dwarf] Backport .debug_str in .o files with -gsplit-dwarf from trunk (issue9052046)

2013-04-30 Thread Sterling Augustine
On Tue, Apr 30, 2013 at 4:47 PM, Cary Coutant ccout...@google.com wrote: The enclosed patch puts strings in the .debug_str section in the .o file with -gsplit-dwarf. It is backported from from trunk (which, in turn, was ported from google_4.7).

[Dwarf Patch] Create .debug_str section in .o with -gsplit-dwarf (issue8540048)

2013-04-23 Thread Sterling Augustine
and not observing new failures. OK for trunk? Sterling 2013-04-22 Sterling Augustine saugust...@google.com * dwarf2out.c (skeleton_debug_str_hash, comp_dir_string, add_skeleton_AT_string. comp_dir_string, debug_str_dwo_section): New. (DEBUG_STR_DWO_SECTION): Rename

Re: [Google 4.7 Split Dwarf] Use .debug_str for some strings. (issue7241067)

2013-02-04 Thread Sterling Augustine
On Mon, Feb 4, 2013 at 11:56 AM, Cary Coutant ccout...@google.com wrote: @@ -22385,21 +22448,21 @@ static void output_indirect_strings (void) { + switch_to_section (debug_str_section); if (!dwarf_split_debug_info) -{ - switch_to_section (debug_str_section); -

Re: [Google 4.7 Split Dwarf] Use .debug_str for some strings. (issue7241067)

2013-02-04 Thread Sterling Augustine
On Mon, Feb 4, 2013 at 1:45 PM, Cary Coutant ccout...@google.com wrote: Ahh, good catch. Fixed as attached. Looks good, thanks. OK for the google/gcc-4_7 branch. (And, yes, please do port this to trunk when Stage 1 reopens.) Thanks. Committed.

[Google 4.7 Split Dwarf] Use .debug_str for some strings. (issue7241067)

2013-02-01 Thread Sterling Augustine
The enclosed patch for Google 4.7 is an optimization for debug strings under -gsplit-dwarf. Currently under -gsplit-dwarf, all strings with DW_FORM_strp end up in the .debug_str.dwo section, which requires any string not destined for the .dwo to use DW_FORM_string, disallowing any duplication

[Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)

2013-01-18 Thread Sterling Augustine
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c Author: Sterling Augustine saugust...@google.com Date: Fri Jan 18 10:38:30 2013 -0800 Fix for Google Ref: b/8028506 Calling find_AT_string can resize the debug_str hash table, even if the string is already present in the hash

Re: [Google 4.7] Fix for Google Ref: b/8028506 (issue7142053)

2013-01-18 Thread Sterling Augustine
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant ccout...@google.com wrote: commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c Author: Sterling Augustine saugust...@google.com Date: Fri Jan 18 10:38:30 2013 -0800 Fix for Google Ref: b/8028506 Calling find_AT_string can resize

Re: [google 4.7] Fix for PR 8013197 (issue7140044)

2013-01-17 Thread Sterling Augustine
On Wed, Jan 16, 2013 at 4:21 PM, Cary Coutant ccout...@google.com wrote: 2013-01-16 Sterling Augustine saugust...@google.com * gcc/dwarf2out.c (resolve_addr): Delete call to remove_addr_table_entry. OK for google/gcc-4_7. The commit log entry should say Google ref: b

Re: [Google 4.7] Backport upstream fission changes (issue6852101)

2012-12-04 Thread Sterling Augustine
On Thu, Nov 29, 2012 at 10:26 AM, Sterling Augustine saugust...@google.com wrote: This patch backports to gcc-google-4_7 the many changes to the fission implementation required to merge fission into trunk. Committed as posted. Thanks!

re: [Bug debug/55328] ICE: in output_addr_table_entry, at dwarf2out.c:21780 with -gsplit-dwarf

2012-11-14 Thread Sterling Augustine
Thanks for testing this. Enclosed is a simple fix for this ICE--address_table_entries that have zero refcounts shouldn't be assigned an index. OK for trunk? Sterling 2012-11-14 Sterling Augustine saugust...@google.com * dwarf2out.c (index_address_table_entry): Check a node's

Re: [Bug debug/55328] ICE: in output_addr_table_entry, at dwarf2out.c:21780 with -gsplit-dwarf

2012-11-14 Thread Sterling Augustine
On Wed, Nov 14, 2012 at 3:19 PM, Cary Coutant ccout...@google.com wrote: Enclosed is a simple fix for this ICE--address_table_entries that have zero refcounts shouldn't be assigned an index. OK for trunk? Sterling 2012-11-14 Sterling Augustine saugust...@google.com

Re: [Dwarf Fission] Implement Fission Proposal (issue6305113)

2012-11-06 Thread Sterling Augustine
Dominique I'm testing the enclosed patch on my end. Does it happen to work for you? Sterling 2012-11-06 Sterling Augustine saugust...@google.com * dwarf2out.c (output_comdat_type_unit): Check for OBJECT_FORMAT_ELF. newpatch.diff Description: Binary data

Re: [Dwarf Fission] Implement Fission Proposal (issue6305113)

2012-11-06 Thread Sterling Augustine
On Tue, Nov 6, 2012 at 5:02 PM, Dominique Dhumieres domi...@lps.ens.fr wrote: I'm testing the enclosed patch on my end. Does it happen to work for you? I am now past the previous error. Full answer tomorrow morning. Thanks Dominique I have committed the above fix as obvious. If there is

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-01 Thread Sterling Augustine
Hi Jakub, I would like to get the fission implementation in before stage 1. It has been under review for some time, and is awaiting another round of review now. More info here: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html Sterling

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-11-01 Thread Sterling Augustine
Hi Jakub, I would like to get the fission implementation in before stage 1. It has been under review for some time, and is awaiting another round of review now. More info here: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html Sterling

re: [Dwarf Fission] Implement Fission Proposal (issue6305113)

2012-10-31 Thread Sterling Augustine
Hi Jason, Just wanted to be sure you saw this. I'm hoping to get it in for stage 1. http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html Sterling

Re: [google/gcc-4_7] Fix problem with asm spec for -gsplit-dwarf

2012-09-12 Thread Sterling Augustine
On Wed, Sep 12, 2012 at 4:18 PM, Cary Coutant ccout...@google.com wrote: 2012-09-12 Cary Coutant ccout...@google.com gcc/ * gcc.c (replace_extension_spec_func): Restrict search for extension to last component of path. Index: gcc/gcc.c

[Google 4.7] Fix static bit for C++ structs in gdb-index v7 (issue6506098)

2012-09-11 Thread Sterling Augustine
The enclosed patch fixes yet another bug with the gdb-index v7 flag byte by reporting certain structs and types as static only for non-C++ and non-java. OK for Google 4.7? Sterling 2012-09-11 Sterling Augustine saugust...@google.com * dwarf2out.c (output_pubname): Index: dwarf2out.c

Re: [Google 4.7] Fix static bit for C++ structs in gdb-index v7 (issue6506098)

2012-09-11 Thread Sterling Augustine
On Tue, Sep 11, 2012 at 5:13 PM, Cary Coutant ccout...@google.com wrote: The enclosed patch fixes yet another bug with the gdb-index v7 flag byte by reporting certain structs and types as static only for non-C++ and non-java. OK for Google 4.7? Sterling 2012-09-11 Sterling Augustine

Re: [PATCH 5/6] Thread pointer built-in functions, xtensa [PING]

2012-09-10 Thread Sterling Augustine
On Sun, Sep 9, 2012 at 11:31 PM, Chung-Lin Tang clt...@codesourcery.com wrote: On 2012/8/28 下午 04:15, Chung-Lin Tang wrote: On 12/7/12 下午2:52, Chung-Lin Tang wrote: Xtensa parts updated to use MD pattern. Thanks, Chung-Lin * config/xtensa/xtensa.md (get_thread_pointersi): Renamed

[Google 4.7] Fix is_static in gdb index generation (issue6498114)

2012-09-10 Thread Sterling Augustine
The enclosed patch fixes a reversed conditional when calculating the is_static flag while generating gdb index--is_static is the opposite of the DW_AT_external flag. OK for google 4.7? Sterling 2012-09-10 Sterling Augustine saugust...@google.com * dwarf2out.c (output_pubname

Re: [Google 4.7] Fix is_static in gdb index generation (issue6498114)

2012-09-10 Thread Sterling Augustine
On Mon, Sep 10, 2012 at 3:05 PM, Cary Coutant ccout...@google.com wrote: The enclosed patch fixes a reversed conditional when calculating the is_static flag while generating gdb index--is_static is the opposite of the DW_AT_external flag. OK for google 4.7? Sterling 2012-09-10 Sterling

[Google 4.7 Pubnames] Use comp_unit_die offset when no skeleton die exists. (issue6501109)

2012-09-07 Thread Sterling Augustine
of the comp_unit_die instead. This problem doesn't exist in later editions of the code because GCC has been patched to ensure that all pubtypes will have a skeleton die. So this is for Google 4.7 only. OK for Google 4.7? Sterling 2012-09-07 Sterling Augustine saugust...@google.com * gcc

Re: [Google 4.7 Pubnames] Use comp_unit_die offset when no skeleton die exists. (issue6501109)

2012-09-07 Thread Sterling Augustine
On Fri, Sep 7, 2012 at 3:44 PM, Cary Coutant ccout...@google.com wrote: 2012-09-07 Sterling Augustine saugust...@google.com * gcc/dwarf2out.c (output_pubnames): Call comp_unit_die. OK for google/gcc-4_7. -cary Committed as r191084.

re: [google/gcc-4_7] Fix GDB test suite regression with -fdebug-types-section patch

2012-09-04 Thread Sterling Augustine
On Sat, Sep 1, 2012 at 1:44 PM, gcc-patches-digest-h...@gcc.gnu.org wrote: From: ccout...@google.com (Cary Coutant) To: d...@google.com, gcc-patches@gcc.gnu.org Cc: Date: Fri, 31 Aug 2012 16:55:40 -0700 (PDT) Subject: [google/gcc-4_7] Fix GDB test suite regression with

Re: [google/gcc-4_7, trunk] Fix problem with -fdebug-types-section and template instantiations, take 2

2012-08-29 Thread Sterling Augustine
On Wed, Aug 29, 2012 at 12:03 PM, Cary Coutant ccout...@google.com wrote: This patch is for trunk and the google/gcc-4_7 branch. 2012-08-28 Cary Coutant ccout...@google.com * gcc/dwarf2out.c (clone_tree_partial): Remove. (copy_decls_walk): Don't copy children of a

re: [google/gcc-4_7, trunk] Fix problem with -fdebug-types-section and template instantiations

2012-08-27 Thread Sterling Augustine
Google ref b/7041390. 2012-08-25 Cary Coutant ccout...@google.com gcc/ * dwarf2out.c (is_template_instantiation): New function. (should_move_die_to_comdat): Reject types that are template instantiations. This patch is OK for google 4.7 Sterling

Re: [Google 4.7] Generate pubnames compatible with gdb-index version 7. (issue6459099)

2012-08-20 Thread Sterling Augustine
On Thu, Aug 16, 2012 at 5:32 PM, Cary Coutant ccout...@google.com wrote: +/* Output a single entry in the pubnames table. */ + +static void +output_pubname (dw_offset die_offset, pubname_entry *entry) For this function, I'd suggest a comment to the effect that the logic is lifted from GDB.

Re: [google/gcc-4_7] Fix ICEs with -gfission.

2012-08-20 Thread Sterling Augustine
On Mon, Aug 20, 2012 at 5:30 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. When a location list or location expression is removed from a DIE, we need to remove entries in the .debug_addr table that were referenced by those location expressions.

[Google 4.7 Obvious] Fix trailing enumerator comma

2012-08-20 Thread Sterling Augustine
My last change to google 4.7 that included gdb/gdb-index.h as it exists in binutils, but it included a trailing comma in an enumerator. I have checked in as obvious the patch below which eliminates the trailing comma. Sterling 2012-08-20 Sterling Augustine saugust...@google.com

Re: PATCH: Replace target MEMBER_TYPE_FORCES_BLK macro with a target hook

2012-08-17 Thread Sterling Augustine
On Fri, Aug 17, 2012 at 6:59 AM, David Edelsohn dje@gmail.com wrote: On Fri, Aug 17, 2012 at 9:39 AM, H.J. Lu hjl.to...@gmail.com wrote: Here is the updated patch. Steve, David, Sterling, can you take a look at ia64, rs6000 and xtensa changes? * config/rs6000/rs6000.c

Re: [google/gcc-4_7] Fix ICE in output_pubnames where union contains a ctor

2012-08-17 Thread Sterling Augustine
On Fri, Aug 17, 2012 at 3:09 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. I'll submit it for trunk after the Fission patches have gone in. When adding names to the pubnames table (-gsplit-dwarf or -gpubnames), a method within a union may not get

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-08-13 Thread Sterling Augustine
On Sun, Aug 12, 2012 at 12:46 PM, Jack Howarth howa...@bromo.med.uc.edu wrote: This patch introduces the regressions... FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler .section\t.debug_pubnames FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler _GLOBAL__sub_I__ZN3one3c1vE0+[

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-08-13 Thread Sterling Augustine
On Sun, Aug 12, 2012 at 12:46 PM, Jack Howarth howa...@bromo.med.uc.edu wrote: On Sun, Jul 01, 2012 at 09:33:06AM -0500, Gabriel Dos Reis wrote: On Thu, Jun 28, 2012 at 12:50 PM, Sterling Augustine saugust...@google.com wrote: The enclosed patch adds a fix for the pubnames anonymous

Re: [google/gcc-4_7] Compute dwo_id for Fission (issue6442047)

2012-07-26 Thread Sterling Augustine
On Wed, Jul 25, 2012 at 5:06 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Compute a dwo_id and write the DW_AT_GNU_dwo_id attribute to both the skeleton compile unit DIE and the DWO compile unit DIE. This is OK for google 4.7. Sterling

Re: [google/gcc-4_7] Add -gfission as alias for -gsplit-dwarf (issue6444043)

2012-07-25 Thread Sterling Augustine
On Tue, Jul 24, 2012 at 5:51 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Add -gfission as alias for -gsplit-dwarf. Tested by bootstrap and regression testing. * common.opt (-gfission): Alias for -gsplit-dwarf. (-gno-fission):

Re: [google/gcc-4_7] Output DW_AT_high_pc as constant (issue6453046)

2012-07-25 Thread Sterling Augustine
On Wed, Jul 25, 2012 at 11:45 AM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Backport pending upstream patch to output DW_AT_high_pc as a constant instead of a relocated address. This significantly reduces the number of entries used in the

Re: [Dwarf Fission] Implement Fission Proposal (issue6305113)

2012-07-25 Thread Sterling Augustine
On Wed, Jul 25, 2012 at 4:00 PM, Cary Coutant ccout...@google.com wrote: +/* Remove an entry from the addr table. Since we have already numbered + all the entries, the best we can do here is null it out. */ This sounds like a design flaw. Since we have everything in memory, there's no

Re: [google/gcc-4_7] Backport pending Fission patch (issue6443043)

2012-07-24 Thread Sterling Augustine
On Tue, Jul 24, 2012 at 5:08 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_7 branch. Backport Fission patches from trunk at r186934, r187061, and r188759. Backport pending Fission patch at http://codereview.appspot.com/6305113. Patches for include/dwarf2.def

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-07-10 Thread Sterling Augustine
On Tue, Jul 10, 2012 at 6:51 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: Hi Sterling, On x86_64-apple-darwin10 the test fails with FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler .section\t.debug_pubnames FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler

Re: [C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-07-09 Thread Sterling Augustine
Committed as posted. Thanks. On Sun, Jul 1, 2012 at 7:33 AM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Thu, Jun 28, 2012 at 12:50 PM, Sterling Augustine saugust...@google.com wrote: The enclosed patch adds a fix for the pubnames anonymous namespaces contained within named

[Obvious] Add previously approved comment

2012-06-29 Thread Sterling Augustine
Enclosed is a patch that fixes indention and adds an already-approved comment that I missed when porting the previous patch. I have checked it in under the obvious rule. Sterling obvious.patch Description: Binary data

[C++ Pubnames Patch] Anonymous namespaces enclosed in named namespaces. (issue6343052)

2012-06-28 Thread Sterling Augustine
. OK for mainline? Sterling gcc/cp/ChangeLog 2012-06-28 Sterling Augustine saugust...@google.com * error.c (lang_decl_name): Use TFF_UNQUALIFIED_NAME flag. gcc/testsuite/ChangeLog 2012-06-28 Sterling Augustine saugust...@google.com * g++.dg/debug/dwarf2/pubnames-2.C: New

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-26 Thread Sterling Augustine
Committed as posted. On Mon, Jun 25, 2012 at 8:35 PM, Jason Merrill ja...@redhat.com wrote: OK. Jason

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-26 Thread Sterling Augustine
On Mon, Jun 25, 2012 at 7:13 PM, Mike Stump mikest...@comcast.net wrote: On Jun 25, 2012, at 3:15 PM, Sterling Augustine wrote: On Sat, Jun 23, 2012 at 3:55 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: As I don't have access to a Darwin machine to test a fix, would you mind updating

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-25 Thread Sterling Augustine
On Sat, Jun 23, 2012 at 3:55 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: As I don't have access to a Darwin machine to test a fix, would you mind updating the test? The failures are gone with the obvious patch: diff -up ../_clean/gcc/testsuite/gcc.dg/pubtypes-2.c

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-25 Thread Sterling Augustine
it whichever way you want. Let me know, Sterling gcc/ChangeLog 2012-06-25 Sterling Augustine saugust...@google.com * dwarf2out.c (output_pubnames): Add check for DW_TAG_enumerator. (prune_unused_types): Add check for DW_TAG_enumerator. enum.patch Description: Binary data

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-22 Thread Sterling Augustine
On Fri, Jun 22, 2012 at 2:47 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: I've heard reports of new test failures due to this patch: FAIL: gcc.dg/pubtypes-2.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[ \\t]+Length of Public Type Names Info FAIL: gcc.dg/pubtypes-3.c scan-assembler

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-22 Thread Sterling Augustine
-22 Sterling Augustine sagust...@google.com * dwarf2out.c (add_enumerator_pubname): Use pubtypes_table.

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-22 Thread Sterling Augustine
On Fri, Jun 22, 2012 at 2:47 AM, Dominique Dhumieres domi...@lps.ens.fr wrote: I've heard reports of new test failures due to this patch: FAIL: gcc.dg/pubtypes-2.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[ \\t]+Length of Public Type Names Info FAIL: gcc.dg/pubtypes-3.c scan-assembler

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-21 Thread Sterling Augustine
Committed as attached. Thanks for your reviews. Sterling gcc/ChangeLog 2012-06-21 Sterling Augustine saugust...@google.com Cary Coutant ccout...@google.com * dwarf2out.c (is_cu_die, is_namespace_die, is_class_die, add_AT_pubnames, add_enumerator_pubname

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-19 Thread Sterling Augustine
On Wed, Jun 13, 2012 at 10:47 PM, Jason Merrill ja...@redhat.com wrote: On 06/13/2012 04:26 PM, Sterling Augustine wrote: I lean toward -g myself, since there doesn't seem to be a strong rule one way or the other. Unless there are further comments, I'll stick with -g then. I think

[Dwarf Patch] Improve pubnames and pubtypes generation. (issue6197069)

2012-06-14 Thread Sterling Augustine
the comdat_type_p field. It sticks with -gpubnames as earlier discussed. Anything else? Sterling 2012-06-14 Sterling Augustine saugust...@google.com Cary Coutant ccout...@google.com * dwarf2out.c (is_cu_die, is_namespace_die, is_class_die, add_AT_pubnames

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-13 Thread Sterling Augustine
I lean toward -g myself, since there doesn't seem to be a strong rule one way or the other. Unless there are further comments, I'll stick with -g then. I think that covers all the comments, so I think I will commit this Friday morning unless I hear anything further. Sterling

Re: [Google 4.6] Backport C++ canonicalization patch (issue6297080)

2012-06-12 Thread Sterling Augustine
On Tue, Jun 12, 2012 at 9:36 AM, Diego Novillo dnovi...@google.com wrote: On 12-06-12 11:58 , Sterling Augustine wrote: +/* Wrap lang_decl_name with options appropriate for dwarf.  */ + +const char * +lang_decl_dwarf_name (tree decl, int v, bool translate) +{ +  const char *name

Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-12 Thread Sterling Augustine
On Fri, Jun 8, 2012 at 3:03 PM, Sterling Augustine saugust...@google.com wrote: [Regarding generating pubnames] OK, I've updated the patch with all these additional comments. Just waiting on the decision between -f and -g. I'll repost and then commit it when that is settled--hopefully soon

Re: [google/gcc-4_6] Fix to use correct form for DW_AT_low_pc in compile_unit DIE. (issue6298055)

2012-06-07 Thread Sterling Augustine
On Wed, Jun 6, 2012 at 11:23 PM, Cary Coutant ccout...@google.com wrote: This patch is for the google/gcc-4_6 branch. In porting the earlier patch to use constant forms for DW_AT_high_pc, the code in dwarf2out_finish was inadvertently changed to use an indirect form for DW_AT_low_pc in the

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-06 Thread Sterling Augustine
On Wed, Jun 6, 2012 at 3:49 PM, Steven Bosscher stevenb@gmail.com wrote: On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine saugust...@google.com wrote: On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-04 Thread Sterling Augustine
On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine saugust...@google.com wrote: After finding yet another bug in the previous patch dealing with pretty-printing decls for dwarf in canonical form, I have

Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)

2012-06-01 Thread Sterling Augustine
to generate pubtypes even if the target disables them by default. Tested with bootstrap and running the test_pubnames_and_indices.py script recently contributed to the GDB project. OK for mainline? Sterling 2012-05-10 Sterling Augustine saugust...@google.com Cary Coutant ccout

[C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-01 Thread Sterling Augustine
cxx_dwarf_name with new functions that set the appropriate flag on the pretty printer. This is much cleaner and avoids the need for translating flags for C++ pretty-printing into standard C pretty printing flags. OK for mainline? Sterling 2012-06-01 Sterling Augustine saugust...@google.com * gcc

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-05-30 Thread Sterling Augustine
On Wed, May 30, 2012 at 2:15 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Tue, May 29, 2012 at 5:32 PM, Sterling Augustine saugust...@google.com wrote: Index: gcc/c-family/c-pretty-print.h === --- gcc/c-family/c

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-05-29 Thread Sterling Augustine
On Wed, May 16, 2012 at 1:03 PM, Sterling Augustine saugust...@google.com wrote: This patch adds new flags and defines such that the C++ decl pretty printer prints both canonical dwarf names for decls without perturbing normal error message output. It addresses the issues with the earlier

Re: [Dwarf Patch] Improve pubnames and pubtypes generation. (issue 6197069)

2012-05-22 Thread Sterling Augustine
On Tue, May 22, 2012 at 10:19 AM, Jason Merrill ja...@redhat.com wrote: I'll let Cary handle the other questions. Yes, I agree that we want to put some_function in pubnames.  I still don't see how putting the anonymous namespace itself in pubnames helps at all.  As far as pubnames is

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-05-21 Thread Sterling Augustine
On Wed, May 16, 2012 at 1:03 PM, Sterling Augustine saugust...@google.com wrote: This patch adds new flags and defines such that the C++ decl pretty printer prints both canonical dwarf names for decls without perturbing normal error message output. It addresses the issues with the earlier

Re: [Dwarf Patch] Improve pubnames and pubtypes generation. (issue6197069)

2012-05-17 Thread Sterling Augustine
On Thu, May 10, 2012 at 9:08 AM, Sterling Augustine saugust...@google.com wrote: The enclosed patch fixes many issues with pubnames and pubtypes. It generates them for many more variables and with mostly correct and canonical dwarf names. This patch should not affect any target that does

[C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-05-16 Thread Sterling Augustine
? Sterling 2012-05-16 Sterling Augustine saugust...@google.com * gcc/c-family/c-pretty-print.h (pp_c_flag_gnu_v3): New enumerator. * gcc/c-family/c-pretty-print.c (pp_c_specifier_qualifier_list): Check it at both the start and end of the function. * gcc/cp/cp

[Dwarf Patch] Improve pubnames and pubtypes generation. (issue6197069)

2012-05-10 Thread Sterling Augustine
patch in to the front end under review at http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00512.html. Tested with bootstrap and running the test_pubnames_and_indices.py script recently contributed to the GDB project. OK for mainline? Sterling 2012-05-10 Sterling Augustine saugust...@google.com

Re: [C++ Patch and pubnames 2/2] Adjust c decl pretty printer to match demangler (issue6195056)

2012-05-08 Thread Sterling Augustine
On Mon, May 7, 2012 at 6:44 PM, Gabriel Dos Reis g...@integrable-solutions.net wrote: On Mon, May 7, 2012 at 7:10 PM, Sterling Augustine saugust...@google.com wrote: This is the second in the series of patches to make c decl pretty printing more closely match the demangler. A full explanation

[C++ Patch and pubnames 1/2] Adjust testsuite results to match demangler (issue6205043)

2012-05-07 Thread Sterling Augustine
with the second patch in this series by running the testsuite and observing no regresssions other than those fixed by this patch. OK for mainline? Sterling 2012-05-07 Sterling Augustine saugust...@google.com * gcc/testsuite/g++.old-deja/g++.pt/memtemp77.C (int main): Adjust

[C++ Patch and pubnames 2/2] Adjust c decl pretty printer to match demangler (issue6195056)

2012-05-07 Thread Sterling Augustine
This is the second in the series of patches to make c decl pretty printing more closely match the demangler. A full explanation is here: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00512.html OK for mainline? Sterling 2012-05-07 Sterling Augustine saugust...@google.com * c-family

[Google 4.6 Fission] Skeleton debug info sections don't have siblings

2012-04-20 Thread Sterling Augustine
Hello, This patch for google 4.6 stops gcc from emitting end-of-sibling markers for skeleton debug info sections, which don't have siblings. This fixes an errors reported by readelf. OK for google 4.6? Sterling 2012-04-20 Sterling Augustine saugust...@google.com * gcc/dwarf2out.c

Re: [Google 4.6 Fission] Skeleton debug info sections don't have siblings

2012-04-20 Thread Sterling Augustine
This time with the patch included. Sterling On Fri, Apr 20, 2012 at 3:51 PM, Sterling Augustine saugust...@google.com wrote: Hello, This patch for google 4.6 stops gcc from emitting end-of-sibling markers for skeleton debug info sections, which don't have siblings. This fixes an errors

Dwarf location list base address entry

2012-04-19 Thread Sterling Augustine
Hi, Under what circumstances does gcc emit a base address selection entry for a dwarf location list? I've looked at the code, and think the answer is never, but perhaps I'm missing something, and I want to be sure. Thanks, Sterling

  1   2   >