On Fri, 17 Jan 2020, Joel Brobecker wrote:
> Do open a GitHub issue if you'd like me to add this check to
> the git-hooks. I will likely give it less priority because
> you'll have a way to implement it on your on, but I will get to it
> eventually.
I think
> A quick run of the testsuite reveals that this assumption is made
> all over. I am opposed to having this feature be a standard feature
> of the git-hooks, so you wouldn't have to add an ad hoc check.
> The way I would do it is by enhancing the git_run function to check
> for a parameter named
> Unfortunately, that's not as simple to implement as I'd hoped, because
> git.py:git_run removes all leading and trailing whitespace from the output
> of the git command it runs, so the code checking commit messages can't
> tell whether there was whitespace at the start of the first line (or
On Tue, 14 Jan 2020, Joseph Myers wrote:
> On Tue, 14 Jan 2020, Jakub Jelinek wrote:
>
> > (untested), another, suggested by Richard on IRC, would be to reject
> > commits where the first line starts with whitespace.
>
> I'd suggest making the hooks reject whitespace at the start of the first
On Tue, 14 Jan 2020, Jakub Jelinek wrote:
> (untested), another, suggested by Richard on IRC, would be to reject
> commits where the first line starts with whitespace.
I'd suggest making the hooks reject whitespace at the start of the first
line of the commit message.
--
Joseph S. Myers
Hi!
I've noticed that a couple of Jason's commits show up in gcc-cvs
in mutt as:
[gcc r10-5937] ?PR c++/92582 - ICE with member template as requirement.
The ? in there comes from a tab character, the full subject is like
Subject:
