https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69443
Yury Gribov changed:
What|Removed |Added
CC||y.gribov at samsung dot com
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70573
--- Comment #9 from Yury Gribov ---
Better do the same for halt_on_error-2.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70573
--- Comment #7 from Yury Gribov ---
Right. Dominique, can you check if s/memset/__builtin_memset/g fixes the issue?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70573
--- Comment #5 from Yury Gribov ---
Created attachment 38213
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=38213=edit
Proposed patch
Ah, so the problem is caused by _FORTIFY_SOURCE being enabled on Darwin by
default. This check precedes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70573
--- Comment #3 from Yury Gribov ---
Problem is that we don't have access to Darwin hardware. Perhaps you could get
a failing stacktrace via gdb?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70573
Yury Gribov changed:
What|Removed |Added
CC||y.gribov at samsung dot com
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67425
--- Comment #5 from Yury Gribov ---
Martin, is this better now? Could you close the bug?
,
||y.gribov at samsung dot com
--- Comment #1 from Yury Gribov ---
Cc Max.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67425
Yury Gribov changed:
What|Removed |Added
CC||y.gribov at samsung dot com
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68988
--- Comment #1 from Yury Gribov ---
The bug was detected with SortChecker tool (https://github.com/yugr/sortcheck).
Component: rtl-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: vmakarov at redhat dot com
Target Milestone: ---
One of the comparisons in reload_pseudo_compare_func violates the transitivity
axiom (i.e. x < y &
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68751
--- Comment #5 from Yury Gribov ---
You most probably can't.
,
||kcc at gcc dot gnu.org,
||y.gribov at samsung dot com
--- Comment #1 from Yury Gribov ---
Added sancov guys.
,
||y.gribov at samsung dot com
--- Comment #1 from Yury Gribov ---
Correction - this is not ASan but UBSan. Summoning Marek.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68016
--- Comment #10 from Yury Gribov ---
> This happens because in LLVM case ASan changes symbols size
> ('f' in our case) and just breaks ABI for the library.
I've filed an upstream bug about this
https://github.com/google/sanitizers/issues/619
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67513
--- Comment #7 from Yury Gribov ---
FYI I'd prefer to keep current BIT_IOR_EXPR approach in asan_expand_check_ifn
as it allows for efficient implementation for ARM targets (as compared to two
successive branches currently used in LLVM).
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67513
--- Comment #1 from Yury Gribov ---
(In reply to Andrey Ryabinin from comment #0)
> (shadow value is usually zero).
What makes you think so? AFAIU for less-than-8-byte scalars it's always
non-zero. I vaguely remember than Kostya did something
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67368
--- Comment #2 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Richard Biener from comment #1)
so it fails on purpose (not sure why though). And it ignores always-inline.
I wonder if we should, for always-inline functions, inline
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: v.garbuzov at samsung dot com
Target Milestone: ---
Invalid or incomplete unwind tables may cause generation of random invalid
pointers which cause libgcc unwinders to access unmapped
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67286
--- Comment #5 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Dmitry Vyukov from comment #4)
+eugeni can provide more details.
Please! E.g. how do you build compiler and runtime?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67286
--- Comment #10 from Yury Gribov y.gribov at samsung dot com ---
(In reply to weiguo.zhou from comment #9)
as I explained just now, after generate the final cross-compile toolchain
for android/arm32 successfully, the last step is generate
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67286
--- Comment #7 from Yury Gribov y.gribov at samsung dot com ---
(In reply to weiguo.zhou from comment #6)
It seems Google's official docs indicate the asan only supported on Android
with LLVM-based clang toolchain.
That was my impression
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67286
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67204
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67204
--- Comment #9 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Dmitry Vyukov from comment #8)
(In reply to Manuel López-Ibáñez from comment #7)
I'm not saying that anyone should stop working on what they are doing to
implement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67204
--- Comment #10 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Marek Polacek from comment #5)
(In reply to smagnet from comment #3)
Moreover, the undefined behavior sanitizer runtime options (UBSAN_OPTIONS,
as described here
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66908
--- Comment #1 from Yury Gribov y.gribov at samsung dot com ---
Looks like -fsanitize=bounds may introduce uninitialized variables when run
after shift.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66880
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66514
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
--- Comment #15 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Thierry Reding from comment #14)
Thanks Yury.
Np, you are welcome.
@Harald: could you close the bug if it works for you?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
--- Comment #17 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Geoff Nixon from comment #16)
what I should use to patch against the release?
Or is there a different set of changes
specific to the 5.1 branch backport?
For 5.1
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
--- Comment #12 from Yury Gribov y.gribov at samsung dot com ---
I'm using your patch applied to 5.1.0 without issues on my system without
xdr.h.
That's probably ok, thanks. I'll submit on Monday then (to be online if
problems arise).
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
--- Comment #10 from Yury Gribov y.gribov at samsung dot com ---
Did libsanitizer build for you both with and without xdr.h? If yes, I'll just
go ahead and submit this.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61547
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64741
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65749
--- Comment #3 from Yury Gribov y.gribov at samsung dot com ---
@Kostya: I suggest to mention this in ASan FAQ.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65749
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
--- Comment #4 from Yury Gribov y.gribov at samsung dot com ---
Finally fixed upstream in
https://github.com/llvm-mirror/compiler-rt/commit/d09b23010698144d10cba0dacc5c599f230cbf62
. Does anyone have time to backport to GCC 5?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64998
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64996
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #39 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Jakub Jelinek from comment #36)
(In reply to Yury Gribov from comment #35)
(In reply to Kostya Serebryany from comment #34)
Frankly, I am not at all motivated
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #32 from Yury Gribov y.gribov at samsung dot com ---
Or (probably less intrusive) add detect_odr_violation=0 to ASAN_OPTIONS
config/bootstrap-asan.mk.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #35 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Kostya Serebryany from comment #34)
Frankly, I am not at all motivated to do any significant surgery in the llvm
compiler instrumentation because for me everything
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64820
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64742
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64741
--- Comment #1 from Yury Gribov y.gribov at samsung dot com ---
*** Bug 64742 has been marked as a duplicate of this bug. ***
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org,
ryabinin.a.a at gmail dot com
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org,
ryabinin.a.a at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64330
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
If executable
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64234
--- Comment #2 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Jakub Jelinek from comment #1)
I think we can only recommend not to do that
For legacy codebase (e.g. when sanitizing full distributions) you often don't
have a choice
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64234
--- Comment #4 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Jakub Jelinek from comment #3)
But why do you want to use -static-libasan ? Just link it dynamically...
For one thing it can speed up code by avoiding PLT calls
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #13 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Kostya Serebryany from comment #12)
But for this example in C the globals will not get instrumented, unless
-fno-common is given.
BTW I think everyone already pairs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #10 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Kostya Serebryany from comment #8)
(sorry for delay, I missed the last comment)
Generally, we do want to instrument even artificial variables, and on many
of them
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
--- Comment #11 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Jakub Jelinek from comment #9)
An ODR violation is IMHO something different, it is the case where you have
the same symbol name (but, you'd need to distinguish
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #9 from Yury Gribov y.gribov at samsung dot com ---
I don't think this patch got to gcc-patches. I don't know how to repro
original error so I can't bootstrap myself.
++
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: jason at redhat dot com
Host: x86_64-unknown-linux-gnu
/home/ygribov/build/gcc-master/./gcc/xgcc -shared-libgcc
-B/home/ygribov/build/gcc-master/./gcc -nostdinc++
-L/home/ygribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63806
--- Comment #5 from Yury Gribov y.gribov at samsung dot com ---
I've posted feature request upstream:
http://llvm.org/bugs/show_bug.cgi?id=21530
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63802
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63802
--- Comment #3 from Yury Gribov y.gribov at samsung dot com ---
Agreed, I'll cook a patch for tomorrow then.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63806
--- Comment #2 from Yury Gribov y.gribov at samsung dot com ---
I think Marat meant that narrowing cast from int to char can be undefined and
it makes sense to emit some check for it as well.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63806
--- Comment #4 from Yury Gribov y.gribov at samsung dot com ---
Looks like some compilers check integer demotions (e.g. MS checks with their
/RTCc flag). I wonder if it makes sense to add an optional flag for this
(obviously not enabled under
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62132
--- Comment #10 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Dominique d'Humieres from comment #9)
Per comments 6 and 7 I have tried
...
but it does not fix the failures. What am I misunderstanding?
That wouldn't help because
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63694
--- Comment #5 from Yury Gribov y.gribov at samsung dot com ---
John, would you mind sending a (tested) patch to gcc-patches? I only have
access to Linux systems which are irrelevant.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63646
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63638
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63638
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Attachment #33803|0 |1
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57316
--- Comment #28 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Paul H. Hargrove from comment #26)
(In reply to Yury Gribov from comment #25)
Can we close this?
Just tried to build the released 4.8.3 and still see the original
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57316
--- Comment #25 from Yury Gribov y.gribov at samsung dot com ---
Can we close this?
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: hubicka at gcc dot gnu.org, khlebnikov at openvz dot org,
ryabinin.a.a at gmail dot com
Created attachment 33712
-- https://gcc.gnu.org/bugzilla/attachment.cgi
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533
--- Comment #3 from Yury Gribov y.gribov at samsung dot com ---
If g is called with argument that is usually 0,
then the partial inlining makes sense.
But note that there are zero callers of g in the file so no inlining can happen
anyway
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63507
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56393
--- Comment #46 from Yury Gribov y.gribov at samsung dot com ---
Can we close this one? Does not seem to repro in trunk.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61897
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62140
--- Comment #5 from Yury Gribov y.gribov at samsung dot com ---
Sabrina, could you close if works for you?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55577
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
hjl.tools at gmail dot com, jakub at gcc dot gnu.org,
kcc at gcc dot gnu.org, polacek
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62216
--- Comment #2 from Yury Gribov y.gribov at samsung dot com ---
Ok, I'll fw this to their tracker.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62216
--- Comment #3 from Yury Gribov y.gribov at samsung dot com ---
Reported upstream: http://llvm.org/bugs/show_bug.cgi?id=20721
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62132
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62132
--- Comment #2 from Yury Gribov y.gribov at samsung dot com ---
s/unwind with fp/unwind without fp/
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62132
--- Comment #4 from Yury Gribov y.gribov at samsung dot com ---
Note that same problem may pop up in other tests as well so IMHO better fix
this in general.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62132
--- Comment #7 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Iain Sandoe from comment #6)
(In reply to Yury Gribov from comment #2)
s/unwind with fp/unwind without fp/
it should be possible to do this, if m32 code
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62141
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||jakub at redhat
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62089
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62140
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62089
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
Asan does not emit memory checks
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62017
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||dodji at gcc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61771
--- Comment #8 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Ramana Radhakrishnan from comment #7)
I think finding a fix in the run time will be better and probably more
resilient across versions of GCC. In any case I think
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61875
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||y.gribov
-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: jakub at gcc dot gnu.org
Host: x86_64-unknown-linux-gnu
Target: x86_64-unknown-linux-gnu
Created attachment 33167
-- https://gcc.gnu.org/bugzilla
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61771
--- Comment #6 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Kostya Serebryany from comment #5)
Perhaps we should just disable fast unwind on ARM?
You will slowdown asan to the point where Valgrind will become preferable
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61771
--- Comment #4 from Yury Gribov y.gribov at samsung dot com ---
It should be possible to detect fp layout on the frame basis -
there is a slot (don't know which one off the top of my head)
that is FP in one compiler and return address
Priority: P3
Component: sanitizer
Assignee: unassigned at gcc dot gnu.org
Reporter: y.gribov at samsung dot com
CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
jakub at gcc dot gnu.org, kcc at gcc dot gnu.org
Created
1 - 100 of 209 matches
Mail list logo
