https://gcc.gnu.org/bugzilla/show_bug.cgi?id=28017
Andrew Pinski changed:
What|Removed |Added
Keywords||wrong-code
See Also|
--- Comment #13 from bkoz at gcc dot gnu dot org 2009-01-27 17:26 ---
*** Bug 25956 has been marked as a duplicate of this bug. ***
--
bkoz at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #11 from pinskia at gcc dot gnu dot org 2006-06-21 04:50
---
Actually I take that back, it is also a problem with targets that don't have
weak symbols too.
On x86_64-linux-gnu with the additional flag of -fno-weak:
pc64:~ g++ test.cc test1.cc -fno-weak
pc64:~ ./a.out
new:
--- Comment #12 from pinskia at gcc dot gnu dot org 2006-06-21 05:05
---
-fno-weak worked in 3.0.4 and below, though I don't know if it was really
working so I am not marking this as a regression.
--
pinskia at gcc dot gnu dot org changed:
What|Removed
--- Comment #10 from hhinnant at apple dot com 2006-06-19 18:11 ---
It turns out this still isn't quite right. Looks like we need:
#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) (DECL_COMMON (decl) \
|| DECL_ONE_ONLY (decl) \
--- Comment #1 from pinskia at gcc dot gnu dot org 2006-06-13 19:14 ---
This works on x86-linux-gnu on the mainline.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28017
--- Comment #2 from pinskia at gcc dot gnu dot org 2006-06-13 19:15 ---
(In reply to comment #1)
This works on x86-linux-gnu on the mainline.
Oh and in 3.3.3.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28017
--- Comment #3 from pinskia at gcc dot gnu dot org 2006-06-13 19:18 ---
|| DECL_ONE_ONLY (decl) || DECL_WEAK (decl) \
Actually those looks should include what is defined for Darwin.
--
pinskia at gcc dot gnu dot org changed:
What|Removed
--- Comment #4 from pinskia at gcc dot gnu dot org 2006-06-13 19:37 ---
For Darwin we do not want explicit instantiations to be
linkonce. */
This is why this testcase fails on darwin.
We should instead of just adding DECL_EXPLICIT_INSTANTIATION, check
--- Comment #5 from hhinnant at apple dot com 2006-06-13 21:23 ---
(In reply to comment #4)
For Darwin we do not want explicit instantiations to be
linkonce. */
This is why this testcase fails on darwin.
We should instead of just adding DECL_EXPLICIT_INSTANTIATION, check
#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) (DECL_COMMON (decl) \
|| DECL_ONE_ONLY (decl) \
|| DECL_WEAK (decl) \
||
--- Comment #6 from pinskia at physics dot uc dot edu 2006-06-13 21:24
---
Subject: Re: lack of guard variables for explicitly instantiated template
static data
#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) (DECL_COMMON (decl) \
--- Comment #7 from hhinnant at apple dot com 2006-06-13 21:41 ---
(In reply to comment #6)
Subject: Re: lack of guard variables for explicitly instantiated template
static data
#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) (DECL_COMMON (decl)
\
--- Comment #7 from hhinnant at apple dot com 2006-06-13 21:41 ---
(In reply to comment #6)
Subject: Re: lack of guard variables for explicitly instantiated template
static data
#define NEEDS_GUARD_P(decl) (TREE_PUBLIC (decl) (DECL_COMMON (decl)
\
--- Comment #8 from pinskia at physics dot uc dot edu 2006-06-13 21:47
---
Subject: Re: lack of guard variables for explicitly instantiated template
static data
--- Comment #7 from hhinnant at apple dot com 2006-06-13 21:41 ---
(In reply to comment #6)
Subject: Re:
--- Comment #9 from hhinnant at apple dot com 2006-06-13 22:02 ---
(In reply to comment #8)
Thanks. That not only makes sense to me now, but it passes the test. :-)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28017
16 matches
Mail list logo
