[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2022-02-04 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #8 from Francois-Xavier Coudert --- I'm not sure if it really counts as an ABI change, given that I know no existing target where this resulted in an actual change in the argument passing convention. (i.e., where that test actually f

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2022-02-01 Thread egallager at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #7 from Eric Gallager --- (In reply to Francois-Xavier Coudert from comment #6) > Fixed in > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=906b4e15ce84790c7657405238d61358e0893676 should this get a note in the release notes due to b

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2022-01-01 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 Francois-Xavier Coudert changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-26 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 Francois-Xavier Coudert changed: What|Removed |Added Keywords||patch URL|

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-26 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #4 from Francois-Xavier Coudert --- Wait, there is more, lower in gfc_conv_scalar_char_value(): /* If we have a constant character expression, make it into an integer. */ if ((*expr)->expr_type == EXPR_CONSTANT

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-26 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #3 from Francois-Xavier Coudert --- Created attachment 52062 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52062&action=edit Patch, v1

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-26 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #2 from Francois-Xavier Coudert --- So, even modifying gfc_sym_type() in trans-types.c to emit the proper type does not fix the issue. Why? Because the rug is pulled under our feet later. Turns out there is a function that deals with

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-25 Thread fxcoudert at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 --- Comment #1 from Francois-Xavier Coudert --- The condition for being treated as a special CHARACTER case in gfc_sym_type() is: if (sym->ts.type == BT_CHARACTER && ((sym->attr.function && sym->attr.is_bind_c) || (sym->attr.r

[Bug fortran/103828] Type generated for CHARACTER(C_CHAR), VALUE arguments is wrong

2021-12-25 Thread iains at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103828 Iain Sandoe changed: What|Removed |Added Keywords||wrong-code Last reconfirmed|