[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 Jeffrey A. Law changed: What|Removed |Added CC||law at gcc dot gnu.org

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #15 from John Paul Adrian Glaubitz --- (In reply to Ian Lance Taylor from comment #11) > Thanks. I committed the patch to the GCC 6 branch. > > GCC 7 will require a different fix, as the code has moved from C to Go. I'm > not sure

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #14 from Ian Lance Taylor --- > Could you maybe also backport the fix for PR/79037? [1] Done. > Btw, even with the fixes from this PR/79281 and PR/79037, the "go" command is > still crashing on m68k with gcc-6. It might be

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #13 from John Paul Adrian Glaubitz --- (In reply to Ian Lance Taylor from comment #11) > GCC 7 will require a different fix, as the code has moved from C to Go. I'm > not sure what the best approach is. Btw, even with the fixes

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #12 from John Paul Adrian Glaubitz --- (In reply to Ian Lance Taylor from comment #11) > Thanks. I committed the patch to the GCC 6 branch. > > GCC 7 will require a different fix, as the code has moved from C to Go. I'm > not sure

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #11 from Ian Lance Taylor --- Thanks. I committed the patch to the GCC 6 branch. GCC 7 will require a different fix, as the code has moved from C to Go. I'm not sure what the best approach is.

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #10 from ian at gcc dot gnu.org --- Author: ian Date: Wed Feb 1 22:58:43 2017 New Revision: 245109 URL: https://gcc.gnu.org/viewcvs?rev=245109=gcc=rev Log: PR go/79281 Force Lock and Note to be aligned to a 4 byte

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 John Paul Adrian Glaubitz changed: What|Removed |Added CC||glaubitz at physik dot

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #8 from James Clarke --- Created attachment 40645 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40645=edit Proposed fix I believe this patch is what Adrian did; Adrian, can you please confirm?

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #7 from Ian Lance Taylor --- It sounds like you have a patch for GCC 6. If you send it in I can apply it. The error you show must be from `make -j`, as compiling a file in libgfortran would not invoke go1. What is the actual

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #6 from John Paul Adrian Glaubitz --- On gcc-7, we actually can't build when enabling the Go frontend: libtool: compile: /<>/build/./gcc/xgcc -B/<>/build/./gcc/ -B/usr/m68k-linux-gnu/bin/ -B/usr/m68k-linux-gnu/lib/ -isystem

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #5 from John Paul Adrian Glaubitz --- (In reply to James Clarke from comment #4) > Ah, sorry, there's a separate C implementation of all this. I imagine it's > the bools in "struct M" in runtime.h messing it up, so "struct Note" and

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #4 from James Clarke --- Ah, sorry, there's a separate C implementation of all this. I imagine it's the bools in "struct M" in runtime.h messing it up, so "struct Note" and "struct Lock" need __attribute__((aligned(4))) on their key

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #3 from James Clarke --- I believe the problem is in the "m" type in runtime2.go. There are 4 bools in a row, which is fine, as they will take up 4 bytes, but then "printlock" is an int8, which means "fastrand" will only be 2-byte

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #2 from Ian Lance Taylor --- Perhaps this would be fixed by adding __attribute__((aligned(4))) to some field of struct Sched in proc.c. This code is all different on trunk/GCC7. I don't know whether it still has the same problem or

[Bug go/79281] gccgo: Binaries using goroutines crash on m68k

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79281 --- Comment #1 from Andreas Schwab --- A futex word must be 4-byte aligned.