http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #23 from Jakub Jelinek jakub at gcc dot gnu.org ---
Author: jakub
Date: Tue Mar 18 11:31:04 2014
New Revision: 208641
URL: http://gcc.gnu.org/viewcvs?rev=208641root=gccview=rev
Log:
PR ipa/58721
gcc/
* internal-fn.c: Include
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Jakub Jelinek jakub at gcc dot gnu.org changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Jakub Jelinek jakub at gcc dot gnu.org changed:
What|Removed |Added
CC||jakub at gcc dot
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #20 from Jakub Jelinek jakub at gcc dot gnu.org ---
Unfortunately the patch regresses abi_check in libstdc++, libstdc++.so.6 now
because of the patch exports
_ZNSt12system_errorC1ESt10error_codeRKSs@@GLIBCXX_3.4.11
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #22 from Jonathan Wakely redi at gcc dot gnu.org ---
(In reply to Jakub Jelinek from comment #20)
Unfortunately the patch regresses abi_check in libstdc++, libstdc++.so.6 now
because of the patch exports
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #21 from Jonathan Wakely redi at gcc dot gnu.org ---
Author: redi
Date: Fri Mar 14 18:10:59 2014
New Revision: 208572
URL: http://gcc.gnu.org/viewcvs?rev=208572root=gccview=rev
Log:
PR ipa/58721
* config/abi/pre/gnu.ver
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #18 from Tobias Burnus burnus at gcc dot gnu.org ---
(In reply to Tobias Burnus from comment #16)
Request for assistance/comment patch for gfortran:
http://gcc.gnu.org/ml/gcc-patches/2013-12/msg01034.html
(In reply to Jan Hubicka
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #17 from Jan Hubicka hubicka at gcc dot gnu.org ---
Created attachment 31517
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31517action=edit
Patch to extend __builtin_expect
Hi,
this patch adds internal use only parameter to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #14 from Jan Hubicka hubicka at ucw dot cz ---
Actually, I would argue that the middle-end should be smart enough to give a
branch that is guaranteed to never return a negligible probability
(independent
of the builtin_expect). It
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #15 from Jan Hubicka hubicka at ucw dot cz ---
The threshold is ~6000 (exactly 5941), i.e. more than twice the default value
2700.
Thanks for working it out. This may be only testcase I know of where
large-function-insns
brings
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Tobias Burnus burnus at gcc dot gnu.org changed:
What|Removed |Added
CC||burnus at gcc
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Joost VandeVondele Joost.VandeVondele at mat dot ethz.ch changed:
What|Removed |Added
CC|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #8 from Dominique d'Humieres dominiq at lps dot ens.fr ---
... bug was introduced by r202567 ...
I have checked that and fixing it with r205586 restores the timing of r202566.
The reason why this is not seen on recent revisions is
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Jan Hubicka hubicka at gcc dot gnu.org changed:
What|Removed |Added
Status|NEW |ASSIGNED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #10 from Jan Hubicka hubicka at gcc dot gnu.org ---
OK,
seems that the problem is with Fortran generating internally __builtin_expect
to control various construct. I would make a lot more sense to use
GIMPLE_PREDICT for those cases.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #11 from Jan Hubicka hubicka at gcc dot gnu.org ---
The inlining of perdida also happens with --param large-function-insns=10.
perhaps it indicates we shoud bump this parameter up little bit.
The reason why inlining order changed
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #12 from Dominique d'Humieres dominiq at lps dot ens.fr ---
The inlining of perdida also happens with --param large-function-insns=10.
perhaps it indicates we shoud bump this parameter up little bit.
The threshold is ~6000
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #6 from Dominique d'Humieres dominiq at lps dot ens.fr ---
It turned out that proposed fix does not help trunk compilers
since now another huge routine is inlined firstly (read_input)
and for perdida we got the following message:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #7 from Yuri Rumyantsev ysrumyan at gmail dot com ---
I saw that on old compiler sources (dated by 20130911) with my patch 'perdida'
was inlined without any additional inline parameters (using -flto) but now it
does not inlined since
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #4 from Yuri Rumyantsev ysrumyan at gmail dot com ---
It turned out that proposed fix does not help trunk compilers since now another
huge routine is inlined firstly (read_input) and for perdida we got the
following message:
not
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #5 from Yuri Rumyantsev ysrumyan at gmail dot com ---
Created attachment 31348
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31348action=edit
test-case to reproduce
It need to be compiled with -Ofast -flto options to reproduce.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Yuri Rumyantsev ysrumyan at gmail dot com changed:
What|Removed |Added
CC||ysrumyan at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
H.J. Lu hjl.tools at gmail dot com changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
--- Comment #3 from Dominique d'Humieres dominiq at lps dot ens.fr ---
After apllying this fix routine is inlined.
I have applied the following patch
--- ../_clean/gcc/ipa-inline.c2013-11-22 17:27:28.0 +0100
+++ gcc/ipa-inline.c
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Richard Biener rguenth at gcc dot gnu.org changed:
What|Removed |Added
Keywords|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58721
Richard Biener rguenth at gcc dot gnu.org changed:
What|Removed |Added
CC|rguenther at suse dot de |hubicka
26 matches
Mail list logo
