--- Comment #18 from burnus at gcc dot gnu dot org 2009-06-10 06:45 ---
I was able to do a regression hunt. Going to r145209 just before the big I/O
patch eliminates the error. I then moved forward to r145636 and confirmed the
breakage.
Is 4.5 also affected?
--
--- Comment #13 from jb at gcc dot gnu dot org 2009-06-09 20:56 ---
Subject: Bug 40330
Author: jb
Date: Tue Jun 9 20:55:53 2009
New Revision: 148326
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=148326
Log:
PR libfortran/40330 Use heap memory for format cache
Modified:
--- Comment #14 from jb at gcc dot gnu dot org 2009-06-09 20:57 ---
Closing as fixed.
--
jb at gcc dot gnu dot org changed:
What|Removed |Added
Status|NEW
--- Comment #15 from jv244 at cam dot ac dot uk 2009-06-09 22:14 ---
(In reply to comment #14)
Closing as fixed.
I'm testing now 4.4 which includes your fix, but I still see CP2K's restarts
failing. This looks like a second issue, different from what you've fixed so
far. The testcase
--- Comment #16 from jvdelisle at gcc dot gnu dot org 2009-06-10 02:18
---
The two locations referenced by valgrind in transfer.c is in code that is
unchanged from 4.3, so I don't think that is where the problem is. However,
looking at the CP2K code line involved:
--- Comment #17 from jvdelisle at gcc dot gnu dot org 2009-06-10 03:11
---
I was able to do a regression hunt. Going to r145209 just before the big I/O
patch eliminates the error. I then moved forward to r145636 and confirmed the
breakage.
I then manually removed the use of the
--- Comment #1 from jv244 at cam dot ac dot uk 2009-06-03 15:46 ---
CCed the experts
--
jv244 at cam dot ac dot uk changed:
What|Removed |Added
CC|
--- Comment #2 from dominiq at lps dot ens dot fr 2009-06-03 15:54 ---
Did you try 4.5?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40330
--- Comment #3 from jv244 at cam dot ac dot uk 2009-06-03 16:08 ---
(In reply to comment #2)
Did you try 4.5?
unfortunately trunk currently fails for other reasons. I'll try to look into
that afterwards.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40330
--- Comment #4 from jv244 at cam dot ac dot uk 2009-06-03 16:31 ---
OK, a good hint from valgrind. The following error is present if I use 4.4.1
but not if I link against the runtime from 4.4.0:
==30712== Invalid read of size 1
==30712==at 0x4A22DF9: strncmp
--- Comment #5 from jv244 at cam dot ac dot uk 2009-06-03 16:47 ---
OK, now with easy testcase, as you'll notice from the output, the loop is
important:
IMPLICIT NONE
character(len=100) :: fmt1,str1,fmt2,str2
real*8 :: r(3)=0
integer :: i,iunit
fmt1=(T2,A2,
str1=a
iunit=6
DO i=1,10
--- Comment #6 from jv244 at cam dot ac dot uk 2009-06-03 16:49 ---
compiled with trunk this is also buggy (with new bugs about dwarf2):
--690-- DWARF2 CFI reader: unhandled CFI instruction 0:10
--690-- DWARF2 CFI reader: unhandled CFI instruction 0:10
--690-- DWARF2 CFI reader:
--
jv244 at cam dot ac dot uk changed:
What|Removed |Added
Target Milestone|--- |4.4.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40330
--- Comment #7 from jb at gcc dot gnu dot org 2009-06-03 17:39 ---
Confirmed on trunk.
This seems to be due to the format caching stuff?
The regression on the 4.4 branch would be explained by the I/O backport
(r147887).
--
jb at gcc dot gnu dot org changed:
What
--- Comment #8 from jb at gcc dot gnu dot org 2009-06-03 18:49 ---
Created an attachment (id=17949)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17949action=view)
Proposed patch
This patch seems to fix it, will formally submit as soon as it regtests.
--
--- Comment #9 from jb at gcc dot gnu dot org 2009-06-03 19:19 ---
Proper patch submitted.
--
jb at gcc dot gnu dot org changed:
What|Removed |Added
URL|
--- Comment #10 from jb at gcc dot gnu dot org 2009-06-03 21:07 ---
Subject: Bug 40330
Author: jb
Date: Wed Jun 3 21:07:19 2009
New Revision: 148149
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=148149
Log:
PR libfortran/40330
Use heap memory for cached format strings.
--- Comment #11 from jv244 at cam dot ac dot uk 2009-06-04 05:16 ---
(In reply to comment #9)
Proper patch submitted.
Thanks, don't wait too long with 4.4 as this should make it in 4.4.1 which
could be released this month, and some further testing on the branch would be
good:
--- Comment #12 from burnus at gcc dot gnu dot org 2009-06-04 05:36 ---
Thanks, don't wait too long with 4.4 as this should make it in 4.4.1 which
could be released this month, and some further testing on the branch would be
good:
Planned for June 21, see (better link):
19 matches
Mail list logo
