--- Comment #17 from singler at kit dot edu 2010-02-09 10:49 ---
The actual problem has vanished, but maybe it would still be nice to use VLA in
the appropriate places.
We can close the bug as fixed/invalid, or reprioritize it as enhancement and
leave it open. Both is fine with me.
--- Comment #16 from paolo dot carlini at oracle dot com 2010-02-08 11:19
---
Can we review this issue? Two comments: 1- Now I can see only dynamic memory
allocations via new / delete everywhere, thus, no __builtin_alloca; 2- *If* one
really wanted to use VLAs, now it should be
--- Comment #14 from bkoz at gcc dot gnu dot org 2009-01-13 08:42 ---
Created an attachment (id=17082)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=17082action=view)
patch for hppa check-abi fail
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #15 from bkoz at gcc dot gnu dot org 2009-01-13 10:06 ---
(From update of attachment 17082)
mistaken, part of 32666
--
bkoz at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #13 from bkoz at gcc dot gnu dot org 2007-10-09 21:51 ---
Subject: Bug 33485
Author: bkoz
Date: Tue Oct 9 21:51:06 2007
New Revision: 129182
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=129182
Log:
2007-10-09 Wolfgang Bangerth [EMAIL PROTECTED]
PR
--- Comment #7 from bangerth at dealii dot org 2007-10-08 14:56 ---
I've just found a number of other places where currently a VLA
is used and we consequently get a warning with current sources if
using the right flags. These are:
quicksort.h:68
multiway_mergesort.h:142
Benjamin, as a
On 8 Oct 2007 14:56:18 -, bangerth at dealii dot org
[EMAIL PROTECTED] wrote:
quicksort.h:68
multiway_mergesort.h:142
Benjamin, as a stopgap would you mind using __builtin_alloca in these
places as well?
Why not use __extension__ in those places?
-- Pinski
--- Comment #8 from pinskia at gmail dot com 2007-10-08 16:34 ---
Subject: Re: parallel v3: do not use __builtin_alloca, use VLA
On 8 Oct 2007 14:56:18 -, bangerth at dealii dot org
[EMAIL PROTECTED] wrote:
quicksort.h:68
multiway_mergesort.h:142
Benjamin, as a stopgap would
--- Comment #9 from bkoz at gcc dot gnu dot org 2007-10-08 18:11 ---
I'd rather do all these the same way.
Wolfgang, do you have a patch?
-benjamin
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #10 from bangerth at dealii dot org 2007-10-08 19:15 ---
Created an attachment (id=14323)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14323action=view)
diffs to multiway_mergesort.h and quicksort.h
The attached diffs appear to do it for me.
W.
--
--- Comment #11 from bkoz at gcc dot gnu dot org 2007-10-08 19:55 ---
Wolfgang this is ok to check in.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #12 from bangerth at dealii dot org 2007-10-08 22:25 ---
I'm sorry, but I don't have a writable account any more. Can you do the
checkin for me?
Thanks
W.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #5 from pinskia at gcc dot gnu dot org 2007-09-26 19:06 ---
Hmm, __extension__ is lost with templates, see PR 21385.
--
pinskia at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #6 from bkoz at gcc dot gnu dot org 2007-09-26 20:43 ---
the real question for me is why #pragma GCC system header doesn't work.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #3 from bkoz at gcc dot gnu dot org 2007-09-19 17:05 ---
Awesome: thanks for doing these PR's Wolfgang.
Andrew, you mean the attribute?
It's my preference to use #pagma GCC system header for this. It does the least
amount of molestation.
However, it doesn't currently
--- Comment #4 from pinskia at gcc dot gnu dot org 2007-09-19 17:08 ---
(In reply to comment #3)
Awesome: thanks for doing these PR's Wolfgang.
Andrew, you mean the attribute?
No.
I mean something like:
int f(int n)
{
__extension__ int h[n];
h[n-1] = 0;
return h[n-1];
}
--- Comment #1 from pinskia at gcc dot gnu dot org 2007-09-19 02:37 ---
shouldn't using __extension__ fix the warning/error for VLAs?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33485
--- Comment #2 from bangerth at math dot tamu dot edu 2007-09-19 02:43
---
Subject: Re: parallel v3: do not use __builtin_alloca,
use VLA
shouldn't using __extension__ fix the warning/error for VLAs?
Yes, that's the other option. I guess Benjamin also wanted to find out for
good
18 matches
Mail list logo
