https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #23 from Richard Biener ---
According to the dup the fix is bogus (the added stmt is optimized away).
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
Richard Biener changed:
What|Removed |Added
CC||oremanj at mit dot edu
--- Comment #22
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
chrbr at gcc dot gnu.org changed:
What|Removed |Added
CC||chrbr at gcc dot gnu.org
---
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #14 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-13
09:46:24 UTC ---
Thanks very much Paolo.
Here it is. I'll commit the patch in the mainline if no objection.
Laurent
2012-04-13 Laurent Alfonsi laurent.alfo...@st.com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #15 from Jonathan Wakely redi at gcc dot gnu.org 2012-04-13
09:48:39 UTC ---
(In reply to comment #14)
PR libstdc++/52604
* src/mt_allocator.cc: (~__freelist): Reset pointer.
^
c++98/
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #16 from Paolo Carlini paolo.carlini at oracle dot com 2012-04-13
10:29:02 UTC ---
Yes, please go ahead, mainline only for now (PR remains open) with Jon's fix to
the ChangeLog and also, between parentheses (__freelist::~__freelist).
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #17 from Paolo Carlini paolo.carlini at oracle dot com 2012-04-13
10:31:01 UTC ---
Ah, another minor nit, remember to add 2012 to the list of Copyright Years
(mind to keep the comment within 80 columns)
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #19 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-13
12:00:44 UTC ---
Author: chrbr
Date: Fri Apr 13 11:58:15 2012
New Revision: 186415
Log Message:
fix last entry
Modified:
trunk/libstdc++-v3/ChangeLog
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #18 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-13
12:00:21 UTC ---
Author: chrbr
Date: Fri Apr 13 11:44:13 2012
New Revision: 186414
Log Message:
PR:52604: (~__freelist): Reset pointer
Modified:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #20 from Paolo Carlini paolo.carlini at oracle dot com 2012-04-13
14:45:29 UTC ---
Remember to always send the patches you commit to gcc-patc...@gcc.gnu.org (and
libstd...@gcc.gnu.org in CC), even if already approved on the fly in
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #9 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-12
15:05:25 UTC ---
Paolo,
I ve discovered that the encoding of M_key is encoded differently for each
thread-implementation. On pthread implementation M_key is an integer,
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
Paolo Carlini paolo.carlini at oracle dot com changed:
What|Removed |Added
CC|jakub at redhat dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #11 from Paolo Carlini paolo.carlini at oracle dot com 2012-04-12
16:29:32 UTC ---
In mainline, for x86_64-linux, the below patchlet indeed avoids the valgrind
errors and passes make check, make check-performance.
Index:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #12 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-12
21:55:42 UTC ---
Thanks very much Paolo. It works fine on SH4 also.
Is that enough to push the patch ?
Laurent
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
Paolo Carlini paolo.carlini at oracle dot com changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #7 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-04-10
15:28:07 UTC ---
Ping ? Here is the patch proposed.
--- libstdc++-v3/src/mt_allocator.cc2011/08/04 07:56:492064
+++
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #8 from Paolo Carlini paolo.carlini at oracle dot com 2012-04-11
01:08:12 UTC ---
Note, stylistically, no curly brackets in the if body, and also no NULL, just 0
in C++98. I also note that you are not patching mainline, all the fixes
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #6 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-03-23
11:06:57 UTC ---
Sorry for the late answer (sickness).
Well, In fact there are 2 things in the atexit list :
1) The destruction of the list_type global variable.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #3 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-03-20
12:31:31 UTC ---
Well, in fact I am facing a runtime crash on another target (SH4). The crash is
fixed by the patch proposed previously.
On the other hand, I ve tried
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #4 from Paolo Carlini paolo.carlini at oracle dot com 2012-03-20
12:48:20 UTC ---
In principle I have no problem with such zeroings, make sense, but it's been a
while since the last time I looked into this code and I fear races. In
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
Jakub Jelinek jakub at gcc dot gnu.org changed:
What|Removed |Added
CC||jakub at gcc dot
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
Paolo Carlini paolo.carlini at oracle dot com changed:
What|Removed |Added
CC||jakub at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52604
--- Comment #1 from Laurent Aflonsi laurent.alfonsi at st dot com 2012-03-16
15:25:23 UTC ---
I would propose to fix as follows :
- Set the _M_Key=NULL when calling the freelist desctuctor.
- Testing the NULL Key before using it with setspecific.
23 matches
Mail list logo
