https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #16 from Jonathan Wakely ---
(In reply to Jonathan Wakely from comment #14)
> Created attachment 43350 [details]
> Patch to use __builtin_object_size in std::string
>
> So it isn't lost, here's a prototype I was working on last year
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
Martin Sebor changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #14 from Jonathan Wakely ---
Created attachment 43350
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=43350=edit
Patch to use __builtin_object_size in std::string
So it isn't lost, here's a prototype I was working on last year
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #13 from Jonathan Wakely ---
(In reply to Jonathan Wakely from comment #10)
> I'm starting to think we should just make libstdc++ headers 100%
> warning-free
We're closer to that now, but not in a position to stop marking our
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #12 from Jonathan Wakely ---
Indeed, it's what allows us to use variadic templates in C++98 mode, for
example. And I don't think there's any way to use
__attribute__((__extension__)) on template parameter packs to do that
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #11 from Marc Glisse ---
(In reply to Jonathan Wakely from comment #10)
> I'm starting to think we should just make libstdc++ headers 100%
> warning-free and stop marking them as system headers with the pragmas. When
> they're
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #10 from Jonathan Wakely ---
I'm starting to think we should just make libstdc++ headers 100% warning-free
and stop marking them as system headers with the pragmas. When they're
installed under /usr they'd still be considered system
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #9 from Martin Sebor ---
Sadly, even with pr79214 fixed and pr79234 implemented, -Wno-system-headers
still somehow defeats the warning.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #8 from Martin Sebor ---
Author: msebor
Date: Thu May 4 23:50:21 2017
New Revision: 247622
URL: https://gcc.gnu.org/viewcvs?rev=247622=gcc=rev
Log:
PR libstdc++/54924 - Warn for std::string constructor with wrong size
PR
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
Bug 54924 depends on bug 79214, which changed state.
Bug 79214 Summary: -Wno-system-header defeats strncat buffer overflow warnings
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79214
What|Removed |Added
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
Martin Sebor changed:
What|Removed |Added
Status|NEW |ASSIGNED
Depends on|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #6 from Martin Sebor ---
As a heads up, with the patch for bug 79234 applied and with -Wsystem-headers
explicitly specified GCC issues the warnings below (the -Warray-bounds is
printed even without the patch). Unfortunately, with
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
Martin Sebor changed:
What|Removed |Added
CC||msebor at gcc dot gnu.org
See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #4 from Jonathan Wakely ---
This seems like a job for sanitizers.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
--- Comment #3 from David Stone ---
Also filed against libc++ here: https://llvm.org/bugs/show_bug.cgi?id=28777
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
Jonathan Wakely redi at gcc dot gnu.org changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54924
David Stone david at doublewise dot net changed:
What|Removed |Added
CC||david at
17 matches
Mail list logo
