https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #28 from Jan Hubicka ---
and forgot to mention, one variant would be to
1) document that gnu_inline artifical always_inline is special and may have
different semantics than offline function but it is also the only case
2) throw
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #27 from Jan Hubicka ---
Well, we can't throw away all extern inlines as that would penalize C++
performance quite a lot (it is ipa-inliner that decides on inlining of most of
keyed methods).
The real fix is to special case GNU
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Richard Biener changed:
What|Removed |Added
Priority|P3 |P2
--- Comment #26 from Richard Biener
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #25 from Martin Jambor ---
My work is done here. I'm not sure if it means that we can close this, given
that the underlying problem is not "really fixed(TM)."
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #24 from Martin Jambor ---
Author: jamborm
Date: Thu Mar 14 16:54:43 2019
New Revision: 269688
URL: https://gcc.gnu.org/viewcvs?rev=269688=gcc=rev
Log:
Zero local estimated benefit for cloning extern inline function
2019-03-14
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #23 from Martin Jambor ---
Author: jamborm
Date: Thu Mar 14 16:50:50 2019
New Revision: 269687
URL: https://gcc.gnu.org/viewcvs?rev=269687=gcc=rev
Log:
Zero local estimated benefit for cloning extern inline function
2019-03-14
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #22 from Martin Jambor ---
Author: jamborm
Date: Thu Mar 7 16:42:20 2019
New Revision: 269464
URL: https://gcc.gnu.org/viewcvs?rev=269464=gcc=rev
Log:
Zero local estimated benefit for cloning extern inline function
2019-03-07
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #21 from Martin Jambor ---
After a bit more thinking, I found a better spot where to treat extern inline
functions differently, I have proposed a patch in the mailing list:
https://gcc.gnu.org/ml/gcc-patches/2019-02/msg02049.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #20 from Jan Hubicka ---
This seems to make sense. One should clone extern inline only if something
useful can be propagated across I suppose. Patch is OK with some comment and
testcase.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Martin Jambor changed:
What|Removed |Added
CC||jamborm at gcc dot gnu.org
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Jakub Jelinek changed:
What|Removed |Added
CC|jakub at redhat dot com|
--- Comment #18 from Jakub
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #17 from Jan Hubicka ---
> GNU extern inline is an extension, so is covered by whatever we define (or
> should have defined). We've never required that the out of line and inline
> definitions are the same or in any way similar
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Jakub Jelinek changed:
What|Removed |Added
CC||jakub at gcc dot gnu.org
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Jan Hubicka changed:
What|Removed |Added
CC||jakub at redhat dot com
--- Comment #15
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Jan Hubicka changed:
What|Removed |Added
CC||mjambor at suse dot cz
--- Comment #14
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
--- Comment #13 from Martin Liška ---
$ ld --version
GNU ld (GNU Binutils; openSUSE Tumbleweed) 2.31.1.20180828-3
Copyright (C) 2018 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Richard Biener changed:
What|Removed |Added
Target Milestone|--- |7.5
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87525
Jan Hubicka changed:
What|Removed |Added
Summary|infinite loop generated for |[7/8/9 Regression] infinite
18 matches
Mail list logo
