--- Comment #69 from danglin at gcc dot gnu dot org 2008-11-01 20:15
---
Fixed.
--
danglin at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #67 from olga at gcc dot gnu dot org 2008-02-07 10:26 ---
(In reply to comment #66)
I looked wo_prof_global_var.c. The test passes with the above options.
The floating point convert operations look similar to those with
-fipa-struct-reorg. However, there's just one
--- Comment #68 from dave at hiauly1 dot hia dot nrc dot ca 2008-02-07
15:33 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
I looked into assembly you send and see the following difference:
for original malloc
--- Comment #66 from dave at hiauly1 dot hia dot nrc dot ca 2008-02-05
02:42 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
If so, there is still question why the tests do not fail without struct-reorg.
Or they
--- Comment #65 from olga at gcc dot gnu dot org 2008-02-03 14:48 ---
(In reply to comment #64)
Oh, it's just what I suspected! Please look at the PR 34534 comment #4.
If so, there is still question why the tests do not fail without struct-reorg.
Or they fail? Can you please check it
--- Comment #61 from alond at il dot ibm dot com 2008-01-31 18:07 ---
Done. Still have same fails on hppa2.0w-hp-hpux11.11.
Dave,
can you please perform an initial debugging?
I think it will make it easier to loacte the bug if we had some debugging
information, like where is the
--- Comment #64 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-31
22:18 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
Then, in the second loop, we load p[968].a and convert it to a float
value of 3. We do a
--- Comment #62 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-31
22:00 ---
Subject: Re: wo_prof_two_strs.c:56: internal
compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605
On Thu, 31 Jan 2008, alond at il dot ibm dot com wrote:
--- Comment #61
--- Comment #60 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-30
19:44 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
On hppa2.0w-hp-hpux11.11, we are down to:
Dave,
Can you please try this patch:
--- Comment #59 from alond at il dot ibm dot com 2008-01-29 10:01 ---
(In reply to comment #58)
On hppa2.0w-hp-hpux11.11, we are down to:
Dave,
Can you please try this patch:
Index: ipa-struct-reorg.c
===
---
--- Comment #58 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-26
22:23 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
can you please check now? I committed patches from comment #11.
On hppa2.0w-hp-hpux11.11,
--- Comment #56 from olga at il dot ibm dot com 2008-01-25 08:10 ---
(In reply to comment #55)
With revision 131802, we are down to the followning fails:
can you please check now? I committed patches from comment #11.
Olga
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34483
--- Comment #57 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-25
18:54 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
can you please check now? I committed patches from comment #11.
Yes.
However, I still
--- Comment #53 from dominiq at lps dot ens dot fr 2008-01-24 12:58 ---
On i686-apple-darwin9 the patch from
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01081.html (now commited in
trunk) solves all the failures in gcc.dg/struct/*, both in 32 and 64 bit modes.
I have even an XPASS:
--- Comment #54 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-24
16:26 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
On i686-apple-darwin9 the patch from
--- Comment #55 from danglin at gcc dot gnu dot org 2008-01-24 23:39
---
With revision 131802, we are down to the followning fails:
FAIL: gcc.dg/struct/wo_prof_global_var.c execution test
FAIL: gcc.dg/struct/wo_prof_local_var.c execution test
FAIL: gcc.dg/struct/wo_prof_two_strs.c
--- Comment #48 from olga at il dot ibm dot com 2008-01-22 20:21 ---
Looking closely on the assembly files you generated, I see that in the version
that fails there is a loop unrolling. On my linux x86_64 machine the assembly
generated for 64 bits has no loop unrolling effects, also as
--- Comment #49 from olga at il dot ibm dot com 2008-01-22 21:55 ---
(In reply to comment #48)
sorry, with
-O3 -fipa-struct-reorg -fipa-type-escape -fwhole-program -combine
wo_prof_mult_fields_peeling.c -fno-unroll-loops
Olga
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34483
--- Comment #50 from dominiq at lps dot ens dot fr 2008-01-22 22:47 ---
I wonder what it will be if we use -fno-unroll-loops in compilation
It does change the segfault:
[ibook-dhum] f90/bug% /opt/gcc/gcc4.3w/bin/gcc -O3 -fno-unroll-loops
-fipa-struct-reorg -fipa-type-escape
--- Comment #51 from olga at il dot ibm dot com 2008-01-22 22:58 ---
(In reply to comment #50)
I wonder what it will be if we use -fno-unroll-loops in compilation
It does change the segfault:
You mean does not, right?
Can you please send me its assembly (with -fno-unroll-loops) to
--- Comment #52 from dominiq at lps dot ens dot fr 2008-01-22 23:25 ---
You mean does not, right?
Yes indeed! sorry for skipping the negation. The assembly follows. Comparing it
to the assembly for wo_prof_mult_field_peeling_db.c in comment #35, the
striking difference is that the
--- Comment #39 from olga at gcc dot gnu dot org 2008-01-21 13:33 ---
(In reply to comment #38)
With patch form comments #11 and #31, the executable for
gcc.dg/struct/wo_prof_mult_field_peeling.c segfault with -m64. I have used the
32 bit mode for -fprofile-generate, run the
--- Comment #40 from dominiq at lps dot ens dot fr 2008-01-21 14:09 ---
Why are you running wo_prof_mult_field_peeling.c with profiling?
My best guess is because I have reused some previous command line(s) with it
(from gcc.dg/struct/w_prof_global_array.c for instance) without
--- Comment #41 from dominiq at lps dot ens dot fr 2008-01-21 14:54 ---
Sorry I missed the second question:
The other question is whether the failing tests that should run *with*
profiling, like w_prof_gloval_var.c and w_prof_local_var.c, fail after
compilation with
--- Comment #42 from olga at il dot ibm dot com 2008-01-21 18:33 ---
(In reply to comment #41)
Sorry I missed the second question:
The other question is whether the failing tests that should run *with*
profiling, like w_prof_gloval_var.c and w_prof_local_var.c, fail after
--- Comment #43 from dominiq at lps dot ens dot fr 2008-01-21 19:09 ---
They failed with -fprofile-generate (BTW they fail without -fprofile-*).
without! sorry
If I understand you correctly, the executable of w_prof_global_var.c, compiled
with -O3
--- Comment #44 from olga at il dot ibm dot com 2008-01-21 20:16 ---
(In reply to comment #43)
They failed with -fprofile-generate (BTW they fail without -fprofile-*).
without! sorry
If I understand you correctly, the executable of w_prof_global_var.c,
--- Comment #45 from dominiq at lps dot ens dot fr 2008-01-21 20:26 ---
Sorry pursuing this issue, but let me completely understand it: when you run
*with* profiling, there are two compilations and two executions. If you
compile
first with:
-O3 -fipa-type-escape -fwhole-program
--- Comment #46 from olga at il dot ibm dot com 2008-01-21 20:42 ---
(In reply to comment #45)
Sorry pursuing this issue, but let me completely understand it: when you run
*with* profiling, there are two compilations and two executions. If you
compile
first with:
-O3
--- Comment #47 from dominiq at lps dot ens dot fr 2008-01-21 20:55 ---
If you run the executable generated by:
-O3 -fipa-type-escape -fwhole-program -combine -fprofile-generate
w_prof_global_var.c -m64
is it fail or not?
It does not fail:
[ibook-dhum] bug/depend%
--- Comment #34 from olga at gcc dot gnu dot org 2008-01-20 13:28 ---
Dave, Dominique,
As I have no such execution failures on any one of machines, would you please
help me debugging the execution failures?
I am actually need the place where it fails and assembly files. The most
--- Comment #35 from dominiq at lps dot ens dot fr 2008-01-20 15:16 ---
Note that the test gcc.dg/struct/wo_prof_mult_field_peeling.c pass for 32 and
64 bit modes on i686-apple-darwin9, so I am not sure that what follows will
help.
For the code in comment #34 the assembly code is:
--- Comment #36 from olga at gcc dot gnu dot org 2008-01-20 17:03 ---
(In reply to comment #35)
Note that the test gcc.dg/struct/wo_prof_mult_field_peeling.c pass for 32 and
64 bit modes on i686-apple-darwin9, so I am not sure that what follows will
help.
Sorry, I meant compiling
--- Comment #37 from dominiq at lps dot ens dot fr 2008-01-20 18:09 ---
(In reply to comment #36)
... And, if I understand correctly the comment #32, with 64 bits mode it does
fails with wo_prof_mult_fields_peeling.c. Please fix me if I am wrong.
Yes, you are right. I did not look
--- Comment #38 from dominiq at lps dot ens dot fr 2008-01-20 20:47 ---
With patch form comments #11 and #31, the executable for
gcc.dg/struct/wo_prof_mult_field_peeling.c segfault with -m64. I have used the
32 bit mode for -fprofile-generate, run the executable, and use -m64 for
--- Comment #31 from olga at gcc dot gnu dot org 2008-01-15 14:11 ---
I gave it another push. The following is a patch solving inconsistency of the
data structures in struct reorg, and releasing comparison with 0. Please try it
together with the Richard's patch. It should give extra
--- Comment #32 from dominiq at lps dot ens dot fr 2008-01-15 20:03 ---
With the patches in comments #11 and 31, the error disappears in 32 bit mode on
Intel Darwin9 (as with #11 alone), now appears in 64 bit mode with the other
errors already reported:
FAIL:
--- Comment #33 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-16
02:33 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
I gave it another push. The following is a patch solving inconsistency of the
data
--- Comment #30 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-08
15:51 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
Subject: Re: wo_prof_two_strs.c:56: internal compiler
error: in find_new_var_of_type,
--- Comment #28 from olga at gcc dot gnu dot org 2008-01-07 13:38 ---
(In reply to comment #27)
Would you please try the Alon's patch for PR 34701.
I am not sure but maybe it's related.
Thank you,
Olga
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34483
--- Comment #29 from dominiq at lps dot ens dot fr 2008-01-07 20:04 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler
error: in find_new_var_of_type, at ipa-struct-reorg.c:605
Would you please try the Alon's patch for PR 34701.
I did but the reported failures are still
--- Comment #23 from rsandifo at nildram dot co dot uk 2008-01-02 13:19
---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
Olga, is it OK if I submit the patch from comment #11? Or would you prefer
to go with the patch
--- Comment #24 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-02
15:11 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
Would you please see the comment #4 for PR 34534, and try it on your machine?
The
--- Comment #25 from dominiq at lps dot ens dot fr 2008-01-02 17:07 ---
On Intel Darwin9 the patch from PR34472 has the same effect than the patch in
comment #11, i.e., the behavior reported in comment #22.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=34483
--- Comment #26 from dave at hiauly1 dot hia dot nrc dot ca 2008-01-03
01:44 ---
Subject: Re: wo_prof_two_strs.c:56: internal
compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605
With the attached change and Richard's patch from comment #11, I'm down
to the same
--- Comment #22 from dominiq at lps dot ens dot fr 2007-12-31 19:43 ---
The patch in comment #11 fixes the failure of
gcc.dg/struct/wo_prof_malloc_size_var.c on i686-apple-darwin9 32 bit mode, but
I have still the failures reported in comment #6 of PR34534 in 64 bit mode.
--
--- Comment #17 from olga at gcc dot gnu dot org 2007-12-30 12:19 ---
(In reply to comment #16)
I think this is related to PR 34472 and PR 34534
true.
Would you please see the comment #4 for PR 34534, and try it on your machine?
Thank you,
Olga
--
--- Comment #18 from pinskia at gcc dot gnu dot org 2007-12-30 14:54
---
*** Bug 34623 has been marked as a duplicate of this bug. ***
--
pinskia at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #16 from hjl at lucon dot org 2007-12-29 16:20 ---
I think this is related to PR 34472 and PR 34534
--
hjl at lucon dot org changed:
What|Removed |Added
--- Comment #11 from rsandifo at gcc dot gnu dot org 2007-12-28 14:57
---
Created an attachment (id=14838)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14838action=view)
Patch for double free and iteration bug
I'm seeing a struct-reorg.exp ICE on MIPS too, although in
--- Comment #12 from olga at gcc dot gnu dot org 2007-12-28 19:28 ---
(In reply to comment #11)
Created an attachment (id=14838)
-- (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14838action=view) [edit]
Patch for double free and iteration bug
I'm seeing a struct-reorg.exp ICE on
--- Comment #13 from rsandifo at nildram dot co dot uk 2007-12-28 19:38
---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
olga at gcc dot gnu dot org [EMAIL PROTECTED] writes:
--- Comment #12 from olga at gcc dot
--- Comment #14 from dave at hiauly1 dot hia dot nrc dot ca 2007-12-28
19:54 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
But isn't my patch more efficient? I don't see why you need to
build a separate list
--- Comment #15 from dave at hiauly1 dot hia dot nrc dot ca 2007-12-29
01:24 ---
Subject: Re: wo_prof_two_strs.c:56: internal compiler error: in
find_new_var_of_type, at ipa-struct-reorg.c:605
But isn't my patch more efficient? I don't see why you need to
build a separate list
--- Comment #2 from dave at hiauly1 dot hia dot nrc dot ca 2007-12-24
02:08 ---
Subject: Re: wo_prof_two_strs.c:56: internal
compiler error: in find_new_var_of_type, at ipa-struct-reorg.c:605
Hi Olga,
On Mon, 17 Dec 2007, olga at gcc dot gnu dot org wrote:
I actually need
--- Comment #1 from olga at gcc dot gnu dot org 2007-12-17 15:15 ---
Thank you a lot for debugging!
As I have not hpux system, and cannot reproduce this dug on x86 or ppc machine,
would you please help me to debug it?
In gcc/gcc/ipa-struct-reorg.c file, please comment out line 3915
56 matches
Mail list logo
