https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #17 from Yury Gribov y.gribov at samsung dot com ---
This should be fully resolved once
https://github.com/llvm-mirror/compiler-rt/commit/d6535ea4c4d49078a93735b315b8518fb692a592
is merged into gcc trunk.
BTW it no longer reproduces
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #16 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Evgeniy Stepanov from comment #15)
In fact, a recent change disabled ASAN_FLEXIBLE_MAPPING_AND_OFFSET and
killed all supporting code. Or are you talking about a
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #14 from Yury Gribov y.gribov at samsung dot com ---
With recent decision to enable ASAN_FLEXIBLE_MAPPING_AND_OFFSET by default I
don't see how LD_PRELOAD is going to work at all. What's the reasoning behind
this change?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #15 from Evgeniy Stepanov eugeni.stepanov at gmail dot com ---
In fact, a recent change disabled ASAN_FLEXIBLE_MAPPING_AND_OFFSET and killed
all supporting code. Or are you talking about a different change?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #13 from Evgeniy Stepanov eugeni.stepanov at gmail dot com ---
(In reply to Yury Gribov from comment #12)
(In reply to Evgeniy Stepanov from comment #8)
... one of the ASan interceptors
that does ENSURE_ASAN_INITED().
Arguably,
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #11 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Evgeniy Stepanov from comment #10)
We don't intercept signal() on Android
This is just an implementation detail, this fails just as well:
$ cat repro.c
#include
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #12 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Evgeniy Stepanov from comment #8)
... one of the ASan interceptors
that does ENSURE_ASAN_INITED().
Arguably, all interceptors should do it.
Can we force all
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #9 from Yury Gribov y.gribov at samsung dot com ---
Created attachment 31204
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31204action=edit
Repro
Just occured to me that I forgot to attach a reprocase, so doing this now.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #10 from Evgeniy Stepanov eugeni.stepanov at gmail dot com ---
We don't intercept signal() on Android, because there is a friendly crash
handler installed by the OS, and we don't need to handle segv ourselves.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
Alexey Samsonov samsonov at google dot com changed:
What|Removed |Added
CC|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #6 from Kostya Serebryany kcc at gcc dot gnu.org ---
adding attribute ctor to __asan_init is questionable
- windows has different syntax.
- running non-instrumented binary w/o calling __asan_init at startup is risky:
the binary may
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #7 from Yury Gribov y.gribov at samsung dot com ---
(In reply to Kostya Serebryany from comment #6)
adding attribute ctor to __asan_init is questionable
- windows has different syntax.
We'll fix that (see the obsolete patch).
-
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #8 from Evgeniy Stepanov eugeni.stepanov at gmail dot com ---
I'm a little surprised we did not run into this on Android yet - we use the
same LD_PRELOAD scheme there. Are you linking libasan with libpthread? This
might go away as
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
CC||samsonov at
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #1 from Yury Gribov y.gribov at samsung dot com ---
Created attachment 31118
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31118action=edit
Draft patch
Here is a draft patch implementing my proposal.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
--- Comment #2 from Jakub Jelinek jakub at gcc dot gnu.org ---
Why don't you add __attribute__((constructor)) to __asan_init instead?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937
Yury Gribov y.gribov at samsung dot com changed:
What|Removed |Added
Attachment #31118|0 |1
is
18 matches
Mail list logo
