https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #57 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #56 from Jakub Jelinek ---
> So, is this resolved now?
The bootstrap failures are AFAIK, but perhaps we should keep it open for
the fixinclude fix backports discovered?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #56 from Jakub Jelinek ---
So, is this resolved now?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #55 from Rainer Orth ---
Author: ro
Date: Sun Nov 20 10:51:53 2016
New Revision: 242634
URL: https://gcc.gnu.org/viewcvs?rev=242634=gcc=rev
Log:
Add PR sanitizer/78267 patch to libsanitizer/LOCAL_PATCHES
Modified:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #54 from Rainer Orth ---
Author: ro
Date: Sun Nov 20 10:49:47 2016
New Revision: 242633
URL: https://gcc.gnu.org/viewcvs?rev=242633=gcc=rev
Log:
Fix libsanitizer build on OS X 10.1[01], macOS 10.12 (PR sanitizer/78267)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Rainer Orth changed:
What|Removed |Added
Target|x86_64-apple-darwin16 |x86_64-apple-darwin1[4-6]
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #52 from Jack Howarth ---
(In reply to Iain Sandoe from comment #51)
> (In reply to r...@cebitec.uni-bielefeld.de from comment #50)
> > > --- Comment #49 from Iain Sandoe ---
> > [...]
> > > I can do darwin14 (I built 242408 last
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #51 from Iain Sandoe ---
(In reply to r...@cebitec.uni-bielefeld.de from comment #50)
> > --- Comment #49 from Iain Sandoe ---
> [...]
> > I can do darwin14 (I built 242408 last night with the patches-in-progress +
> > __BLOCKS__)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #50 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #49 from Iain Sandoe ---
[...]
> I can do darwin14 (I built 242408 last night with the patches-in-progress +
> __BLOCKS__) but that's a little bit more than the minimum
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #49 from Iain Sandoe ---
(In reply to r...@cebitec.uni-bielefeld.de from comment #48)
> > --- Comment #47 from Maxim Ostapenko ---
> [...]
> > Rainer, sorry for a dumb question: are you going to commit your fix for
> >
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #48 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #47 from Maxim Ostapenko ---
[...]
> Rainer, sorry for a dumb question: are you going to commit your fix for
> darwin_availabilityinternal part? Or should I just apply a
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #47 from Maxim Ostapenko ---
(In reply to r...@cebitec.uni-bielefeld.de from comment #45)
> > --- Comment #44 from Maxim Ostapenko ---
> [...]
> >> Otherwise the definition of SANITIZER_OS_TRACE results in
> >>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #45 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #44 from Maxim Ostapenko ---
[...]
>> Otherwise the definition of SANITIZER_OS_TRACE results in
>> libsanitizer/sanitizer_common/sanitizer_mac.cc making calls to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #46 from Dominique d'Humieres ---
Don't forget:
> For the record, note that configuring gcc with --disable-libsanitizer
> replace an ICE with accept-invalid in pr44348.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #44 from Maxim Ostapenko ---
(In reply to Jack Howarth from comment #41)
> (In reply to r...@cebitec.uni-bielefeld.de from comment #39)
> > > --- Comment #36 from Jack Howarth ---
> > > Created attachment 40044 [details]
> > > -->
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #43 from Iain Sandoe ---
(In reply to Jack Howarth from comment #42)
> (In reply to Jack Howarth from comment #41)
> > (In reply to r...@cebitec.uni-bielefeld.de from comment #39)
> > Otherwise the definition of SANITIZER_OS_TRACE
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #42 from Jack Howarth ---
(In reply to Jack Howarth from comment #41)
> (In reply to r...@cebitec.uni-bielefeld.de from comment #39)
> > > --- Comment #36 from Jack Howarth ---
> > > Created attachment 40044 [details]
> > > -->
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #41 from Jack Howarth ---
(In reply to r...@cebitec.uni-bielefeld.de from comment #39)
> > --- Comment #36 from Jack Howarth ---
> > Created attachment 40044 [details]
> > -->
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #40 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #37 from Jack Howarth ---
> Created attachment 40045
> --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40045=edit
> preprocessed source for sanitizer_mac.cc from
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #39 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #36 from Jack Howarth ---
> Created attachment 40044
> --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40044=edit
> fixincludes trace.h generated in stage 1
>
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #38 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
>
> --- Comment #35 from Jack Howarth ---
> Created attachment 40043
> -->
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #37 from Jack Howarth ---
Created attachment 40045
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40045=edit
preprocessed source for sanitizer_mac.cc from stage3
preprocessed source for sanitizer_mac.cc from stage3 generated
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #36 from Jack Howarth ---
Created attachment 40044
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40044=edit
fixincludes trace.h generated in stage 1
fixincludes trace.h generated in stage 1 on darwin15 using
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #35 from Jack Howarth ---
Created attachment 40043
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40043=edit
stock /usr/include/os/trace.h from OS X 10.11.6
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #34 from Eric Gallager ---
(In reply to Iain Sandoe from comment #23)
> (In reply to Eric Gallager from comment #22)
> >
> > To be specific, they're not supported by the FSF release of GCC. Apple's
> > fork of GCC supported blocks
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #33 from Jack Howarth ---
Alternative fix posted at
https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01366.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #32 from Jack Howarth ---
FYI, it looks like r242387 has introduced orthogonal breakage in the darwin
bootstrap...
[ -f stage_final ] || echo stage3 > stage_final
rm -f stage_current
make[4]: Nothing to be done for `all'.
make[3]:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #31 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #29 from Iain Sandoe ---
[...]
> FWIW, the SDKs don't generally change once N+1 is out, so I think that the
> fixes to 10.10 and 10.11 will not be fragile, they just need
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #30 from Jack Howarth ---
Created attachment 40035
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40035=edit
proposed fix for fixing darwin15 and earlier bootstraps
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #29 from Iain Sandoe ---
(In reply to Maxim Ostapenko from comment #28)
> So, perhaps I can commit it (from #15) as Jakub suggested to restore GCC
> bootstrap for now?
if we're going down that path can we make the conditional
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #28 from Maxim Ostapenko ---
So, perhaps I can commit it (from #15) as Jakub suggested to restore GCC
bootstrap for now?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #27 from Jack Howarth ---
IMHO, the fixincludes approach looks much more fragile than simply using the
approach suggested in Comment 5 of...
Index: libsanitizer/sanitizer_common/sanitizer_mac.cc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #26 from Jack Howarth ---
Created attachment 40034
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40034=edit
trace.h differences between darwin15 and darwin16
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #25 from Dominique d'Humieres ---
Confirmed provided I run genfixes in the fixincludes directory.
For the record, note that configuring gcc with --disable-libsanitizer replace
an ICE with accept-invalid in pr44348.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Rainer Orth changed:
What|Removed |Added
URL||https://gcc.gnu.org/ml/gcc-
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #23 from Iain Sandoe ---
(In reply to Eric Gallager from comment #22)
> (In reply to Iain Sandoe from comment #3)
> > (In reply to Maxim Ostapenko from comment #1)
> > > Eh, mine.
> > >
> > > typedef void
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Eric Gallager changed:
What|Removed |Added
CC||egall at gwmail dot gwu.edu
--- Comment
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #21 from Dominique d'Humieres ---
> Created attachment 40012 [details]
> Untested fix 2.
Bootstrap completed successfully with this patch.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #20 from Dominique d'Humieres ---
> Did you regen fixincl.x (with ./genfixes in the source tree)?
I did a clean bootstrap, but I did know that I had to run ./genfixes. BTW you
probably mean ./fixincludes/genfixes, isn't it?
I am
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #19 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #18 from Dominique d'Humieres ---
[...]
> Bootstrap is still broken with the patch:
[...]
Did you regen fixincl.x (with ./genfixes in the source tree)?
A macOS 10.12
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #18 from Dominique d'Humieres ---
> Created attachment 40013 [details]
> proposed fixincludes-based patch
>
> The attached patch passes fixincludes make check. I'll have to wait until
> tonight to test it for real on macOS 10.12,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #17 from Rainer Orth ---
Created attachment 40013
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40013=edit
proposed fixincludes-based patch
The attached patch passes fixincludes make check. I'll have to wait until
tonight
to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #16 from Jakub Jelinek ---
Preapproved. If/once Rainer will have a fixincludes patch, this can be
reverted.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #15 from Maxim Ostapenko ---
Created attachment 40012
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40012=edit
Untested fix 2.
Ok, thanks.
I'm attaching a second short-term fix for now.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE ---
> --- Comment #13 from Maxim Ostapenko ---
[...]
> The fixincludes fix looks cleaner, but it's harder to me to cook a patch
> because:
>
> 1) I have no experience with fixincludes.
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #13 from Maxim Ostapenko ---
(In reply to Rainer Orth from comment #11)
> (In reply to Jakub Jelinek from comment #5)
> > extern char **environ;
> > #endif
> >
> > -#if defined(__has_include) && __has_include()
> > +#if
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #12 from Rainer Orth ---
(In reply to Dominique d'Humieres from comment #10)
> > Attaching untested fix.
> > Dominique, could you try it?
>
> Now breaks with
[...]
> In file included from /usr/include/Availability.h:180:0,
>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Rainer Orth changed:
What|Removed |Added
CC||ro at gcc dot gnu.org
--- Comment #11
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #10 from Dominique d'Humieres ---
> Attaching untested fix.
> Dominique, could you try it?
Now breaks with
libtool: compile: /opt/gcc/build_w/./gcc/xgcc -shared-libgcc
-B/opt/gcc/build_w/./gcc -nostdinc++
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #9 from Jack Howarth ---
(In reply to Maxim Ostapenko from comment #6)
> Created attachment 40007 [details]
> Untested fix.
>
> Attaching untested fix.
> Dominique, could you try it?
The change fixes the bootstrap of current gcc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #8 from Maxim Ostapenko ---
(In reply to Dominique d'Humieres from comment #7)
> > Attaching untested fix.
> > Dominique, could you try it?
>
> Allow for ~2 hours.
Or better Jakub's fix, it looks cleaner.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Dominique d'Humieres changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #6 from Maxim Ostapenko ---
Created attachment 40007
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=40007=edit
Untested fix.
Attaching untested fix.
Dominique, could you try it?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #5 from Jakub Jelinek ---
extern char **environ;
#endif
-#if defined(__has_include) && __has_include()
+#if defined(__has_include) && __has_include() &&
defined(__clang__)
#define SANITIZER_OS_TRACE 1
#include
#else
is
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #4 from Maxim Ostapenko ---
(In reply to Iain Sandoe from comment #3)
> (In reply to Maxim Ostapenko from comment #1)
> > Eh, mine.
> >
> > typedef void (^os_trace_payload_t)(xpc_object_t xdict) looks very strange,
> > it seems that
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #3 from Iain Sandoe ---
(In reply to Maxim Ostapenko from comment #1)
> Eh, mine.
>
> typedef void (^os_trace_payload_t)(xpc_object_t xdict) looks very strange,
> it seems that it's an Objective-C declaration, right?
It's declaring
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
--- Comment #2 from Dominique d'Humieres ---
Unfortunately I don’t know the answers to the questions. I am under OS X
10.12.1 (aka darwin16.1) and Xcode 8.1.
/usr/lib/libc.dylib points to libSystem.B.dylib.
Dominique
> Le 9 nov. 2016 à 08:54,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Richard Biener changed:
What|Removed |Added
Target Milestone|--- |7.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78267
Maxim Ostapenko changed:
What|Removed |Added
CC||m.ostapenko at samsung dot com
---
58 matches
Mail list logo
