[Bug target/105719] RFE: fixincludes should handle Frameworks

2023-05-15 Thread bkorb at gnu dot org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105719

--- Comment #5 from Bruce Korb  ---
It's been a long time since I mucked with fixincludes. My first guess, without
going back and reading code, would be to provide fixincludes with a list of
trees to traverse and not have it burned into fixincludes at all. That might
even be helpful for cross compiles also. :)

[Bug target/93082] macOS Authorization.h needs fixinclude

2022-05-15 Thread bkorb at gnu dot org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #9 from Bruce Korb  ---
Um, I didn't finish my misthink for item#1 above. Please ignore. :)

[Bug target/93082] macOS Authorization.h needs fixinclude

2022-05-15 Thread bkorb at gnu dot org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082

--- Comment #8 from Bruce Korb  ---
It should not be terribly difficult to add another include tree for fixinc to
search. Also, unless 32 is cast as forever being the only value
kAuthorizationExternalFormLength could possibly ever have:

select=
"static const size_t kAuthorizationExternalFormLength = (32);\n";
c_fix = format;
c_fix_arg =
"enum { kAuthorizationExternalFormLength = %1 };\n";

BTW:
1. if you're going to simply replace text

2. on page https://gcc.gnu.org/wiki/GitMirror the "getting started" section
leads to this error:

> fatal: 'svn/trunk' is not a commit and a branch 'trunk' cannot be created 
> from it

(I don't have access to the GCC tree anymore [lost keys], so I'm starting
over.)

[Bug other/91085] fixincludes breaks

2021-06-27 Thread bkorb at gnu dot org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91085

--- Comment #15 from Bruce Korb  ---
Obviously, "print_quote()" was needed early on (1999) and then saved for
prosperity :). Your patch is inadequate because it will have to not expand
'linux' in a line such as:

#if __has_include()

In other words, it will have to skip over three flavors of quote. Or just two,
if you omit apostrophe quotes. In any event, the '<' character will have to be
matched with '>', which is a tiny change to the logic.

Don't forget to add tests in the final result.

[Bug other/91085] fixincludes breaks

2021-06-27 Thread bkorb at gnu dot org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91085

--- Comment #14 from Bruce Korb  ---
Reworking fixfixes.c seems pretty heavy duty.
I'm downloading the GCC sources now. I'll take a peek tomorrow.

[Bug other/91085] fixincludes breaks

2020-08-20 Thread bkorb at gnu dot org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91085

--- Comment #12 from Bruce Korb  ---
I'll put it on my to-do list, but I might be participating in a fire evacuation
tonight or tomorrow and I haven't built GCC in several years now. I'm going to
guess that you have to not do the substitution when the line contains something
like:

#[ \t]*if[ \t]+__glibc_has

[Bug tree-optimization/88973] [8/9 Regression] New -Wrestrict warning since r268048

2019-02-19 Thread bkorb at gnu dot org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88973

Bruce Korb  changed:

   What|Removed |Added

 CC||bkorb at gnu dot org

--- Comment #5 from Bruce Korb  ---
(In reply to Martin Sebor from comment #4)

> canonicalize_pathname.c: In function ‘canonicalize_pathname’:
> canonicalize_pathname.c:61:2: warning: ‘strcpy’ accessing 1 byte at offsets
> [0, 9223372036854775807] and [0, 9223372036854775807] may overlap 1 byte at
> offset 0 [-Wrestrict]
>61 |  strcpy( result + start + 1, result + i + 2 );
>   |  ^~~~
> strcpy (0x217f265 = "//bar", 0x217f267 = "bar"): 3
> /foo/bar

I have a copy of this code in my project, but I haven't been writing code for
several years now. How was this fixed? The best fix would be to determine the
string length and do memmove-s, but that's enough fiddling that I'd have to
clear cobwebs and spend a mess of time. If someone's already done that, ... :)

[Bug preprocessor/51776] fixincludes hacks around a C++ deficiency

2015-03-08 Thread bkorb at gnu dot org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51776

Bruce Korb bkorb at gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Bruce Korb bkorb at gnu dot org ---
This hack is no longer in inclhack.def.


[Bug target/57792] fixincludes doesn't honor the use of --with-sysroot during bootstrap

2013-07-04 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57792

Bruce Korb bkorb at gnu dot org changed:

   What|Removed |Added

 CC||bonzini at gnu dot org,
   ||ghazi at gcc dot gnu.org

--- Comment #2 from Bruce Korb bkorb at gnu dot org ---
Paolo did the config stuff, with Kaveh's help.
However, Jack Howarth may be in a better position to
make a patch since I do not have an Apple development
system.


[Bug preprocessor/51776] fixincludes hacks around a C++ deficiency

2012-10-08 Thread bkorb at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51776



--- Comment #3 from bkorb at gnu dot org 2012-10-08 17:46:04 UTC ---

(In reply to comment #2)

 adding ... PR as a dependency so Bruce gets prodded when it changes state



Bruce has now been prodded. :)  I will fix this in 3 weeks or so.


[Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-11 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

--- Comment #47 from bkorb at gnu dot org 2012-01-11 14:31:15 UTC ---
To eliminate any possible ambiguity, the patch is approved

On 01/10/12 23:49, andreast at gcc dot gnu.org wrote:
 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

 Andreas Toblerandreast at gcc dot gnu.org  changed:

 What|Removed |Added
 
   Status|NEW |ASSIGNED

 --- Comment #46 from Andreas Toblerandreast at gcc dot gnu.org  2012-01-11 
 07:49:41 UTC ---
 I'm going to apply the patch from comment #45 this evening.

 Bootstraped several times, make check in fixincludes successful.

 This is the CL I prepared:

 2012-01-11  Bruce Korbbk...@gnu.org
  Steven G. Karglka...@gcc.gnu.org
  Andreas Toblerandre...@fgznet.ch

  PR bootstrap/57105
  PR preprocessor/51776
  * inclhack.def (cdef_cplusplus): Add a replacement for [[noreturn]].
  * fixincl.x: Regenerate.
  * tests/base/sys/cdefs.h: Update.

  * genfixes: Remove the 'Ver.' from the version check.


Index: inclhack.def
===
--- inclhack.def(revision 183089)
+++ inclhack.def(working copy)
@@ -20,6 +20,7 @@
  FIXINC_DEBUG = yes;
  #endif

+
  /* On AIX when _LARGE_FILES is defined stdio.h defines fopen to
   * fopen64 etc. and this causes problems when building with g++
   * because cstdio udefs everything from stdio.h, leaving us with
@@ -1028,6 +1029,22 @@
  test_text = '#define  vfscanf__svfscanf';
  };

+/*
+ * 'g++ -std=c++11' defines __cplusplus to 201103L, which suggests
+ * that it conforms to ISO/IEC 14882:2011.  Until G++ fully conforms,
+ * it should not set __cplusplus to that value.  It currently does
+ * not support the [[noreturn]] procedure attribute.
+ * When it does, this hack should be removed.
+ * SEE:  gcc.gnu.org/bugzilla/show_bug.cgi?id=51776
+ */
+fix = {
+hackname  = cdef_cplusplus;
+files = sys/cdefs.h;
+select= '\[\[noreturn\]\]';
+c_fix = format;
+c_fix_arg = '__attribute__((__noreturn__))';
+test_text = #define _Noreturn[[noreturn]];
+};

  /*
   *  Fix various macros used to define ioctl numbers.
Index: tests/base/sys/cdefs.h
===
--- tests/base/sys/cdefs.h(revision 183089)
+++ tests/base/sys/cdefs.h(working copy)
@@ -9,6 +9,11 @@



+#if defined( CDEF_CPLUSPLUS_CHECK )
+#define _Noreturn__attribute__((__noreturn__))
+#endif  /* CDEF_CPLUSPLUS_CHECK */
+
+
  #if defined( FREEBSD_GCC3_BREAKAGE_CHECK )
  #if __GNUC__ == 2  __GNUC_MINOR__ = 7
  #endif  /* FREEBSD_GCC3_BREAKAGE_CHECK */
Index: genfixes
===
--- genfixes(revision 183089)
+++ genfixes(working copy)
@@ -62,7 +62,7 @@
  AG=autogen $AG
  set -e

-if [ -z `${AG} -v | fgrep 'Ver. 5.'` ]
+if [ -z `${AG} -v | fgrep ' 5.'` ]
  then
echo AutoGen appears to be out of date or not correctly installed.
echo Please download and install:


[Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-09 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

--- Comment #37 from bkorb at gnu dot org 2012-01-09 22:11:09 UTC ---
It is getting too confusing.

+/*
+ * 'g++ -std=c++11' defines __cplusplus to 201103L, which suggests
+ * that it conforms to ISO/IEC 14882:2011.  Until G++ fully conforms,
+ * it should not set __cplusplus to that value.  It currently does
+ * not support the [[noreturn]] procedure attribute.
+ * When it does, this hack should be removed.
+ * SEE:  gcc.gnu.org/bugzilla/show_bug.cgi?id=51776
+ */
+fix = {
+hackname  = cdef_cplusplus;
+files = sys/cdefs.h;
+select= '\[\[noreturn\]\]';
+c_fix = format;
+c_fix_arg = '__attribute__((__noreturn__))';
+test_text = #define _Noreturn [[noreturn]];
+};

This is the fix/hack that should be used.
There will also be a change required for tests/base/sys/cdefs.h.

The following is also correct, since I read a more recent GNU Coding
standards that makes it clear to not use Ver. in the version.

This is approved.  Regards, Bruce

Index: genfixes
===
--- genfixes(revision 182738)
+++ genfixes(working copy)
@@ -62,7 +62,7 @@ fi
 AG=autogen $AG
 set -e

-if [ -z `${AG} -v | fgrep 'Ver. 5.'` ]
+if [ -z `${AG} -v | fgrep ' 5.'` ]
 then
   echo AutoGen appears to be out of date or not correctly installed.
   echo Please download and install:


[Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-06 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

--- Comment #25 from bkorb at gnu dot org 2012-01-06 15:09:46 UTC ---
RE: Comment #16 through Comment #23 -- Do not use sed.  There is no compelling
reason to do so.  Please read the fixincludes README, wherein sed is
disparaged.  I'll add to that the fact that BSD has some non-POSIX treatments
of multi-line commands.  I think this is what you want (not specific to BSD):

+/*
+ * g++ -std=c++11 defines __cplusplus to 201103L, but does not
+ * properly support [[noreturn]].
+ */
+fix = {
+hackname  = cdef_cplusplus;
+files = sys/cdefs.h;
+select= '\[\[noreturn\]\]';
+c_fix = format;
+c_fix_arg = /* noreturn */;
+test_text = #define _Noreturn [[noreturn]];
+};

Note to self (Bruce): devise a way to compile this fix out
once GCC++ properly supports [[noreturn]].


[Bug preprocessor/51776] New: fixincludes hacks around a C++ deficiency

2012-01-06 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51776

 Bug #: 51776
   Summary: fixincludes hacks around a C++ deficiency
Classification: Unclassified
   Product: gcc
   Version: 4.7.0
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: preprocessor
AssignedTo: unassig...@gcc.gnu.org
ReportedBy: bk...@gnu.org


a new fixinclude hack is about to be added to paper over the fact that
g++ -std=c++11 claims full compliance, but is slightly deficient.
Once that is fixed, this new hack should be removed.  It will be
approximately thus:

+/*
+ * g++ -std=c++11 defines __cplusplus to 201103L, but does not
+ * properly support [[noreturn]].
+ */
+fix = {
+hackname  = cdef_cplusplus;
+files = sys/cdefs.h;
+select= '\[\[noreturn\]\]';
+c_fix = format;
+c_fix_arg = __attribute__((__noreturn__));
+test_text = #define _Noreturn [[noreturn]];
+};

CF: bug #51705 comment #25


[Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-06 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

--- Comment #30 from bkorb at gnu dot org 2012-01-06 16:10:33 UTC ---
(In reply to comment #28)
 I'll remember to add a comment to this PR once ...
I fully intend to remember, too.
Probably the appropriate thing is a new bug #51776


[Bug bootstrap/51705] [4.7 Regression] FreeBSD uses unsupported C++11 features when __cplusplus == 201103L

2012-01-06 Thread bkorb at gnu dot org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51705

--- Comment #32 from bkorb at gnu dot org 2012-01-06 16:14:08 UTC ---
(In reply to comment #29)
 +c_fix_arg = __attribute__\(\(__noreturn__\)\);

In a double quoted string, the backslash quotes always quote
the character that follows.  Here, it yields a noop, which
is fine because the c-fix-arg is scanned for %1 type markers,
not regular expressions.


[Bug c/25509] can't disable __attribute__((warn_unused_result))

2010-08-30 Thread bkorb at gnu dot org


--- Comment #25 from bkorb at gnu dot org  2010-08-30 14:42 ---
  gcc currently has no middle option.
 
 Also this attribute is not on by default in glibc so you are asking to  
 turn on the style based warnings.

(In reply to comment #24)
 FIXED in GCC 4.5

After having waded through this long series of comments, I am left
wondering just how this got addressed.  Does  --no-warn-unused-result
mean that fwrite() usage may be cast to void, or that it may be
treated as if it were a void procedure?  I think it is very reasonable
to warn if a returned result is not handled.  Casting to void is
a valid way to handle the result.  I would like warnings when returned
results are not handled.  What does the fix do?


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509



[Bug target/16300] Bug in vendor /usr/include/net/if.h needs fixincluding

2009-02-28 Thread bkorb at gnu dot org


--- Comment #17 from bkorb at gnu dot org  2009-02-28 16:39 ---
Bruce Korb left Veritas 3 years ago.  It's called Symantec now anyway.


-- 

bkorb at gnu dot org changed:

   What|Removed |Added

 CC|bkorb at veritas dot com|bkorb at gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=16300



[Bug bootstrap/29311] toplevel configure script does not test for GNU Make

2008-12-28 Thread bkorb at gnu dot org


--- Comment #2 from bkorb at gnu dot org  2008-12-28 23:01 ---
It would seem to me that requiring one to read through installation
documentation is unreasonable when a trivial change to the configure script can
tell the hapless builder what is wrong.  You are correct in that it is
documented.  But adding a useful error message in configure is still the right
thing to do.

Something like this:

--- configure.ac(revision 140070)
+++ configure.ac(working copy)
@@ -160,13 +160,24 @@
 #
 host_libs=intl mmalloc libiberty opcodes bfd readline tcl tk itcl libgui zlib
libcpp libdecnumber gmp mpfr ppl cloog

+[MAKE=${MAKE-make}
+case `${MAKE} --version` in
+GNU Make * ) : ;;
+* ) MAKE=gmake
+case `${MAKE} --version` in
+GNU Make * ) : ;;
+* ) AC_MSG_ERROR([GNU Make is required to build]) ;;
+esac
+;;
+esac ]
+
 # these tools are built for the host environment
 # Note, the powerpc-eabi build depends on sim occurring before gdb in order to
 # know that we are building the simulator.
 # binutils, gas and ld appear in that order because it makes sense to run
 # make check in that particular order.
 # If --enable-gold is used, gold will replace ld.
-host_tools=texinfo byacc flex bison binutils gas ld fixincludes gcc sid sim
gdb make patch prms send-pr gprof etc expect dejagnu ash bash bzip2 m4 autoconf
automake libtool diff rcs fileutils shellutils time textutils wdiff find
uudecode hello tar gzip indent recode release sed utils guile perl gawk
findutils gettext zip fastjar gnattools
+host_tools=texinfo byacc flex bison binutils gas ld fixincludes gcc sid sim
gdb ${MAKE} patch prms send-pr gprof etc expect dejagnu ash bash bzip2 m4
autoconf automake libtool diff rcs fileutils shellutils time textutils wdiff
find uudecode hello tar gzip indent recode release sed utils guile perl gawk
findutils gettext zip fastjar gnattools

 # libgcj represents the runtime libraries only used by gcj.
 libgcj=target-libffi \


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29311



[Bug bootstrap/29311] toplevel configure script does not test for GNU Make

2008-12-28 Thread bkorb at gnu dot org


--- Comment #4 from bkorb at gnu dot org  2008-12-29 01:24 ---
If GNU Make is only required for the GCC build, then the configure script
for the gcc piece is the only place where such code would be needed.
Anyway, my basic point is that it would be very helpful to not force folks
to find things in various manuals when a line or two of code makes the
problem easy to decipher and respond to.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29311



[Bug bootstrap/33200] install fails when trying to install fix-header since fix-header wasn't built

2008-01-19 Thread bkorb at gnu dot org


--- Comment #6 from bkorb at gnu dot org  2008-01-19 17:23 ---
fixincludes has nothing to do with fixproto, other than both working
with fixing up headers and having names that start with fix.  So,
I know little about it and even less about canadian crosses.  fix-header
also starts with fix, but has a different purpose:
gcc/fix-header.c:/* fix-header.c - Make C header file suitable for C++.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33200



[Bug other/32771] Fixincludes should fix realloc in stdlib.h in glibc

2007-07-15 Thread bkorb at gnu dot org


--- Comment #1 from bkorb at gnu dot org  2007-07-15 22:53 ---
I'd take ownership, but I cannot.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32771



[Bug bootstrap/30678] [4.3 regression] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-08 Thread bkorb at gnu dot org


--- Comment #15 from bkorb at gnu dot org  2007-02-08 20:53 ---
The commit notice went out to gcc-patches, too.  I'd have updated this,
but apparently I need more than gcc-CVS commit permissions to do so.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug bootstrap/30678] [4.3 regression] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-07 Thread bkorb at gnu dot org


--- Comment #13 from bkorb at gnu dot org  2007-02-07 21:02 ---
The problem was supposed to have been fixed:
http://gcc.gnu.org/ml/gcc-cvs/2007-02/msg00194.html
http://gcc.gnu.org/ml/gcc-cvs/2007-02/msg00172.html

If you are still having problems, please show the nature of the difficulty.
Specifically, the text that is mistakenly reformed or text that
should be reformed but is not.  THank you.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug bootstrap/30678] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-03 Thread bkorb at gnu dot org


--- Comment #5 from bkorb at gnu dot org  2007-02-03 18:32 ---
I'm looking at the inclhack fix now:

 fix = {
hackname  = glibc_c99_inline_4;
files = sys/sysmacros.h, '*/sys/sysmacros.h';
bypass= __STDC_VERSION__;
c_fix = format;
c_fix_arg = \n#if __STDC_VERSION__  19901L\nextern\n#endif\n;
c_fix_arg = extern;
test_text = -EOT
   __extension__ extern __inline unsigned int
   EOT;
 };

Unfortunately, there is no commentary about intended purpose and the current
discussion does not explain exactly what is needed.  I am going to take a guess
that the __extern_inline macro will not ever need this special treatment.
Therefore, the fix should look like the following.  Comments, please?

 fix = {
 hackname  = glibc_c99_inline_4;
 files = sys/sysmacros.h, '*/sys/sysmacros.h';
 bypass= __STDC_VERSION__;
 select= ' extern ';
 c_fix = format;
 c_fix_arg = \n#if __STDC_VERSION__  19901L\nextern\n#endif\n;
 test_text = -EOT
   __extension__ extern __inline unsigned int
   EOT;
 };


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug bootstrap/30678] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-03 Thread bkorb at gnu dot org


--- Comment #7 from bkorb at gnu dot org  2007-02-03 20:37 ---
Subject: Re:  sysmacros.h get currupt from Fixincludes
 with updated glibc.

ron3763 at msn dot com wrote:
 --- Comment #6 from ron3763 at msn dot com  2007-02-03 19:33 ---
 Well I guess is the intended purpose is to patch a much needed system file,
 even if glibc, hasn't been patched (aka updated), will in my case, I applied
 the patch set to jk or jh at glibc group.
 
 I can upload the patch here if you like.  If you need sysmacros.h pre-patch,
 post-install (glibc) and munged file you may email me direct.
 
 So my take is, you see fixed sysmacros.h file, bail-out??  is that possible? 
 Or do you need to create a test case to bail via 'else' clause.

If the current sysmacros.h header can be compiled by the current GCC
without any tweaking (fixinclude twiddling), then by far the simplest
method is to simply use ``__STDC_VERSION__'' somewhere in that header.
By using that string, you imply that the header is guarded against
semantic variations based on the version of STDC.  fixincludes is already
rigged to *not* apply the fix if this string is found in the header.

(BTW, simply adding:
/* __STDC_VERSION__  19901L aware */
would be sufficient.)

If it looks too ugly to add a fixincludes-skip-me marker, then
you need to say exactly how a fixed header can be identified.
Perhaps just finding no existence of  extern  is sufficient,
in which case the attached patch is all that is needed.

Thanks - Bruce
Index: tests/base/sys/sysmacros.h
===
--- tests/base/sys/sysmacros.h  (revision 120553)
+++ tests/base/sys/sysmacros.h  (working copy)
@@ -10,9 +10,10 @@


 #if defined( GLIBC_C99_INLINE_4_CHECK )
-__extension__ 
+__extension__
 #if __STDC_VERSION__  19901L
 extern
 #endif
- __inline unsigned int
+__inline unsigned int
+__extension__ __extern_inline unsigned int
 #endif  /* GLIBC_C99_INLINE_4_CHECK */
Index: inclhack.def
===
--- inclhack.def(revision 120553)
+++ inclhack.def(working copy)
@@ -1359,12 +1369,13 @@
 hackname  = glibc_c99_inline_4;
 files = sys/sysmacros.h, '*/sys/sysmacros.h';
 bypass= __STDC_VERSION__;
+select= ' extern ';
 c_fix = format;
 c_fix_arg = \n#if __STDC_VERSION__  19901L\nextern\n#endif\n;
-c_fix_arg = extern;
 test_text = -EOT
-__extension__ extern __inline unsigned int
-EOT;
+   __extension__ extern __inline unsigned int
+   __extension__ __extern_inline unsigned int
+   EOT;
 };


Index: fixincl.x
===
--- fixincl.x   (revision 120553)
+++ fixincl.x   (working copy)
@@ -2,11 +2,11 @@
  * 
  * DO NOT EDIT THIS FILE   (fixincl.x)
  * 
- * It has been AutoGen-ed  Saturday January  6, 2007 at 10:08:19 AM PST
+ * It has been AutoGen-ed  Saturday February  3, 2007 at 11:59:48 AM PST
  * From the definitionsinclhack.def
  * and the template file   fixincl
  */
-/* DO NOT SVN-MERGE THIS FILE, EITHER Sat Jan  6 10:08:19 PST 2007
+/* DO NOT SVN-MERGE THIS FILE, EITHER Sat Feb  3 11:59:48 PST 2007
  *
  * You must regenerate it.  Use the ./genfixes script.
  *
@@ -2318,14 +2318,21 @@
 #define apzGlibc_C99_Inline_4Machs (const char**)NULL

 /*
+ *  content selection pattern - do fix if pattern found
+ */
+tSCC zGlibc_C99_Inline_4Select0[] =
+extern ;
+
+/*
  *  content bypass pattern - skip fix if pattern found
  */
 tSCC zGlibc_C99_Inline_4Bypass0[] =
__STDC_VERSION__;

-#defineGLIBC_C99_INLINE_4_TEST_CT  1
+#defineGLIBC_C99_INLINE_4_TEST_CT  2
 static tTestDesc aGlibc_C99_Inline_4Tests[] = {
-  { TT_NEGREP,   zGlibc_C99_Inline_4Bypass0, (regex_t*)NULL }, };
+  { TT_NEGREP,   zGlibc_C99_Inline_4Bypass0, (regex_t*)NULL },
+  { TT_EGREP,zGlibc_C99_Inline_4Select0, (regex_t*)NULL }, };

 /*
  *  Fix Command Arguments for Glibc_C99_Inline_4
@@ -2336,7 +2343,6 @@
 #if __STDC_VERSION__  19901L\n\
 extern\n\
 #endif\n,
-extern,
 (char*)NULL };

 /* * * * * * * * * * * * * * * * * * * * * * * * * *
@@ -8420,7 +8426,7 @@
  *
  *  List of all fixes
  */
-#define REGEX_COUNT  250
+#define REGEX_COUNT  251
 #define MACH_LIST_SIZE_LIMIT 261
 #define FIX_COUNT207



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug bootstrap/30678] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-02 Thread bkorb at gnu dot org


--- Comment #2 from bkorb at gnu dot org  2007-02-02 14:57 ---
Thanks for all the detail.  I'll fix it to only do that for
extern as a full word.  (i.e. when not attached to a __
prefix or suffix)


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug bootstrap/30678] sysmacros.h get currupt from Fixincludes with updated glibc.

2007-02-02 Thread bkorb at gnu dot org


--- Comment #4 from bkorb at gnu dot org  2007-02-02 21:32 ---
I intend to do this tomorrow.  I cannot fiddle the bugzilla tho.
It says I'm only authorized to add comments.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30678



[Bug driver/29311] New: configure script does not test for GNU Make

2006-10-01 Thread bkorb at gnu dot org
Typescript from Solaris 9 using SUNWspro/bin and no
GNU tools available (i.e., make comes from that same
directory):

echo ./regex.o ./cplus-dem.o ./cp-demangle.o ./md5.o ./alloca.o
./argv.o./choose-temp.o ./concat.o ./cp-demint.o
./dyn-string.o./fdmatch.o ./fibheap.o ./floatformat.o ./fnmatch.o 
./fopen_unlocked.o   ./getopt.o
./getopt1.o ./getpwd.o ./getruntime.o ./hashtab.o
./hex.o./lbasename.o ./lrealpath.o 
./make-relative-prefix.o ./make-temp-file.o  ./objalloc.o
./obstack.o./partition.o ./pexecute.o ./physmem.o  
./pex-common.o ./pex-one.o ./pex-unix.o  ./safe-ctype.o
./sort.o ./spaces.o ./splay-tree.o ./strerror.o   ./strsignal.o./ternary.o 
./unlink-if-ordinary.o 
 ./xatexit.o ./xexit.o ./xmalloc.o ./xmemdup.o
./xstrdup.o./xstrerror.o ./xstrndup.o  required-list
make: Fatal error in reader: Makefile, line 51: Unexpected end of line seen
Current working directory /usr/share/src/gcc/gcc-4.1.1/_b/fixincludes
*** Error code 1
make: Fatal error: Command failed for target `all-fixincludes'
Current working directory /usr/share/src/gcc/gcc-4.1.1/_b
*** Error code 1
make: Fatal error: Command failed for target `all'

The line in question:

  target_noncanonical:=sparc-sun-solaris2.9

``:='' ??  If you are going to require GNU make, you *MUST* cause
configure to fail and issue such a message.  Thanks - Bruce


-- 
   Summary: configure script does not test for GNU Make
   Product: gcc
   Version: 4.2.0
Status: UNCONFIRMED
  Severity: normal
  Priority: P3
 Component: driver
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: bkorb at gnu dot org
 GCC build triplet: *-*-solaris*
  GCC host triplet: *-*-solaris*
GCC target triplet: *-*-solaris*


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29311



[Bug testsuite/23400] [4.1/4.2 Regression] make check fixinclude failure

2005-11-24 Thread bkorb at gnu dot org


--- Comment #8 from bkorb at gnu dot org  2005-11-25 07:25 ---
A couple of issues:
1.  Replacement fixes should not be checked, so it is interesting that
the failure shows up.

2.  fixincl should not create files without terminating new lines anyway.
I've just applied a patch to fixfixes.c to fix this problem.

I'll look into the former issue when my bootstrap finishes:)
I'd assign this thing to myself, but I guess I'm not powerful enough


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23400