https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
--- Comment #9 from Joshua Cogliati ---
Looking at write.c, there are multiple places where things like the pattern:
result = select_string (dtp, f, str_buf, _len, kind);
...
get_float_string (dtp, f, source , kind, 0, buffer,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
--- Comment #8 from Joshua Cogliati ---
Created attachment 44186
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44186=edit
Patch by keeping original length
This patches the problem by storing the allocated length in a separate
variable.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
--- Comment #7 from Joshua Cogliati ---
Created attachment 44185
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44185=edit
Patch by checking against original buffer
This is one possible patch for this problem, it just checks if the buffer
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
--- Comment #4 from Joshua Cogliati ---
And to replicate it with the simple program:
gfortran -Wall -g -o simple simple.f90
valgrind --leak-check=full ./simple
and you get things like:
==19171== 323 bytes in 1 blocks are definitely lost in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
--- Comment #3 from Joshua Cogliati ---
Created attachment 44150
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=44150=edit
simple program to demonstrate problem
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85840
Joshua Cogliati changed:
What|Removed |Added
CC||jjcogliati-r1 at yahoo dot com
Assignee: unassigned at gcc dot gnu.org
Reporter: jjcogliati-r1 at yahoo dot com
Target Milestone: ---
This bug comes from trying to find a memory leak in my own program.
gfortran --version
GNU Fortran (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Copyright (C) 2017 Free Software Foundation, Inc
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #30 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Yes, it is fixed so far as I am concerned. I checked out gcc trunk 205109, and
bootstraped it and tried it out on:
int main(int argc, char ** argv) {
int i = 3.14
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #27 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 31097
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31097action=edit
Patch to add -Wfloat-conversion option against trunk with new testcase
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #26 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 31065
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=31065action=edit
Patch to add -Wfloat-conversion option against trunk with new testcase
This adds
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Attachment #30979|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Attachment #30899|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #23 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 30980
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=30980action=edit
Patch to fixup gcc float conversions in GCC
This changes the float conversions
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Attachment #30913|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #19 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 30913
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=30913action=edit
Patch to add -Wfloat-conversion option against trunk
This version is against gcc
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #18 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
(In reply to Manuel López-Ibáñez from comment #17)
(In reply to Joshua Cogliati from comment #16)
This does not bootstrap trunk yet, because gcc has floating conversion
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Attachment #30873|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Attachment #30870|0 |1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
CC
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #9 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 30871
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=30871action=edit
some floating conversion issues
This tests three of the floating conversion
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #11 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Created attachment 30873
-- http://gcc.gnu.org/bugzilla/attachment.cgi?id=30873action=edit
Patch to add -Wfloat-conversion option
This version also is enabled with -Wextra
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #14 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
Manuel López-Ibáñez, thank you for the patch review. I will make the changes
you requested, and rebase it against svn trunk, and run bootstrap and
testsuite. It may be a few
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #7 from Joshua Cogliati jjcogliati-r1 at yahoo dot com ---
I wrote the patch for 4.8.1 (which is the easy part), now I will see if I can
get approval to submit it through the bureaucracies (the hard part).
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #5 from Joshua Cogliati jjcogliati-r1 at yahoo dot com 2012-06-22
12:29:14 UTC ---
(In reply to comment #3)
(In reply to comment #2)
I should have time to create a patch for this before 4.8 goes into stage 3.
Do
you think
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
--- Comment #2 from Joshua Cogliati jjcogliati-r1 at yahoo dot com 2012-04-16
12:16:45 UTC ---
Yes, it should also warn for non-constants, and also for other floating
decreases in accuracy such as:
float foo(double x) {
return x;
}
I should
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001
Bug #: 53001
Summary: -Wfloat-conversion should be available to warn about
floating point errors
Classification: Unclassified
Product: gcc
Version: unknown
Status:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49324
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Known to fail||4.6.1
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49324
Summary: iso_varying_string and reshape fail
Product: gcc
Version: 4.6.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
AssignedTo:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49324
--- Comment #2 from Joshua Cogliati jjcogliati-r1 at yahoo dot com 2011-06-08
16:30:16 UTC ---
(In reply to comment #1)
Not an analysis, just some observations ...
I get different results with different compilers:
gfortran 4.7:
array2d
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47367
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
CC
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47367
Joshua Cogliati jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
Status|WAITING |RESOLVED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47367
Summary: internal compiler error: verify_cgraph_node failed
Product: gcc
Version: 4.6.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
AssignedTo:
: jjcogliati-r1 at yahoo dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43298
--- Comment #1 from jjcogliati-r1 at yahoo dot com 2010-03-08 21:17 ---
program should be: (both exhibit the bug though, but this works if bug is not
present)
program nan_test
implicit none
character(15) :: nan = ' NAN -INF INF'
real :: a,b,c, d = 0.0
print
--- Comment #15 from jjcogliati-r1 at yahoo dot com 2010-01-13 23:27
---
(In reply to comment #14)
I am testing the workaround
Index: gcc/gimple.c
===
--- gcc/gimple.c(revision 155860)
+++ gcc/gimple.c
--- Comment #12 from jjcogliati-r1 at yahoo dot com 2010-01-12 21:14
---
(In reply to comment #10)
Subject: Re: Internal compiler exception in with gfortran
when using -fwhole-program -flto -fopenmp
On Mon, 11 Jan 2010, jjcogliati-r1 at yahoo dot com wrote
--- Comment #7 from jjcogliati-r1 at yahoo dot com 2010-01-11 15:50 ---
(In reply to comment #6)
Try
Index: gcc/gimple.c
===
--- gcc/gimple.c(revision 155739)
+++ gcc/gimple.c(working copy
--- Comment #9 from jjcogliati-r1 at yahoo dot com 2010-01-11 17:15 ---
My hunch, (and I could be wrong since my knowledge of gcc's tree code was zero
as of Friday morning) is that it is trying to find the array's min and max
size, but that only the min location is available
--- Comment #11 from jjcogliati-r1 at yahoo dot com 2010-01-11 18:58
---
(In reply to comment #10)
Subject: Re: Internal compiler exception in with gfortran
when using -fwhole-program -flto -fopenmp
On Mon, 11 Jan 2010, jjcogliati-r1 at yahoo dot com wrote
: normal
Priority: P3
Component: lto
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jjcogliati-r1 at yahoo dot com
GCC build triplet: x86_64-unknown-linux-gnu
GCC host triplet: x86_64-unknown-linux-gnu
GCC target triplet: x86_64-unknown-linux-gnu
--- Comment #2 from jjcogliati-r1 at yahoo dot com 2010-01-08 21:27 ---
(In reply to comment #1)
Can you run it in a debugger and print what 'code' actually is? Can you
check if removing -g fixes the ICE?
The ICE still happens when -g is removed. I'm working on trying
--- Comment #3 from jjcogliati-r1 at yahoo dot com 2010-01-08 21:38 ---
(In reply to comment #1)
Can you run it in a debugger and print what 'code' actually is? Can you
check if removing -g fixes the ICE?
Code is:
ERROR_MARK
(gdb) break tree.c:6592
Breakpoint 1 at 0x89a063: file
--- Comment #5 from jjcogliati-r1 at yahoo dot com 2010-01-08 22:28 ---
(In reply to comment #4)
Subject: Re: Internal compiler exception in with gfortran
when using -fwhole-program -flto -fopenmp
On Fri, 8 Jan 2010, jjcogliati-r1 at yahoo dot com wrote:
--- Comment #3
: 4.3.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libfortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jjcogliati-r1 at yahoo dot com
GCC build triplet: x86_64-redhat-linux
GCC host triplet: x86_64-redhat
--- Comment #3 from jjcogliati-r1 at yahoo dot com 2006-11-13 04:35 ---
(In reply to comment #2)
Use --disable-multilib as ppc-darwin is configured by default to also build
the
64bit libraries.
Why is this not a bug? --disable-multilib is not mentioned in
http://gcc.gnu.org
--- Comment #14 from jjcogliati-r1 at yahoo dot com 2006-06-28 18:02
---
This works in 4.1.0, so only 4.1.1 has this bug so far as I can tell.
--
jjcogliati-r1 at yahoo dot com changed:
What|Removed |Added
--- Comment #5 from jjcogliati-r1 at yahoo dot com 2006-05-24 12:49 ---
(In reply to comment #4)
(In reply to comment #3)
So in GCC 4.1.0, the only problem seems to be that _gfortran_runtime_error
is
not printing the filename and the line number and the line number seems
--- Comment #3 from jjcogliati-r1 at yahoo dot com 2006-05-10 13:54 ---
(In reply to comment #1)
Confirmed. Though sometimes I wonder if this is an over use of printf style
debugging.
rantWell, I have a fortran program. It ran fine for the first 10 and a half
hours
Priority: P3
Component: fortran
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: jjcogliati-r1 at yahoo dot com
GCC build triplet: i686-pc-linux-gnu
GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id
: jjcogliati-r1 at yahoo dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26791
at gcc dot gnu dot org
ReportedBy: jjcogliati-r1 at yahoo dot com
GCC build triplet: i686-pc-linux-gnu
GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26682
51 matches
Mail list logo
