[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Rainer Orth changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #23 from Rainer Orth --- (In reply to Eric Gallager from comment #22) > (In reply to Rainer Orth from comment #8) > > Fixed for 4.8.0. > > Rainer, do you want to remain the assignee for this? It was reopened for a > different platform than you originally opened it for... Although, then again: > > (In reply to Jason Merrill from comment #18) > > Author: jason > > Date: Wed Mar 6 15:34:11 2013 > > New Revision: 196493 > > > > URL: http://gcc.gnu.org/viewcvs?root=gcc=rev=196493 > > Log: > > PR debug/53363 > > * g++.dg/debug/dwarf2/thunk1.C: Skip on darwin. > > > > Modified: > > trunk/gcc/testsuite/ChangeLog > > trunk/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C > > ...did this fix it? If so we can just close it and it won't matter who the > assignee is. I don't see any failure of this test on any target, so it can be closed. Thanks for looking after this. Rainer
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org --- Comment #22 from Eric Gallager --- (In reply to Rainer Orth from comment #8) > Fixed for 4.8.0. Rainer, do you want to remain the assignee for this? It was reopened for a different platform than you originally opened it for... Although, then again: (In reply to Jason Merrill from comment #18) > Author: jason > Date: Wed Mar 6 15:34:11 2013 > New Revision: 196493 > > URL: http://gcc.gnu.org/viewcvs?root=gcc=rev=196493 > Log: > PR debug/53363 > * g++.dg/debug/dwarf2/thunk1.C: Skip on darwin. > > Modified: > trunk/gcc/testsuite/ChangeLog > trunk/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C ...did this fix it? If so we can just close it and it won't matter who the assignee is.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Richard Biener rguenth at gcc dot gnu.org changed: What|Removed |Added Target Milestone|4.8.3 |---
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Jakub Jelinek jakub at gcc dot gnu.org changed: What|Removed |Added Target Milestone|4.8.1 |4.8.2 --- Comment #20 from Jakub Jelinek jakub at gcc dot gnu.org --- GCC 4.8.1 has been released.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Jakub Jelinek jakub at gcc dot gnu.org changed: What|Removed |Added Target Milestone|4.8.0 |4.8.1 --- Comment #19 from Jakub Jelinek jakub at gcc dot gnu.org 2013-03-22 14:44:18 UTC --- GCC 4.8.0 is being released, adjusting target milestone.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #18 from Jason Merrill jason at gcc dot gnu.org 2013-03-06 15:34:19 UTC --- Author: jason Date: Wed Mar 6 15:34:11 2013 New Revision: 196493 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=196493 Log: PR debug/53363 * g++.dg/debug/dwarf2/thunk1.C: Skip on darwin. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Jack Howarth howarth at nitro dot med.uc.edu changed: What|Removed |Added CC||howarth at nitro dot ||med.uc.edu --- Comment #9 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-05 13:43:57 UTC --- This failure has re-appeared at r196444 on x86_64-apple-darwin12... FAIL: g++.dg/debug/dwarf2/thunk1.C -std=gnu++98 scan-assembler-times LFB3 5 FAIL: g++.dg/debug/dwarf2/thunk1.C -std=gnu++11 scan-assembler-times LFB3 5
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #10 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-05 13:48:03 UTC --- Created attachment 29584 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29584 m32 thunk1.s -std=gnu++98 on x86_64-apple-darwin12 at r196444 Generated with... /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/testsuite/g++/../../xg++ -B/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/testsuite/g++/../../ /sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20130304/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C -fno-diagnostics-show-caret -nostdinc++ -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/i386/libstdc++-v3/include/x86_64-apple-darwin12.2.0 -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/i386/libstdc++-v3/include -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20130304/libstdc++-v3/libsupc++ -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20130304/libstdc++-v3/include/backward -I/sw/src/fink.build/gcc48-4.8.0-1000/gcc-4.8-20130304/libstdc++-v3/testsuite/util -fmessage-length=0 -std=gnu++98 -g -fpic -fno-dwarf2-cfi-asm -S -m32 -o thunk1.s
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Jason Merrill jason at gcc dot gnu.org changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #11 from Jason Merrill jason at gcc dot gnu.org 2013-03-05 14:21:02 UTC --- It seems that darwin doesn't do PIC the way ELF targets do, so this test should be skipped.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #12 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-05 15:01:55 UTC --- (In reply to comment #11) It seems that darwin doesn't do PIC the way ELF targets do, so this test should be skipped. I also confirmed this with stock gcc trunk (to verify that it was unrelated to the proposed fix for PR target/51784 at http://gcc.gnu.org/ml/gcc-bugs/2013-02/msg00468.html).
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #13 from Dominique d'Humieres dominiq at lps dot ens.fr 2013-03-05 15:11:48 UTC --- (In reply to comment #9) This failure has re-appeared at r196444 on x86_64-apple-darwin12... FAIL: g++.dg/debug/dwarf2/thunk1.C -std=gnu++98 scan-assembler-times LFB3 5 FAIL: g++.dg/debug/dwarf2/thunk1.C -std=gnu++11 scan-assembler-times LFB3 5 There are two issues for x86_64-apple-darwin* (1) As noticed in comment #2: On Darwin/x86 (32-bit i386-apple-darwin11.3.0 compiler), LFB3 doesn't occur in thunk1.s at all. (2) Before revision 195842 the test was unsupported on x86_64-*-*. (In reply to comment #11) It seems that darwin doesn't do PIC the way ELF targets do, so this test should be skipped. What is supposed to be tested? Sould the whole test skipped on darwin or only the dg-final?
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #14 from Jason Merrill jason at gcc dot gnu.org 2013-03-05 15:41:15 UTC --- (In reply to comment #13) What is supposed to be tested? Should the whole test skipped on darwin or only the dg-final? The whole test; the test is verifying that the x86 PIC thunk doesn't have debug info, but Darwin doesn't emit that thunk.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363
--- Comment #15 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-05
16:55:07 UTC ---
(In reply to comment #14)
(In reply to comment #13)
What is supposed to be tested? Should the whole test skipped on darwin or
only
the dg-final?
The whole test; the test is verifying that the x86 PIC thunk doesn't have
debug
info, but Darwin doesn't emit that thunk.
Any idea how to disable this on darwin? While...
// { dg-do compile { target { { i?86-*-* || x86_64-*-* } { ! *-*-darwin* } }
} }
parses in dejagnu, the required...
// { dg-do compile { target { { i?86-*-* || x86_64-*-* } { ! *-*-darwin* }
ia32 } } }
doesn't...
ERROR: g++.dg/debug/dwarf2/thunk1.C -std=gnu++98: syntax error in target
selector target i?86-*-* || x86_64-*-*! *-*-darwin*ia32 for
dg-do 2 compile { target { { i?86-*-* || x86_64-*-* } { ! *-*-darwin* } {
ia32 } } }
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #16 from Jason Merrill jason at gcc dot gnu.org 2013-03-05 19:01:18 UTC --- If it's easier to just disable the dg-final, that's fine too.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #17 from Jack Howarth howarth at nitro dot med.uc.edu 2013-03-05 22:20:33 UTC --- (In reply to comment #16) If it's easier to just disable the dg-final, that's fine too. Patch posted at http://gcc.gnu.org/ml/gcc-patches/2013-03/msg00210.html. Can you commit it?
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #7 from Rainer Orth ro at gcc dot gnu.org 2013-02-07 09:55:56 UTC --- Author: ro Date: Thu Feb 7 09:55:48 2013 New Revision: 195842 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=195842 Log: Fix g++.dg/debug/dwarf2/thunk1.C (PR debug/53363) PR debug/53363 * g++.dg/debug/dwarf2/thunk1.C: Restrict to 32-bit x86. Add -fno-dwarf2-cfi-asm to dg-options. Adapt match count. Modified: trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Rainer Orth ro at gcc dot gnu.org changed: What|Removed |Added Status|NEW |RESOLVED URL||http://gcc.gnu.org/ml/gcc-p ||atches/2013-02/msg00292.htm ||l Resolution||FIXED AssignedTo|unassigned at gcc dot |ro at gcc dot gnu.org |gnu.org | --- Comment #8 from Rainer Orth ro at gcc dot gnu.org 2013-02-07 10:06:49 UTC --- Fixed for 4.8.0.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #6 from Jason Merrill jason at gcc dot gnu.org 2013-02-06 18:26:37 UTC --- OK.
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #5 from Rainer Orth ro at gcc dot gnu.org 2013-02-05 10:24:28 UTC --- Created attachment 29353 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=29353 proposed patch I've now looked a bit closer and came up with the attached patch: it restricts the test to 32-bit x86. Checking the difference between Linux/x86 and Solaris/x86, it turns out that Linux uses .cfi* directives, while Solaris does not. To account for this, I'm adding -fno-dwarf2-cfi-asm (enforcing -fdwarf2-cfi-asm didn't work) and update the match count. The resulting patch was tested on i386-pc-solaris2.11, i686-pc-unknown-linux-gnu and x86_64-unknown-linux-gnu. Ok for mainline? Rainer
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 Rainer Orth ro at gcc dot gnu.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2013-02-05 Target Milestone|--- |4.8.0 Ever Confirmed|0 |1
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE ro at CeBiTec dot Uni-Bielefeld.DE 2012-05-16 10:51:33 UTC --- --- Comment #1 from Jason Merrill jason at gcc dot gnu.org 2012-05-15 19:09:37 UTC --- Yes, the test should only run in 32-bit mode. For me, on i686-unknown-linux-gnu the test passes. What are the uses of LFB3 on Solaris for? The failure on linux is with 32-bit binaries in my case, but only for the -m64 compilation, which shouldn't be run in the first place. I've recompiled the file on Solaris/x86 with -dA. Those are the instances of LFB3: .LFB3: .long .LFB3 / FDE initial location .long .LFE3-.LFB3 / FDE address range .long .LFB3@GOTOFF/ FDE initial location .long .LFE3-.LFB3 / FDE address range I'm also attaching the complete file. On Darwin/x86 (32-bit i386-apple-darwin11.3.0 compiler), LFB3 doesn't occur in thunk1.s at all. Rainer
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #4 from Rainer Orth ro at gcc dot gnu.org 2012-05-16 10:53:01 UTC --- Created attachment 27420 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=27420 32-bit thunk1.s -dA on i386-apple-darwin11.3.0
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #3 from Rainer Orth ro at gcc dot gnu.org 2012-05-16 10:52:26 UTC --- Created attachment 27419 -- http://gcc.gnu.org/bugzilla/attachment.cgi?id=27419 32-bit thunk1.s -dA on i386-pc-solaris2.10 configured to use gas
[Bug debug/53363] g++.dg/debug/dwarf2/thunk1.C FAILs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53363 --- Comment #1 from Jason Merrill jason at gcc dot gnu.org 2012-05-15 19:09:37 UTC --- Yes, the test should only run in 32-bit mode. For me, on i686-unknown-linux-gnu the test passes. What are the uses of LFB3 on Solaris for?
