[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Tamar Christina changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #20 from Tamar Christina --- I'll continue with the miscompile in PR113539 which I think is a duplicate of PR113467 which I'll verify now.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #19 from Tamar Christina --- *** Bug 113555 has been marked as a duplicate of this bug. ***
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Tamar Christina changed: What|Removed |Added CC||dcb314 at hotmail dot com --- Comment #18 from Tamar Christina --- *** Bug 113561 has been marked as a duplicate of this bug. ***
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #17 from GCC Commits --- The master branch has been updated by Tamar Christina : https://gcc.gnu.org/g:72429448fd16733f876b282bb37a0653049c446d commit r14-8382-g72429448fd16733f876b282bb37a0653049c446d Author: Tamar Christina Date: Wed Jan 24 07:37:17 2024 + middle-end: fix epilog reductions when vector iters peeled [PR113364] This fixes a bug where vect_create_epilog_for_reduction does not handle the case where all exits are early exits. In this case we should do like induction handling code does and not have a main exit. This shows that some new miscompiles are happening (stage3 is likely miscompiled) but that's unrelated to this patch and I'll look at it next. gcc/ChangeLog: PR tree-optimization/113364 * tree-vect-loop.cc (vect_create_epilog_for_reduction): If all exits all early exits then we must reduce from the first offset for all of them. gcc/testsuite/ChangeLog: PR tree-optimization/113364 * gcc.dg/vect/vect-early-break_107-pr113364.c: New test.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #16 from Tamar Christina --- Ok, I've submitted the patch since the ICE and miscompare are unrelated. I'll keep this ticket open in any case. The miscompares didn't happen based on commits from ~2 weeks ago, So this will give me a place to start. Hopefully send a patch for those tomorrow.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #15 from Tamar Christina --- Ok, the fix fixes the ICE but after rebasing to trunk I get a misscompile during bootstrap which miscompiles the x86 backend. This is likely related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113539 so tracking it down...
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #14 from Tamar Christina --- Yes I had to rerun my baseline after updating trunk. Will post patch once peak finishes
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #13 from Tamar Christina --- Yes I had to rerun my baseline after updating trunk. Will post patch once peak finishes
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Richard Biener changed: What|Removed |Added Last reconfirmed|2024-01-13 00:00:00 |2024-1-23 --- Comment #12 from Richard Biener --- Re-confirmed after my fixes btw.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #11 from Jakub Jelinek --- Like in PR113374, started to ICE with one message in r14-7194-g6cb155a6cf314232248a12bdd395ed4151ae5a28, another one in r14-7195-g411de96dbf2bdafc7a90ebbfc63e68afd6388d29 and yet another one r14-7196-g99c0a540d6689ede068f9ba98af6f38c3cd71362 which is what we get until latest trunk.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Richard Biener changed: What|Removed |Added Priority|P3 |P1
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 --- Comment #10 from Sam James --- (In reply to Tamar Christina from comment #8) > Hmm curious, does it work for you with --with-build-config='bootstrap-O3' > that's how I tested it before Will have a look. I'll try ignore the bootstrap failure and build userland stuff now so we can get some other cases if any. Did you have -march= too? I imagine bare '-O2' or '-O3' will be ok on amd64. I built with the above configure args but also: 1. make -j32 -l32 'STAGE1_CFLAGS=-O3 -march=znver2 -pipe' 'BOOT_CFLAGS=-O3 -march=znver2 -pipe' ... 2. CFLAGS=... exported in the env
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364
--- Comment #9 from Tamar Christina ---
vect_create_epilog_for_reduction needs to handle the case where the vectorizer
has picked a different exit than the main one.
diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc
index eccf0953bba..6f761a4a78f 100644
--- a/gcc/tree-vect-loop.cc
+++ b/gcc/tree-vect-loop.cc
@@ -5965,7 +5965,8 @@ vect_create_epilog_for_reduction (loop_vec_info
loop_vinfo,
loop-closed PHI of the inner loop which we remember as
def for the reduction PHI generation. */
bool double_reduc = false;
- bool main_exit_p = LOOP_VINFO_IV_EXIT (loop_vinfo) == loop_exit;
+ bool main_exit_p = LOOP_VINFO_IV_EXIT (loop_vinfo) == loop_exit
+&& !LOOP_VINFO_EARLY_BREAKS_VECT_PEELED (loop_vinfo);
stmt_vec_info rdef_info = stmt_info;
if (STMT_VINFO_DEF_TYPE (stmt_info) == vect_double_reduction_def)
{
fixes it. But would be good if I can reproduce the bootstrap issue. Will try
with provided options.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Tamar Christina changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |tnfchris at gcc dot gnu.org Status|NEW |ASSIGNED --- Comment #8 from Tamar Christina --- Hmm curious, does it work for you with --with-build-config='bootstrap-O3' that's how I tested it before
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Andrew Pinski changed: What|Removed |Added Target||aarch64-linux-gnu ||x86_64-linux-gnu --- Comment #7 from Andrew Pinski --- Note the testcase also ICEs on aarch64 with just -O3.
[Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364 Andrew Pinski changed: What|Removed |Added Summary|[14 regression] Failed |[14 regression] ICE |bootstrap |verify_ssa: `definition in ||block N does not dominate ||use in block` with `-O3 ||-march=znver2` Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Last reconfirmed||2024-01-13
