[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread pinskia at gcc dot gnu.org 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

Andrew Pinski pinskia at gcc dot gnu.org changed:

   What|Removed |Added

 Target|x86_64-apple-darwin10.4.0   |*-darwin10.4.0
  Component|c   |target
   Host|x86_64-apple-darwin10.4.0   |
   Target Milestone|--- |4.6.0
Summary|error: '-fsplit-stack'  |[4.6 Regression] error:
   |currently only supported on |'-fsplit-stack' currently
   |GNU/Linux   |only supported on GNU/Linux
  Build|x86_64-apple-darwin10.4.0   |
   Severity|normal  |major

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread ian at airs dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

Ian Lance Taylor ian at airs dot com changed:

   What|Removed |Added

 CC||ian at airs dot com

--- Comment #2 from Ian Lance Taylor ian at airs dot com 2010-09-28 15:09:07 
UTC ---
That shouldn't happen, because flag_split_stack is initialized to -1, and you
should only see that error if flag_split_stack != -1 in decode_options.  Can
you find out what is setting flag_split_stack to a value other than -1?

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread dominiq at lps dot ens.fr 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

--- Comment #3 from Dominique d'Humieres dominiq at lps dot ens.fr 2010-09-28 
15:19:29 UTC ---
 That shouldn't happen, because flag_split_stack is initialized to -1, and you
 should only see that error if flag_split_stack != -1 in decode_options.  Can
 you find out what is setting flag_split_stack to a value other than -1?

In gcc/opts.c at lines 1092-1102, I see

  if (flag_split_stack == -1)
flag_split_stack = 0;
  else
{
  if (!targetm.supports_split_stack (true))
{
  error (%-fsplit-stack% is not supported by 
 this compiler configuration);
  flag_split_stack = 0;
}
}

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread howarth at nitro dot med.uc.edu 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

Jack Howarth howarth at nitro dot med.uc.edu changed:

   What|Removed |Added

 CC||howarth at nitro dot
   ||med.uc.edu

--- Comment #4 from Jack Howarth howarth at nitro dot med.uc.edu 2010-09-28 
16:20:31 UTC ---
(In reply to comment #3)
  That shouldn't happen, because flag_split_stack is initialized to -1, and 
  you
  should only see that error if flag_split_stack != -1 in decode_options.  Can
  you find out what is setting flag_split_stack to a value other than -1?
 
 In gcc/opts.c at lines 1092-1102, I see
 
   if (flag_split_stack == -1)
 flag_split_stack = 0;
   else
 {
   if (!targetm.supports_split_stack (true))
 {
   error (%-fsplit-stack% is not supported by 
  this compiler configuration);
   flag_split_stack = 0;
 }
 }

I can confirm on x86_64-apple-darwin that the section...

   if (flag_split_stack == -1)
 flag_split_stack = 0;

is being executed during the compilation of /gcc.dg/pr37106-1.c

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread ian at airs dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

--- Comment #5 from Ian Lance Taylor ian at airs dot com 2010-09-28 16:32:16 
UTC ---
Dominique: yes, but flag_split_stack should be -1 going into that code, so the
effect of that should be to set flag_split_stack to 0.  Can you confirm that
the generated file options.h was correctly regenerated in your build?  It
should contain the lines

/* Set by -fsplit-stack.
   Generate discontiguous stack frames  */
int flag_split_stack = -1;

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread dominiq at lps dot ens.fr 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

--- Comment #6 from Dominique d'Humieres dominiq at lps dot ens.fr 2010-09-28 
17:01:07 UTC ---
 Dominique: yes, but flag_split_stack should be -1 going into that code, so the
 effect of that should be to set flag_split_stack to 0.  Can you confirm that
 the generated file options.h was correctly regenerated in your build?  It
 should contain the lines

 /* Set by -fsplit-stack.
Generate discontiguous stack frames  */
 int flag_split_stack = -1;

It does not:

[macbook] gcc/build_w% grep flag_split_stack *gcc/options.h
gcc/options.h:extern int flag_split_stack;
prev-gcc/options.h:extern int flag_split_stack;
stage1-gcc/options.h:extern int flag_split_stack;

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread ian at airs dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

--- Comment #7 from Ian Lance Taylor ian at airs dot com 2010-09-28 17:14:04 
UTC ---
I'm sorry, I said options.h, but of course I meant options.c.  Can you check
options.c?

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread ian at gcc dot gnu.org 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

--- Comment #8 from ian at gcc dot gnu.org ian at gcc dot gnu.org 2010-09-28 
18:22:19 UTC ---
Author: ian
Date: Tue Sep 28 18:22:13 2010
New Revision: 164695

URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=164695
Log:
PR target/45815
* opts.c (decode_options): Don't test whether the target supports
split stack if flag_split_stack == 0.

Modified:
trunk/gcc/ChangeLog
trunk/gcc/opts.c

[Bug target/45815] [4.6 Regression] error: '-fsplit-stack' currently only supported on GNU/Linux

2010-09-28 Thread ian at airs dot com 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45815

Ian Lance Taylor ian at airs dot com changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||FIXED

--- Comment #9 from Ian Lance Taylor ian at airs dot com 2010-09-28 18:27:15 
UTC ---
Should be fixed now.  Thanks for the bug report.