[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

--- Comment #8 from Jeffrey A. Law  ---
Author: law
Date: Tue Feb  9 19:16:30 2016
New Revision: 233253

URL: https://gcc.gnu.org/viewcvs?rev=233253=gcc=rev
Log:
2015-04-25  Daniel Starke  

PR target/65867
* ssp.c: Added wincrypt.h include for Windows targets.

Modified:
trunk/libssp/ChangeLog
trunk/libssp/ssp.c

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Jakub Jelinek  changed:

   What|Removed |Added

 CC||dj at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek  ---
Kai or DJ, is the patch ok for trunk/gcc 5?
Is that header always available if
#if defined (_WIN32) && !defined (__CYGWIN__)
or should it be guarded say by
#ifdef HAVE_WINCRYPT_H
and wincrypt.h added to AC_CHECK_HEADERS in configure?
The ChangeLog entry is wrong, libssp/ prefix shouldn't be there and on the
other side this PR should be mentioned there, but that is something that can be
trivially changed by the committer.
I can commit it if anybody from the GCC maintainers that know something about
Windows acks it.

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Richard Biener  changed:

   What|Removed |Added

   Target Milestone|5.3 |5.4

--- Comment #6 from Richard Biener  ---
GCC 5.3 is being released, adjusting target milestone.

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Richard Biener rguenth at gcc dot gnu.org changed:

   What|Removed |Added

   Target Milestone|5.2 |5.3

--- Comment #5 from Richard Biener rguenth at gcc dot gnu.org ---
GCC 5.2 is being released, adjusting target milestone to 5.3.

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[daniel.f.starke at freenet dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

--- Comment #4 from Daniel Starke daniel.f.starke at freenet dot de ---
I have already sent a patch to the ML.
https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01539.html

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Richard Biener rguenth at gcc dot gnu.org changed:

   What|Removed |Added

   Priority|P3  |P2

--- Comment #3 from Richard Biener rguenth at gcc dot gnu.org ---
So...?  Would be nice to fix for 5.2.

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Kai Tietz ktietz at gcc dot gnu.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Last reconfirmed||2015-04-25
 Ever confirmed|0   |1

--- Comment #2 from Kai Tietz ktietz at gcc dot gnu.org ---
Well, that this include is required seems to me like a bug in mingw.org, as
wincrypt.h should be auto-included by windows.h.  Nevertheless this is a
trivial patch, so it is ok.  Please post it to ML, and I will take care to
apply.

Thanks

[Bug target/65867] [5/6 Regression] bootstrap fails for mingw32 due to missing header in ssp.c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65867

Jakub Jelinek jakub at gcc dot gnu.org changed:

   What|Removed |Added

 CC||jakub at gcc dot gnu.org,
   ||ktietz at gcc dot gnu.org
Summary|[5 Regression] bootstrap|[5/6 Regression] bootstrap
   |fails for mingw32 due to|fails for mingw32 due to
   |missing header in ssp.c |missing header in ssp.c

--- Comment #1 from Jakub Jelinek jakub at gcc dot gnu.org ---
Supposedly started with r220559.