[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 Andrew Pinski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #20 from Andrew Pinski --- Fixed so closing.
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #19 from Xi Ruoyao --- Fixed on trunk.
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #18 from CVS Commits --- The master branch has been updated by Xi Ruoyao : https://gcc.gnu.org/g:3363022ed810a2797c47867890547c8f73163257 commit r12-5477-g3363022ed810a2797c47867890547c8f73163257 Author: Xi Ruoyao Date: Thu Nov 18 18:46:12 2021 +0800 fixincludes: don't abort() on access failure [PR103306] Some distro may ship dangling symlinks in include directories, triggers the access failure. Skip it and continue to next header instead of being to panic. Restore to old behavior before r12-5234 but without resurrecting the problematic getcwd() call, by using the environment variable "INPUT" exported by fixinc.sh. Tested on x86_64-linux-gnu, with a dangling symlink intentionally injected into /usr/include. fixincludes/ PR bootstrap/103306 * fixincl.c (process): Don't call abort().
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 Xi Ruoyao changed: What|Removed |Added CC||bkorb at gnu dot org --- Comment #17 from Xi Ruoyao --- (In reply to Zdenek Sojka from comment #16) > (In reply to Xi Ruoyao from comment #15) > > patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html > > Thank you for the patch; it fixes non-bootstrap build for me. I didn't check > full bootstrap yet. > > Is there a chance to check why is there the strange behavior now, with the > abort() in fixincludes? > - parallel build hangs (eg. no "Error" or "Waiting for unfinished jobs" > message from make) > - non-parallel build succeeds (even though fixincludes aborted) I think the reason is when fixinc.sh invokes fixincl executable, it does not check if fixincl succeeds. Then if fixincl fails, it may leave the building into a inconsistent status. On my system the parallel build fails with "cannot find config.status".
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #16 from Zdenek Sojka --- (In reply to Xi Ruoyao from comment #15) > patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html Thank you for the patch; it fixes non-bootstrap build for me. I didn't check full bootstrap yet. Is there a chance to check why is there the strange behavior now, with the abort() in fixincludes? - parallel build hangs (eg. no "Error" or "Waiting for unfinished jobs" message from make) - non-parallel build succeeds (even though fixincludes aborted)
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #15 from Xi Ruoyao --- patch: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584815.html
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #14 from Jakub Jelinek --- No matter what, IMO assertions or aborts should be for bugs in the tool (fixincl in this case), something that shouldn't happen if the tool doesn't have bugs, while errors or possibly ignored errors should be for the case where the bug is outside of the tool like in this case. And, for a tool like fixincl, the big question is if it should be a fatal error or just warning or non-fatal error, something the tool can survive and continue with next header.
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #13 from Zdenek Sojka --- (In reply to Xi Ruoyao from comment #12) > I'll make a workaround in maybe an hour... > > But why should a distro ship broken symlinks? It broke during on of the updates, probably around 2017.
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #12 from Xi Ruoyao --- I'll make a workaround in maybe an hour... But why should a distro ship broken symlinks?
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 --- Comment #11 from Zdenek Sojka --- I can observe broken header symlinks on other long-standing Gentoo systems. I don't know what's the situation like for other distros.
[Bug bootstrap/103306] [12 Regression] parallel build hangs since r12-5234-g04c5a9 when /usr/include includes broken symbolic links
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103306 Andrew Pinski changed: What|Removed |Added Summary|parallel build hangs since |[12 Regression] parallel |r12-5234-g04c5a91d068c4ca2f |build hangs since |09c2bc206fce00db9d1790b |r12-5234-g04c5a9 when ||/usr/include includes ||broken symbolic links Target Milestone|--- |12.0
