[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-10 Thread barry.revzin at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #13 from Barry Revzin --- Thanks Marek!

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-10 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Marek Polacek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-10 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #11 from Marek Polacek --- Author: mpolacek Date: Fri May 10 14:57:22 2019 New Revision: 271066 URL: https://gcc.gnu.org/viewcvs?rev=271066=gcc=rev Log: PR c++/78010 - bogus -Wsuggest-override warning on final function.

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-10 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #10 from Marek Polacek --- Author: mpolacek Date: Fri May 10 14:53:30 2019 New Revision: 271065 URL: https://gcc.gnu.org/viewcvs?rev=271065=gcc=rev Log: PR c++/78010 - bogus -Wsuggest-override warning on final function.

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-06 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Marek Polacek changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2019-05-06 Thread barry.revzin at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Barry Revzin changed: What|Removed |Added CC||barry.revzin at gmail dot com ---

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2018-01-10 Thread albert.astals.cid at kdab dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Albert Astals Cid changed: What|Removed |Added CC||albert.astals.cid at kdab dot com

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-10-05 Thread lloyd at randombit dot net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Jack Lloyd changed: What|Removed |Added CC||lloyd at randombit dot net --- Comment #6

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #5 from Jonathan Wakely --- (In reply to Arnaud Desitter from comment #3) > Interesting reference. Note that "virtual + final" can be useful even if the > core guidelines discourage its use. > > struct A { > virtual void f()

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread ol.rakhimov at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #4 from ol.rakhimov at gmail dot com --- (In reply to Arnaud Desitter from comment #3) > Interesting reference. Note that "virtual + final" can be useful even if the > core guidelines discourage its use. > > struct A { > virtual

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread arnaud02 at users dot sourceforge.net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #3 from Arnaud Desitter --- Interesting reference. Note that "virtual + final" can be useful even if the core guidelines discourage its use. struct A { virtual void f() final; }; struct B : A { // "void f()" cannot be defined

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 --- Comment #2 from Jonathan Wakely --- https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rh-override says that virtual functions should use exactly one of virtual, override or final. Which agrees with the suggestion

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Jonathan Wakely changed: What|Removed |Added Keywords||diagnostic

[Bug c++/78010] --Wsuggest-override reports a redundant warning on a 'final' method

2017-04-25 Thread arnaud02 at users dot sourceforge.net
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78010 Arnaud Desitter changed: What|Removed |Added CC||arnaud02 at users dot sourceforge.