[Bug c++/90428] -Wredundant-move could warn for more cases
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90428 Marek Polacek changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #4 from Marek Polacek --- Should be fixed.
[Bug c++/90428] -Wredundant-move could warn for more cases
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90428
--- Comment #3 from CVS Commits ---
The trunk branch has been updated by Marek Polacek :
https://gcc.gnu.org/g:6c136d53e89e32fe9d22e41e5df89c08d3470049
commit r13-2097-g6c136d53e89e32fe9d22e41e5df89c08d3470049
Author: Marek Polacek
Date: Wed Aug 17 13:36:52 2022 -0400
c++: Extend -Wredundant-move for const-qual objects [PR90428]
In this PR, Jon suggested extending the -Wredundant-move warning
to warn when the user is moving a const object as in:
struct T { };
T f(const T& t)
{
return std::move(t);
}
where the std::move is redundant, because T does not have
a T(const T&&) constructor (which is very unlikely). Even with
the std::move, T(T&&) would not be used because it would mean
losing the const. Instead, T(const T&) will be called.
I had to restructure the function a bit, but it's better now. This patch
depends on my other recent patches to maybe_warn_pessimizing_move.
PR c++/90428
gcc/cp/ChangeLog:
* typeck.cc (can_do_rvo_p): Rename to ...
(can_elide_copy_prvalue_p): ... this.
(maybe_warn_pessimizing_move): Extend the
-Wredundant-move warning to warn about std::move on a
const-qualified object.
gcc/testsuite/ChangeLog:
* g++.dg/cpp0x/Wredundant-move1.C: Adjust dg-warning.
* g++.dg/cpp0x/Wredundant-move9.C: Likewise.
* g++.dg/cpp0x/Wredundant-move10.C: New test.
[Bug c++/90428] -Wredundant-move could warn for more cases
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90428 Marek Polacek changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org Status|NEW |ASSIGNED
[Bug c++/90428] -Wredundant-move could warn for more cases
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90428 Marek Polacek changed: What|Removed |Added CC||mpolacek at gcc dot gnu.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Last reconfirmed||2022-07-16 --- Comment #2 from Marek Polacek --- Confirmed.
[Bug c++/90428] -Wredundant-move could warn for more cases
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90428 Eric Gallager changed: What|Removed |Added CC||egallager at gcc dot gnu.org See Also||https://gcc.gnu.org/bugzill ||a/show_bug.cgi?id=81159, ||https://gcc.gnu.org/bugzill ||a/show_bug.cgi?id=67906 --- Comment #1 from Eric Gallager --- kinda related to other requests for improvements to warnings regarding std::move, such as bug 81159 and bug 67906
