--- Comment #17 from mueller at gcc dot gnu dot org 2007-03-10 17:26
---
Subject: Bug 17946
Author: mueller
Date: Sat Mar 10 17:26:33 2007
New Revision: 122798
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=122798
Log:
2007-03-10 Dirk Mueller [EMAIL PROTECTED]
PR
--- Comment #18 from manu at gcc dot gnu dot org 2007-03-10 21:43 ---
(In reply to comment #17)
Modified:
trunk/gcc/testsuite/ChangeLog
Just Changelog changes??
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17946
--- Comment #13 from mueller at gcc dot gnu dot org 2007-03-09 16:16
---
Subject: Bug 17946
Author: mueller
Date: Fri Mar 9 16:16:35 2007
New Revision: 122751
URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=122751
Log:
2007-03-09 Dirk Mueller [EMAIL PROTECTED]
PR
--- Comment #14 from mueller at gcc dot gnu dot org 2007-03-09 16:17
---
Fixed for 4.3.
--
mueller at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #15 from pinskia at gcc dot gnu dot org 2007-03-10 02:30
---
on spu-elf, I get:
cc1plus: error: unrecognized command line option -Winvariant-expr^M
FAIL: g++.dg/warn/Wlogical-op-1.C (test for warnings, line 31) FAIL:
g++.dg/warn/Wlogical-op-1.C (test for warnings, line
--- Comment #16 from pinskia at gcc dot gnu dot org 2007-03-10 02:33
---
(In reply to comment #15)
on spu-elf, I get:
Likewise for the C testcase too.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17946
--- Comment #12 from mueller at gcc dot gnu dot org 2007-02-19 10:21
---
I've submitted a patch
--
mueller at gcc dot gnu dot org changed:
What|Removed |Added
--- Comment #11 from trt at acm dot org 2006-01-24 20:33 ---
HP liked this warning suggestion. It will be in their next compiler release.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17946
--- Additional Comments From trt at acm dot org 2004-12-08 18:48 ---
I should mention there is a hack for the problem noted in comment #5: do the
temporary truthvalue conversions with warnings suppressed.
That is, change the two instances of
tree t = lang_hooks.truthvalue_conversion
--- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-14 14:31
---
I still say that people do have a 4 in their code meaning a != 0 4 !=0. Also a
1 should be
caught too but that would just give too many false postives so there is no way for GCC
to warn about
this.
--- Additional Comments From trt at acm dot org 2004-10-14 15:54 ---
a 4 in their code meaning a != 0 4 !=0
That happens, but when it does `a' is not integer type. I use a gcc with this
warning on a 35Mloc code base. There are currently 4 warnings, all pointing to
real bugs.
This is
--- Additional Comments From bangerth at dealii dot org 2004-10-14 17:33 ---
Andrew, I'm getting angry when you selfishly close PRs that other people
think are useful to be kept open. The submitter of this PR has shown that
the cases you claim exist are not frequent, and that they
--- Additional Comments From giovannibajo at libero dot it 2004-10-15 00:37
---
I will confirm this because I agree with the submitter, this looks like a good
warning to use. It would be great if the conflict with the other warning can be
solved.
--
What|Removed
--- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-12 14:19
---
I the only way this can be done right is not to warn about a 1 as people sometimes
do that
(especially with macros) and that shows up in GCC a huge amount.
--
What|Removed
--- Additional Comments From pinskia at gcc dot gnu dot org 2004-10-12 14:27
---
Really we should not warn because we could be doing a CONST where we want CONST to
be
compared against 0 so this is invalid.
--
What|Removed |Added
--- Additional Comments From trt at acm dot org 2004-10-12 14:45 ---
Patch here: http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00990.html
This patch does not warn about a 1 for the reason noted in comment #1.
Some mistakes will go unwarned, but it still catches quite a lot.
The
--- Additional Comments From bangerth at dealii dot org 2004-10-12 16:07 ---
If this is put under a flag of its own, it may actually be useful. I
see no reason why we should dismiss it that quickly.
W.
--
What|Removed |Added
--- Additional Comments From trt at acm dot org 2004-10-12 18:52 ---
Given the problem pointed out in
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg01013.html I do not see how this
patch can be readily made to work. To avoid redundant truthvalue conversion it
might be necessary e.g. to
18 matches
Mail list logo
