[Bug c/79692] [7 Regression] -Wformat-overflow false positive with unknown width

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79692

--- Comment #4 from Martin Sebor  ---
Author: msebor
Date: Wed Mar  1 23:39:59 2017
New Revision: 245822

URL: https://gcc.gnu.org/viewcvs?rev=245822=gcc=rev
Log:
PR middle-end/79692 - [7 Regression] -Wformat-overflow false positive

gcc/ChangeLog:

PR middle-end/79692
* gimple-ssa-sprintf.c
(directive::known_width_and_precision): New function.
(format_integer): Use it.
(get_mpfr_format_length): Consider the full range of precision
when computing %g output with the # flag.  Set the likely byte
count to 3 rather than 1 when precision is indeterminate.
(format_floating): Correct the lower bound of precision.

gcc/testsuite/ChangeLog:

PR middle-end/79692
* gcc.dg/tree-ssa/builtin-sprintf-2.c: Add test cases.
* gcc.dg/tree-ssa/builtin-sprintf-warn-10.c: Correct %#g.
* gcc.dg/tree-ssa/builtin-sprintf-warn-15.c: New test.
* gcc.dg/tree-ssa/builtin-snprintf-3.c: Ditto.


Added:
trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-snprintf-3.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-15.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/gimple-ssa-sprintf.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-2.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/builtin-sprintf-warn-10.c

[Bug c/79692] [7 Regression] -Wformat-overflow false positive with unknown width

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79692

Martin Sebor  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Martin Sebor  ---
Fix committed in r245822.

[Bug c/79692] [7 Regression] -Wformat-overflow false positive with unknown width

[sirl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79692

--- Comment #3 from Franz Sirl  ---
I can confirm that the patch fixes both the submitted testcase and the original
code.
Thanks for your efforts.

[Bug c/79692] [7 Regression] -Wformat-overflow false positive with unknown width

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79692

Martin Sebor  changed:

   What|Removed |Added

   Keywords||patch
 Status|NEW |ASSIGNED
Summary|[7 Regression]  |[7 Regression]
   |-Wformat-overflow false |-Wformat-overflow false
   |positive?   |positive with unknown width

--- Comment #2 from Martin Sebor  ---
Patch submitted for review:
https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01564.html