[Bug c/89985] [9 Regression] Stray notes from OPT_Waddress_of_packed_member with -w

2019-04-06 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89985

--- Comment #4 from Eric Gallager  ---
(In reply to Eric Gallager from comment #3)
> since the issue of calls to inform being done without checking the return
> value of warning[_at] first seems to keep coming up, I almost wonder if it's
> worth adding __attribute__((unused_result)) to warning[_at]...

er __attribute__((warn_unused_result)) I mean

[Bug c/89985] [9 Regression] Stray notes from OPT_Waddress_of_packed_member with -w

2019-04-06 Thread egallager at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89985

Eric Gallager  changed:

   What|Removed |Added

 CC||egallager at gcc dot gnu.org

--- Comment #3 from Eric Gallager  ---
since the issue of calls to inform being done without checking the return value
of warning[_at] first seems to keep coming up, I almost wonder if it's worth
adding __attribute__((unused_result)) to warning[_at]...

[Bug c/89985] [9 Regression] Stray notes from OPT_Waddress_of_packed_member with -w

2019-04-05 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89985

David Malcolm  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from David Malcolm  ---
Should be fixed by r270169.

[Bug c/89985] [9 Regression] Stray notes from OPT_Waddress_of_packed_member with -w

2019-04-05 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89985

--- Comment #1 from David Malcolm  ---
Author: dmalcolm
Date: Fri Apr  5 15:15:37 2019
New Revision: 270169

URL: https://gcc.gnu.org/viewcvs?rev=270169=gcc=rev
Log:
Guard notes for -Waddress-of-packed-member on warning emission (PR c/89985)

gcc/c-family/ChangeLog:
PR c/89985
* c-warn.c (check_address_or_pointer_of_packed_member): Add
auto_diagnostic_group.  Guard inform calls by result of
warning_at call.

gcc/testsuite/ChangeLog:
PR c/89985
* c-c++-common/pr89985.c: New test.


Added:
trunk/gcc/testsuite/c-c++-common/pr89985.c
Modified:
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-warn.c
trunk/gcc/testsuite/ChangeLog