[Bug fortran/101399] Horizonal tab character not ignored on print statement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399 --- Comment #5 from Steve Kargl --- On Fri, Jul 09, 2021 at 11:44:11PM +, urbanjost at comcast dot net wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399 > > --- Comment #4 from urbanjost at comcast dot net --- > Wow. I cannot get a pizza delivered that fast. > A patch has been attached to the PR. No telling when someone might commit it to the source repository. I no longer commit as I have zero interest in git.
[Bug fortran/101399] Horizonal tab character not ignored on print statement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399 --- Comment #4 from urbanjost at comcast dot net --- Wow. I cannot get a pizza delivered that fast. Thanks! I have -Wtabs set in my compiler script and the script I use for editing codes does a :retabs after turning off tabs in vim(1) and runs any file ending in a Fortran suffix through expand(1) if using any other editor; so I would totally vote for -Wtabs being the default but I know a lot of others who would definitely vote for tabs being allowed as part of the standard. In fact, the majority of Fortran users I know would prefer it being standard.
[Bug fortran/101399] Horizonal tab character not ignored on print statement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399
kargl at gcc dot gnu.org changed:
What|Removed |Added
CC||kargl at gcc dot gnu.org
Last reconfirmed||2021-07-09
Priority|P3 |P5
Status|UNCONFIRMED |NEW
Severity|normal |enhancement
Ever confirmed|0 |1
--- Comment #3 from kargl at gcc dot gnu.org ---
diff --git a/gcc/fortran/io.c b/gcc/fortran/io.c
index 40cd76eb585..8c3f841098f 100644
--- a/gcc/fortran/io.c
+++ b/gcc/fortran/io.c
@@ -4226,7 +4226,10 @@ match_io (io_kind k)
if (gfc_current_form == FORM_FREE)
{
- char c = gfc_peek_ascii_char ();
+ char c;
+
+ gfc_gobble_whitespace ();
+ c = gfc_peek_ascii_char ();
if (c != ' ' && c != '*' && c != '\'' && c != '"')
{
m = MATCH_NO;
Personally, I think -Wtab should be the default behavior.
I lost that fight years ago.
PS: you'll need someone to commit this for you, or it
will sit with the 10 to 20 patches I've put into PRs.
[Bug fortran/101399] Horizonal tab character not ignored on print statement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399 --- Comment #2 from urbanjost at comcast dot net --- I agree tabs are not part of the standard, but even by default it is a very common extension ( I tried it with gfortran, ifort, nvfortran just today). I not not use the extension normally myself, but it came up in another context today and is an odd inconsistency. I ran 200 000, lines of Fortran through the ULS command unexpand(1) to create many source files with tabs in them and had no other problem with gfortran with tabs. I also took a small program with no long lines in it and replaced all spaces with tabs and had no problem compiling it with gfortran. This is not a high priority for me but seems like an odd inconsistency that would not be hard to rectify.
[Bug fortran/101399] Horizonal tab character not ignored on print statement
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101399 --- Comment #1 from Andrew Pinski --- tab is not part of Fortran character set.
