[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Janne Blomqvist  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Janne Blomqvist  ---
Fixed on trunk, closing. There might still be uses of 32-bit integers for
record lengths in the library (if so, file a new bug or reopen this one), but
the ABI issue and at least the most obvious internal usage should now be fixed.

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

--- Comment #11 from Janne Blomqvist  ---
Author: jb
Date: Sat Nov 18 22:05:13 2017
New Revision: 254918

URL: https://gcc.gnu.org/viewcvs?rev=254918=gcc=rev
Log:
PR 44292 Handle large record lengths

Now that the ABI supports large record lengths, there's a few places
in libgfortran where we need to use larger types. For internal units
which by definition are in-memory, it's enought to use ptrdiff_t, for
external units gfc_offset.

Regtested on x86_64-pc-linux-gnu?

libgfortran/ChangeLog:

2017-11-19  Janne Blomqvist  

PR fortran/44292
* io/transfer.c (skip_record): Use gfc_offset to handle large
records.
(next_record_r): Likewise.
(sset): Likewise.
(next_record_w): Use gfc_offset/ptrdiff_t appropriately.

Modified:
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/transfer.c

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Janne Blomqvist  changed:

   What|Removed |Added

URL|https://gcc.gnu.org/ml/gcc- |https://gcc.gnu.org/ml/gcc-
   |patches/2017-11/msg01563.ht |patches/2017-11/msg01646.ht
   |ml  |ml

--- Comment #10 from Janne Blomqvist  ---
Follow-up patch: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01646.html

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

--- Comment #9 from Janne Blomqvist  ---
Author: jb
Date: Sat Nov 18 16:13:20 2017
New Revision: 254915

URL: https://gcc.gnu.org/viewcvs?rev=254915=gcc=rev
Log:
PR 44292 Enable large record lengths in OPEN and INQUIRE statements

This is a straightforward change that we can do now that the ABI has
been bumped (again!).

Regtested on x86_64-pc-linux-gnu.

gcc/fortran/ChangeLog:

2017-11-18  Janne Blomqvist  

PR fortran/44292
* ioparm.def (IOPARM): Make recl_in intio, and recl_out pintio.

libgfortran/ChangeLog:

2017-11-18  Janne Blomqvist  

PR fortran/44292
* io/io.h: Make recl_in a GC_IO_INT and recl_out a type
GFC_IO_INT*.

gcc/testsuite/ChangeLog:

2017-11-18  Janne Blomqvist  

PR fortran/44292
* gfortran.dg/large_recl.f90: New test.

Added:
trunk/gcc/testsuite/gfortran.dg/large_recl.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/ioparm.def
trunk/gcc/testsuite/ChangeLog
trunk/libgfortran/ChangeLog
trunk/libgfortran/io/io.h

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Janne Blomqvist  changed:

   What|Removed |Added

URL||https://gcc.gnu.org/ml/gcc-
   ||patches/2017-11/msg01563.ht
   ||ml

--- Comment #8 from Janne Blomqvist  ---
Patch: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01563.html

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jb at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Janne Blomqvist  changed:

   What|Removed |Added

 CC||jb at gcc dot gnu.org
   Assignee|jvdelisle at gcc dot gnu.org   |jb at gcc dot gnu.org

--- Comment #7 from Janne Blomqvist  ---
I have a functioning patch, will post shortly.

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jvdelisle at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Jerry DeLisle  changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |jvdelisle at gcc dot 
gnu.org

--- Comment #6 from Jerry DeLisle  ---
(In reply to Thomas Koenig from comment #5)
> Hi Jerry,
> 
> should we also look at this when we bump the library number?

Sure, but I will have to start over to find the places since things have moved
around.

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[tkoenig at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Thomas Koenig  changed:

   What|Removed |Added

   Last reconfirmed|2010-05-30 05:38:00 |2017-7-31
 CC||jvdelisle at gcc dot gnu.org,
   ||tkoenig at gcc dot gnu.org

--- Comment #5 from Thomas Koenig  ---
Hi Jerry,

should we also look at this when we bump the library number?

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

Dominique d'Humieres dominiq at lps dot ens.fr changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[burnus at gcc dot gnu dot org]

--- Comment #4 from burnus at gcc dot gnu dot org  2010-06-30 08:08 ---
See also: PR 29602


-- 

burnus at gcc dot gnu dot org changed:

   What|Removed |Added

OtherBugsDependingO||29602
  nThis||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jvdelisle at gcc dot gnu dot org]

--- Comment #3 from jvdelisle at gcc dot gnu dot org  2010-06-06 06:01 
---
I have managed a patch that writes one very big record as in the test case.  I
don't have sufficient memory to actually test a read.

It should be noted that the record length stored in gfc_unit which is created
at runtime is a 64 bit value already.  The front-end changes needed to support
large record lengths is almost trivial.

On the library side, writing is fairly simple as well.  Reading is a little bit
more complicated.  Hopefully soon I will post a partial patch (or maybe even a
complete but untested one)  I know Steve has a machine with lots of RAM, is
there anyone else who would like to help with testing this? 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[tkoenig at gcc dot gnu dot org]

--- Comment #1 from tkoenig at gcc dot gnu dot org  2010-05-29 22:20 ---
Confirmed.


-- 

tkoenig at gcc dot gnu dot org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever Confirmed|0   |1
   Last reconfirmed|-00-00 00:00:00 |2010-05-29 22:20:03
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292

[Bug fortran/44292] [libgfortran ABI breakage] Increase internal size of RECL= of the OPEN statement

[jvdelisle at gcc dot gnu dot org]

--- Comment #2 from jvdelisle at gcc dot gnu dot org  2010-05-30 05:38 
---
I would like to work this one.


-- 

jvdelisle at gcc dot gnu dot org changed:

   What|Removed |Added

 AssignedTo|unassigned at gcc dot gnu   |jvdelisle at gcc dot gnu dot
   |dot org |org
 Status|NEW |ASSIGNED
   Last reconfirmed|2010-05-29 22:20:03 |2010-05-30 05:38:00
   date||


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44292