[Bug fortran/54678] second call to get_environment_variable gives valgrind warning with 8-byte integers

2013-01-06 Thread burnus at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54678



--- Comment #3 from Tobias Burnus burnus at gcc dot gnu.org 2013-01-06 
12:43:49 UTC ---

Author: burnus

Date: Sun Jan  6 12:43:45 2013

New Revision: 194948



URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=194948

Log:

2013-01-06  Tobias Burnus  bur...@net-b.de



PR fortran/54678

* intrinsics/env.c (get_environment_variable_i8): Don't use

uninitialized variable.





Modified:

trunk/libgfortran/ChangeLog

trunk/libgfortran/intrinsics/env.c

[Bug fortran/54678] second call to get_environment_variable gives valgrind warning with 8-byte integers

2013-01-06 Thread burnus at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54678



Tobias Burnus burnus at gcc dot gnu.org changed:



   What|Removed |Added



 Status|NEW |RESOLVED

 Resolution||FIXED



--- Comment #4 from Tobias Burnus burnus at gcc dot gnu.org 2013-01-06 
12:46:16 UTC ---

FIXED on the trunk (4.8).



Thanks for the report - and sorry for the delay.



Thomas: Thanks for the reminder.

[Bug fortran/54678] second call to get_environment_variable gives valgrind warning with 8-byte integers

2013-01-05 Thread tkoenig at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54678



Thomas Koenig tkoenig at gcc dot gnu.org changed:



   What|Removed |Added



 Status|UNCONFIRMED |NEW

   Last reconfirmed||2013-01-05

 CC||tkoenig at gcc dot gnu.org

 Ever Confirmed|0   |1



--- Comment #2 from Thomas Koenig tkoenig at gcc dot gnu.org 2013-01-05 
20:54:57 UTC ---

Hi Tobias,



do you plan to commit the patch from Comment #1?

It looks obvious to me.

[Bug fortran/54678] second call to get_environment_variable gives valgrind warning with 8-byte integers

2012-09-24 Thread burnus at gcc dot gnu.org 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54678



Tobias Burnus burnus at gcc dot gnu.org changed:



   What|Removed |Added



 CC||burnus at gcc dot gnu.org



--- Comment #1 from Tobias Burnus burnus at gcc dot gnu.org 2012-09-24 
06:37:26 UTC ---

Draft patch:



--- a/libgfortran/intrinsics/env.c

+++ b/libgfortran/intrinsics/env.c

@@ -186,5 +186,6 @@ get_environment_variable_i8 (char *name, char *value,

GFC_INTEGER_8 *length,



   get_environment_variable_i4 (name, value, length4, status4, 

-  trim_name4, name_len, value_len);

+  trim_name ? trim_name4 : NULL,

+  name_len, value_len);



   if (length)