https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
Bernd Edlinger edlinger at gcc dot gnu.org changed:
What|Removed |Added
Status|NEW |RESOLVED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #21 from Bernd Edlinger edlinger at gcc dot gnu.org ---
Author: edlinger
Date: Sun Feb 22 19:38:53 2015
New Revision: 220899
URL: https://gcc.gnu.org/viewcvs?rev=220899root=gccview=rev
Log:
2015-02-22 Bernd Edlinger
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #20 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
(In reply to Dominique d'Humieres from comment #12)
In addition Bernd's patch fixes/hides the ICE for pr61960.
this pr is fixed by this hunk alone:
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #19 from Dominique d'Humieres dominiq at lps dot ens.fr ---
BTW: should we add the original test case from pr64230 the test suite,
because class_allocate_18.f90 failed to spot this regression?
Why not? Better safe than sorry. Note
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #16 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
(In reply to Mikael Morin from comment #14)
Bernd, do you have a reliable way to test a patch, checking for aliasing
violations?
No, all I can do is run the test suite on
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #18 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
(In reply to Dominique d'Humieres from comment #17)
I think this updated patch fixes all mentioned test cases.
Confirmed, bootstrapped and regtested cleanly.
but
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #17 from Dominique d'Humieres dominiq at lps dot ens.fr ---
I think this updated patch fixes all mentioned test cases.
Confirmed, bootstrapped and regtested cleanly.
but there are many regressions, which would need to be fixed
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #11 from Mikael Morin mikael at gcc dot gnu.org ---
Created attachment 34755
-- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34755action=edit
Another proposed fix
(In reply to Bernd Edlinger from comment #10)
Yes, but I have no
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #12 from Dominique d'Humieres dominiq at lps dot ens.fr ---
With any of the patches the first test for pr64230 fails at run time with
At line 35 of file pr64230.f90
Fortran runtime error: Attempt to DEALLOCATE unallocated 't'
but
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #13 from Mikael Morin mikael at gcc dot gnu.org ---
Created attachment 34757
-- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34757action=edit
Yet another attempt using TYPE_CANONICAL
this tries to remove any use of
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #14 from Mikael Morin mikael at gcc dot gnu.org ---
Bernd, do you have a reliable way to test a patch, checking for aliasing
violations?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #15 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
Created attachment 34758
-- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34758action=edit
Updated patch that also fixes pr64230.f90
(In reply to Dominique d'Humieres
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #7 from Dominique d'Humieres dominiq at lps dot ens.fr ---
With this patch all fortran test cases pass on x86_64.
And the ICE goes away in the reduced test example.
Does it work for you?
It works for me for all the tests in this
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #9 from Mikael Morin mikael at gcc dot gnu.org ---
(In reply to Bernd Edlinger from comment #8)
I will post this new patch, which combines Mikael's patch and
fixes class_41.f03 and these test cases,
Actually, my patch was not
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #8 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
Created attachment 34751
-- https://gcc.gnu.org/bugzilla/attachment.cgi?id=34751action=edit
Proposed Fix
OK, now I see the original test case exposes an aliasing violation
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #10 from Bernd Edlinger bernd.edlinger at hotmail dot de ---
(In reply to Mikael Morin from comment #9)
(In reply to Bernd Edlinger from comment #8)
The call of get_d_position is now rewritten as follows:
this.22 =
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
Bernd Edlinger bernd.edlinger at hotmail dot de changed:
What|Removed |Added
CC|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
--- Comment #5 from Mikael Morin mikael at gcc dot gnu.org ---
(In reply to Mikael Morin from comment #4)
This cures it:
Another way to cure it:
Index: trans-expr.c
===
---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64980
Richard Biener rguenth at gcc dot gnu.org changed:
What|Removed |Added
Priority|P3 |P4
19 matches
Mail list logo
